17 Nov, 2006

1 commit

  • platform_device_register_simple() returns error code as pointer when it
    fails. The return value should be checked by IS_ERR().

    Cc: Abhay Salunke
    Signed-off-by: Akinobu Mita
    Cc: Matt Domsch
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     

22 Oct, 2006

1 commit


21 Oct, 2006

1 commit


12 Oct, 2006

3 commits


11 Oct, 2006

1 commit


04 Oct, 2006

2 commits


03 Oct, 2006

1 commit


30 Sep, 2006

1 commit

  • This teaches dmi_decode() how to decode and save OEM Strings (type 11) DMI
    information, which is currently discarded silently. Existing code using
    DMI is not affected. Follows the "System Management BIOS (SMBIOS)
    Specification" (http://www.dmtf.org/standards/smbios), and also the
    userspace dmidecode.c code.

    OEM Strings are the only safe way to identify some hardware, e.g., the
    ThinkPad embedded controller used by the soon-to-be-submitted tp_smapi
    driver. This will also let us eliminate the long whitelist in the mainline
    hdaps driver (in a future patch).

    Signed-off-by: Shem Multinymous
    Cc: Bjorn Helgaas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Shem Multinymous
     

01 Jul, 2006

1 commit


26 Jun, 2006

2 commits


15 Apr, 2006

1 commit

  • dmi_scan.c is arch-independent and is used by i386, x86_64, and ia64.
    Currently all three arches compile it from arch/i386, which means that ia64
    and x86_64 depend on things in arch/i386 that they wouldn't otherwise care
    about.

    This is simply "mv arch/i386/kernel/dmi_scan.c drivers/firmware/" (removing
    trailing whitespace) and the associated Makefile changes. All three
    architectures already set CONFIG_DMI in their top-level Kconfig files.

    Signed-off-by: Bjorn Helgaas
    Cc: Andi Kleen
    Cc: "Luck, Tony"
    Cc: Andrey Panin
    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Bjorn Helgaas
     

28 Mar, 2006

1 commit

  • The kernel's implementation of notifier chains is unsafe. There is no
    protection against entries being added to or removed from a chain while the
    chain is in use. The issues were discussed in this thread:

    http://marc.theaimsgroup.com/?l=linux-kernel&m=113018709002036&w=2

    We noticed that notifier chains in the kernel fall into two basic usage
    classes:

    "Blocking" chains are always called from a process context
    and the callout routines are allowed to sleep;

    "Atomic" chains can be called from an atomic context and
    the callout routines are not allowed to sleep.

    We decided to codify this distinction and make it part of the API. Therefore
    this set of patches introduces three new, parallel APIs: one for blocking
    notifiers, one for atomic notifiers, and one for "raw" notifiers (which is
    really just the old API under a new name). New kinds of data structures are
    used for the heads of the chains, and new routines are defined for
    registration, unregistration, and calling a chain. The three APIs are
    explained in include/linux/notifier.h and their implementation is in
    kernel/sys.c.

    With atomic and blocking chains, the implementation guarantees that the chain
    links will not be corrupted and that chain callers will not get messed up by
    entries being added or removed. For raw chains the implementation provides no
    guarantees at all; users of this API must provide their own protections. (The
    idea was that situations may come up where the assumptions of the atomic and
    blocking APIs are not appropriate, so it should be possible for users to
    handle these things in their own way.)

    There are some limitations, which should not be too hard to live with. For
    atomic/blocking chains, registration and unregistration must always be done in
    a process context since the chain is protected by a mutex/rwsem. Also, a
    callout routine for a non-raw chain must not try to register or unregister
    entries on its own chain. (This did happen in a couple of places and the code
    had to be changed to avoid it.)

    Since atomic chains may be called from within an NMI handler, they cannot use
    spinlocks for synchronization. Instead we use RCU. The overhead falls almost
    entirely in the unregister routine, which is okay since unregistration is much
    less frequent that calling a chain.

    Here is the list of chains that we adjusted and their classifications. None
    of them use the raw API, so for the moment it is only a placeholder.

    ATOMIC CHAINS
    -------------
    arch/i386/kernel/traps.c: i386die_chain
    arch/ia64/kernel/traps.c: ia64die_chain
    arch/powerpc/kernel/traps.c: powerpc_die_chain
    arch/sparc64/kernel/traps.c: sparc64die_chain
    arch/x86_64/kernel/traps.c: die_chain
    drivers/char/ipmi/ipmi_si_intf.c: xaction_notifier_list
    kernel/panic.c: panic_notifier_list
    kernel/profile.c: task_free_notifier
    net/bluetooth/hci_core.c: hci_notifier
    net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_chain
    net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_expect_chain
    net/ipv6/addrconf.c: inet6addr_chain
    net/netfilter/nf_conntrack_core.c: nf_conntrack_chain
    net/netfilter/nf_conntrack_core.c: nf_conntrack_expect_chain
    net/netlink/af_netlink.c: netlink_chain

    BLOCKING CHAINS
    ---------------
    arch/powerpc/platforms/pseries/reconfig.c: pSeries_reconfig_chain
    arch/s390/kernel/process.c: idle_chain
    arch/x86_64/kernel/process.c idle_notifier
    drivers/base/memory.c: memory_chain
    drivers/cpufreq/cpufreq.c cpufreq_policy_notifier_list
    drivers/cpufreq/cpufreq.c cpufreq_transition_notifier_list
    drivers/macintosh/adb.c: adb_client_list
    drivers/macintosh/via-pmu.c sleep_notifier_list
    drivers/macintosh/via-pmu68k.c sleep_notifier_list
    drivers/macintosh/windfarm_core.c wf_client_list
    drivers/usb/core/notify.c usb_notifier_list
    drivers/video/fbmem.c fb_notifier_list
    kernel/cpu.c cpu_chain
    kernel/module.c module_notify_list
    kernel/profile.c munmap_notifier
    kernel/profile.c task_exit_notifier
    kernel/sys.c reboot_notifier_list
    net/core/dev.c netdev_chain
    net/decnet/dn_dev.c: dnaddr_chain
    net/ipv4/devinet.c: inetaddr_chain

    It's possible that some of these classifications are wrong. If they are,
    please let us know or submit a patch to fix them. Note that any chain that
    gets called very frequently should be atomic, because the rwsem read-locking
    used for blocking chains is very likely to incur cache misses on SMP systems.
    (However, if the chain's callout routines may sleep then the chain cannot be
    atomic.)

    The patch set was written by Alan Stern and Chandra Seetharaman, incorporating
    material written by Keith Owens and suggestions from Paul McKenney and Andrew
    Morton.

    [jes@sgi.com: restructure the notifier chain initialization macros]
    Signed-off-by: Alan Stern
    Signed-off-by: Chandra Seetharaman
    Signed-off-by: Jes Sorensen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Stern
     

27 Mar, 2006

1 commit

  • Almost all users of the table addresses from the EFI system table want
    physical addresses. So rather than doing the pa->va->pa conversion, just keep
    physical addresses in struct efi.

    This fixes a DMI bug: the efi structure contained the physical SMBIOS address
    on x86 but the virtual address on ia64, so dmi_scan_machine() used ioremap()
    on a virtual address on ia64.

    This is essentially the same as an earlier patch by Matt Tolentino:
    http://marc.theaimsgroup.com/?l=linux-kernel&m=112130292316281&w=2
    except that this changes all table addresses, not just ACPI addresses.

    Matt's original patch was backed out because it caused MCAs on HP sx1000
    systems. That problem is resolved by the ioremap() attribute checking added
    for ia64.

    Signed-off-by: Bjorn Helgaas
    Cc: Matt Domsch
    Cc: "Tolentino, Matthew E"
    Cc: "Brown, Len"
    Cc: Andi Kleen
    Acked-by: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bjorn Helgaas
     

23 Mar, 2006

1 commit


22 Mar, 2006

1 commit

  • Do not use platform_device_register_simple() as it is going away, define
    dcdbas_driver and implement ->probe() and ->remove() functions so manual
    binding and unbinding will work with this driver.

    Also switch to using attribute_group when creating sysfs attributes and
    make sure to check and handle errors; explicitely remove attributes when
    detaching driver.

    Signed-off-by: Dmitry Torokhov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dmitry Torokhov
     

10 Mar, 2006

1 commit


15 Jan, 2006

1 commit

  • This fixes http://bugzilla.kernel.org/show_bug.cgi?id=5854

    Root cause:

    The dell_rbu driver creates entries in /sys/class/firmware/dell_rbu/ by
    calling request_firmware_nowait (without hotplug ) this function inturn
    starts a kernel thread which creates the entries in
    /sys/class/firmware/dell_rbu/loading , data and the thread waits on the
    user action to return control back to the callback fucntion of dell_rbu.
    The thread calls wait_on_completion which puts it in a D state until the
    user action happens. If there is no user action happening the load average
    goes up as the thread D state is taken in to account. Also after
    downloading the BIOS image the enrties go away momentarily but they are
    recreated from the callback function in dell_rbu. This causes the thread
    to get recreated causing the load average to permenently stay around 1.

    Fix:

    The dell_rbu also creates the entry
    /sys/devices/platform/dell_rbu/image_type at driver load time. The image
    type by default is mono if required the user can echo packet to image_type
    to make the BIOS update mechanism using packets. Also by echoing init in
    to image_type the /sys/class/firmware/dell_rbu entries can be created.

    The driver code was changed to not create /sys/class/firmware/dell_rbu
    entries during load time, and also to not create the above entries from the
    callback function. The entries are only created by echoing init to
    /sys/devices/platform/dell_rbu/image_type The user now needs to create the
    entries to download the image monolithic or packet. This fixes the issue
    since the kernel thread only is created when ever the user is ready to
    download the BIOS image; this minimizes the life span of the kernel thread
    and the load average goes back to normal.

    Signed off by Abhay Salunke

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Abhay Salunke
     

12 Jan, 2006

1 commit

  • - Move capable() from sched.h to capability.h;

    - Use where capable() is used
    (in include/, block/, ipc/, kernel/, a few drivers/,
    mm/, security/, & sound/;
    many more drivers/ to go)

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy.Dunlap
     

16 Dec, 2005

1 commit


23 Nov, 2005

1 commit


09 Nov, 2005

1 commit

  • This patch removes almost all inclusions of linux/version.h. The 3
    #defines are unused in most of the touched files.

    A few drivers use the simple KERNEL_VERSION(a,b,c) macro, which is
    unfortunatly in linux/version.h.

    There are also lots of #ifdef for long obsolete kernels, this was not
    touched. In a few places, the linux/version.h include was move to where
    the LINUX_VERSION_CODE was used.

    quilt vi `find * -type f -name "*.[ch]"|xargs grep -El '(UTS_RELEASE|LINUX_VERSION_CODE|KERNEL_VERSION|linux/version.h)'|grep -Ev '(/(boot|coda|drm)/|~$)'`

    search pattern:
    /UTS_RELEASE\|LINUX_VERSION_CODE\|KERNEL_VERSION\|linux\/\(utsname\|version\).h

    Signed-off-by: Olaf Hering
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Olaf Hering
     

07 Nov, 2005

2 commits

  • Signed-off-by: Deepak Saxena
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Deepak Saxena
     
  • This patch has the changes to support the memory floor fix done in Dell
    BIOS. The BIOS incase of packet update mechanism would not accept packet
    placed in memory below a cretain address. This address is by default 128K
    but can change. The driver now can accept the memory floor if the user
    chooses to make it will try to allocate contiguous physical memory above
    the memory floor by allocating a set of packets till a valid memory
    allocation is made. All the allocates then are freed. This repeats for
    everty packet.

    This patch was created by Michael E Brown and has been tested on 2.6.14-rc5

    Signed-of-by: Michael E Brown
    Signed-off-by: Abhay Salunke
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Abhay Salunke
     

31 Oct, 2005

3 commits


30 Oct, 2005

1 commit


12 Oct, 2005

1 commit

  • In the current dell_rbu code ver 2.0 the packet update mechanism makes the
    user app dump every individual packet in to the driver.

    This adds in efficiency as every packet update makes the
    /sys/class/firmware/dell_rbu/loading and data files to disappear and reappear
    again. Thus the user app needs to wait for the files to reappear to dump
    another packet. This slows down the packet update tremendously in case of
    large number of packets. I am submitting a new patch for dell_rbu which will
    change the way we do packet updates;

    In the new method the user app will create a new single file which has already
    packetized the rbu image and all the packets are now staged in this file.

    This driver also creates a new entry in
    /sys/devices/platform/dell_rbu/packet_size ; the user needs to echo the packet
    size here before downloading the packet file.

    The user should do the following:

    create one single file which has all the packets stacked together.
    echo the packet size in to /sys/devices/platform/dell_rbu/packet_size.
    echo 1 > /sys/class/firmware/dell_rbu/loading
    cat the packetfile > /sys/class/firmware/dell_rbu/data
    echo 0 > /sys/class/firmware/dell_rbu/loading

    The driver takes the file which came through /sys/class/firmware/dell_rbu/data
    and takes chunks of paket_size data from it and place in contiguous memory.

    This makes packet update process very efficient and fast. As all the packet
    update happens in one single operation. The user can still read back the
    downloaded file from /sys/devices/platform/dell_rbu/data.

    Signed-off-by: Abhay Salunke
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Abhay Salunke
     

18 Sep, 2005

2 commits

  • Whitespace standardisation.

    Cc: Abhay Salunke
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • BUG fixes:

    The driver used to allocate memory with spinlock held which has been
    fixed in this patch.

    The driver was printing the entire buffer when it received a invalid
    entry in image_type. The fix is to only print a warning message and not
    the buffer.

    Usability enhancements:

    It is possible that due to user error the /sys/class/firmware/dell_rbu
    entries might be missing, this can happen if the user does the following

    echo 1 > /sys/class/firmware/dell_rbu/loading
    echo 0 > /sys/class/firmware/dell_rbu/loading

    This will make the entries in /sys/class/firmware/ to disappear and the
    only way get them back was bby unloading and loading the driver.

    This patch makes the user recreate these entries by echoing init in to
    image_type.

    This patch has been tested with Libsmbios and Dell OpenManage.

    Signed-off-by: Abhay Salunke
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Abhay Salunke
     

08 Sep, 2005

2 commits


28 Jul, 2005

1 commit


14 Jul, 2005

1 commit

  • Mark's patch added "attribute((packed))" for pcdp_uart, without
    accounting for the fact that the structure definition _relied_ on
    implicit padding by 6 bytes. Fix is to make the padding explicit.

    Signed-off-by: David Mosberger-Tang
    Signed-off-by: Tony Luck

    David Mosberger-Tang
     

29 Jun, 2005

1 commit

  • Resend 2 with changes per Bjorn Helgaas comments. Changes from original:

    + Change globals to vga_console_iobase/vga_console_membase and make them
    unconditional.
    + Address style-related comments.

    Patch to extend the PCDP vga setup code to support PCI io/mem translations
    for the legacy vga ioport and ram spaces on architectures (e.g. altix) which
    need them.

    Summary of the changes:

    drivers/firmware/pcdp.c
    drivers/firmware/pcdp.h
    -----------------------
    + add declaration for the spec-defined PCI interface struct (pcdp_if_pci)
    as well as support macros.

    + extend setup_vga_console() to know about pcdp_if_pci and add a couple of
    globals to hold the io and mem translation offsets if present.

    arch/ia64/kernel/setup.c
    ------------------------
    + tweek early_console_setup() to allow multiple early console setup routines
    to be called.

    include/asm-ia64/vga.h
    ----------------------
    + make VGA_MAP_MEM vga_console_membase aware

    Signed-off-by: Mark Maule
    Signed-off-by: Tony Luck

    Mark Maule
     

26 Jun, 2005

1 commit

  • Here's a patch with kfree() cleanups for drivers/firmware/efivars.c Patch
    removes redundant NULL checks before kfree and also makes a small
    whitespace cleanup - moves two statements on same line to separate lines.

    Signed-off-by: Jesper Juhl
    Acked-by: Matt Domsch
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl