18 Jun, 2018
1 commit
-
Work is guaranteed to be initialized on exit. Drop the unnecessary
if statement and always call flush_work.This fixes a warning seen with clang:
sound/soc/codecs/pcm1789.c:265:13: warning: address of 'priv->work' will
always evaluate to 'true' [-Wpointer-bool-conversion]
if (&priv->work)
~~ ~~~~~~^~~~Signed-off-by: Stefan Agner
Signed-off-by: Mark Brown
31 May, 2018
1 commit
-
When CONFIG_GPIOLIB is disabled, this codec fails to build
because gpio/consumer.h is not included implicitly.sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init':
sound/soc/codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration]
pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
^~~~~~~~~~~~~~~~~~~~~~~Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789")
Signed-off-by: Arnd Bergmann
Signed-off-by: Mark Brown
19 Mar, 2018
1 commit
-
Add Texas Instruments's PCM1789 DAC support.
It is a simple DAC and does not have many registers.One particularity about this DAC is that the clocks must be
always enabled. Also, an entire software reset is necessary
while starting to play a sound otherwise, the clocks are not
synchronized (so the DAC is not able to send data).Signed-off-by: Mylène Josserand
Signed-off-by: Mark Brown