06 Nov, 2018

2 commits

  • The previous version made it necessary to first generate an
    EDID data set without correct CRC and then to fix the CRC in
    a second step. This patch adds the CRC calculation to the
    makefile in such a way that a correct EDID data set is generated
    in a single build step. Successfully tested with all existing
    and a couple of new data sets.

    Signed-off-by: Christoph Niedermaier
    Reviewed-by: Carsten Emde
    Signed-off-by: Jonathan Corbet

    Christoph Niedermaier
     
  • The problem was found when EDID data sets for displays other
    than the provided samples were generated. The patch has
    no effect on the provided samples that still match the data
    used in drivers/gpu/drm/drm_edid_load.c.

    The provided samples use small values for XOFFSET, XPULSE,
    YOFFSET and YPULSE, where the error doesn't occur. This fix
    corrects the use of that values in case of high values, because
    the most significant bits were treated incorrectly.

    So in edid.S msbs4 should use bit 8 and 9 of XOFFSET and XPULS.
    For YOFFSET and YPULSE msbs4 should use bit 4 and 5.

    lsbs2 was introduced for a better overview, without
    functional change.

    Removing also the useless value 63 of all files, because
    it is added in the *.S description files and then it is
    subtracted in edid.S.

    Signed-off-by: Christoph Niedermaier
    Reviewed-by: Carsten Emde
    Signed-off-by: Jonathan Corbet

    Christoph Niedermaier
     

26 May, 2014

1 commit

  • The 800x600 (SVGA) screen resolution was lacking in the set of
    built-in selectable EDID screen resolutions that can be used to
    repair misbehaving monitor firmware.

    This patch adds the related data set and expands the documentation.
    Note that the SVGA bit occupies a different byte to all the existing
    users of the established timing bits forcing a rework of the
    ESTABLISHED_TIMINGS_BITS macro.

    Tested new EDID on an aged (and misbehaving) industrial LCD panel;
    existing EDIDs still pass edid-decode's checksum checks.

    Signed-off-by: Daniel Thompson
    Cc: Randy Dunlap
    Cc: David Airlie
    Cc: Carsten Emde
    Cc: linux-doc@vger.kernel.org
    Cc: dri-devel@lists.freedesktop.org
    Reviewed-by: Alex Deucher
    Signed-off-by: Dave Airlie

    Daniel Thompson