Eric Lee / smarc-fsl-linux-kernel

25 May, 2019

1 commit

  • 1c7ebeabc   parport: Fix mem leak in parport_register_dev_model ... Browse Code »

    BUG: memory leak
    unreferenced object 0xffff8881df48cda0 (size 16):
    comm "syz-executor.0", pid 5077, jiffies 4295994670 (age 22.280s)
    hex dump (first 16 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
    backtrace:
    [] parport_register_dev_model+0x141/0x6e0 [parport]
    [] 0xffffffffc15d1196
    [] platform_drv_probe+0x7e/0x100
    [] really_probe+0x342/0x4d0
    [] driver_probe_device+0x8c/0x170
    [] __device_attach_driver+0xda/0x100
    [] bus_for_each_drv+0xfe/0x170
    [] __device_attach+0x190/0x230
    [] bus_probe_device+0x123/0x140
    [] device_add+0x7cc/0xce0
    [] platform_device_add+0x230/0x3c0
    [] 0xffffffffc15d0949
    [] port_check+0x3b/0x50 [parport]
    [] bus_for_each_dev+0x115/0x180
    [] __parport_register_driver+0x1f0/0x210 [parport]
    [] 0xffffffffc15d803e

    After commit 4e5a74f1db8d ("parport: Revert "parport: fix
    memory leak""), free_pardevice do not free par_dev->state,
    we should free it in error path of parport_register_dev_model
    before return.

    Reported-by: Hulk Robot
    Fixes: 4e5a74f1db8d ("parport: Revert "parport: fix memory leak"")
    Signed-off-by: YueHaibing
    Signed-off-by: Greg Kroah-Hartman

    YueHaibing
     

26 Mar, 2019

1 commit

  • a3ac7917b   Revert "parport: daisy: use new parport device model" ... Browse Code »

    This reverts commit 1aec4211204d9463d1fd209eb50453de16254599.

    Steven Rostedt reports that it causes a hang at bootup and bisected it
    to this commit.

    The troigger is apparently a module alias for "parport_lowlevel" that
    points to "parport_pc", which causes a hang with

    modprobe -q -- parport_lowlevel

    blocking forever with a backtrace like this:

    wait_for_completion_killable+0x1c/0x28
    call_usermodehelper_exec+0xa7/0x108
    __request_module+0x351/0x3d8
    get_lowlevel_driver+0x28/0x41 [parport]
    __parport_register_driver+0x39/0x1f4 [parport]
    daisy_drv_init+0x31/0x4f [parport]
    parport_bus_init+0x5d/0x7b [parport]
    parport_default_proc_register+0x26/0x1000 [parport]
    do_one_initcall+0xc2/0x1e0
    do_init_module+0x50/0x1d4
    load_module+0x1c2e/0x21b3
    sys_init_module+0xef/0x117

    Supid says:
    "Due to the new device model daisy driver will now try to find the
    parallel ports while trying to register its driver so that it can bind
    with them. Now, since daisy driver is loaded while parport bus is
    initialising the list of parport is still empty and it tries to load
    the lowlevel driver, which has an alias set to parport_pc, now causes
    a deadlock"

    But I don't think the daisy driver should be loaded by the parport
    initialization in the first place, so let's revert the whole change.

    If the daisy driver can just initialize separately on its own (like a
    driver should), instead of hooking into the parport init sequence
    directly, this issue probably would go away.

    Reported-and-bisected-by: Steven Rostedt (VMware)
    Reported-by: Michal Kubecek
    Acked-by: Greg Kroah-Hartman
    Cc: Sudip Mukherjee
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

14 Feb, 2019

1 commit

16 Mar, 2017

1 commit

  • 03270c6ac   parport: fix attempt to write duplicate procfiles ... Browse Code »

    Usually every parallel port will have a single pardev registered with
    it. But ppdev driver is an exception. This userspace parallel port
    driver allows to create multiple parrallel port devices for a single
    parallel port. And as a result we were having a nice warning like:
    "sysctl table check failed:
    /dev/parport/parport0/devices/ppdev0/timeslice Sysctl already exists"

    Use the same logic as used in parport_register_device() and register
    the proc files only once for each parallel port.

    Fixes: 6fa45a226897 ("parport: add device-model to parport subsystem")
    Cc: stable # v4.4+
    Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1414656
    Bugzilla: https://bugs.archlinux.org/task/52322
    Tested-by: James Feeney
    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     

02 Mar, 2017

1 commit

04 Jan, 2016

11 commits

26 Jul, 2015

1 commit

23 Jul, 2015

3 commits

  • 68d35c7b3   parport: fix freeing freed memory ... Browse Code »

    After the reference count becomes 0 when put_device() is called, it will
    execute the release callback where we are freeing all the allocated
    memory associated with the device. So if we just continue on the error
    path then we are again freeing devname and trying to dereference par_dev
    which has already been free-ed in the release callback.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     
  • 23c405912   parport: fix memory leak ... Browse Code »

    After the reference count becomes 0 when put_device() is called, it will
    execute the release callback where we are freeing all the allocated
    memory associated with the device. We missed freeing par_dev->state.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     
  • cabea6958   parport: fix error handling ... Browse Code »

    After registering the device if exclusive access fails for any reason
    then we need to unregister the device to remove all references.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     

13 Jun, 2015

1 commit

  • 50566ac87   parport: check exclusive access before register ... Browse Code »

    As of now we were starting the registration process and after the device
    is registered we were checking if the device can be used by the
    parport. Now lets check it first so that we do not need to go through
    the registration process only to fail at the end.
    The original exclusive access check at the end is still there so that we
    do not get any surprises if two different process registers its device
    with same parport and with exclusive access at the same time.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     

01 Jun, 2015

1 commit

  • 6fa45a226   parport: add device-model to parport subsystem ... Browse Code »

    parport subsystem starts using the device-model. Drivers using the
    device-model has to define devmodel as true and should register the
    device with parport using parport_register_dev_model().

    Tested-by: Jean Delvare
    Tested-by: Alan Cox
    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Greg Kroah-Hartman

    Sudip Mukherjee
     

01 Mar, 2014

1 commit

  • 76ae0536d   parport: fix interruptible_sleep_on race ... Browse Code »

    The interruptible_sleep_on function is can still lead to the
    deadlock mentioned in the comment above the caller, and we want
    to remove it soon, so replace it now with the race-free
    wait_event_interruptible.

    Signed-off-by: Arnd Bergmann
    Cc: Andrew Morton
    Cc: Greg Kroah-Hartman
    Signed-off-by: Greg Kroah-Hartman

    Arnd Bergmann
     

04 Jul, 2013

1 commit

26 Jan, 2011

1 commit

  • cbeb4b7ad   parport: make lockdep happy with waitlist_lock ... Browse Code »

    parport_unregister_device() should never be used when interrupts are
    enabled in hardware and irq handler is registered so there is no need to
    disable interrupts when using waitlist_lock. But there is no way to
    explain this subtle semantics to lockdep analyzer.

    So disable interrupts here too to simplify things. The price is
    negligible.

    Signed-off-by: Alexander Gordeev
    Cc: Ingo Molnar
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexander Gordeev
     

12 Oct, 2010

1 commit

03 Jun, 2009

1 commit

  • 05ad709d0   parport: quickfix the proc registration bug ... Browse Code »

    Ideally we should have a directory of drivers and a link to the 'active'
    driver. For now just show the first device which is effectively the existing
    semantics without a warning.

    This is an update on the original buggy patch that I then forgot to
    resubmit. Confusingly it was proposed by Red Hat, written by Etched Pixels
    fixed and submitted by Intel ...

    Resolves-Bug: http://bugzilla.kernel.org/show_bug.cgi?id=9749
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     

17 Oct, 2008

1 commit

24 Oct, 2007

3 commits

09 May, 2007

1 commit

  • c15a3837d   parport->dev driver model support ... Browse Code »

    Currently a parport_driver can't get a handle on the device node for the
    underlying parport (PNPACPI, PCI, etc). That prevents correct placement of
    sysfs child nodes, which can affect things like power management.

    This patch adds a field to "struct parport" pointing to that device node, and
    updates non-legacy port drivers to initialize that device pointer. That field
    replaces the analagous PCI-only support in parport_pc.

    [akpm@linux-foundation.org: fix powerpc build]
    Signed-off-by: David Brownell
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

01 Jul, 2006

1 commit

26 Jun, 2006

1 commit

27 Mar, 2006

1 commit

  • 14cc3e2b6   [PATCH] sem2mutex: misc static one-file mutexes ... Browse Code »

    Semaphore to mutex conversion.

    The conversion was generated via scripts, and the result was validated
    automatically via a script as well.

    Signed-off-by: Ingo Molnar
    Cc: Dave Jones
    Cc: Paul Mackerras
    Cc: Ralf Baechle
    Cc: Jens Axboe
    Cc: Neil Brown
    Acked-by: Alasdair G Kergon
    Cc: Greg KH
    Cc: Dominik Brodowski
    Cc: Adam Belay
    Cc: Martin Schwidefsky
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

07 Jan, 2006

1 commit

07 Nov, 2005

1 commit

  • 6044ec888   [PATCH] kfree cleanup: misc remaining drivers ... Browse Code »

    This is the remaining misc drivers/ part of the big kfree cleanup patch.

    Remove pointless checks for NULL prior to calling kfree() in misc files in
    drivers/.

    Signed-off-by: Jesper Juhl
    Acked-by: Aristeu Sergio Rozanski Filho
    Acked-by: Roland Dreier
    Acked-by: Pierre Ossman
    Acked-by: Jean Delvare
    Acked-by: Greg Kroah-Hartman
    Acked-by: Len Brown
    Acked-by: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds