16 Jun, 2015
2 commits
-
When CONFIG_SND_HDA_I915=n, we get a compile warning:
sound/pci/hda/hda_intel.c: In function ‘azx_probe_continue’:
sound/pci/hda/hda_intel.c:1882:2: warning: label ‘skip_i915’ defined but not used [-Wunused-label]Fix it by putting again ifdef to it. Sigh.
Fixes: bf06848bdbe5 ('ALSA: hda - Continue probing even if i915 binding fails')
Reported-by: Borislav Petkov
Signed-off-by: Takashi Iwai -
The new Dell XPS13 also requires the similar quirk for fixing the
noisy outputs. (But, as the codec was changed, now the fixup for
Latitude is used instead.)Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=99851
Signed-off-by: Takashi Iwai
15 Jun, 2015
3 commits
-
Fix the missing dependency on PCM stuff.
[Add the same fix for HAL2, too -- tiwai]
Signed-off-by: Nicholas Mc Guire
Signed-off-by: Takashi Iwai -
We still got a report that the audio crackles and noises occur with
the recent 4.1 kernels on Dell machines. These machines seem to need
similar workarounds that have been applied to the recent Dell XPS 13
models. Since the codec of these machines (Dell Latitute E7240 and
E7440) is different from XPS 13's one, we need a new fixup entry.Also, it was confirmed that the previous workaround to disable the
widget power-save (commit [219f47e4f964: ALSA: hda - Disable widget
power-saving for ALC292 & co]) is no longer needed after this fix.
So, this patch includes the partial revert of the commit, too.Reported-and-tested-by: Mihai Donțu
Tested-by: Jonathan McDowell
Signed-off-by: Takashi Iwai -
On a HP Envy TouchSmart laptop, there are 2 speakers (main speaker
and subwoofer speaker), 1 headphone and 2 DACs, without this fixup,
the headphone will be assigned to a DAC and the 2 speakers will be
assigned to another DAC, this assignment makes the surround-2.1
channels invalid.To fix it, here using a DAC/pin preference map to bind the main
speaker to 1 DAC and the subwoofer speaker will be assigned to another
DAC.Cc:
Signed-off-by: Hui Wang
Signed-off-by: Takashi Iwai
12 Jun, 2015
1 commit
-
The previous patch tried to continue the probe if i915 binding fails.
For for simplicity reason, we haven't implemented abort even for
controller chips that are dedicated for HDMI/DP on HSW and BDW.
However, Mengdong suggested that this can be dangerous; BIOS may
disable gfx power well although the PCI entry for HD-audio is left,
and this may result in the unexpected behavior, kernel errors, etc.For avoiding this situation, abort the probe at i915 binding failure
only for HSW/BDW chips selectively. For other chips, it still
continues.Fixes: bf06848bdbe5 ('ALSA: hda - Continue probing even if i915 binding fails')
Reported-by: Mengdong Lin
Signed-off-by: Takashi Iwai
11 Jun, 2015
2 commits
-
Yet another regression by the transition to regmap cache; for better
usability, we had the fake mute control using the zero amp value for
Conexant codecs, and this was forgotten in the new hda core code.Since the bits 4-7 are unused for the amp registers (as we follow the
syntax of AMP_GET verb), the bit 4 is now used to indicate the fake
mute. For setting this flag, snd_hda_codec_amp_update() becomes a
function from a simple macro. The bonus is that it gained a proper
function description.Signed-off-by: Takashi Iwai
-
Currently snd-hda-intel driver aborts the probing of Intel HD-audio
controller with i915 power well management when binding with i915
driver via hda_i915_init() fails. This is no big problem for Haswell
and Broadwell where the HD-audio controllers are dedicated to
HDMI/DP, thus i915 link is mandatory. However, Skylake, Baytrail and
Braswell have only one controller and both HDMI/DP and analog codecs
share the same bus. Thus, even if HDMI/DP isn't usable, we should
keep the controller working for other codecs.For fixing this, this patch simply allows continuing the probing even
if hda_i915_init() call fails. This may leave stale sound components
for HDMI/DP devices that are unbound with graphics. We could abort
the probing selectively, but from the code simplicity POV, it's better
to continue in all cases.Reported-by: Libin Yang
Signed-off-by: Takashi Iwai
10 Jun, 2015
1 commit
-
Along with the transition to regmap for managing the cached parameter
reads, the caps overwrite was also moved to regmap cache. The cache
change itself works, but it still tries to write the non-existing verb
(the HDA parameter is read-only) wrongly. It's harmless in most
cases, but some chips are picky and may result in the codec
communication stall.This patch avoids it just by adding the missing flag check in
reg_write ops.Signed-off-by: Takashi Iwai
09 Jun, 2015
1 commit
-
The new regmap code seems to cache this, which isn't helpful
for the hotplug dock situation where this gets updated.Use the uncached query for this.
Signed-off-by: Dave Airlie
Signed-off-by: Takashi Iwai
08 Jun, 2015
1 commit
-
This patch adds native DSD support for the XMOS based JLsounds I2SoverUSB board
Signed-off-by: Jurgen Kramer
Cc:
Signed-off-by: Takashi Iwai
03 Jun, 2015
3 commits
-
The driver worked around an error in the MAYA44 USB(+)'s mixer unit
descriptor by aborting before parsing the missing field. However,
aborting parsing too early prevented parsing of the other units
connected to this unit, so the capture mixer controls would be missing.Fix this by moving the check for this descriptor error after the parsing
of the unit's input pins.Reported-by: nightmixes
Tested-by: nightmixes
Signed-off-by: Clemens Ladisch
Cc:
Signed-off-by: Takashi Iwai -
Add mixer control names for the ESI Maya44 USB+ (which appears to be
identical width the AudioTrak Maya44 USB).Reported-by: nightmixes
Signed-off-by: Clemens Ladisch
Cc:
Signed-off-by: Takashi Iwai -
Acer Aspire 9420 with ALC883 (1025:0107) needs the fixup for EAPD to
make the sound working like other Aspire models.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=94111
Cc:
Signed-off-by: Takashi Iwai
31 May, 2015
1 commit
-
VT202x codecs seem requiring some delay after the resume D0 power
transition for making the jack detection working again. Without the
delay soon after D0, the jack is always detected as unplugged.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=98921
Signed-off-by: Takashi Iwai
30 May, 2015
1 commit
-
This quirk allows us to avoid the noisy:
current rate 0 is different from the runtime rate
message every time playback starts. While USB DAC in the RR2150
supports reading the sample rate, it never returns a sample rate
other than zero in my observation with common sample rates.Signed-off-by: Eric Wong
Cc: Joe Turner
Cc:
Signed-off-by: Takashi Iwai
29 May, 2015
3 commits
-
Fix this from the logs:
usb 7-1: New USB device found, idVendor=046d, idProduct=08ca
...
usb 7-1: Warning! Unlikely big volume range (=3072), cval->res is probably wrong.
usb 7-1: [5] FU [Mic Capture Volume] ch = 1, val = 4608/7680/1Signed-off-by: Wolfram Sang
Cc:
Signed-off-by: Takashi Iwai -
Dell SSID 0x0706 support headset mode.
Signed-off-by: Kailang Yang
Signed-off-by: Takashi Iwai -
The commit [49fb18972581: ALSA: hda - Set stream_pm ops automatically
by generic parser] resulted in regressions on some Realtek and VIA
codecs because these drivers set patch_ops after calling the generic
parser, thus stream_pm got cleared to NULL again. I haven't noticed
since I tested with IDT codec.Restore (partial revert) the stream_pm ops for them to fix the
regression.Fixes: 49fb18972581 ('ALSA: hda - Set stream_pm ops automatically by generic parser')
Reported-by: Jeremiah Mahler
Signed-off-by: Takashi Iwai
28 May, 2015
2 commits
-
When headphone mic boost is above zero, some 10 - 20 second delay
might occur before the headphone mic is operational.
Therefore disable the headphone mic boost control (recording gain is
sufficient even without it).(Note: this patch is not about the headset mic, it's about the less
common mic-in only mode.)BugLink: https://bugs.launchpad.net/bugs/1454235
Suggested-by: Kailang Yang
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
We've got a regression report that 4.1-rc causes noises on a Dell
laptop. Similar like Realtek codec, this seems also triggered by the
recent power_save_node feature. As this kind of issue is quite hard
to debug without actual hardware, disable the power_save_node flag for
this codec as a workaround.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=98971
Signed-off-by: Takashi Iwai
27 May, 2015
2 commits
-
A new AMD controller [1002:aac8] seems to need the quirk for other AMD
NS HDMI stuff, otherwise it gives noisy sounds.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=99021
Cc:
Signed-off-by: Takashi Iwai -
This allows user to test power_save_node feature via sysfs or patch
firmware even on the codecs that don't specify it. It'll also save a
few lines.Signed-off-by: Takashi Iwai
26 May, 2015
1 commit
-
Add ALC3246 for Dell platform.
Signed-off-by: Kailang Yang
Signed-off-by: Takashi Iwai
24 May, 2015
2 commits
-
This reverts commit 7290006d8c0900c56d8c58428134f02c35109d17.
Through the regression report, it was revealed that the
tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the
mute LED but actually mutes the sound. This is contradiction to the
expectation, and rather confuses user.According to Henrique, it's not trivial to judge which TP model
behaves "LED-only" and which model does whatever more intrusive, as
Lenovo's implementations vary model by model. So, from the safety
reason, we should revert the patch for now.Reported-by: Martin Steigerwald
Cc: Pali Rohár
Cc:
Signed-off-by: Takashi Iwai -
Microsoft LifeCam HD-3000 (045e:0779) needs a similar quirk for
suppressing the unsupported sample rate inquiry.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=98481
Cc:
Signed-off-by: Vittorio Gambaletta
Signed-off-by: Takashi Iwai
20 May, 2015
3 commits
-
We've got reports that ALC3226 (a Dell variant of ALC292) gives click
noises at transition from D3 to D0 when the widget power-saving is
enabled. Further debugging session showed that avoiding it isn't
trivial, unfortunately, since paths are basically activated
dynamically while the pins have been already enabled.This patch disables the widget power-saving for such codecs.
Reported-by: Jonathan McDowell
Signed-off-by: Takashi Iwai -
The widget (node) power-saves restore the widget states at each
transition from D3 to D0 on each node. This was added in the commit
[d545a57c5f84:ALSA: hda - Sync node attributes at resume from widget
power saving]. However, the test was rater false-positive; this
wasn't needed for any codecs.Since the resync may take significant number of additional verbs to be
executed, it's better to reduce it. Let's disable it for now again.Signed-off-by: Takashi Iwai
-
The recently added DT support for the ac97 driver is causing
a gcc warning:sound/atmel/ac97c.c: In function 'atmel_ac97c_probe_dt':
sound/atmel/ac97c.c:919:29: warning: unused variable 'match' [-Wunused-variable]
const struct of_device_id *match;The variable is clearly unused, so we can remove it.
Signed-off-by: Arnd Bergmann
Acked-by: Alexander Stein
Signed-off-by: Takashi Iwai
19 May, 2015
2 commits
-
Microsoft LifeCam Studio (045e:0772) needs a similar quirk for
suppressing the wrong sample rate inquiry.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=98481
Cc:
Signed-off-by: Takashi Iwai -
Currently in snd_pcm_update_hw_ptr0 during interrupt,
we consider there were double acknowledged interrupts when:
1. HW reported pointer is smaller than expected, and
2. Time from last update time (hdelta) is over half a buffer time.However, when HW reported pointer is only a few bytes smaller than
expected, and when hdelta is just a little larger than half a buffer time
(e.g. ping-pong buffer), it wrongly treats this IRQ as double acknowledged.The condition #2 uses jiffies, but jiffies is not high resolution
since it is integer. We should consider jiffies inaccuracy.Signed-off-by: Koro Chen
Signed-off-by: Takashi Iwai
18 May, 2015
4 commits
-
…roonie/sound into for-linus
ASoC: Fixes for v4.1
A few more fixes for v4.1, some driver fixes plus one core fix which
fixes registration of DAI links when adding prefixes to CODECs to
deuplicate in multi-CODEC systems. -
The Lenovo ThinkPad L450 requires the ALC292_FIXUP_TPT440_DOCK fix in
order to get sound output on the docking stations audio port.This patch was tested using a ThinkPad L450 (20DSS00B00) using kernel
4.0.3 and a ThinkPad Pro Dock.Signed-off-by: Ansgar Hegerfeld
Cc:
Signed-off-by: Takashi Iwai -
This patch adds support for Conexant HD Audio codecs
CX20721, CX20722, CX20723 and CX20724.Cc: stable@vger.kernel.org
BugLink: https://bugs.launchpad.net/bugs/1454656
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
ALC662 does not need any special verbs to change the jack functionality,
and enables mic in through the headphone jack mode by changing the
direction of the headphone pin node.BugLink: https://bugs.launchpad.net/bugs/1454235
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
13 May, 2015
5 commits
-
…/uda1380', 'asoc/fix/wm8960' and 'asoc/fix/wm8994' into asoc-linus
-
According to the RM of wm8958, BCLK DIV 348 doesn't exist, correct it
to 384.Signed-off-by: Zidan Wang
Acked-by: Charles Keepax
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
It should be "RINPUT3" instead of "LINPUT3" route to "Right Input
Mixer".Signed-off-by: Zidan Wang
Acked-by: Charles Keepax
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
When there is prefix specified, currently we will add this prefix in
widget->name, but not in widget->sname.
it causes failure at snd_soc_dapm_link_dai_widgets:if (!w->sname || !strstr(w->sname, dai_w->name))
because dai_w->name has prefix added, but w->sname does not.
We should also add prefix for stream nameSigned-off-by: Koro Chen
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
