29 Mar, 2006
1 commit
-
Mark the f_ops members of inodes as const, as well as fix the
ripple-through this causes by places that copy this f_ops and then "do
stuff" with it.Signed-off-by: Arjan van de Ven
Signed-off-by: Alexey Dobriyan
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
27 Mar, 2006
1 commit
-
Modify well over a dozen mempool users to call mempool_create_slab_pool()
rather than calling mempool_create() with extra arguments, saving about 30
lines of code and increasing readability.Signed-off-by: Matthew Dobson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
26 Mar, 2006
1 commit
-
This patch fixes i2o_dump_hrt output from dmesg:
iop0: HRT has 1 entries of 16 bytes each.
Adapter 00000012: TID 0000:[HPC*]:PCI 1: Bus 1 Device 22
Function 0Signed-off-by: Vasily Averin
Cc: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Mar, 2006
1 commit
-
i2o_exec_lct_modified() does not release memory allocated for work_struct.
Signed-off-by: Vasily Averin
Although your patch is the same, i've rewritten it a little bit for
naming consistency in the I2O driver.Acked-by: Markus Lidel
Signed-off-by: James Bottomley
06 Feb, 2006
1 commit
-
Fix http://bugzilla.kernel.org/show_bug.cgi?id=5923
When a scsi command failed, an oops would result.
Back-to-back SMART queries would make the Seagate drives unhappy. The
second SMART query would timeout, and the command would be aborted.Acked-by: Markus Lidel
Cc: Kenny Simpson
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 Feb, 2006
2 commits
-
- This controller violates the I2O spec for the I/O registers. The patch
contains a workaround which moves the registers to the proper location.
(originally author: Matthew Starzewski)- If a message frame is beyond the mapped address range a error is
returned.Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
If PCI device is enabled before probing, it will not be disabled at exit.
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
15 Jan, 2006
2 commits
-
There was a use before initialisation of c->name
Signed-off-by: James Bottomley
-
The problem in dpt_i2o could be the pci config space accesses it
triggers as it loads, dangerous to do if there is any I/O activity going
on in the other driver (probable if a boot driver I guess).I approve this patch to dpt_i2o.c, and am applying it to the Adaptec
branch of the driver.Thanks for the investigation Ryoji.
---
In linux 2.6.15, data transfer does hang when both dpt_i2o
and i2o_block drivers are loaded.
It seems that location of pci_request_regions() are wrong.
I moved it just behind pci_enable_device() like other drivers,
and it becomes fine.Signed-off-by: Ryoji Kamei
Signed-off-by: James Bottomley
10 Jan, 2006
1 commit
-
Signed-off-by: Adrian Bunk
09 Jan, 2006
1 commit
-
HDIO_GETGEO is implemented in most block drivers, and all of them have to
duplicate the code to copy the structure to userspace, as well as getting
the start sector. This patch moves that to common code [1] and adds a
->getgeo method to fill out the raw kernel hd_geometry structure. For many
drivers this means ->ioctl can go away now.[1] the s390 block drivers are odd in this respect. xpram sets ->start
to 4 always which seems more than odd, and the dasd driver shifts
the start offset around, probably because of it's non-standard
sector size.Signed-off-by: Christoph Hellwig
Cc: Jens Axboe
Cc:
Cc: Jeff Dike
Cc: Paolo Giarrusso
Cc: Bartlomiej Zolnierkiewicz
Cc: Neil Brown
Cc: Markus Lidel
Cc: Russell King
Cc: David Woodhouse
Cc: Martin Schwidefsky
Cc: James Bottomley
Signed-off-by: Adrian Bunk
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
07 Jan, 2006
8 commits
-
Manual fixup for merge with Jens' "Suspend support for libata", commit
ID 9b847548663ef1039dd49f0eb4463d001e596bc3.Signed-off-by: Linus Torvalds
-
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- make i2o_iop_free() static inline (from Adrian Bunk)
- changed kmalloc() + memset(0) into kzalloc()
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Fix some typos and minor code beautifying.
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- Removed some kmalloc's with __GFP_ZERO and replace it with memset()
because it didn't work properly.- Fixed returned message frame in i2o_cfg_passthru() which caused raidutils
to display wrong error message in case a disk was missing.- Fixed size of printk() in i2o_scsi.c.
- Fixed get_device() and put_device() in probing of the I2O controller.
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Removed wrong I2O device class, which was only needed to add sysfs attributes.
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Fix lot of BE LE bugs which prevent it from working on SPARC.
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Changed the I2O API to create I2O messages first in kernel memory and then
transfer it at once over the PCI bus instead of sending each quad-word over
the PCI bus.Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
06 Jan, 2006
1 commit
-
add @uptodate argument to end_that_request_last() and @error
to rq_end_io_fn(). there's no generic way to pass error code
to request completion function, making generic error handling
of non-fs request difficult (rq->errors is driver-specific and
each driver uses it differently). this patch adds @uptodate
to end_that_request_last() and @error to rq_end_io_fn().for fs requests, this doesn't really matter, so just using the
same uptodate argument used in the last call to
end_that_request_first() should suffice. imho, this can also
help the generic command-carrying request jens is working on.Signed-off-by: tejun heo
Signed-Off-By: Jens Axboe
19 Dec, 2005
1 commit
-
When dpt_i2o is loaded first, i2o being loaded would cause it to call
pci_device_disable, thus breaking dpt_i2o's use of the device. Based on
similar usage of pci_disable_device in other drivers.Signed-off-by: Ben Collins
Signed-off-by: Linus Torvalds
28 Nov, 2005
1 commit
-
The Coverity checker spotted this obvious NULL pointer dereference.
Signed-off-by: Adrian Bunk
Acked-by: Markus Lidel
Signed-off-by: Linus Torvalds
07 Nov, 2005
2 commits
-
Use schedule_timeout_interruptible() instead of
set_current_state()/schedule_timeout() to reduce kernel size.Signed-off-by: Nishanth Aravamudan
Cc: "Moore, Eric Dean"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Fix more include file problems that surfaced since I submitted the previous
fix-missing-includes.patch. This should now allow not to include sched.h
from module.h, which is done by a followup patch.Signed-off-by: Tim Schmielau
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
31 Oct, 2005
2 commits
-
I recently picked up my older work to remove unnecessary #includes of
sched.h, starting from a patch by Dave Jones to not include sched.h
from module.h. This reduces the number of indirect includes of sched.h
by ~300. Another ~400 pointless direct includes can be removed after
this disentangling (patch to follow later).
However, quite a few indirect includes need to be fixed up for this.In order to feed the patches through -mm with as little disturbance as
possible, I've split out the fixes I accumulated up to now (complete for
i386 and x86_64, more archs to follow later) and post them before the real
patch. This way this large part of the patch is kept simple with only
adding #includes, and all hunks are independent of each other. So if any
hunk rejects or gets in the way of other patches, just drop it. My scripts
will pick it up again in the next round.Signed-off-by: Tim Schmielau
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Typo fix: dots appearing after a newline in printk strings.
Signed-off-by: Jean Delvare
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
29 Oct, 2005
4 commits
-
The previous patch adding the ability to nest struct class_device
changed the paramaters to the call class_device_create(). This patch
fixes up all in-kernel users of the function.Signed-off-by: Greg Kroah-Hartman
-
I2O: cleanup - remove i2o_device_class
I2O devices reside on their own bus so there should be no reason
to also have i2c_device class that mirros i2o bus.Signed-off-by: Dmitry Torokhov
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Greg Kroah-Hartman
-
I2O: remove i2o_device_class_interface misuse
The intent of class interfaces was to provide different
'views' at the same object, not just run some code every
time a new class device is registered. Kill interface
structure, make class core register default attributes
and set up sysfs links right when registering class
devices.Signed-off-by: Dmitry Torokhov
Signed-off-by: Greg Kroah-Hartman
22 Sep, 2005
1 commit
-
We currently unregister the config-osm driver if initialization of the
legacy ioctl() handlers failed but still return success. We should be
returning -EBUSY in this case.Signed-off-by: Deepak Saxena
Cc: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
10 Aug, 2005
2 commits
-
Added pci_request_regions() before using the controller to avoid duplicate
usage of the I2O controller when the dpt_i2o driver and I2O subsystem is
loaded at the same time.Signed-off-by: Markus Lidel
Cc: James Bottomley
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Remove new configuration API from i2o_config
The API-patch is still available from the I2O website (which is mentioned in
the kernel config now). It is removed because it creates a new binary
sysfs-attribute, which doesn't have the limitiation of 4k. Expect for the
Adaptec controllers, which has a limitation in the hardware this attribute
doesn't make sense anywhere else. Until the sysfs API provides an attribute
which doesn't buffer (like firmware) and let access to at least 64k blocks i
provide a separate patch...(akpm: basically, this API was introduced post-2.6.12 and Markus wants to pull
it out before 2.6.13).Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
08 Jul, 2005
1 commit
-
Various stuff missing on alpha:
drivers/message/i2o/config-osm.c:35: error: field `fops' has incomplete type
drivers/message/i2o/config-osm.c: In function `sysfs_create_fops_file':
drivers/message/i2o/config-osm.c:71: error: storage size of `tmp' isn't known
drivers/message/i2o/config-osm.c:78: error: dereferencing pointer to incomplete type
drivers/message/i2o/config-osm.c:81: error: dereferencing pointer to incomplete typeSigned-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
24 Jun, 2005
6 commits
-
This patch updates all the device attribute callbacks that weren't
updated with the new parameter, I guess because they weren't in Greg's
tree (including drivers/pcmcia/ds.c). Without the patch these
callbacks are probably broken (and generate a warning along the lines
of "assignment from incompatible pointer type").Please see http://lkml.org/lkml/2005/5/19/40 for the scripts I used to
update the attributes automatically.Signed-off-by: Yani Ioannou
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
LD .tmp_vmlinux1
drivers/built-in.o: In function `i2o_cfg_parms':
config-osm.c:(.text+0x12764a): undefined reference to `i2o_parm_issue'Cc: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Set max sectors to 256 for Promise controllers.
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Lindent run and replaced printk() through the corresponding osm_*() function
Signed-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Changes:
- Added header "core.h" for i2o_core.ko internal definitions
- More sparse fixes
- Changed display of TID's in sysfs attributes from XXX to 0xXXX
- Use the right functions for accessing I/O and normal memory
- Removed error handling of SCSI device errors and let the SCSI layer
take care of it
- Added new device / removed device handling to SCSI-OSM
- Make status access volatile
- Cleaned up activation of I2O controller
- Removed unnecessary wmb() and rmb() calls
- Use own struct i2o_io for I/O memory instead of struct i2o_dmaSigned-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Changes:
- Provide SG_IO access to BLOCK and EXECUTIVE class on Adaptec
controllers
- Use PRIVATE messages in SCSI-OSM because on some controllers normal
SCSI class commands like READ or READ CAPACITY cause errors
- Use new DMA and SG list creation function
- Added workaround to limit sectors per request for Adaptec 2400A
controllersSigned-off-by: Markus Lidel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds