21 Jul, 2014
1 commit
-
Currently we're limited by a constant level of vlan nestings, and fail to
find anything beyound that level (currently 2).To fix this - remove the limit of nestings when going through device tree,
and when the end device is found - allocate the needed amount of vlan tags
and return them, instead of found/not found.CC: Jay Vosburgh
CC: Andy Gospodarek
Signed-off-by: Veaceslav Falico
Signed-off-by: David S. Miller
20 Jul, 2014
1 commit
-
Fixes: fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")
Fixes: 759a0cc5a3e1 ("cxgb4i: Add ipv6 code to driver, call into libcxgbi ipv6
api")
Signed-off-by: Anish Bhatt
Signed-off-by: David S. Miller
18 Jul, 2014
24 commits
-
Fixed error introduced in commit id 7730b4c (" cxgb4/iw_cxgb4: work request
logging feature") while compiling on 32 bit architecture reported by kbuild.Signed-off-by: Hariprasad Shenai
Signed-off-by: David S. Miller -
Implement per channel software TX and RX packet counters
accessed as ethtool statistics.This allows confirmation with MAC statistics.
Signed-off-by: Shradha Shah
Signed-off-by: David S. Miller -
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
The driver so far used adapter->num_vfs value to check if SR-IOV is enabled
or not. But, the patch bec84e6("create optimal number of queues on SR-IOV
config") changed this logic. The adapter->num_vfs value is validated and set
much before SR-IOV is enabled. So, we now use an explicit flag to track
SR-IOV enabled state.Signed-off-by: Vasundhara Volam
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
As SRIOV is not supported on BE2 chip, avoid calling be_get/set_sriov_config()
for BE2 chip.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
max-vfs value must be accessed via the macro be_max_vfs(adapter).
The earlier patch "create optimal number of queues on SR-IOV config"
by mistake, did not use this macro. This patch fixes it.fixes: bec84e6b ("be2net: create optimal number of queues on SR-IOV config")
Signed-off-by: Vasundhara Volam
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Replace "if (foo == NULL)" statements with "if (!foo)" to be consistent
across the driver.Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
A pointer to adapter struct is passed anyway to all of the FW-cmd routines
in be_cmds.c. For routines which query data from FW, the adapter pointer
is enough to return the queried fields.
There is no need to separately pass pointers to individual members of
the adapter structure. This patch fixes this for be_cmd_get_fw_ver()
and be_cmd_get_fw_cfg() routines.Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
This patch updates some description strings for BEx/Skyhawk-R
UE (unrecoverable error) status register bits. The appropriate strings
are logged when a UE is detected in the adapter.
Signed-off-by: Vasundhara Volam
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
The netlink layer expects a -ve status value to be returned when a driver
ndo method encounters an error. The driver was directly passing the
error status returned by FW (a positive value) to the stack.
This patch fixes this by returning -EIO status when a FW-cmd reports an error.Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
ethtool expects a -ve status value to be returned when a driver method
encounters an error. The driver was directly passing the
error status returned by FW (a positive value) to ethtool.
This patch fixes this by returning -EIO status in cases where FW returns
an error.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
When the FW stops responding with completions, return -ETIMEDOUT error
(instead of -1) to the stack.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
For FW download ethtool cmd, if the user provides an FW-image incompatible
with the chip, return -EINVAL instead of -1.Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Updating VF's tx-rate and FW-download are not allowed when the interface is
down. In such cases return -ENETDOWN to the stack.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Currently we might arrive to bond_net_exit() with some bonds left (that
were created while the module is unloading). We take care of that by
destroying sysfs (the last possibility to add new bonds) and then
destroying all the remaining bonds.However, we destroy the /proc/net/bonding directory before destroying those
last bonds, and get a warning that we're trying to destroy a non-empty
proc directory (containing /proc/net/bonding/bondX).Fix this by moving bond_destroy_proc_dir() after all the bonds are
destroyed, so that we're sure that no bonds exist.CC: Jay Vosburgh
CC: Andy Gospodarek
Signed-off-by: Veaceslav Falico
Signed-off-by: David S. Miller -
As it's always called with RTNL held, via dev_set_allmulti/promiscuity.
Also, remove the wrong comment.CC: Jay Vosburgh
CC: Andy Gospodarek
Signed-off-by: Veaceslav Falico
Acked-by: Eric Dumazet
Signed-off-by: David S. Miller -
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
Signed-off-by: David S. Miller -
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
Signed-off-by: David S. Miller -
Signed-off-by: Anish Bhatt
Signed-off-by: David S. Miller -
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication
Signed-off-by: Anish Bhatt
Acked-by: Steve Wise
Signed-off-by: David S. Miller -
Current L2 hash helper calculates destination eth addr and
source ether addr as L2 hash factors. This patch is adding
packet type ID field into L2 hash factors. While one of
BOND_XMIT_POLICY_LAYER2 or BOND_XMIT_POLICY_{LAYER|ENCAP}23
is applied, for the 2nd level hash, enhanced hash method can
help to distribute different types of packets like IPv4/IPv6
packets to different slave devices.CC: Jay Vosburgh
CC: Veaceslav Falico
CC: Andy Gospodarek
CC: David S. Miller
CC: Pan JiafeiAcked-by: Eric Dumazet
Signed-off-by: Jianhua Xie
Signed-off-by: David S. Miller -
v2: fixed issue with checking return of dcbnl_rtnl_ops->getapp()
Signed-off-by: Anish Bhatt
Signed-off-by: David S. Miller
17 Jul, 2014
14 commits
-
Jeff Kirsher says:
====================
Intel Wired LAN Driver Updates 2014-07-16This series contains updates to i40e only.
Neerav adds support to get the port MAC address from firmware and adds
support to the ndo_get_phys_port_id() callback to provide port specific
unique ids to the netdev layer.Jakub Kicinski provides 2 fixes, first fixes i40e to never generate a software
time stamp if the hardware time stamp is provided. Second fixes a race
condition on queueing skb for hardware time by using a simple bit lock to
avoid race conditions and leaking skbs when multiple transmit rings try
to claim time stamping.Paul does some general cleanup of the driver to remove unneeded spaces,
comments that are no longer valid, and break that will never get touched.Jacob Keller adds a verbose warning message when the incorrect PF attempts
to control timestamping for a port to which it was not assigned. The primary
intent of this message is to help debugging the reason why the SIOCSHWSTAMP
ioctl has failed and to help narrow the cause of the issue.
====================Signed-off-by: David S. Miller
-
In TLB mode if tlb_dynamic_lb is NOT set, slaves from the bond
group are selected based on the hash distribution. This does not
exclude dead links which are part of the bond. Also if there is a
temporary link event which brings down the interface, packets
hashed on that interface would be dropped too.This patch fixes these issues and distributes flows across the
UP links only. Also the array construction of links which are
capable of sending packets happen in the control path leaving
only link-selection during the data-path.One possible side effect of this is - at a link event; all
flows will be shuffled to get good distribution. But impact of
this should be minimum with the assumption that a member or
members of the bond group are not available is a very temporary
situation.Signed-off-by: Mahesh Bandewar
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
This patch allows to create PHYs from DT in case
if they are explicitly defined. The of_mdiobus_register() is
used for such purposes.For backward compatibility, call of_mdiobus_register() only in case
if at least one PHY's child is defined in DT, otherwise rollback to
mdiobus_register().Reviewed-by: Santosh Shilimkar
Acked-by: Mugunthan V N
Signed-off-by: Grygorii Strashko
Reviewed-by: Lad, Prabhakar
Signed-off-by: David S. Miller -
The similar MDIO HW blocks is used by keystone 2 SoCs as
in Davinci SoCs:
- one in Gigabit Ethernet (GbE) Switch Subsystem
See http://www.ti.com/lit/ug/sprugv9d/sprugv9d.pdf
- one in 10 Gigabit Ethernet Subsystem
See http://www.ti.com/lit/ug/spruhj5/spruhj5.pdfHence, reuse Davinci MDIO driver for Keystone 2 and
enable TI networking for Keystone 2 devicesReviewed-by: Santosh Shilimkar
Acked-by: Mugunthan V N
Signed-off-by: Grygorii Strashko
Reviewed-by: Lad, Prabhakar
Signed-off-by: David S. Miller -
In B0 steering mode if promiscuous QP asks to be detached from MCG entry,
and it is the only one in this entry then the entry will never be deleted.
This is a wrong behavior since we don't want to keep those entries after
the promiscuous QP becomes non-promiscuous. Therefore remove steering
entry containing only promiscuous QP.Signed-off-by: Saeed Mahameed
Signed-off-by: Eugenia Emantayev
Signed-off-by: Amir Vadai
Signed-off-by: David S. Miller -
In current situation host is adding the promiscuous QP to all steering
entries and the default entry as well. In this case when having PV
and SR-IOV on the same setup bridge will receive all traffic that is
targeted to the other VMs. This is bad.
Solution: In SR-IOV mode host can add promiscuous QP to default entry only.
The above problem and fix are relevant for B0 steering mode only.Signed-off-by: Eugenia Emantayev
Signed-off-by: Amir Vadai
Signed-off-by: David S. Miller -
In B0 steering mode when adding QPs to the default MCG entry need
to check that maximal number of QPs per MCG entry was not exceeded.Signed-off-by: Alexander Guller
Reviewed-by: Aviad Yehezkel
Signed-off-by: Eugenia Emantayev
Signed-off-by: Amir Vadai
Signed-off-by: David S. Miller -
To make sure that the array index isn't used in the code with
negative value, we stop using the for loop integer iterator
outside of it.
>From now on use members count to swap the last QP with removed one.
Fix also the second occurrence of this flow in mlx4_qp_detach_common().
In mlx4_qp_detach_common() use members_count instead of
loop iterator outside of the for loop.Signed-off-by: Dotan Barak
Reviewed-by: Yevgeny Petrilin
Signed-off-by: Eugenia Emantayev
Signed-off-by: Amir Vadai
Signed-off-by: David S. Miller -
When removing multicast address in B0 steering mode there is
a bug in cases where there is a single QP registered for the address,
and this QP is also promiscuous. In such cases the entry wouldn't be
deleted from the SW structure representing all Ethernet MCG entries,
but would be removed in HW. This way when driver goes to remove it
from SW and HW structures the HW deletion fails.
Moreover the same index could later be used for registering
different address, which can be Infiniband.Signed-off-by: Yevgeny Petrilin
Signed-off-by: Eugenia Emantayev
Signed-off-by: Amir Vadai
Signed-off-by: David S. Miller -
Commit d762d038497c9df51c19fcbe69b094b3bf8e5568 resets the counter holding the
next sequence number for multilink PPP fragments to zero whenever the
SC_MULTILINK flag is set. However, this counter only exists if
CONFIG_PPP_MULTILINK is defined. Consequently, the new code has to be enclosed
within #ifdef CONFIG_PPP_MULTILINK ... #endif.Signed-off-by: Christoph Schulz
Signed-off-by: David S. Miller -
Signed-off-by: David S. Miller
-
Display a verbose warning message when the incorrect PF attempts to
control timestamping for a port to which it was not assigned. This
shouldn't display except in the case of multiple PFs per port. The
primary intent of this message is to help debugging the reason why the
SIOCSHWTSTAMP ioctl has failed, and to help narrow the cause of the
issue.Change-ID: Ic98798e0c844d98389d4c20e7160ba256f2bc7e8
Signed-off-by: Jacob Keller
Tested-by: Jim Young
Signed-off-by: Jeff Kirsher -
1. Remove some break statements that will never get touched.
2. Remove an extra space.
3. Remove a comment for a parameter that doesn't exist
4. Move the assignment of a variable up to get rid of an else case.Change-ID: I308a4b5ec070b1f0601f13b041ba4375aaad4b06
Signed-off-by: Paul M Stillwell Jr
Tested-by: Jim Young
Tested-by: Sibai Li
Signed-off-by: Jeff Kirsher -
i40e has a single set of TX time stamping resources per NIC.
Use a simple bit lock to avoid race conditions and leaking skbs
when multiple TX rings try to claim time stamping.Signed-off-by: Jakub Kicinski
Tested-By: Jim Young
Signed-off-by: Jeff Kirsher
