11 May, 2007

2 commits

  • * 'for-linus' of git://git390.osdl.marist.edu/pub/scm/linux-2.6:
    [S390] update default configuration.
    [S390] Kconfig: no wireless on s390.
    [S390] Kconfig: use common Kconfig files for s390.
    [S390] Kconfig: common config options for s390.
    [S390] Kconfig: unwanted menus for s390.
    [S390] Kconfig: menus with depends on HAS_IOMEM.
    [S390] Kconfig: refine depends statements.
    [S390] Avoid compile warning.
    [S390] qdio: re-add lost perf_stats.tl_runs change in qdio_handle_pci
    [S390] Avoid sparse warnings.
    [S390] dasd: Fix modular build.
    [S390] monreader inlining cleanup.
    [S390] cio: Make some structures and a function static.
    [S390] cio: Get rid of _ccw_device_get_device_number().
    [S390] fix subsystem removal fallout

    Linus Torvalds
     
  • Reduce debugging noise generated by AF_RXRPC.

    Signed-off-by: David Howells
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     

10 May, 2007

16 commits

  • Hide the config menues for wireless on s390.

    Cc: John W. Linville
    Signed-off-by: Martin Schwidefsky

    Martin Schwidefsky
     
  • Disable some more menus in the configuration files that are of no
    interest to a s390 machine.

    Signed-off-by: Martin Schwidefsky

    Martin Schwidefsky
     
  • …e/wireless-2.6 into upstream

    Jeff Garzik
     
  • While the comment says:
    * To prevent rpciod from hanging, this allocator never sleeps,
    * returning NULL if the request cannot be serviced immediately.

    The function does not actually check for NULL pointers being returned.

    Signed-off-by: Peter Zijlstra
    Signed-off-by: Trond Myklebust

    Peter Zijlstra
     
  • Use a cleaner method to find the size of an rpc_buffer. This actually
    works on x86-64!

    Signed-off-by: Chuck Lever
    Signed-off-by: Trond Myklebust

    Chuck Lever
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial: (25 commits)
    sound: convert "sound" subdirectory to UTF-8
    MAINTAINERS: Add cxacru website/mailing list
    include files: convert "include" subdirectory to UTF-8
    general: convert "kernel" subdirectory to UTF-8
    documentation: convert the Documentation directory to UTF-8
    Convert the toplevel files CREDITS and MAINTAINERS to UTF-8.
    remove broken URLs from net drivers' output
    Magic number prefix consistency change to Documentation/magic-number.txt
    trivial: s/i_sem /i_mutex/
    fix file specification in comments
    drivers/base/platform.c: fix small typo in doc
    misc doc and kconfig typos
    Remove obsolete fat_cvf help text
    Fix occurrences of "the the "
    Fix minor typoes in kernel/module.c
    Kconfig: Remove reference to external mqueue library
    Kconfig: A couple of grammatical fixes in arch/i386/Kconfig
    Correct comments in genrtc.c to refer to correct /proc file.
    Fix more "deprecated" spellos.
    Fix "deprecated" typoes.
    ...

    Fix trivial comment conflict in kernel/relay.c.

    Linus Torvalds
     
  • Since nonboot CPUs are now disabled after tasks and devices have been
    frozen and the CPU hotplug infrastructure is used for this purpose, we need
    special CPU hotplug notifications that will help the CPU-hotplug-aware
    subsystems distinguish normal CPU hotplug events from CPU hotplug events
    related to a system-wide suspend or resume operation in progress. This
    patch introduces such notifications and causes them to be used during
    suspend and resume transitions. It also changes all of the
    CPU-hotplug-aware subsystems to take these notifications into consideration
    (for now they are handled in the same way as the corresponding "normal"
    ones).

    [oleg@tv-sign.ru: cleanups]
    Signed-off-by: Rafael J. Wysocki
    Cc: Gautham R Shenoy
    Cc: Pavel Machek
    Signed-off-by: Oleg Nesterov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Rafael J. Wysocki
     
  • This while loop has an overly complex condition, which performs a couple of
    assignments. This hurts readability.

    We don't really need a loop at all. We can just return -EAGAIN and (providing
    we set SK_DATA), the function will be called again.

    So discard the loop, make the complex conditional become a few clear function
    calls, and hopefully improve readability.

    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     
  • If I send a RPC_GSS_PROC_DESTROY message to NFSv4 server, it will reply with a
    bad rpc reply which lacks an authentication verifier. Maybe this patch is
    needed.

    Send/recv packets as following:

    send:

    RemoteProcedureCall
    xid
    rpcvers = 2
    prog = 100003
    vers = 4
    proc = 0
    cred = AUTH_GSS
    version = 1
    gss_proc = 3 (RPCSEC_GSS_DESTROY)
    service = 1 (RPC_GSS_SVC_NONE)
    verf = AUTH_GSS
    checksum

    reply:

    RemoteProcedureReply
    xid
    msg_type
    reply_stat
    accepted_reply

    Signed-off-by: Wei Yongjun
    Signed-off-by: "J. Bruce Fields"
    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Wei Yongjun
     
  • I have been investigating a module reference count leak on the server for
    rpcsec_gss_krb5.ko. It turns out the problem is a reference count leak for
    the security context in net/sunrpc/auth_gss/svcauth_gss.c.

    The problem is that gss_write_init_verf() calls gss_svc_searchbyctx() which
    does a rsc_lookup() but never releases the reference to the context. There is
    another issue that rpc.svcgssd sets an "end of time" expiration for the
    context

    By adding a cache_put() call in gss_svc_searchbyctx(), and setting an
    expiration timeout in the downcall, cache_clean() does clean up the context
    and the module reference count now goes to zero after unmount.

    I also verified that if the context expires and then the client makes a new
    request, a new context is established.

    Here is the patch to fix the kernel, I will start a separate thread to discuss
    what expiration time should be set by rpc.svcgssd.

    Acked-by: "J. Bruce Fields"
    Signed-off-by: Frank Filz
    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Frank Filz
     
  • It's not necessarily correct to assume that the xdr_buf used to hold the
    server's reply must have page data whenever it has tail data.

    And there's no need for us to deal with that case separately anyway.

    Acked-by: "J. Bruce Fields"
    Signed-off-by: Neil Brown
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     
  • register_rpc_pipefs() needs to clean up rpc_inode_cache
    by kmem_cache_destroy() on register_filesystem() failure.

    init_sunrpc() needs to unregister rpc_pipe_fs by unregister_rpc_pipefs()
    when rpc_init_mempool() returns error.

    Signed-off-by: Akinobu Mita
    Cc: Neil Brown
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     
  • When the kernel calls svc_reserve to downsize the expected size of an RPC
    reply, it fails to account for the possibility of a checksum at the end of
    the packet. If a client mounts a NFSv2/3 with sec=krb5i/p, and does I/O
    then you'll generally see messages similar to this in the server's ring
    buffer:

    RPC request reserved 164 but used 208

    While I was never able to verify it, I suspect that this problem is also
    the root cause of some oopses I've seen under these conditions:

    https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227726

    This is probably also a problem for other sec= types and for NFSv4. The
    large reserved size for NFSv4 compound packets seems to generally paper
    over the problem, however.

    This patch adds a wrapper for svc_reserve that accounts for the possibility
    of a checksum. It also fixes up the appropriate callers of svc_reserve to
    call the wrapper. For now, it just uses a hardcoded value that I
    determined via testing. That value may need to be revised upward as things
    change, or we may want to eventually add a new auth_op that attempts to
    calculate this somehow.

    Unfortunately, there doesn't seem to be a good way to reliably determine
    the expected checksum length prior to actually calculating it, particularly
    with schemes like spkm3.

    Signed-off-by: Jeff Layton
    Acked-by: Neil Brown
    Cc: Trond Myklebust
    Acked-by: J. Bruce Fields
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Layton
     
  • Now that sk_defer_lock protects two different things, make the name more
    generic.

    Also don't bother with disabling _bh as the lock is only ever taken from
    process context.

    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     
  • flush_work(wq, work) doesn't need the first parameter, we can use cwq->wq
    (this was possible from the very beginnig, I missed this). So we can unify
    flush_work_keventd and flush_work.

    Also, rename flush_work() to cancel_work_sync() and fix all callers.
    Perhaps this is not the best name, but "flush_work" is really bad.

    (akpm: this is why the earlier patches bypassed maintainers)

    Signed-off-by: Oleg Nesterov
    Cc: Jeff Garzik
    Cc: "David S. Miller"
    Cc: Jens Axboe
    Cc: Tejun Heo
    Cc: Auke Kok ,
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Oleg Nesterov
     
  • net/ipv4/ipvs/ip_vs_core.c

    module_exit
    ip_vs_cleanup
    ip_vs_control_cleanup
    cancel_rearming_delayed_work
    // done

    This is unsafe. The module may be unloaded and the memory may be freed
    while defense_work's handler is still running/preempted.

    Do flush_work(&defense_work.work) after cancel_rearming_delayed_work().

    Alternatively, we could add flush_work() to cancel_rearming_delayed_work(),
    but note that we can't change cancel_delayed_work() in the same manner
    because it may be called from atomic context.

    Signed-off-by: Oleg Nesterov
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Oleg Nesterov
     

09 May, 2007

5 commits

  • Signed-off-by: Michael Opdenacker
    Signed-off-by: Adrian Bunk

    Michael Opdenacker
     
  • Fix several typos in help text in Kconfig* files.

    Signed-off-by: David Sterba
    Signed-off-by: Adrian Bunk

    David Sterba
     
  • Commit c5a4dd8b7c15927a8fbff83171b57cad675a79b9 introduced the following
    compiler warnings:

    net/sunrpc/sched.c:766: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'size_t'
    net/sunrpc/sched.c:785: warning: format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'

    - Use %zu to format size_t
    - Kill 2 useless casts

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: Linus Torvalds

    Geert Uytterhoeven
     
  • Remove includes of where it is not used/needed.
    Suggested by Al Viro.

    Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
    sparc64, and arm (all 59 defconfigs).

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • 1) Introduces a new method in 'struct dentry_operations'. This method
    called d_dname() might be called from d_path() to build a pathname for
    special filesystems. It is called without locks.

    Future patches (if we succeed in having one common dentry for all
    pipes/sockets) may need to change prototype of this method, but we now
    use : char *d_dname(struct dentry *dentry, char *buffer, int buflen);

    2) Adds a dynamic_dname() helper function that eases d_dname() implementations

    3) Defines d_dname method for sockets : No more sprintf() at socket
    creation. This is delayed up to the moment someone does an access to
    /proc/pid/fd/...

    4) Defines d_dname method for pipes : No more sprintf() at pipe
    creation. This is delayed up to the moment someone does an access to
    /proc/pid/fd/...

    A benchmark consisting of 1.000.000 calls to pipe()/close()/close() gives a
    *nice* speedup on my Pentium(M) 1.6 Ghz :

    3.090 s instead of 3.450 s

    Signed-off-by: Eric Dumazet
    Acked-by: Christoph Hellwig
    Acked-by: Linus Torvalds
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric Dumazet
     

08 May, 2007

5 commits

  • In ieee80211, the output of scan results lists channels, but not
    frequencies, which are needed by NetworkManager. This patch uses
    the new ieee80211_channel_to_freq routine to add the frequency to the output.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     
  • The routines that interrogate the ieee80211_geo struct are missing a
    channel to frequency entry. This patch adds it.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     
  • More fallout from the removal of "struct subsystem" from the core device
    model.

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • * master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6:
    [NET]: rfkill: add support for input key to control wireless radio
    [NET] net/core: Fix error handling
    [TG3]: Update version and reldate.
    [TG3]: Eliminate spurious interrupts.
    [TG3]: Add ASPM workaround.
    [Bluetooth] Correct SCO buffer for another Broadcom based dongle
    [Bluetooth] Add support for Targus ACB10US USB dongle
    [Bluetooth] Disconnect L2CAP connection after last RFCOMM DLC
    [Bluetooth] Check that device is in rfcomm_dev_list before deleting
    [Bluetooth] Use in-kernel sockets API
    [Bluetooth] Attach host adapters to the Bluetooth bus
    [Bluetooth] Fix L2CAP and HCI setsockopt() information leaks

    Linus Torvalds
     
  • I have never seen a use of SLAB_DEBUG_INITIAL. It is only supported by
    SLAB.

    I think its purpose was to have a callback after an object has been freed
    to verify that the state is the constructor state again? The callback is
    performed before each freeing of an object.

    I would think that it is much easier to check the object state manually
    before the free. That also places the check near the code object
    manipulation of the object.

    Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
    compiled with SLAB debugging on. If there would be code in a constructor
    handling SLAB_DEBUG_INITIAL then it would have to be conditional on
    SLAB_DEBUG otherwise it would just be dead code. But there is no such code
    in the kernel. I think SLUB_DEBUG_INITIAL is too problematic to make real
    use of, difficult to understand and there are easier ways to accomplish the
    same effect (i.e. add debug code before kfree).

    There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
    clear in fs inode caches. Remove the pointless checks (they would even be
    pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.

    This is the last slab flag that SLUB did not support. Remove the check for
    unimplemented flags from SLUB.

    Signed-off-by: Christoph Lameter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Lameter
     

07 May, 2007

4 commits

  • The RF kill patch that provides infrastructure for implementing
    switches controlling radio states on various network and other cards.

    [dtor@insightbb.com: address review comments]
    [akpm@linux-foundation.org: cleanups, build fixes]

    Signed-off-by: Ivo van Doorn
    Signed-off-by: Andrew Morton
    Signed-off-by: Dmitry Torokhov
    Signed-off-by: David S. Miller

    Ivo van Doorn
     
  • Upon failure to register "ptype" procfs entry, "softnet_stat" was not
    removed, and an incorrect attempt was made to remove the "ptype" entry.

    Signed-off-by: Josef 'Jeff' Sipek
    Signed-off-by: David S. Miller

    Josef 'Jeff' Sipek
     
  • David S. Miller
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild: (38 commits)
    kconfig: fix mconf segmentation fault
    kbuild: enable use of code from a different dir
    kconfig: error out if recursive dependencies are found
    kbuild: scripts/basic/fixdep segfault on pathological string-o-death
    kconfig: correct minor typo in Kconfig warning message.
    kconfig: fix path to modules.txt in Kconfig help
    usr/Kconfig: fix typo
    kernel-doc: alphabetically-sorted entries in index.html of 'htmldocs'
    kbuild: be more explicit on missing .config file
    kbuild: clarify the creation of the LOCALVERSION_AUTO string.
    kbuild: propagate errors from find in scripts/gen_initramfs_list.sh
    kconfig: refer to qt3 if we cannot find qt libraries
    kbuild: handle compressed cpio initramfs-es
    kbuild: ignore section mismatch warning for references from .paravirtprobe to .init.text
    kbuild: remove stale comment in modpost.c
    kbuild/mkuboot.sh: allow spaces in CROSS_COMPILE
    kbuild: fix make mrproper for Documentation/DocBook/man
    kbuild: remove kconfig binaries during make mrproper
    kconfig/menuconfig: do not hardcode '.config'
    kbuild: override build timestamp & version
    ...

    Linus Torvalds
     

06 May, 2007

3 commits


05 May, 2007

5 commits

  • * git://git.linux-nfs.org/pub/linux/nfs-2.6: (28 commits)
    NFS: Fix a compile glitch on 64-bit systems
    NFS: Clean up nfs_create_request comments
    spkm3: initialize hash
    spkm3: remove bad kfree, unnecessary export
    spkm3: fix spkm3's use of hmac
    NFS4: invalidate cached acl on setacl
    NFS: Fix directory caching problem - with test case and patch.
    NFS: Set meaningful value for fattr->time_start in readdirplus results.
    NFS: Added support to turn off the NFSv3 READDIRPLUS RPC.
    SUNRPC: RPC client should retry with different versions of rpcbind
    SUNRPC: remove old portmapper
    NFS: switch NFSROOT to use new rpcbind client
    SUNRPC: switch the RPC server to use the new rpcbind registration API
    SUNRPC: switch socket-based RPC transports to use rpcbind
    SUNRPC: introduce rpcbind: replacement for in-kernel portmapper
    SUNRPC: Eliminate side effects from rpc_malloc
    SUNRPC: RPC buffer size estimates are too large
    NLM: Shrink the maximum request size of NLM4 requests
    NFS: Use pgoff_t in structures and functions that pass page cache offsets
    NFS: Clean up nfs_sync_mapping_wait()
    ...

    Linus Torvalds
     
  • The RFCOMM specification says that the device closing the last DLC on
    a particular session is responsible for closing the multiplexer by
    closing the corresponding L2CAP channel.

    Signed-off-by: Ville Tervo
    Signed-off-by: Marcel Holtmann

    Marcel Holtmann
     
  • If RFCOMM_RELEASE_ONHUP flag is on and rfcomm_release_dev is called
    before connection is closed, rfcomm_dev is deleted twice from the
    rfcomm_dev_list and refcount is messed up. This patch adds a check
    before deleting device that the device actually is listed.

    Signed-off-by: Ville Tervo
    Signed-off-by: Marcel Holtmann

    Marcel Holtmann
     
  • The kernel provides a new convenient way to access the sockets API for
    in-kernel users. It is a good idea to actually use it.

    Signed-off-by: Marcel Holtmann

    Marcel Holtmann
     
  • The Bluetooth host adapters are attached to the Bluetooth class and the
    low-level connections are children of these class devices. Having class
    devices as parent of bus devices breaks a lot of reasonable assumptions
    about sysfs. The host adapters should be attached to the Bluetooth bus
    to simplify the dependency resolving. For compatibility an additional
    symlink from the Bluetooth class will be used.

    Signed-off-by: Marcel Holtmann

    Marcel Holtmann