13 Feb, 2009

1 commit

• 1d7b33f77   wimax: fix oops in wimax_dev_get_by_genl_info() when looking up non-wimax iface ... Browse Code »

  When a non-wimax interface is looked up by the stack, a bad pointer is
  returned when the looked-up interface is not found in the list (of
  registered WiMAX interfaces). This causes an oops in the caller when
  trying to use the pointer.

  Fix by properly setting the pointer to NULL if we don't exit from the
  list_for_each() with a found entry.

  Signed-off-by: Inaky Perez-Gonzalez
  Signed-off-by: David S. Miller

  Inaky Perez-Gonzalez

  2009-02-13 09:00:20 +0800  

09 Jan, 2009

1 commit

• d48e470f7   wimax: fix '#ifndef CONFIG_BUG' layout to avoid warning ... Browse Code »

  Reported by Randy Dunlap:

  > Also, this warning needs to be fixed:
  >
  > linux-next-20090106/net/wimax/id-table.c:133: warning: ISO C90
  > forbids mixed declarations and code

  Move the return on #defined(CONFIG_BUG) below the variable
  declarations so it doesn't violate ISO C90.

  On wimax_id_table_release() we want to do a debug check if CONFIG_BUG
  is enabled. However, we also want the debug code to be always compiled
  to ensure there is no bitrot. It will be optimized out by the compiler
  when CONFIG_BUG is disabled.

  Added a note to the function header stating this.

  Signed-off-by: Inaky Perez-Gonzalez
  Signed-off-by: David S. Miller

  Inaky Perez-Gonzalez

  2009-01-09 03:06:48 +0800  

08 Jan, 2009

1 commit

• 15530dfd3   wimax: generic device management (registration, deregistration, lookup) ... Browse Code »

  Implements the basic life cycles of a 'struct wimax_dev', some common
  generic netlink functionality for marshalling calls to user space,
  and the device state machine.

  For looking up net devices based on their generic netlink family IDs,
  use a low overhead method that optimizes for the case where most
  systems have a single WiMAX device, or at most, a very low number of
  WiMAX adaptors.

  Signed-off-by: Inaky Perez-Gonzalez
  Signed-off-by: Greg Kroah-Hartman

  Inaky Perez-Gonzalez

  2009-01-08 02:00:17 +0800