24 Jul, 2006
3 commits
-
Fix ABBA deadlock between lock_cpu_hotplug() and the cpuset
callback_mutex lock.It only happens on cpu_exclusive cpusets, due to the dynamic
sched domain code trying to take the cpu hotplug lock inside
the cpuset callback_mutex lock.This bug has apparently been here for several months, but didn't
get hit until the right customer load on a large system.This fix appears right from inspection, but it will take a few
more days running it on that customers workload to be confident
we nailed it. We don't have any other reproducible test case.The cpu_hotplug_lock() tends to cover large runs of code.
The other places that hold both that lock and the cpuset callback
mutex lock always nest the cpuset lock inside the hotplug lock.
This place tries to do the reverse, risking an ABBA deadlock.This is in the cpuset_rmdir() code, where we:
* take the callback_mutex lock
* mark the cpuset CS_REMOVED
* call update_cpu_domains for cpu_exclusive cpusets
* in that call, take the cpu_hotplug lock if the
cpuset is marked for removal.Thanks to Jack Steiner for identifying this deadlock.
The fix is to tear down the dynamic sched domain before we grab
the cpuset callback_mutex lock. This way, the two locks are
serialized, with the hotplug lock taken and released before
trying for the cpuset lock.I suspect that this bug was introduced when I changed the
cpuset locking from one lock to two. The dynamic sched domain
dependency on cpu_exclusive cpusets and its hotplug hooks were
added to this code earlier, when cpusets had only a single lock.
It may well have been fine then.Signed-off-by: Paul Jackson
Signed-off-by: Linus Torvalds -
The CPU hotplug locking was quite messy, with a recursive lock to
handle the fact that both the actual up/down sequence wanted to
protect itself from being re-entered, but the callbacks that it
called also tended to want to protect themselves from CPU events.This splits the lock into two (one to serialize the whole hotplug
sequence, the other to protect against the CPU present bitmaps
changing). The latter still allows recursive usage because some
subsystems (ondemand policy for cpufreq at least) had already gotten
too used to the lax locking, but the locking mistakes are hopefully
now less fundamental, and we now warn about recursive lock usage
when we see it, in the hope that it can be fixed.Signed-off-by: Linus Torvalds
-
Shutting down the ondemand policy was fraught with potential
problems, causing issues for SMP suspend (which wants to hot-
unplug) all but the last CPU.This should fix at least the worst problems (divide-by-zero
and infinite wait for the workqueue to shut down).Signed-off-by: Linus Torvalds
22 Jul, 2006
37 commits
-
* master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6: (21 commits)
[TIPC]: Removing useless casts
[IPV4]: Fix nexthop realm dumping for multipath routes
[DUMMY]: Avoid an oops when dummy_init_one() failed
[IFB] After ifb_init_one() failed, i is increased. Decrease
[NET]: Fix reversed error test in netif_tx_trylock
[MAINTAINERS]: Mark LAPB as Oprhan.
[NET]: Conversions from kmalloc+memset to k(z|c)alloc.
[NET]: sun happymeal, little pci cleanup
[IrDA]: Use alloc_skb() in IrDA TX path
[I/OAT]: Remove pci_module_init() from Intel I/OAT DMA engine
[I/OAT]: net/core/user_dma.c should #include
[SCTP]: ADDIP: Don't use an address as source until it is ASCONF-ACKed
[SCTP]: Set chunk->data_accepted only if we are going to accept it.
[SCTP]: Verify all the paths to a peer via heartbeat before using them.
[SCTP]: Unhash the endpoint in sctp_endpoint_free().
[SCTP]: Check for NULL arg to sctp_bucket_destroy().
[PKT_SCHED] netem: Fix slab corruption with netem (2nd try)
[WAN]: Converted synclink drivers to use netif_carrier_*()
[WAN]: Cosmetic changes to N2 and C101 drivers
[WAN]: Added missing netif_dormant_off() to generic HDLC
... -
Removing useless casts
Signed-off-by: Panagiotis Issaris
Signed-off-by: David S. Miller -
Routing realms exist per nexthop, but are only returned to userspace
for the first nexthop. This is due to the fact that iproute2 only
allows to set the realm for the first nexthop and the kernel refuses
multipath routes where only a single realm is present.Dump all realms for multipath routes to enable iproute to correctly
display them.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Nicolas Dichtel
Signed-off-by: David S. Miller -
It before entering in the loop for freeing the other ifb devices.
Signed-off-by: Nicolas Dichtel
Acked-by: Jamal Hadi Salim
Signed-off-by: David S. Miller -
A non-zero return value indicates success from spin_trylock,
not error.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Maintainer email not longer exists.
Signed-off-by: David S. Miller
-
Signed-off-by: Panagiotis Issaris
Signed-off-by: David S. Miller -
Use pci_register_driver instead of pci_module_init. Use PCI_DEVICE macro.
Signed-off-by: Jiri Slaby
Signed-off-by: David S. Miller -
As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be
used for allocating TX sk_buff. The IrDA stack was exclusively calling
dev_alloc_skb() on the TX path, and this patch fixes that.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller -
Changes pci_module_init() to pci_register_driver().
Signed-off-by: Henrik Kretzschmar
Signed-off-by: David S. Miller -
Every file should #include the headers containing the prototypes for
its global functions.Especially in cases like this one where gcc can tell us through a
compile error that the prototype was wrong...Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
This implements Rules D1 and D4 of Sec 4.3 in the ADDIP draft.
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
Currently there is a code path in sctp_eat_data() where it is possible
to set this flag even when we are dropping this chunk.Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
This patch implements Path Initialization procedure as described in
Sec 2.36 of RFC4460.Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
This prevents a race between the close of a socket and receive of an
incoming packet.Signed-off-by: Vlad Yasevich
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
CONFIG_DEBUG_SLAB found the following bug:
netem_enqueue() in sch_netem.c gets a pointer inside a slab object:
struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb;
But then, the slab object may be freed:
skb = skb_unshare(skb, GFP_ATOMIC)
cb is still pointing inside the freed skb, so here is a patch to
initialize cb later, and make it clear that initializing it sooner
is a bad idea.[From Stephen Hemminger: leave cb unitialized in order to let gcc
complain in case of use before initialization]Signed-off-by: Guillaume Chazarain
Signed-off-by: David S. Miller -
WAN: Converted synclink drivers to use netif_carrier_*() instead
of hdlc_set_carrier().Signed-off-by: Krzysztof Halasa
Signed-off-by: David S. Miller -
WAN: Cosmetic changes to N2 and C101 drivers
Signed-off-by: Krzysztof Halasa
Signed-off-by: David S. Miller -
WAN: Fixed a problem with PPP/raw HDLC/X.25 protocols not doing
netif_dormant_off() at startup.Signed-off-by: Krzysztof Halasa
Signed-off-by: David S. Miller -
Now that we always zero the IPCB->opts in ip_rcv, it is no longer
necessary to do so before calling netif_rx for tunneled packets.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Signed-off-by: David S. Miller
-
Found by scrashme.
Signed-off-by: David S. Miller
-
Just do a linear enumeration so that we handle sun4d systems
correctly. As a consequence, eliminate the hard coded keyboard and
mouse channel line values, use the CONS_{KEYB,MS} flags instead.Also, report the keyboard/mouse Zilog channels just like the uart ones
do.Signed-off-by: David S. Miller
-
We do it now in sunzilog_init() after all devices have been
probed.Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
By using for_each_node_by_type().
Also, correct a spurioud test in check_cpu_node() on sparc64.
It is only called with nodes that have device_type "cpu".Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
1) Explicitly traverse to the root looking for the "sbi".
2) Grab the "board#" property from the sbi's parent and
verify that this parent is an "io-unit" node.
3) Skip IRQ initialization when device lacks "reg" property.Signed-off-by: David S. Miller
-
Otherwise we will deref half-initialized channel pointers
and crash in the interrupt handler.Signed-off-by: David S. Miller
-
Just name them "sbus%d" otherwise on sun4d we try to register
multiple entries named "sbi@0,0" which does not work.Based upon a report from Raymond Burns.
Signed-off-by: David S. Miller
-
On sparc32 the prom_{first,next}prop() interfaces work
a little differently. The buffer argument is ignored on
sparc32 and the firmware just returns a raw pointer to
the property name.Signed-off-by: David S. Miller
-
Table sizing code should look for "se" not "su" nodes.
The chip at the lower address should get the first index.
Signed-off-by: David S. Miller
-
Register second SAB port before the first one, as serial A is wired to
it, and expected to appear as ttyS0.Signed-off-by: Marc Zyngier
Signed-off-by: David S. Miller -
The m68k port's sun3 asm/oplib.h had a stray reference too, so I
killed that off as well.Signed-off-by: David S. Miller
