17 Jan, 2012
1 commit
-
Until we get a datasheet for the IT8728F, treat it as fully compatible
with the IT8721F, as it seems to work reasonably well.This closes kernel bug #27262.
Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
06 Jan, 2012
1 commit
-
replaced strict_strtol with kstrtol and
replaced strict_strtuol with kstrtuolThis satisfies checkpatch -f
Compile tested only: no warnings or errors givenSigned-off-by: Frans Meulenbroeks
Signed-off-by: Guenter Roeck
26 Jul, 2011
1 commit
-
Add chassis intrusion detection support for all supported devices,
using the standard interface.Signed-off-by: Jean Delvare
18 Jul, 2011
1 commit
-
A copy-and-paste error caused it87_attributes_vid to be referenced
where it87_attributes_label should be. Thankfully the group is only
used for attribute removal, not attribute creation, so the effects of
this bug are limited, but let's fix it still.Signed-off-by: Jean Delvare
Cc: stable@kernel.org
Acked-by: Guenter Roeck
26 May, 2011
1 commit
-
Serialize access to the hardware by using "request_muxed_region" macro
defined by Alan Cox. Call to this macro will hold off the requestor if
the resource is currently busy. "superio_enter" will return an error
if call to "request_muxed_region" fails. Rest of the code change is to
ripple an error return from superio_enter to the top level.Signed-off-by: Nat Gurumoorthy
Acked-by: Guenter Roeck
Signed-off-by: Jean Delvare
13 Jan, 2011
1 commit
-
Added #define pr_fmt KBUILD_MODNAME ": " fmt
Converted printks to pr_
Coalesced any long formats
Removed prefixes from formatsSigned-off-by: Joe Perches
Signed-off-by: Jean Delvare
08 Dec, 2010
1 commit
-
The manual fan speed control logic of the IT8721F is much different
from what older devices had. Update the code to properly support that.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
29 Oct, 2010
2 commits
-
Add support for the IT8721F/IT8758E. These new chips differ from the
older IT87xxF chips in the following ways:
* ADC LSB is 12 mV instead of 16 mV.
* PWM values are 8-bit instead of 7-bit.
There are other minor changes we don't have to care about in the
driver.Another change is that we will handle internal voltage scaling in the
driver instead of delegating the work to user-space.Signed-off-by: Jean Delvare
-
Move conversion functions until after structure defintions. This is
needed for future changes which make use of the structures in the
conversion funtcions.Signed-off-by: Jean Delvare
15 Aug, 2010
1 commit
-
Some voltage sensors can be wired internally to the IT87xxF chip's own
power supply channels. In that case, we can inform user-space that the
wiring is known by exporting proper labels for these sensors.Signed-off-by: Jean Delvare
09 Jul, 2010
1 commit
-
The IT8720F has no VIN7 pin, so VCCH should always be routed
internally to VIN7 with an internal divider. Curiously, there still
is a configuration bit to control this, which means it can be set
incorrectly. And even more curiously, many boards out there are
improperly configured, even though the IT8720F datasheet claims that
the internal routing of VCCH to VIN7 is the default setting. So we
force the internal routing in this case.It turns out that all boards with the wrong setting are from Gigabyte,
so I suspect a BIOS bug. But it's easy enough to workaround in the
driver, so let's do it.Signed-off-by: Jean Delvare
Cc: Jean-Marc Spaggiari
Cc: stable@kernel.org
14 Apr, 2010
3 commits
-
When any temperature sensor type is changed, the corresponding
temperature value needs to be updated. The register caching mechanism
may delay this update, so we want to invalidate the cache to force an
immediate update.Signed-off-by: Jean Delvare
-
Currently, if someone tries to set the thermal sensor type to an
unsupported value, subsequent accesses to the chip may temporarily
show the sensor in question as disabled. Use a temporary variable
and only update the cached value on success, to prevent such
confusion.Signed-off-by: Jean Delvare
-
Temperature channels can be used in 2 different modes (thermistor and
thermal diode) and we don't know which one, if any, is correct for
every given board. So don't arbitrarily choose one. Instead, leave the
temperature channels untouched. They can be configured from user-space
if needed anyway.Signed-off-by: Jean Delvare
06 Mar, 2010
9 commits
-
Before switching to automatic fan control mode, make sure that all the
trip points make sense. Otherwise, the control loop could lead to
weird fan behavior.Signed-off-by: Jean Delvare
-
Add support for the automatic fan speed control interface as
implemented by IT8705F chips up to revision F and IT8712F chips up to
revision G. This implementation fits very well in our standard sysfs
interface.I implemented the old and not the new interface because the only chip
I have at hand is an old one, and the new interface is more difficult
to map to the standard sysfs interface. Adding support later should be
possible though, if someone with a supported chip is interested.Signed-off-by: Jean Delvare
-
For consistency and robustness, use strict_strtol instead of
simple_strtol.Signed-off-by: Jean Delvare
-
Fix 20 errors and 11 warnings reported by the checkpatch script. The
remainining errors would require more work. The remaining warnings
will be addressed later.Signed-off-by: Jean Delvare
-
The IT87xxF chips support beeping on alarm, if properly wired and
configured. There is one control bit for each input type (temperature,
fan, voltage.) Let the user see and change them.Signed-off-by: Jean Delvare
-
Only VID-related attributes are left in it87_attributes_opt, so we
might as well rename it to it87_attributes_vid and use this group to
create all attributes at once.Signed-off-by: Jean Delvare
-
There is a lot of code redundancy in the creation of the fan and
pwm attributes. Move these attributes to arrays so that the code can
be simplified.This in turns makes the attributes removal code larger, so move it to
a separate function that can be called in both the standard removal
case and the error path during probing.Signed-off-by: Jean Delvare
-
Let the user read the PWM-to-temperature mappings. Until the trip
points are also exposed, this is essentially a way to know how the
BIOS has set things up. The ability to change the settings will be
added later, together with the trip points.Signed-off-by: Jean Delvare
-
The it87 driver doesn't yet support automatic fan control. Let it at
least tell the user when a fan output is in automatic mode. Also let
the user switch from automatic mode (possibly set by the BIOS) to
manual mode and back without losing the settings.Signed-off-by: Jean Delvare
10 Dec, 2009
2 commits
-
The fan2 and fan3 input and output pins can be used as GPIOs. Check
their function before exposing their sysfs attributes and accessing
their registers.Signed-off-by: Jean Delvare
-
The VID input pins can alternatively be used as GPIOs. Make sure we
have at least 4 pins used for VID, otherwise don't bother reading and
exposing VID.Signed-off-by: Jean Delvare
Tested-by: Adam Nielsen
24 Oct, 2009
1 commit
-
Comparing apples to bananas doesn't seem right. Consistently use the
chips enum for chip type comparisons, to avoid such bugs in the
future.The bug has been there since support for the IT8718F was added, so
VID never worked for this chip nor for the similar IT8720F.Signed-off-by: Jean Delvare
15 Sep, 2009
1 commit
-
Drivers should be including instead of .
Signed-off-by: H Hartley Sweeten
Cc: Alistair John Strachan
Cc: Nicolas Boichat
Cc: Juerg Haefliger
Cc: Frank Seidel
Acked-by: Jim Cromie
Cc: "Mark M. Hoffman"
Cc: Roger Lucas
Signed-off-by: Jean Delvare
12 Mar, 2009
1 commit
-
The it87 driver is reporting -128 degrees C as +128 degrees C.
That's not a terribly likely temperature value but let's still
get it right, especially when it simplifies the code.Signed-off-by: Jean Delvare
07 Jan, 2009
3 commits
-
Signed-off-by: Jean Delvare
Acked-by: Hans de Goede
Acked-by: David Hubbard -
Check for ACPI resource conflicts in hwmon drivers. I've included
all Super-I/O and PCI drivers.I've voluntarily left out:
* Vendor-specific drivers: if they conflicted on any system, this would
pretty much mean that they conflict on all systems, and we would know
by now.
* Legacy ISA drivers (lm78 and w83781d): they only support chips found
on old designs were ACPI either wasn't supported or didn't deal with
thermal management.
* Drivers accessing the I/O resources indirectly (e.g. through SMBus):
the checks are already done where they belong, i.e. in the bus drivers.Signed-off-by: Jean Delvare
Acked-by: David Hubbard -
Allow it87.c to handle IT8720 chipset like IT8718 in order to
retrieve voltage, temperatures and fans speed from sensors
tools. Also updating the related documentation.Signed-off-by: Jean-Marc Spaggiari
Signed-off-by: Jean Delvare
17 Oct, 2008
1 commit
-
The it87 driver doesn't follow the standard sensor type values as
documented in Documentation/hwmon/sysfs-interface. It uses value 2 for
thermistors instead of value 4. This causes "sensors" to tell the user
that the chip is setup for a transistor while it is actually setup for
a thermistor.Using value 4 for thermistors solves the problem. For compatibility
reasons, we still accept value 2 but emit a warning message so that
users update their configuration files.Signed-off-by: Jean Delvare
Acked-by: Hans de Goede
09 Oct, 2008
1 commit
-
On the Shuttle SN68PT, FAN_CTL2 is apparently not connected to a fan,
but to something else. One user has reported instant system power-off
when changing the PWM2 duty cycle, so we disable it.I use the board name string as the trigger in case the same board is
ever used in other systems.This closes lm-sensors ticket #2349:
pwmconfig causes a hard poweroff
http://www.lm-sensors.org/ticket/2349Signed-off-by: Jean Delvare
20 Sep, 2008
1 commit
-
The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
The driver was incorrectly attempting to enable 16-bit fan
readings on rev 0x7 (I) which led to incorrect RPM values.Signed-off-by: Andrew Paprocki
Tested-by: John Gumb
Signed-off-by: Jean Delvare
07 Aug, 2008
2 commits
-
The it8705 chip supports 16-bit fan tachometers in revisions at least
>= 0x03 (Version G). This patch enables 16-bit fan readings on all
revisions >= 0x03 just like the it8712, it8716, and it8718 chips.Signed-off-by: Andrew Paprocki
Signed-off-by: Jean Delvare -
The it8712 chip supports 16-bit fan tachometers in revisions >= 0x07.
Revisions >= 0x08 dropped support for 8-bit fan divisor registers. The
patch enables 16-bit fan readings on all revisions >= 0x07 just like
the it8716 and it8718 chips.Signed-off-by: Andrew Paprocki
Signed-off-by: Jean Delvare
08 Feb, 2008
3 commits
-
In commit f8d0c19a93cea3a26a90f2462295e1e01a4cd250 I forgot to delete
the pwmN_freq files on driver removal, here's the fix.Signed-off-by: Jean Delvare
Acked-by: Riku Voipio
Signed-off-by: Mark M. Hoffman -
The new libsensors needs this.
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman