08 Apr, 2013
11 commits
-
Most times that mesh_path_add() is called, it is followed by
a lookup to get the just-added mpath. We can instead just
return the new mpath in the case that we allocated one (or the
existing one if already there), so do that. Also, reorder the
code in mesh_path_add a bit so that we don't need to allocate
in the pre-existing case.Signed-off-by: Bob Copeland
Signed-off-by: Johannes Berg -
The mesh hwmp debug message is a bit confusing. The "sending PREP
to %p" should be the MAC address of mesh STA that has originated
the PREQ message and the "received PREP from %pM" should be the MAC
address of the mesh STA that has originated the PREP message.Signed-off-by: Chun-Yeow Yeoh
Signed-off-by: Johannes Berg -
Instead of open-coding the accesses and length check do
the length check in the IE parser and assign a struct
pointer for use in the remaining code.Signed-off-by: Johannes Berg
-
It's always just one byte, so check for that and
remove the length field from the parser struct.Signed-off-by: Johannes Berg
-
It's always just one byte, so check for that and
remove the length field from the parser struct.Signed-off-by: Johannes Berg
-
There's no need to parse IEs that aren't used
so just remove them.Signed-off-by: Johannes Berg
-
The master interface no longer exists ... and hasn't for
a few years now, so remove this reference :-)Signed-off-by: Johannes Berg
-
I don't think we should send the events unless it was actually
a beacon that was lost...not just any probe of an AP.Signed-off-by: Ben Greear
Signed-off-by: Johannes Berg -
Beacon-timeout and number of beacon loss events.
Signed-off-by: Ben Greear
Signed-off-by: Johannes Berg -
Drivers can now advertise VHT support even if they don't use channel
contexts.Signed-off-by: Karl Beldan
Signed-off-by: Johannes Berg -
It is possible since the global hw config and local switched to
cfg80211_chan_def.Signed-off-by: Karl Beldan
Signed-off-by: Johannes Berg
26 Mar, 2013
1 commit
-
Drivers that don't use chanctxes cannot perform VHT association because
they still use a "backward compatibility" pair of {ieee80211_channel,
nl80211_channel_type} in ieee80211_conf and ieee80211_local.Signed-off-by: Karl Beldan
[fix kernel-doc]
Signed-off-by: Johannes Berg
25 Mar, 2013
4 commits
-
mac80211 currently sets uAPSD parameters to have VO AC trigger-
and delivery-enabled, with maximum service period length.Allow drivers to change these default settings since different
uAPSD client implementations may handle errors differently and
be able to recover from some errors.Note: some APs may not function correctly if one or all ACs are
trigger- and delivery-enabled, see
http://thread.gmane.org/gmane.linux.kernel.wireless.general/93577.
We retested with this AP and later firmware doesn't have this
bug any more.Signed-off-by: Alexander Bondar
Signed-off-by: Johannes Berg -
Instead of having an SKB all the time, use a beacon_data struct
with just the information required. This also allows removing a
synchronize_rcu() and using kfree_rcu() instead.Signed-off-by: Johannes Berg
-
If we don't disable beaconing, the driver might attempt
to continue, but would fail to request a beacon. That's
strange, so disable beaconing first.Signed-off-by: Johannes Berg
-
This was forgotten from the commit that added support for FT
operations with drivers that implement SME.Signed-off-by: Jouni Malinen
Signed-off-by: Johannes Berg
22 Mar, 2013
4 commits
-
Add P2P NoA settings for STA mode.
Signed-off-by: Janusz Dziedzic
[fix docs]
Signed-off-by: Johannes Berg -
Use ieee80211_p2p_noa_attr structure during
P2P_PS (oppps) detection.Signed-off-by: Janusz Dziedzic
Signed-off-by: Johannes Berg -
Add P2P Notice of Absence attribute structure.
Signed-off-by: Janusz Dziedzic
Signed-off-by: Johannes Berg -
On loaded systems with lots of VIFs, I see lots of beacon
timeouts, even though the connection to the AP is very
good. Allow tuning the beacon-loss-count variable to
give the system longer to process beacons if the user
prefers.Signed-off-by: Ben Greear
[add the number of beacons to the message]
Signed-off-by: Johannes Berg
21 Mar, 2013
1 commit
-
For the sake of speed of calculation and number accuracy,
mac80211 tracks the RSSI in dBm * 16. But it forgot to
divide back by 16 when the RSSI is asked by the driver.Signed-off-by: Emmanuel Grumbach
Signed-off-by: Johannes Berg
20 Mar, 2013
2 commits
-
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.Signed-off-by: Wei Yongjun
Signed-off-by: Johannes Berg -
If wpa_supplicant and iw/iwconfig are used together, very
rarely the system crashes. It seems to be related to the
connection parameters not being set up, but it's not all
clear to me how this happens. In any case, checking that
the conn pointer exists here is probably a good idea.Signed-off-by: Johannes Berg
19 Mar, 2013
8 commits
-
When an interface change type, the CAB queue must be reassigned,
do this in hwsim to avoid warnings/crashes.Reported-by: Jouni Malinen
Signed-off-by: Johannes Berg -
Sometimes queues are flushed in the middle of
operation, which can lead to driver issues.
Stop queues temporarily, while flushing, to
avoid transmitting new packets while they are
being flushed.Signed-off-by: Johannes Berg
-
There are a number of situations in which mac80211 only
really needs to flush queues for one virtual interface,
and in fact during this frames might be transmitted on
other virtual interfaces. Calculate and pass a queue
bitmap to the driver so it knows which queues to flush.Signed-off-by: Johannes Berg
-
max_tp_rate2 and max_prob_rate tend to get used occasionally during
retransmission, which is more useful for the statistics than probing
with individual probe packets.Signed-off-by: Felix Fietkau
Signed-off-by: Johannes Berg -
Slow rates that have >95% success probability do not need to be
monitored continuously. When the channel conditions change rapidly, the
slow sampling results are useless anyway. When conditions change slowly,
they will be monitored by gradual downgrading of the actively used
rates. This patch slightly improves throughput under good conditions.Signed-off-by: Felix Fietkau
Signed-off-by: Johannes Berg -
Under load, otherwise stable rates can easily fluctuate because of
collisions. In my tests on a clean channel, the success probability of
the max throughput rate often stays somewhere between 90% and 100% under
load. This can cause some unnecessary switching to lower rates.
This patch improves stability by treating success probability values
between 90% and 100% the same.
In my tests on a 3x3 HT20 link with lots of TCP traffic, it improves the
average throughput by a few mbit/s.Signed-off-by: Felix Fietkau
Signed-off-by: Johannes Berg -
This basically reverts commit b207cdb07f3f01ec1adaac62e9d0cc918c60a81a.
Now is possible to use drv_{add,remove}_interface() and vif->debugfs_dir
to create/remove per interface debugfs files. Remove redundant
callbacks.Signed-off-by: Stanislaw Gruszka
Signed-off-by: Johannes Berg -
There is need create driver own per interface debugfs files. This is
currently done by drv_{add,remove}_interface_debugfs() callbacks. But it
is possible that after we remove interface from the driver (i.e.
on suspend) we call drv_remove_interface_debugfs() function. Fixing this
problem will require to add call drv_{add,remove}_interface_debugfs()
anytime we create and remove interface in mac80211. So it's better to
add debugfs dir dentry to vif structure to allow to create/remove
custom debugfs driver files on drv_{add,remove}_interface().Signed-off-by: Stanislaw Gruszka
Signed-off-by: Johannes Berg
11 Mar, 2013
5 commits
-
Some devices have multicast filter capability for each individual
virtual interface rather than just a global one. Add an interface
specific driver callback allowing such drivers to configure this.Signed-off-by: Alexander Bondar
Signed-off-by: Johannes Berg -
Found by compiling with W=1.
Signed-off-by: Johannes Berg
-
Instead of calling synchronize_net() for every key
on an interface or when a station is removed, do it
only once for all keys in both of these cases.As a side-effect, removing station keys now always
calls synchronize_net() even if there are no keys,
which fixes an issue with station removal happening
in the driver while the station could still be used
for TX.Signed-off-by: Johannes Berg
-
Some key function don't exist without underscores, so
remove the underscores from those.Signed-off-by: Johannes Berg
-
When a key is allocated but not really added, there's no
need to go through the entire teardown process. Also, if
adding a key fails, ieee80211_key_link() can take care of
freeing it instead of the (only) caller.Signed-off-by: Johannes Berg
07 Mar, 2013
3 commits
-
It is possible that sta_info_recalc_tim() is called consecutively
without changing the station's tim bit. In such cases there is no
need to call the driver's set_tim() callback.Signed-off-by: Ilan Peer
Signed-off-by: Johannes Berg -
The irqsafe version ieee80211_sta_eosp_irqsafe() exists, but
drivers must not mix calls to any irqsafe/non-irqsafe function.
Both ath9k and iwlwifi, the likely first users of this interface,
use non-irqsafe RX/TX/TX status so must also use a non-irqsafe
version of this function. Since no driver uses the _irqsafe()
version, remove that.Signed-off-by: Johannes Berg
-
Make the TX bytes/packets counters race-free by keeping
them per AC so concurrent TX on queues can't cause lost
or wrong updates. This works since each station belongs
to a single interface. While at it also make the bytes
counters 64-bit.Signed-off-by: Johannes Berg
06 Mar, 2013
1 commit
-
There is a corner case which wasn't being covered:
userspace may authenticate and allocate stations,
but still leave the peering up to the kernel.Initialize the peering timer if the MPM is not in
userspace, in a path which is taken by both the kernel and
userspace when allocating stations.Signed-off-by: Thomas Pedersen
Signed-off-by: Johannes Berg
