Eric Lee / smarc-fsl-linux-kernel

30 Nov, 2020

1 commit

02 Nov, 2020

1 commit

  • d9b5665fb   kbuild: remove unused OBJSIZE ... Browse Code »

    The "size" tool has been solely used by s390 to enforce .bss section usage
    restrictions in early startup code. Since commit 980d5f9ab36b ("s390/boot:
    enable .bss section for compressed kernel") and commit 2e83e0eb85ca
    ("s390: clean .bss before running uncompressed kernel") these restrictions
    have been lifted for the decompressor and uncompressed kernel and the
    size tool is now unused.

    Signed-off-by: Vasily Gorbik
    Reviewed-by: Nathan Chancellor
    Signed-off-by: Masahiro Yamada

    Vasily Gorbik
     

25 Oct, 2020

1 commit

21 Oct, 2020

1 commit

14 Oct, 2020

1 commit

  • eb38f37c3   kbuild: doc: describe proper script invocation ... Browse Code »

    During an investigation to fix up the execute bits of scripts in the
    kernel repository, Andrew Morton and Kees Cook pointed out that the
    execute bit should not matter, and that build scripts cannot rely on that.
    Kees could not point to any documentation, though.

    Masahiro Yamada explained the convention of setting execute bits to make
    it easier for manual script invocation.

    Provide some basic documentation how the build shall invoke scripts, such
    that the execute bits do not matter, and acknowledge that execute bits are
    useful nonetheless.

    This serves as reference for further clean-up patches in the future.

    Suggested-by: Andrew Morton
    Suggested-by: Kees Cook
    Signed-off-by: Lukas Bulwahn
    Signed-off-by: Andrew Morton
    Cc: Masahiro Yamada
    Cc: Michal Marek
    Cc: Jonathan Corbet
    Cc: Ujjwal Kumar
    Cc: Lukas Bulwahn
    Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
    Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
    Link: https://lore.kernel.org/linux-kbuild/CAK7LNAQdrvMkDA6ApDJCGr+5db8SiPo=G+p8EiOvnnGvEN80gA@mail.gmail.com/
    Link: https://lkml.kernel.org/r/20201001075723.24246-1-lukas.bulwahn@gmail.com
    Signed-off-by: Linus Torvalds

    Lukas Bulwahn
     

13 Oct, 2020

1 commit

  • 50d228345   Merge tag 'docs-5.10' of git://git.lwn.net/linux ... Browse Code »

    Pull documentation updates from Jonathan Corbet:
    "As hoped, things calmed down for docs this cycle; fewer changes and
    almost no conflicts at all. This includes:

    - A reworked and expanded user-mode Linux document

    - Some simplifications and improvements for submitting-patches.rst

    - An emergency fix for (some) problems with Sphinx 3.x

    - Some welcome automarkup improvements to automatically generate
    cross-references to struct definitions and other documents

    - The usual collection of translation updates, typo fixes, etc"

    * tag 'docs-5.10' of git://git.lwn.net/linux: (81 commits)
    gpiolib: Update indentation in driver.rst for code excerpts
    Documentation/admin-guide: tainted-kernels: Fix typo occured
    Documentation: better locations for sysfs-pci, sysfs-tagging
    docs: programming-languages: refresh blurb on clang support
    Documentation: kvm: fix a typo
    Documentation: Chinese translation of Documentation/arm64/amu.rst
    doc: zh_CN: index files in arm64 subdirectory
    mailmap: add entry for
    doc: seq_file: clarify role of *pos in ->next()
    docs: trace: ring-buffer-design.rst: use the new SPDX tag
    Documentation: kernel-parameters: clarify "module." parameters
    Fix references to nommu-mmap.rst
    docs: rewrite admin-guide/sysctl/abi.rst
    docs: fb: Remove vesafb scrollback boot option
    docs: fb: Remove sstfb scrollback boot option
    docs: fb: Remove matroxfb scrollback boot option
    docs: fb: Remove framebuffer scrollback boot option
    docs: replace the old User Mode Linux HowTo with a new one
    Documentation/admin-guide: blockdev/ramdisk: remove use of "rdev"
    Documentation/admin-guide: README & svga: remove use of "rdev"
    ...

    Linus Torvalds
     

28 Sep, 2020

1 commit

26 Sep, 2020

1 commit

  • e30d694c3   Documentation/llvm: Fix clang target examples ... Browse Code »

    clang --target= is how we can specify a particular toolchain
    triple to be use, fix the two occurences in the documentation.

    Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
    Signed-off-by: Florian Fainelli
    Reviewed-by: Nick Desaulniers
    Reviewed-by: Nathan Chancellor
    Signed-off-by: Masahiro Yamada

    Florian Fainelli
     

07 Sep, 2020

1 commit

03 Sep, 2020

1 commit

  • b26ff488b   kbuild: Documentation: clean up makefiles.rst ... Browse Code »

    This is a general cleanup of kbuild/makefiles.rst:

    * Use "Chapter" for major heading references and use "section" for
    the next-level heading references, for consistency.
    * Section 3.8 was deleted long ago.
    * Drop the ending ':' in section names in the contents list.
    * Correct some section numbering references.
    * Correct verb agreement typo.
    * Fix run-on sentence punctuation.

    Signed-off-by: Randy Dunlap
    Signed-off-by: Masahiro Yamada

    Randy Dunlap
     

01 Sep, 2020

1 commit

  • 3519c4d6e   Documentation: add minimum clang/llvm version ... Browse Code »

    Based on a vote at the LLVM BoF at Plumbers 2020, we decided to start
    small, supporting just one formal upstream release of LLVM for now.

    We can probably widen the support window of supported versions over
    time. Also, note that LLVM's release process is different than GCC's.
    GCC tends to have 1 major release per year while releasing minor updates
    to the past 3 major versions. LLVM tends to support one major release
    and one minor release every six months.

    Signed-off-by: Nick Desaulniers
    Tested-by: Gustavo A. R. Silva
    Tested-by: Nathan Chancellor
    Reviewed-by: Kees Cook
    Reviewed-by: Nathan Chancellor
    Reviewed-by: Masahiro Yamada
    Acked-by: Will Deacon
    Link: https://lore.kernel.org/r/20200826191555.3350406-1-ndesaulniers@google.com
    Signed-off-by: Jonathan Corbet

    Nick Desaulniers
     

31 Aug, 2020

1 commit

  • 91a9d5021   Documentation/llvm: Improve formatting of commands, variables, and arguments ... Browse Code »

    While reviewing a separate patch, I noticed that the formatting of the
    commands, variables, and arguments was not in a monospaced font like the
    rest of the Kbuild documentation (see kbuild/kconfig.rst for an
    example). This is due to a lack of "::" before indented command blocks
    and single backticks instead of double backticks for inline formatting.

    Add those so that the document looks nicer in an HTML format, while not
    ruining the look in plain text.

    As a result of this, we can remove the escaped backslashes in the last
    code block and move them to single backslashes.

    Signed-off-by: Nathan Chancellor
    Reviewed-by: Nick Desaulniers
    Signed-off-by: Masahiro Yamada

    Nathan Chancellor
     

10 Aug, 2020

5 commits

  • c592c0732   Merge fc80c51fd4b2 ("Merge tag 'kbuild-v5.9' of git://git.kernel.org/pub/scm/lin… ... Browse Code »

    …ux/kernel/git/masahiroy/linux-kbuild") into android-mainline

    Steps on the way to 5.9-rc1

    Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
    Change-Id: I75b7f1589f230e546c0f2103456fd725c8866460

    Greg Kroah-Hartman
     
  • fc80c51fd   Merge tag 'kbuild-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild ... Browse Code »

    Pull Kbuild updates from Masahiro Yamada:

    - run the checker (e.g. sparse) after the compiler

    - remove unneeded cc-option tests for old compiler flags

    - fix tar-pkg to install dtbs

    - introduce ccflags-remove-y and asflags-remove-y syntax

    - allow to trace functions in sub-directories of lib/

    - introduce hostprogs-always-y and userprogs-always-y syntax

    - various Makefile cleanups

    * tag 'kbuild-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
    kbuild: stop filtering out $(GCC_PLUGINS_CFLAGS) from cc-option base
    kbuild: include scripts/Makefile.* only when relevant CONFIG is enabled
    kbuild: introduce hostprogs-always-y and userprogs-always-y
    kbuild: sort hostprogs before passing it to ifneq
    kbuild: move host .so build rules to scripts/gcc-plugins/Makefile
    kbuild: Replace HTTP links with HTTPS ones
    kbuild: trace functions in subdirectories of lib/
    kbuild: introduce ccflags-remove-y and asflags-remove-y
    kbuild: do not export LDFLAGS_vmlinux
    kbuild: always create directories of targets
    powerpc/boot: add DTB to 'targets'
    kbuild: buildtar: add dtbs support
    kbuild: remove cc-option test of -ffreestanding
    kbuild: remove cc-option test of -fno-stack-protector
    Revert "kbuild: Create directory for target DTB"
    kbuild: run the checker after the compiler

    Linus Torvalds
     
  • faabed295   kbuild: introduce hostprogs-always-y and userprogs-always-y ... Browse Code »

    To build host programs, you need to add the program names to 'hostprogs'
    to use the necessary build rule, but it is not enough to build them
    because there is no dependency.

    There are two types of host programs: built as the prerequisite of
    another (e.g. gen_crc32table in lib/Makefile), or always built when
    Kbuild visits the Makefile (e.g. genksyms in scripts/genksyms/Makefile).

    The latter is typical in Makefiles under scripts/, which contains host
    programs globally used during the kernel build. To build them, you need
    to add them to both 'hostprogs' and 'always-y'.

    This commit adds hostprogs-always-y as a shorthand.

    The same applies to user programs. net/bpfilter/Makefile builds
    bpfilter_umh on demand, hence always-y is unneeded. In contrast,
    programs under samples/ are added to both 'userprogs' and 'always-y'
    so they are always built when Kbuild visits the Makefiles.

    userprogs-always-y works as a shorthand.

    Signed-off-by: Masahiro Yamada
    Acked-by: Miguel Ojeda

    Masahiro Yamada
     
  • 16a122c74   kbuild: Replace HTTP links with HTTPS ones ... Browse Code »

    Rationale:
    Reduces attack surface on kernel devs opening the links for MITM
    as HTTPS traffic is much harder to manipulate.

    Deterministic algorithm:
    For each file:
    If not .svg:
    For each line:
    If doesn't contain `\bxmlns\b`:
    For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
    If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
    If both the HTTP and HTTPS versions
    return 200 OK and serve the same content:
    Replace HTTP with HTTPS.

    Signed-off-by: Alexander A. Klimov
    Signed-off-by: Masahiro Yamada

    Alexander A. Klimov
     
  • 15d5761ad   kbuild: introduce ccflags-remove-y and asflags-remove-y ... Browse Code »

    CFLAGS_REMOVE_.o filters out flags when compiling a particular
    object, but there is no convenient way to do that for every object in
    a directory.

    Add ccflags-remove-y and asflags-remove-y to make it easily.

    Use ccflags-remove-y to clean up some Makefiles.

    The add/remove order works as follows:

    [1] KBUILD_CFLAGS specifies compiler flags used globally

    [2] ccflags-y adds compiler flags for all objects in the
    current Makefile

    [3] ccflags-remove-y removes compiler flags for all objects in the
    current Makefile (New feature)

    [4] CFLAGS_ adds compiler flags per file.

    [5] CFLAGS_REMOVE_ removes compiler flags per file.

    Having [3] before [4] allows us to remove flags from most (but not all)
    objects in the current Makefile.

    For example, kernel/trace/Makefile removes $(CC_FLAGS_FTRACE)
    from all objects in the directory, then adds it back to
    trace_selftest_dynamic.o and CFLAGS_trace_kprobe_selftest.o

    The same applies to lib/livepatch/Makefile.

    Please note ccflags-remove-y has no effect to the sub-directories.
    In contrast, the previous notation got rid of compiler flags also from
    all the sub-directories.

    The following are not affected because they have no sub-directories:

    arch/arm/boot/compressed/
    arch/powerpc/xmon/
    arch/sh/
    kernel/trace/

    However, lib/ has several sub-directories.

    To keep the behavior, I added ccflags-remove-y to all Makefiles
    in subdirectories of lib/, except the following:

    lib/vdso/Makefile - Kbuild does not descend into this Makefile
    lib/raid/test/Makefile - This is not used for the kernel build

    I think commit 2464a609ded0 ("ftrace: do not trace library functions")
    excluded too much. In the next commit, I will remove ccflags-remove-y
    from the sub-directories of lib/.

    Suggested-by: Sami Tolvanen
    Signed-off-by: Masahiro Yamada
    Acked-by: Steven Rostedt (VMware)
    Acked-by: Michael Ellerman (powerpc)
    Acked-by: Brendan Higgins (KUnit)
    Tested-by: Anders Roxell

    Masahiro Yamada
     

07 Aug, 2020

1 commit

05 Aug, 2020

2 commits

  • 2324d50d0   Merge tag 'docs-5.9' of git://git.lwn.net/linux ... Browse Code »

    Pull documentation updates from Jonathan Corbet:
    "It's been a busy cycle for documentation - hopefully the busiest for a
    while to come. Changes include:

    - Some new Chinese translations

    - Progress on the battle against double words words and non-HTTPS
    URLs

    - Some block-mq documentation

    - More RST conversions from Mauro. At this point, that task is
    essentially complete, so we shouldn't see this kind of churn again
    for a while. Unless we decide to switch to asciidoc or
    something...:)

    - Lots of typo fixes, warning fixes, and more"

    * tag 'docs-5.9' of git://git.lwn.net/linux: (195 commits)
    scripts/kernel-doc: optionally treat warnings as errors
    docs: ia64: correct typo
    mailmap: add entry for
    doc/zh_CN: add cpu-load Chinese version
    Documentation/admin-guide: tainted-kernels: fix spelling mistake
    MAINTAINERS: adjust kprobes.rst entry to new location
    devices.txt: document rfkill allocation
    PCI: correct flag name
    docs: filesystems: vfs: correct flag name
    docs: filesystems: vfs: correct sync_mode flag names
    docs: path-lookup: markup fixes for emphasis
    docs: path-lookup: more markup fixes
    docs: path-lookup: fix HTML entity mojibake
    CREDITS: Replace HTTP links with HTTPS ones
    docs: process: Add an example for creating a fixes tag
    doc/zh_CN: add Chinese translation prefer section
    doc/zh_CN: add clearing-warn-once Chinese version
    doc/zh_CN: add admin-guide index
    doc:it_IT: process: coding-style.rst: Correct __maybe_unused compiler label
    futex: MAINTAINERS: Re-add selftests directory
    ...

    Linus Torvalds
     
  • 280812bec   ANDROID: kbuild: Add support for installing out-of-tree kernel headers ... Browse Code »

    Add support for installing out-of-tree kernel headers. The
    "headers_install" target was copied to the external module compilation
    section (lines 1245:1270), and the src/obj variables were tweaked to
    include $(KBUILD_EXTMODULE).

    Bug: 162332589
    Change-Id: I2e2c7598612bea94267e6a9bc6d0793da53915ac
    Signed-off-by: Elliot Berman

    Elliot Berman
     

13 Jul, 2020

1 commit

07 Jul, 2020

1 commit

  • 893ab0043   kbuild: remove cc-option test of -fno-stack-protector ... Browse Code »

    Some Makefiles already pass -fno-stack-protector unconditionally.
    For example, arch/arm64/kernel/vdso/Makefile, arch/x86/xen/Makefile.

    No problem report so far about hard-coding this option. So, we can
    assume all supported compilers know -fno-stack-protector.

    GCC 4.8 and Clang support this option (https://godbolt.org/z/_HDGzN)

    Get rid of cc-option from -fno-stack-protector.

    Remove CONFIG_CC_HAS_STACKPROTECTOR_NONE, which is always 'y'.

    Note:
    arch/mips/vdso/Makefile adds -fno-stack-protector twice, first
    unconditionally, and second conditionally. I removed the second one.

    Signed-off-by: Masahiro Yamada
    Reviewed-by: Kees Cook
    Acked-by: Ard Biesheuvel
    Reviewed-by: Nick Desaulniers

    Masahiro Yamada
     

28 Jun, 2020

2 commits

06 Jun, 2020

1 commit

25 May, 2020

1 commit

17 May, 2020

1 commit

  • e079a08c6   kbuild: doc: document the new syntax 'userprogs' ... Browse Code »

    Kbuild now supports the syntax 'userprogs' to compile userspace
    programs for the same architecture as the kernel.

    Insert the section '5 Userspace Program support' to explain it.

    I copy-pasted '4 Host Program support' and fixed it up.

    Signed-off-by: Masahiro Yamada
    Acked-by: Sam Ravnborg

    Masahiro Yamada
     

23 Apr, 2020

1 commit

09 Apr, 2020

2 commits

  • a0d1c951e   kbuild: support LLVM=1 to switch the default tools to Clang/LLVM ... Browse Code »

    As Documentation/kbuild/llvm.rst implies, building the kernel with a
    full set of LLVM tools gets very verbose and unwieldy.

    Provide a single switch LLVM=1 to use Clang and LLVM tools instead
    of GCC and Binutils. You can pass it from the command line or as an
    environment variable.

    Please note LLVM=1 does not turn on the integrated assembler. You need
    to pass LLVM_IAS=1 to use it. When the upstream kernel is ready for the
    integrated assembler, I think we can make it default.

    We discussed what we need, and we agreed to go with a simple boolean
    flag that switches both target and host tools:

    https://lkml.org/lkml/2020/3/28/494
    https://lkml.org/lkml/2020/4/3/43

    Some items discussed, but not adopted:

    - LLVM_DIR

    When multiple versions of LLVM are installed, I just thought supporting
    LLVM_DIR=/path/to/my/llvm/bin/ might be useful.

    CC = $(LLVM_DIR)clang
    LD = $(LLVM_DIR)ld.lld
    ...

    However, we can handle this by modifying PATH. So, we decided to not do
    this.

    - LLVM_SUFFIX

    Some distributions (e.g. Debian) package specific versions of LLVM with
    naming conventions that use the version as a suffix.

    CC = clang$(LLVM_SUFFIX)
    LD = ld.lld(LLVM_SUFFIX)
    ...

    will allow a user to pass LLVM_SUFFIX=-11 to use clang-11 etc.,
    but the suffixed versions in /usr/bin/ are symlinks to binaries in
    /usr/lib/llvm-#/bin/, so this can also be handled by PATH.

    Signed-off-by: Masahiro Yamada
    Reviewed-by: Nathan Chancellor
    Tested-by: Nathan Chancellor # build
    Tested-by: Nick Desaulniers
    Reviewed-by: Nick Desaulniers

    Masahiro Yamada
     
  • 7e20e47c7   kbuild: replace AS=clang with LLVM_IAS=1 ... Browse Code »

    The 'AS' variable is unused for building the kernel. Only the remaining
    usage is to turn on the integrated assembler. A boolean flag is a better
    fit for this purpose.

    AS=clang was added for experts. So, I replaced it with LLVM_IAS=1,
    breaking the backward compatibility.

    Suggested-by: Nick Desaulniers
    Signed-off-by: Masahiro Yamada
    Reviewed-by: Nathan Chancellor
    Reviewed-by: Nick Desaulniers

    Masahiro Yamada
     

08 Apr, 2020

1 commit

01 Apr, 2020

1 commit

  • 5b67fbfc3   Merge tag 'kbuild-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild ... Browse Code »

    Pull Kbuild updates from Masahiro Yamada:
    "Build system:

    - add CONFIG_UNUSED_KSYMS_WHITELIST, which will be useful to define a
    fixed set of export symbols for Generic Kernel Image (GKI)

    - allow to run 'make dt_binding_check' without .config

    - use full schema for checking DT examples in *.yaml files

    - make modpost fail for missing MODULE_IMPORT_NS(), which makes more
    sense because we know the produced modules are never loadable

    - Remove unused 'AS' variable

    Kconfig:

    - sanitize DEFCONFIG_LIST, and remove ARCH_DEFCONFIG from Kconfig
    files

    - relax the 'imply' behavior so that symbols implied by 'y' can
    become 'm'

    - make 'imply' obey 'depends on' in order to make 'imply' really weak

    Misc:

    - add documentation on building the kernel with Clang/LLVM

    - revive __HAVE_ARCH_STRLEN for 32bit sparc to use optimized strlen()

    - fix warning from deb-pkg builds when CONFIG_DEBUG_INFO=n

    - various script and Makefile cleanups"

    * tag 'kbuild-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: (34 commits)
    Makefile: Update kselftest help information
    kbuild: deb-pkg: fix warning when CONFIG_DEBUG_INFO is unset
    kbuild: add outputmakefile to no-dot-config-targets
    kbuild: remove AS variable
    net: wan: wanxl: refactor the firmware rebuild rule
    net: wan: wanxl: use $(M68KCC) instead of $(M68KAS) for rebuilding firmware
    net: wan: wanxl: use allow to pass CROSS_COMPILE_M68k for rebuilding firmware
    kbuild: add comment about grouped target
    kbuild: add -Wall to KBUILD_HOSTCXXFLAGS
    kconfig: remove unused variable in qconf.cc
    sparc: revive __HAVE_ARCH_STRLEN for 32bit sparc
    kbuild: refactor Makefile.dtbinst more
    kbuild: compute the dtbs_install destination more simply
    Makefile: disallow data races on gcc-10 as well
    kconfig: make 'imply' obey the direct dependency
    kconfig: allow symbols implied by y to become m
    net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()
    modpost: return error if module is missing ns imports and MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=n
    modpost: rework and consolidate logging interface
    kbuild: allow to run dt_binding_check without kernel configuration
    ...

    Linus Torvalds
     

31 Mar, 2020

1 commit

  • 481ed297d   Merge tag 'docs-5.7' of git://git.lwn.net/linux ... Browse Code »

    Pull documentation updates from Jonathan Corbet:
    "This has been a busy cycle for documentation work.

    Highlights include:

    - Lots of RST conversion work by Mauro, Daniel ALmeida, and others.
    Maybe someday we'll get to the end of this stuff...maybe...

    - Some organizational work to bring some order to the core-api
    manual.

    - Various new docs and additions to the existing documentation.

    - Typo fixes, warning fixes, ..."

    * tag 'docs-5.7' of git://git.lwn.net/linux: (123 commits)
    Documentation: x86: exception-tables: document CONFIG_BUILDTIME_TABLE_SORT
    MAINTAINERS: adjust to filesystem doc ReST conversion
    docs: deprecated.rst: Add BUG()-family
    doc: zh_CN: add translation for virtiofs
    doc: zh_CN: index files in filesystems subdirectory
    docs: locking: Drop :c:func: throughout
    docs: locking: Add 'need' to hardirq section
    docs: conf.py: avoid thousands of duplicate label warning on Sphinx
    docs: prevent warnings due to autosectionlabel
    docs: fix reference to core-api/namespaces.rst
    docs: fix pointers to io-mapping.rst and io_ordering.rst files
    Documentation: Better document the softlockup_panic sysctl
    docs: hw-vuln: tsx_async_abort.rst: get rid of an unused ref
    docs: perf: imx-ddr.rst: get rid of a warning
    docs: filesystems: fuse.rst: supress a Sphinx warning
    docs: translations: it: avoid duplicate refs at programming-language.rst
    docs: driver.rst: supress two ReSt warnings
    docs: trace: events.rst: convert some new stuff to ReST format
    Documentation: Add io_ordering.rst to driver-api manual
    Documentation: Add io-mapping.rst to driver-api manual
    ...

    Linus Torvalds
     

17 Mar, 2020

1 commit

  • 5190044c2   modpost: move the namespace field in Module.symvers last ... Browse Code »

    In order to preserve backwards compatability with kmod tools, we have to
    move the namespace field in Module.symvers last, as the depmod -e -E
    option looks at the first three fields in Module.symvers to check symbol
    versions (and it's expected they stay in the original order of crc,
    symbol, module).

    In addition, update an ancient comment above read_dump() in modpost that
    suggested that the export type field in Module.symvers was optional. I
    suspect that there were historical reasons behind that comment that are
    no longer accurate. We have been unconditionally printing the export
    type since 2.6.18 (commit bd5cbcedf44), which is over a decade ago now.

    Fix up read_dump() to treat each field as non-optional. I suspect the
    original read_dump() code treated the export field as optional in order
    to support pre
    Reviewed-by: Matthias Maennich
    Reviewed-by: Lucas De Marchi
    Signed-off-by: Jessica Yu
    Signed-off-by: Masahiro Yamada

    Jessica Yu
     

13 Mar, 2020

3 commits

  • 3a9dd3ecb   kconfig: make 'imply' obey the direct dependency ... Browse Code »

    The 'imply' statement may create unmet direct dependency when the
    implied symbol depends on m.

    [Test Code]

    config FOO
    tristate "foo"
    imply BAZ

    config BAZ
    tristate "baz"
    depends on BAR

    config BAR
    def_tristate m

    config MODULES
    def_bool y
    option modules

    If you set FOO=y, BAZ is also promoted to y, which results in the
    following .config file:

    CONFIG_FOO=y
    CONFIG_BAZ=y
    CONFIG_BAR=m
    CONFIG_MODULES=y

    This does not meet the dependency 'BAZ depends on BAR'.

    Unlike 'select', what is worse, Kconfig never shows the
    'WARNING: unmet direct dependencies detected for ...' for this case.

    Because 'imply' is considered to be weaker than 'depends on', Kconfig
    should take the direct dependency into account.

    For clarification, describe this case in kconfig-language.rst too.

    Signed-off-by: Masahiro Yamada
    Acked-by: Nicolas Pitre
    Tested-by: Geert Uytterhoeven

    Masahiro Yamada
     
  • def2fbffe   kconfig: allow symbols implied by y to become m ... Browse Code »

    The 'imply' keyword restricts a symbol to y or n, excluding m
    when it is implied by y. This is the original behavior since
    commit 237e3ad0f195 ("Kconfig: Introduce the "imply" keyword").

    However, the author of this feature, Nicolas Pitre, stated that
    the 'imply' keyword should not impose any restrictions.
    (https://lkml.org/lkml/2020/2/19/714)

    I agree, and want to get rid of this tricky behavior.

    Suggested-by: Nicolas Pitre
    Signed-off-by: Masahiro Yamada
    Acked-by: Nicolas Pitre

    Masahiro Yamada
     
  • 2eebb7abe   kbuild: doc: fix references to other documents ... Browse Code »

    All the files in Documentation/kbuild/ were converted to reST.

    Signed-off-by: Masahiro Yamada

    Masahiro Yamada
     

11 Mar, 2020

1 commit

03 Mar, 2020

1 commit

27 Feb, 2020

1 commit