05 Oct, 2020

1 commit

  • Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new
    tasklet_setup() API") broke this driver by not removing the old channel
    update method.

    Fix this by remove the offending call as channel is queried from
    tasklet structure.

    Fixes: 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
    Signed-off-by: Vinod Koul
    Link: https://lore.kernel.org/r/20201001164740.178977-1-vkoul@kernel.org
    Signed-off-by: Vinod Koul

    Vinod Koul
     

18 Sep, 2020

1 commit

  • In preparation for unconditionally passing the
    struct tasklet_struct pointer to all tasklet
    callbacks, switch to using the new tasklet_setup()
    and from_tasklet() to pass the tasklet pointer explicitly.

    Signed-off-by: Romain Perier
    Signed-off-by: Allen Pais
    Link: https://lore.kernel.org/r/20200831134745.314945-1-allen.lkml@gmail.com
    Signed-off-by: Vinod Koul

    Allen Pais
     

29 Jun, 2017

1 commit

  • of_device_ids are not supposed to change at runtime. All functions
    working with of_device_ids provided by work with const
    of_device_ids. So mark the non-const structs as const.

    File size before:
    text data bss dec hex filename
    3981 608 0 4589 11ed drivers/dma/fsl_raid.o

    File size after constify:
    text data bss dec hex filename
    4381 192 0 4573 11dd drivers/dma/fsl_raid.o

    Signed-off-by: Arvind Yadav
    Signed-off-by: Vinod Koul

    Arvind Yadav
     

14 Nov, 2016

1 commit

  • If the driver is built as a module, autoload won't work because the module
    alias information is not filled. So user-space can't match the registered
    device with the corresponding module.

    Export the module alias information using the MODULE_DEVICE_TABLE() macro.

    Before this patch:

    $ modinfo drivers/dma/fsl_raid.ko | grep alias
    $

    After this patch:

    $ modinfo drivers/dma/fsl_raid.ko | grep alias
    alias: of:N*T*Cfsl,raideng-v1.0C*
    alias: of:N*T*Cfsl,raideng-v1.0

    Signed-off-by: Javier Martinez Canillas
    Signed-off-by: Vinod Koul

    Javier Martinez Canillas
     

07 Oct, 2016

1 commit

  • Pull dmaengine updates from Vinod Koul:
    "This is bit large pile of code which bring in some nice additions:

    - Error reporting: we have added a new mechanism for users of
    dmaenegine to register a callback_result which tells them the
    result of the dma transaction. Right now only one user (ntb) is
    using it.

    - As we discussed on KS mailing list and pointed out NO_IRQ has no
    place in kernel, this also remove NO_IRQ from dmaengine subsystem
    (both arm and ppc users)

    - Support for IOMMU slave transfers and its implementation for arm.

    - To get better build coverage, enable COMPILE_TEST for bunch of
    driver, and fix the warning and sparse complaints on these.

    - Apart from above, usual updates spread across drivers"

    * tag 'dmaengine-4.9-rc1' of git://git.infradead.org/users/vkoul/slave-dma: (169 commits)
    async_pq_val: fix DMA memory leak
    dmaengine: virt-dma: move function declarations
    dmaengine: omap-dma: Enable burst and data pack for SG
    DT: dmaengine: rcar-dmac: document R8A7743/5 support
    dmaengine: fsldma: Unmap region obtained by of_iomap
    dmaengine: jz4780: fix resource leaks on error exit return
    dma-debug: fix ia64 build, use PHYS_PFN
    dmaengine: coh901318: fix integer overflow when shifting more than 32 places
    dmaengine: edma: avoid uninitialized variable use
    dma-mapping: fix m32r build warning
    dma-mapping: fix ia64 build, use PHYS_PFN
    dmaengine: ti-dma-crossbar: enable COMPILE_TEST
    dmaengine: omap-dma: enable COMPILE_TEST
    dmaengine: edma: enable COMPILE_TEST
    dmaengine: ti-dma-crossbar: Fix of_device_id data parameter usage
    dmaengine: ti-dma-crossbar: Correct type for of_find_property() third parameter
    dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs
    dmaengine: edma: Rename set_bits and remove unused clear_bits helper
    dmaengine: edma: Use correct type for of_find_property() third parameter
    dmaengine: edma: Fix of_device_id data parameter usage (legacy vs TPCC)
    ...

    Linus Torvalds
     

03 Oct, 2016

2 commits


14 Sep, 2016

1 commit


22 Aug, 2016

1 commit


08 Aug, 2016

2 commits

  • Completion callback should happen after dma_descriptor_unmap() has
    happened. This allow the cache invalidate to happen and ensure that
    the data accessed by the upper layer is in memory that was from DMA
    rather than stale data. On some architecture this is done by the
    hardware, however we should make the code consistent to not cause
    confusion.

    Signed-off-by: Dave Jiang
    Cc: Xuelin Shi
    Signed-off-by: Vinod Koul

    Dave Jiang
     
  • This is in preperation of moving to a callback that provides results to the
    callback for the transaction. The conversion will maintain current behavior
    and the driver must convert to new callback mechanism at a later time in
    order to receive results.

    Signed-off-by: Dave Jiang
    Reviewed-by: Lars-Peter Clausen
    Signed-off-by: Vinod Koul

    Dave Jiang
     

23 Jul, 2016

1 commit


16 Jul, 2016

2 commits

  • size_t should be printed with %zu, not %lu as driver did, so fix these
    warning by doing this change

    drivers/dma/fsl_raid.c: In function 'fsl_re_prep_dma_genq':
    drivers/dma/fsl_raid.c:341:4: warning: format '%lu' expects argument of type
    'long unsigned int', but argument 3 has type 'size_t' [-Wformat=]
    len, FSL_RE_MAX_DATA_LEN);
    ^
    drivers/dma/fsl_raid.c: In function 'fsl_re_prep_dma_pq':
    drivers/dma/fsl_raid.c:428:4: warning: format '%lu' expects argument of type
    'long unsigned int', but argument 3 has type 'size_t' [-Wformat=]
    len, FSL_RE_MAX_DATA_LEN);
    ^
    drivers/dma/fsl_raid.c: In function 'fsl_re_prep_dma_memcpy':
    drivers/dma/fsl_raid.c:549:4: warning: format '%lu' expects argument of type
    'long unsigned int', but argument 3 has type 'size_t' [-Wformat=]
    len, FSL_RE_MAX_DATA_LEN);
    ^

    Signed-off-by: Vinod Koul

    Vinod Koul
     
  • drivers should ensure that tasklets are killed, so that they can't be
    run after driver remove is executed

    Signed-off-by: Vinod Koul
    Cc: Xuelin Shi

    Vinod Koul
     

02 Apr, 2015

2 commits