17 Aug, 2020

1 commit

  • Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
    make it static:

    drivers/edac/thunderx_edac.c:457:22: warning:
    symbol 'lmc_dfs_ents' was not declared. Should it be static?

    Reported-by: Hulk Robot
    Signed-off-by: Wei Yongjun
    Signed-off-by: Borislav Petkov
    Acked-by: Robert Richter
    Link: https://lkml.kernel.org/r/20200714142308.46612-1-weiyongjun1@huawei.com

    Wei Yongjun
     

23 Apr, 2020

1 commit

  • Make a couple of symbols static, as reported by sparse.

    [ bp: Massage. ]

    Reported-by: Hulk Robot
    Signed-off-by: Zou Wei
    Signed-off-by: Borislav Petkov
    Link: https://lkml.kernel.org/r/1587624744-97240-1-git-send-email-zou_wei@huawei.com

    Zou Wei
     

13 Oct, 2018

1 commit

  • Fix memory leak in L2c threaded interrupt handler.

    [ bp: Rewrite commit message. ]

    Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
    Signed-off-by: Dan Carpenter
    Signed-off-by: Borislav Petkov
    CC: David Daney
    CC: Jan Glauber
    CC: Mauro Carvalho Chehab
    CC: Sergey Temerkhanov
    CC: linux-edac
    Link: http://lkml.kernel.org/r/20181013102843.GG16086@mwanda

    Dan Carpenter
     

09 Jul, 2018

1 commit

  • In the quest to remove all stack VLA usage from the kernel[1], switch to
    using a kmalloc-allocated buffer instead of stack space. This should be
    fine since the existing routine is allocating memory too.

    Signed-off-by: Kees Cook
    Acked-by: Jan Glauber
    Cc: David Daney
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/20180629184850.GA37464@beast
    Link: https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com [1]
    Signed-off-by: Borislav Petkov

    Kees Cook
     

27 Sep, 2017

1 commit

  • The memory controller on ThunderX/OcteonTX systems does not support
    power management. Therefore remove the suspend/resume callbacks.

    Signed-off-by: Jan Glauber
    Cc: David Daney
    Cc: Jan Glauber
    Cc: Mark Rutland
    Cc: Mauro Carvalho Chehab
    Cc: Ralf Baechle
    Cc: Suzuki K Poulose
    Cc: Will Deacon
    Cc: Zhangshaokun
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-edac
    Cc: linux-mips@linux-mips.org
    Link: http://lkml.kernel.org/r/20170925123502.17289-2-jglauber@cavium.com
    Signed-off-by: Borislav Petkov

    Jan Glauber
     

19 Aug, 2017

1 commit


17 Jul, 2017

1 commit

  • It is a write-only variable so get rid of it.

    Signed-off-by: Borislav Petkov
    Acked-by: Robert Richter
    Acked-by: Michal Simek
    Acked-by: Thor Thayer
    Acked-by: Tony Luck
    Cc: Mark Gross
    Cc: Tim Small
    Cc: Ranganathan Desikan
    Cc: "Arvind R."
    Cc: Jason Baron
    Cc: "Sören Brinkmann"
    Cc: Ralf Baechle
    Cc: David Daney
    Cc: Loc Ho
    Cc: linux-edac@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-mips@linux-mips.org

    Borislav Petkov
     

02 Jun, 2017

1 commit

  • Compare the number of debugfs entries created by
    thunderx_create_debugfs_nodes() with the requested number of entries to
    properly determine whether to print a warning.

    Signed-off-by: Vadim Lomovtsev
    Cc: linux-edac
    Cc: linux-mips@linux-mips.org
    Link: http://lkml.kernel.org/r/20170531155157.93583-1-stemerkhanov@cavium.com
    Signed-off-by: Sergey Temerkhanov
    Signed-off-by: Borislav Petkov

    Vadim Lomovtsev
     

07 Apr, 2017

2 commits

  • Remove unused code reserved for upcoming CPUs.

    Reported-by: Dan Carpenter
    Signed-off-by: Sergey Temerkhanov
    Cc: David Daney
    Cc: Jan.Glauber@cavium.com
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/20170406113834.17153-1-s.temerkhanov@gmail.com
    Signed-off-by: Borislav Petkov

    Sergey Temerkhanov
     
  • Shift the node number by 3 bits instead of 8 allowing proper functioning
    with default EDAC_MAX_MCS.

    Signed-off-by: Sergey Temerkhanov
    Cc: David Daney
    Cc: Jan.Glauber@cavium.com
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/20170406113755.17082-1-s.temerkhanov@gmail.com
    Signed-off-by: Borislav Petkov

    Sergey Temerkhanov
     

05 Apr, 2017

1 commit

  • Fix a typo that disabled the MCI interrupts using the wrong bitmask.

    Signed-off-by: Jan Glauber
    Cc: David Daney
    Cc: Ralf Baechle
    Cc: Sergey Temerkhanov
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/20170405102739.6301-1-jglauber@cavium.com
    Signed-off-by: Borislav Petkov

    Jan Glauber
     

27 Mar, 2017

1 commit

  • Add support for Cavium ThunderX EDAC capable on-chip peripherals, namely
    the DRAM controller (LMC), cache coherent processor interconnect (CCPI)
    and level 2 cache blocks (L2C-TAD, L2C-MCI, L2C-CBC)

    Signed-off-by: Sergey Temerkhanov
    Cc: David.Daney@cavium.com
    Cc: Jan.Glauber@cavium.com
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/20170324222837.60583-1-s.temerkhanov@gmail.com
    Signed-off-by: Borislav Petkov

    Sergey Temerkhanov