22 Aug, 2019

1 commit

  • This is a common pattern in the HID drivers to reset the drvdata. Some
    do it properly, some do it only in case of failure.

    But, this is actually already handled by driver core, so there is no need
    to do it manually.

    [for hid-sensor-hub.c]
    Acked-by: Srinivas Pandruvada
    [For hid-picolcd_core.c]
    Acked-by: Bruno Prémont
    Signed-off-by: Benjamin Tissoires

    Benjamin Tissoires
     

31 May, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 3029 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

26 Apr, 2018

1 commit

  • It is not a good idea to try to fit all types of applications in the
    same input report. There are a lot of devices that are needing
    the quirk HID_MULTI_INPUT but this quirk doesn't match the actual HID
    description as it is based on the report ID.

    Given that most devices with MULTI_INPUT I can think of split nicely
    the devices inputs into application, it is a good thing to split the
    devices by default based on this assumption.

    Also make hid-multitouch following this rule, to not have to deal
    with too many input created.

    While we are at it, fix some checkpatch complaints about converting
    'unsigned' to 'unsigned int'.

    Signed-off-by: Benjamin Tissoires
    Signed-off-by: Jiri Kosina

    Benjamin Tissoires
     

06 Nov, 2015

1 commit

  • The input_configured callback was recently changed to return
    an 'int', but the newly added driver uses the old API:

    drivers/hid/hid-gfrm.c:151:22: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]

    This changes the driver like the other ones.

    Signed-off-by: Arnd Bergmann
    Fixes: 34fc1322e7aa ("HID: hid-gfrm: Google Fiber TV Box remote controls")
    Fixes: b2c68a2f1bab ("HID: hid-input: allow input_configured callback return errors")
    Acked-by: Petri Gynther
    Signed-off-by: Dmitry Torokhov

    Arnd Bergmann
     

26 Oct, 2015

1 commit