21 May, 2019

1 commit

  • Based on 2 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details you
    should have received a copy of the gnu general public license along
    with this program if not see http www gnu org licenses

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details [based]
    [from] [clk] [highbank] [c] you should have received a copy of the
    gnu general public license along with this program if not see http
    www gnu org licenses

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 355 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Kate Stewart
    Reviewed-by: Jilayne Lovejoy
    Reviewed-by: Steve Winslow
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190519154041.837383322@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

01 Nov, 2017

1 commit


30 Oct, 2017

1 commit


01 Oct, 2017

1 commit

  • Commit 2ca492e22cb7 has moved the call to 'kfifo_alloc()' from after the
    main 'if' statement to before it.
    But it has not updated the error handling paths accordingly.

    Fix all that:
    - if 'kfifo_alloc()' fails we can return directly
    - direct returns after 'kfifo_alloc()' must now go to 'out_mbox_free'
    - 'goto out_mbox_free' must be replaced by 'goto out', otherwise the
    '[pcc_]mbox_free_channel()' call will be missed.

    Fixes: 2ca492e22cb7 ("hwmon: (xgene) Fix crash when alarm occurs before driver probe")
    Signed-off-by: Christophe JAILLET
    Signed-off-by: Guenter Roeck

    Christophe Jaillet
     

10 Sep, 2016

1 commit

  • The newly added hwmon driver fails to build in an allmodconfig
    kernel:

    ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!

    According to comments in the code, the mailbox is a shared memory region,
    not a set of MMIO registers, so we should use memremap() for mapping it
    instead of ioremap or acpi_os_ioremap, and pointer dereferences instead
    of readl/writel.

    The driver already uses plain kernel pointers, so it's a bit unusual
    to work with functions that operate on __iomem pointers, and this
    fixes that part too.

    I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior
    regarding the ordering of the accesses from the CPU, but note that
    there are no barriers (also unchanged from before).

    I'm also keeping the endianness behavior, though I'm unsure whether
    the message data was supposed to be in LE32 format in the first
    place, it's possible this was meant to be interpreted as a byte
    stream instead.

    Signed-off-by: Arnd Bergmann
    Acked-by: Hoan Tran
    Tested-by: Hoan Tran
    Signed-off-by: Guenter Roeck

    Arnd Bergmann
     

09 Sep, 2016

2 commits

  • The system crashes during probing xgene-hwmon driver when temperature
    alarm interrupt occurs before.
    It's because
    - xgene_hwmon_probe() requests mailbox channel which also enables
    the mailbox interrupt.
    - As temperature alarm interrupt is pending, ISR runs and crashes when
    accesses into invalid resourse as unmapped PCC shared memory.

    This patch fixes this issue by saving this alarm message and scheduling a
    bottom handler after xgene_hwmon_probe() finish.

    Signed-off-by: Hoan Tran
    Reported-by: Itaru Kitayama
    Signed-off-by: Guenter Roeck

    hotran
     
  • This patch adds hardware temperature and power reading support for
    APM X-Gene SoC using the mailbox communication interface.

    Signed-off-by: Hoan Tran
    Reviewed-by: Guenter Roeck
    Signed-off-by: Guenter Roeck

    hotran