Eric Lee / smarc-fsl-linux-kernel

06 Nov, 2020

1 commit

  • 06ea59405   staging: ralink-gdma: fix kconfig dependency bug for DMA_RALINK ... Browse Code »

    When DMA_RALINK is enabled and DMADEVICES is disabled, it results in the
    following Kbuild warnings:

    WARNING: unmet direct dependencies detected for DMA_ENGINE
    Depends on [n]: DMADEVICES [=n]
    Selected by [y]:
    - DMA_RALINK [=y] && STAGING [=y] && RALINK [=y] && !SOC_RT288X [=n]

    WARNING: unmet direct dependencies detected for DMA_VIRTUAL_CHANNELS
    Depends on [n]: DMADEVICES [=n]
    Selected by [y]:
    - DMA_RALINK [=y] && STAGING [=y] && RALINK [=y] && !SOC_RT288X [=n]

    The reason is that DMA_RALINK selects DMA_ENGINE and DMA_VIRTUAL_CHANNELS
    without depending on or selecting DMADEVICES while DMA_ENGINE and
    DMA_VIRTUAL_CHANNELS are subordinate to DMADEVICES. This can also fail
    building the kernel as demonstrated in a bug report.

    Honor the kconfig dependency to remove unmet direct dependency warnings
    and avoid any potential build failures.

    Link: https://bugzilla.kernel.org/show_bug.cgi?id=210055
    Signed-off-by: Necip Fazil Yildiran
    Link: https://lore.kernel.org/r/20201104181522.43567-1-fazilyildiran@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Necip Fazil Yildiran
     

16 Sep, 2020

1 commit

  • 54617b527   staging: ralink-gdma: convert tasklets to use new tasklet_setup() API ... Browse Code »

    In preparation for unconditionally passing the
    struct tasklet_struct pointer to all tasklet
    callbacks, switch to using the new tasklet_setup()
    and from_tasklet() to pass the tasklet pointer explicitly.

    Signed-off-by: Romain Perier
    Signed-off-by: Allen Pais
    Link: https://lore.kernel.org/r/20200916062341.58322-1-allen.lkml@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Allen Pais
     

25 Oct, 2019

1 commit

31 Jul, 2019

1 commit

  • 04d15d5ca   staging: Remove dev_err() usage after platform_get_irq() ... Browse Code »

    We don't need dev_err() messages when platform_get_irq() fails now that
    platform_get_irq() prints an error message itself when something goes
    wrong. Let's remove these prints with a simple semantic patch.

    //
    @@
    expression ret;
    struct platform_device *E;
    @@

    ret =
    (
    platform_get_irq(E, ...)
    |
    platform_get_irq_byname(E, ...)
    );

    if ( \( ret < 0 \| ret

    While we're here, remove braces on if statements that only have one
    statement (manually).

    Signed-off-by: Stephen Boyd
    Link: https://lore.kernel.org/r/20190730181557.90391-43-swboyd@chromium.org
    Signed-off-by: Greg Kroah-Hartman

    Stephen Boyd
     

09 Jun, 2019

1 commit

16 Apr, 2019

1 commit

  • e291fa123   staging: ralink-gdma: Use struct_size() in kzalloc() ... Browse Code »

    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:

    struct foo {
    int stuff;
    struct boo entry[];
    };

    size = sizeof(struct foo) + count * sizeof(struct boo);
    instance = kzalloc(size, GFP_KERNEL)

    Instead of leaving these open-coded and prone to type mistakes, we can
    now use the new struct_size() helper:

    size = struct_size(instance, entry, count);

    or

    instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL)

    Based on the above, replace gdma_dma_alloc_desc() with kzalloc() and
    use the new struct_size() helper.

    This code was detected with the help of Coccinelle.

    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Greg Kroah-Hartman

    Gustavo A. R. Silva
     

03 Apr, 2019

4 commits

26 Mar, 2019

3 commits

18 Mar, 2019

3 commits

15 Jan, 2019

1 commit

  • d6b109054   staging: Move ralink-gdma to its own directory ... Browse Code »

    This is in preparation to allow it and the mt7621-dma drivers to be
    built separately. They are completely independent pieces of software,
    and the Kconfig specifies very different requirements.

    Cc: linux-kernel@vger.kernel.org
    Cc: devel@driverdev.osuosl.org
    Cc: Neil Brown
    Signed-off-by: George Hilliard
    Signed-off-by: Greg Kroah-Hartman

    George Hilliard