03 Sep, 2020
1 commit
-
Fix cppcheck warning:
sound/ac97/bus.c:133:60: style:inconclusive: Function
'snd_ac97_bus_scan_one' argument 1 names different: declaration 'ac97'
definition 'adrv'. [funcArgNamesDifferent]Signed-off-by: Pierre-Louis Bossart
Link: https://lore.kernel.org/r/20200902212133.30964-14-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai
03 Jan, 2020
1 commit
-
Now snd_ac97_bus() takes the const ops pointer, so we can define the
snd_ac97_bus_ops locally as const as well for further optimization.There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-24-tiwai@suse.de
Signed-off-by: Takashi Iwai
23 Jul, 2019
1 commit
-
put_device will call ac97_codec_release to free
ac97_codec_device and other resources, so remove the kfree
and other redundant code.Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Ding Xiang
Cc:
Signed-off-by: Takashi Iwai
19 Jun, 2019
1 commit
-
Based on 2 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundationthis program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 4122 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Enrico Weigelt
Reviewed-by: Kate Stewart
Reviewed-by: Allison Randal
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman
21 May, 2019
1 commit
-
Add SPDX license identifiers to all Make/Kconfig files which:
- Have no license information of any form
These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:GPL-2.0-only
Signed-off-by: Thomas Gleixner
Signed-off-by: Greg Kroah-Hartman
20 Feb, 2019
1 commit
-
ac97_of_get_child_device() take the refcount of the node explicitly
via of_node_get(), but this leads to an unbalance. The
for_each_child_of_node() loop itself takes the refcount for each
iteration node, hence you don't need to take the extra refcount
again.Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
Reviewed-by: Robert Jarzmik
Signed-off-by: Takashi Iwai
20 Aug, 2018
3 commits
-
Runtime PM is enabled at ac97_bus_probe() and should be disabled
at ac97_bus_remove().Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Lihua Yao
Acked-by: Robert Jarzmik
Cc:
Signed-off-by: Takashi Iwai -
pm_runtime_get_sync returns negative on failure.
Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Lihua Yao
Acked-by: Robert Jarzmik
Cc:
Signed-off-by: Takashi Iwai -
ac97->dev is an object of 'struct device' type. It should be initialized
via device_initialize() or device_register().Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Lihua Yao
Tested-by: Robert Jarzmik
Acked-by: Robert Jarzmik
Cc:
Signed-off-by: Takashi Iwai
25 Jun, 2018
1 commit
-
Add a devicetree binding for codecs. This is especially useful if the
AC97 bitclk clock is provided by the codec, as it has to be described in
the devicetree description for the ac97 bus code to aquire it.Signed-off-by: Robert Jarzmik
Signed-off-by: Takashi Iwai
12 Feb, 2018
1 commit
-
The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol
AC97.Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the
select was put in by mistake and can be safely removed, with no other
changes required. Remove it.Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Ulf Magnusson
Signed-off-by: Takashi Iwai
05 Sep, 2017
1 commit
-
AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one
controller to 0 to 4 AC97 codecs.The goal of this new implementation is to implement a device/driver
model for AC97, with an automatic scan of the bus and automatic
discovery of AC97 codec devices.Signed-off-by: Robert Jarzmik
Reviewed-by: Takashi Iwai
Signed-off-by: Mark Brown