Eric Lee / smarc-fsl-linux-kernel

31 Oct, 2018

1 commit

  • 7a20c2fa1   lib/zlib_inflate/inflate.c: remove fall through warnings ... Browse Code »

    This patch remove all following fall through warnings by
    adding /* fall through */ markers.
    Note that we cannot add "__attribute__ ((fallthrough));" due to it is GCC7 only
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:384:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:391:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:393:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:430:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:556:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:595:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:602:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:627:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:646:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
    arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:696:25: warning: this statement may fall through [-Wimplicit-fallthrough=]

    It is easy to see that thoses fall through are needed since in each case state->mode are set to the case value just below.

    Link: http://lkml.kernel.org/r/1536215920-19955-1-git-send-email-clabbe@baylibre.com
    Signed-off-by: Corentin Labbe
    Cc: David Miller
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corentin Labbe
     

09 May, 2017

1 commit

  • da5e108b0   lib/zlib_inflate/inftrees.c: fix potential buffer overflow ... Browse Code »

    smatch says:

    WARNING: please, no spaces at the start of a line
    #30: FILE: lib/zlib_inflate/inftrees.c:112:
    + for (min = 1; min < MAXBITS; min++)$

    total: 0 errors, 1 warnings, 8 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    ./patches/zlib-inflate-fix-potential-buffer-overflow.patch has style problems, please review.

    NOTE: If any of the errors are false positives, please report
    them to the maintainer, see CHECKPATCH in MAINTAINERS.

    Please run checkpatch prior to sending patches

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Guenter Roeck
     

07 Aug, 2014

1 commit

  • 62e7ca528   zlib: clean up some dead code ... Browse Code »

    Cleanup unused `if 0'-ed functions, which have been dead since 2006
    (commits 87c2ce3b9305 ("lib/zlib*: cleanups") by Adrian Bunk and
    4f3865fb57a0 ("zlib_inflate: Upgrade library code to a recent version")
    by Richard Purdie):

    - zlib_deflateSetDictionary
    - zlib_deflateParams
    - zlib_deflateCopy
    - zlib_inflateSync
    - zlib_syncsearch
    - zlib_inflateSetDictionary
    - zlib_inflatePrime

    Signed-off-by: Sergey Senozhatsky
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sergey Senozhatsky