Eric Lee / smarc-fsl-linux-kernel

27 May, 2011

3 commits

  • 02d54f092   getdelays: show average CPU/IO/SWAP/RECLAIM delays ... Browse Code »

    I find it very handy to show the average delays in milliseconds.

    Example output (on 100 concurrent dd reading sparse files):

    CPU count real total virtual total delay total delay average
    986 3223509952 3207643301 38863410579 39.415ms
    IO count delay total delay average
    0 0 0ms
    SWAP count delay total delay average
    0 0 0ms
    RECLAIM count delay total delay average
    1059 5131834899 4ms
    dd: read=0, write=0, cancelled_write=0

    Signed-off-by: Wu Fengguang
    Cc: Mel Gorman
    Cc: Balbir Singh
    Reviewed-by: Satoru Moriya
    Reviewed-by: KOSAKI Motohiro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Wu Fengguang
     
  • 4ed960b14   Documentation/accounting/getdelays.c: handle sendto() failures ... Browse Code »

    Fixes

    Documentation/accounting/getdelays.c: In function `get_family_id':
    Documentation/accounting/getdelays.c:172:14: warning: variable `rc' set but not used [-Wunused-but-set-variable]

    Reported-by: "Justin P. Mattock"
    Cc: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • fbdd91a62   Documentation/accounting/getdelays.c: fix unused var warning ... Browse Code »

    Fixes

    Documentation/accounting/getdelays.c: In function `main':
    Documentation/accounting/getdelays.c:436:7: warning: variable `i' set but not used [-Wunused-but-set-variable]

    Signed-off-by: Justin P. Mattock
    Cc: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Justin P. Mattock
     

23 Dec, 2010

1 commit

  • 4be2c95d1   taskstats: pad taskstats netlink response for aligment issues on ia64 ... Browse Code »

    The taskstats structure is internally aligned on 8 byte boundaries but the
    layout of the aggregrate reply, with two NLA headers and the pid (each 4
    bytes), actually force the entire structure to be unaligned. This causes
    the kernel to issue unaligned access warnings on some architectures like
    ia64. Unfortunately, some software out there doesn't properly unroll the
    NLA packet and assumes that the start of the taskstats structure will
    always be 20 bytes from the start of the netlink payload. Aligning the
    start of the taskstats structure breaks this software, which we don't
    want. So, for now the alignment only happens on architectures that
    require it and those users will have to update to fixed versions of those
    packages. Space is reserved in the packet only when needed. This ifdef
    should be removed in several years e.g. 2012 once we can be confident
    that fixed versions are installed on most systems. We add the padding
    before the aggregate since the aggregate is already a defined type.

    Commit 85893120 ("delayacct: align to 8 byte boundary on 64-bit systems")
    previously addressed the alignment issues by padding out the pid field.
    This was supposed to be a compatible change but the circumstances
    described above mean that it wasn't. This patch backs out that change,
    since it was a hack, and introduces a new NULL attribute type to provide
    the padding. Padding the response with 4 bytes avoids allocating an
    aligned taskstats structure and copying it back. Since the structure
    weighs in at 328 bytes, it's too big to do it on the stack.

    Signed-off-by: Jeff Mahoney
    Reported-by: Brian Rogers
    Cc: Jeff Mahoney
    Cc: Guillaume Chazarain
    Cc: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Mahoney
     

28 Oct, 2010

1 commit

  • db9e5679d   delay-accounting: reimplement -c for getdelays.c to report information on a target command ... Browse Code »

    Task delay-accounting was identified as one means of determining how long
    a process spends in congestion_wait() without adding new statistics. For
    example, if the workload should not be doing IO, delay-accounting could
    reveal how long it was spending in unexpected IO or delays.
    Unfortunately, on closer examination it was clear that getdelays does not
    act as documented.

    Commit a3baf649 ("per-task-delay-accounting: documentation") added
    Documentation/accounting/getdelays.c with a -c switch that was documented
    to fork/exec a child and report statistics on it but for reasons that are
    unclear to me, commit 9e06d3f9 deleted support for this switch but did not
    update the documentation. It might be an oversight or it might be because
    the control flow of the program meant that accounting information would be
    printed once early in the lifetime of the program making it of limited
    use.

    This patch reimplements -c for getdelays.c to act as documented. Unlike
    the original version, it waits until the command completes before printing
    any information on it. An example of it being used looks like

    $ ./getdelays -d -c find /home/mel -name mel
    print delayacct stats ON
    /home/mel
    /home/mel/.notes-wine/drive_c/windows/profiles/mel
    /home/mel/.wine/drive_c/windows/profiles/mel
    /home/mel/git-configs/dot.kde/share/apps/konqueror/home/mel
    PID 5923

    CPU count real total virtual total delay total
    42779 5051232096 5164722692 564207988
    IO count delay total
    41727 97804147758
    SWAP count delay total
    0 0
    RECLAIM count delay total
    0 0

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Mel Gorman
    Acked-by: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mel Gorman
     

23 Sep, 2009

1 commit

17 Jun, 2009

1 commit

16 Jan, 2009

1 commit

13 Aug, 2008

1 commit

  • 666593137   docsrc: fix getdelays printk formats ... Browse Code »

    Fix printf format type warnings (seen on alpha & ia64):

    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 6 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 7 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 8 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 9 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 12 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 13 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 16 has type '__u64'
    Documentation/accounting/getdelays.c:206: warning: format '%15llu' expects type 'long long unsigned int', but argument 17 has type '__u64'
    Documentation/accounting/getdelays.c:214: warning: format '%15llu' expects type 'long long unsigned int', but argument 4 has type '__u64'
    Documentation/accounting/getdelays.c:214: warning: format '%15llu' expects type 'long long unsigned int', but argument 5 has type '__u64'
    Documentation/accounting/getdelays.c:221: warning: format '%llu' expects type 'long long unsigned int', but argument 2 has type '__u64'
    Documentation/accounting/getdelays.c:221: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type '__u64'
    Documentation/accounting/getdelays.c:221: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type '__u64'
    Documentation/accounting/getdelays.c:221: warning: format '%llu' expects type 'long long unsigned int', but argument 5 has type '__u64'
    Documentation/accounting/getdelays.c:221: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type '__u64'
    Documentation/accounting/getdelays.c:236: warning: 'cmd_type' may be used uninitialized in this function

    Signed-off-by: Randy Dunlap
    Cc: Balbir Singh
    Cc: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

26 Jul, 2008

1 commit

09 Feb, 2008

1 commit

  • 10e6f32bd   getdelays: fix gcc warnings ... Browse Code »

    Fix gcc warnings in getdelays.c:

    Documentation/accounting/getdelays.c: In function 'task_context_switch_counts':
    Documentation/accounting/getdelays.c:214: warning: format '%15lu' expects type 'long unsigned int', but argument 4 has type '__u64'
    Documentation/accounting/getdelays.c:214: warning: format '%15lu' expects type 'long unsigned int', but argument 5 has type '__u64'
    Documentation/accounting/getdelays.c: In function 'main':
    Documentation/accounting/getdelays.c:402: warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned int'
    Documentation/accounting/getdelays.c: In function 'get_family_id':
    Documentation/accounting/getdelays.c:171: warning: 'id' may be used uninitialized in this function

    One warning is not a problem and can be dismissed:
    Documentation/accounting/getdelays.c: In function 'main':
    Documentation/accounting/getdelays.c:236: warning: 'cmd_type' may be used uninitialized in this function

    Signed-off-by: Randy Dunlap
    Acked-by: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

15 Nov, 2007

1 commit

  • 546040dc4   make getdelays cgroupstats aware ... Browse Code »

    Update the getdelays utility to become cgroupstats aware. A new -C option has
    been added. It takes in a control group path and prints out a summary of the
    states of tasks in the control group

    Signed-off-by: Balbir Singh
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Balbir Singh
     

17 Oct, 2007

1 commit

23 Aug, 2007

1 commit

  • efbee7f1c   Documentation: fix getdelays.c printf bug ... Browse Code »

    Commit b663a79c191508f27cd885224b592a878c0ba0f6 ("taskstats: add
    context-switch counters") incorrectly removed a comma from a printf
    statement. This causes corruption in the output printing or a seg
    fault.

    Signed-off-by: Michael Neuling
    Acked-by: Balbir Singh
    Signed-off-by: Linus Torvalds

    Michael Neuling
     

17 Jul, 2007

1 commit

  • b663a79c1   taskstats: add context-switch counters ... Browse Code »

    Make available to the user the following task and process performance
    statistics:

    * Involuntary Context Switches (task_struct->nivcsw)
    * Voluntary Context Switches (task_struct->nvcsw)

    Statistics information is available from:
    1. taskstats interface (Documentation/accounting/)
    2. /proc/PID/status (task only).

    This data is useful for detecting hyperactivity patterns between processes.

    [akpm@linux-foundation.org: cleanup]
    Signed-off-by: Maxim Uvarov
    Cc: Shailabh Nagar
    Cc: Balbir Singh
    Cc: Jay Lan
    Cc: Jonathan Lim
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Maxim Uvarov
     

09 May, 2007

2 commits

11 Dec, 2006

2 commits

  • cf709844d   [PATCH] io-accounting: add to getdelays ... Browse Code »

    Wire up the IO accounting into getdelays.c.

    Usage:

    To display I/O stats for each exitting task:

    vmm:/home/akpm> ./getdelays -m0,1,2,3 -i -l
    cpumask 0 maskset 1
    printing IO accounting
    listen forever
    rm: read=8192, write=0, cancelled_write=0
    cvs: read=733184, write=4255744, cancelled_write=4096
    make: read=217088, write=0, cancelled_write=0
    cc1: read=4263936, write=12288, cancelled_write=0
    as: read=811008, write=8192, cancelled_write=0
    gcc: read=323584, write=0, cancelled_write=12288
    cc1: read=0, write=8192, cancelled_write=0
    as: read=4096, write=4096, cancelled_write=0
    gcc: read=16384, write=0, cancelled_write=4096
    as: read=4096, write=4096, cancelled_write=0
    gcc: read=16384, write=0, cancelled_write=8192
    ld: read=1011712, write=16384, cancelled_write=0
    collect2: read=626688, write=0, cancelled_write=0
    gcc: read=204800, write=0, cancelled_write=0
    cc1: read=0, write=8192, cancelled_write=0
    as: read=4096, write=4096, cancelled_write=0
    gcc: read=16384, write=0, cancelled_write=8192
    ld: read=8192, write=16384, cancelled_write=0
    collect2: read=49152, write=0, cancelled_write=0
    gcc: read=0, write=0, cancelled_write=0
    cc1: read=0, write=4096, cancelled_write=0
    ld: read=4096, write=12288, cancelled_write=0
    collect2: read=49152, write=0, cancelled_write=0
    gcc: read=0, write=0, cancelled_write=0

    To display I/O stats for a particular presently-running task:

    vmm:/home/akpm> ./getdelays -i -p $(pidof crond)
    printing IO accounting
    crond: read=61440, write=0, cancelled_write=0

    Cc: Jay Lan
    Cc: Shailabh Nagar
    Cc: Balbir Singh
    Cc: Chris Sturtivant
    Cc: Tony Ernst
    Cc: Guillaume Thouvenin
    Cc: David Wright
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • d2f7bf134   [PATCH] getdelays: various fixes ... Browse Code »

    - Various cleanups

    - Report errors to stderr, not stdout

    - A printf was missing a \n and was hiding from me.

    Cc: Jay Lan
    Cc: Shailabh Nagar
    Cc: Balbir Singh
    Cc: Chris Sturtivant
    Cc: Tony Ernst
    Cc: Guillaume Thouvenin
    Cc: David Wright
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     

04 Nov, 2006

1 commit

01 Oct, 2006

1 commit

  • 7d1bdca9b   [PATCH] Fix getdelays.c - cpumask length and error reporting ... Browse Code »

    Fix the length passed while (un)registering cpumask. We were passing sizeof
    the array, make it strlen().

    Error value printed in fatal errors should be derived from the message. The
    message contains an nlmsgerr embedded with an error value. We must report
    that value to the user.

    Signed-off-by: Balbir Singh
    Cc: Jamal Hadi
    Cc: Shailabh Nagar
    Cc: Thomas Graf
    Cc: "David S. Miller"
    Cc: Jay Lan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Balbir Singh
     

15 Jul, 2006

2 commits