04 Jan, 2012
1 commit
-
vfs_mkdir() gets int, but immediately drops everything that might not
fit into umode_t and that's the only caller of ->mkdir()...Signed-off-by: Al Viro
02 Nov, 2011
1 commit
-
Replace remaining direct i_nlink updates with a new set_nlink()
updater function.Signed-off-by: Miklos Szeredi
Tested-by: Toshiyuki Okajima
Signed-off-by: Christoph Hellwig
23 Oct, 2011
1 commit
-
We should call cifs_all_info_to_fattr in rc == 0 case only.
Cc:
Signed-off-by: Pavel Shilovsky
Reviewed-by: Jeff Layton
Signed-off-by: Steve French
17 Oct, 2011
1 commit
-
Now build security descriptor to change either owner or group at the
server. Initially security descriptor was built to change only
(D)ACL, that functionality has been extended.When either an Owner or a Group of a file object at the server is changed,
rest of security descriptor remains same (DACL etc.).To set security descriptor, it is necessary to open that file
with permission bits of either WRITE_DAC if DACL is being modified or
WRITE_OWNER (Take Ownership) if Owner or Group is being changed.It is the server that decides whether a set security descriptor with
either owner or group change succeeds or not.Signed-off-by: Shirish Pargaonkar
Signed-off-by: Steve French
05 Aug, 2011
1 commit
-
Regression from 2.6.39...
The delimiters in the prefixpath are not being converted based on
whether posix paths are in effect. Fixes:https://bugzilla.redhat.com/show_bug.cgi?id=727834
Reported-and-Tested-by: Iain Arnell
Reported-by: Patrick Oltmann
Cc: Pavel Shilovsky
Cc: stable@kernel.org
Signed-off-by: Jeff Layton
Signed-off-by: Steve French
27 May, 2011
4 commits
-
secMode to sec_mode
and
cifsTconInfo to cifs_tcon
and
cifsSesInfo to cifs_sesSigned-off-by: Steve French
-
Add rwpidforward mount option that switches on a mode when we forward
pid of a process who opened a file to any read and write operation.This can prevent applications like WINE from failing on read or write
operation on a previously locked file region from the same netfd from
another process if we use mandatory brlock style.It is actual for WINE because during a run of WINE program two processes
work on the same netfd - share the same file struct between several VFS
fds:
1) WINE-server does open and lock;
2) WINE-application does read and write.Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French -
Now we point superblock to a server share root and set a root dentry
appropriately. This let us share superblock between mounts like
//server/sharename/foo/bar and //server/sharename/foo further.Reviewed-by: Jeff Layton
Signed-off-by: Pavel ShilovskySigned-off-by: Steve French
-
We need it to make them work with mandatory locking style because
we can fail in a situation like when kernel need to flush dirty pages
and there is a lock held by a process who opened file.Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French
21 May, 2011
1 commit
-
Fix to earlier "Simplify invalidate part (try #6)" patch
That patch caused problems with connectathon test 5.Reviewed-by: Jeff Layton
Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French
19 May, 2011
3 commits
-
Simplify many places when we call cifs_revalidate/invalidate to make
it do what it exactly needs.Reviewed-by: Jeff Layton
Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French -
Use invalidate_inode_pages2 that don't leave pages even if shrink_page_list()
has a temp ref on them. It prevents a data coherency problem when
cifs_invalidate_mapping didn't invalidate pages but the client thinks that a data
from the cache is uptodate according to an oplock level (exclusive or II).Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French -
ino is unused in function cifs_root_iget().
Signed-off-by: Shirish Pargaonkar
Signed-off-by: Steve French
21 Jan, 2011
1 commit
-
Invalidate inode mapping if we don't have at least Level II oplock in
cifs_strict_fsync. Also remove filemap_write_and_wait call from cifs_fsync
because it is previously called from vfs_fsync_range. Add file operations'
structures for strict cache mode.Reviewed-by: Jeff Layton
Signed-off-by: Pavel Shilovsky
Signed-off-by: Steve French
16 Jan, 2011
1 commit
-
Make CIFS use the new d_automount() dentry operation rather than abusing
follow_link() on directories.[NOTE: THIS IS UNTESTED!]
Signed-off-by: David Howells
Cc: Steve French
Signed-off-by: Al Viro
13 Jan, 2011
1 commit
-
Signed-off-by: Al Viro
10 Jan, 2011
1 commit
-
Reduce false inode collisions by using the CreationTime like an
i_generation field. This way, even if the server ends up reusing
a uniqueid after a delete/create cycle, we can avoid matching
the inode incorrectly.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
07 Jan, 2011
4 commits
-
dcache_inode_lock can be replaced with per-inode locking. Use existing
inode->i_lock for this. This is slightly non-trivial because we sometimes
need to find the inode from the dentry, which requires d_inode to be
stabilised (either with refcount or d_lock).Signed-off-by: Nick Piggin
-
Reduce some branches and memory accesses in dcache lookup by adding dentry
flags to indicate common d_ops are set, rather than having to check them.
This saves a pointer memory access (dentry->d_op) in common path lookup
situations, and saves another pointer load and branch in cases where we
have d_op but not the particular operation.Patched with:
git grep -E '[.>]([[:space:]])*d_op([[:space:]])*=' | xargs sed -e 's/\([^\t ]*\)->d_op = \(.*\);/d_set_d_op(\1, \2);/' -e 's/\([^\t ]*\)\.d_op = \(.*\);/d_set_d_op(\&\1, \2);/' -i
Signed-off-by: Nick Piggin
-
dcache_lock no longer protects anything. remove it.
Signed-off-by: Nick Piggin
-
Add a new lock, dcache_inode_lock, to protect the inode's i_dentry list
from concurrent modification. d_alias is also protected by d_lock.Signed-off-by: Nick Piggin
08 Dec, 2010
1 commit
-
It's possible that cifs_mount will call cifs_build_path_to_root on a
newly instantiated cifs_sb. In that case, it's likely that the
master_tlink pointer has not yet been instantiated.Fix this by having cifs_build_path_to_root take a cifsTconInfo pointer
as well, and have the caller pass that in.Reported-and-Tested-by: Robbert Kouprie
Signed-off-by: Jeff Layton
Signed-off-by: Steve French
07 Dec, 2010
1 commit
-
Some of the code under CONFIG_CIFS_ACL is dependent upon code under
CONFIG_CIFS_EXPERIMENTAL, but the Kconfig options don't reflect that
dependency. Move more of the ACL code out from under
CONFIG_CIFS_EXPERIMENTAL and under CONFIG_CIFS_ACL.Also move find_readable_file out from other any sort of Kconfig
option and make it a function normally compiled in.Reported-and-Acked-by: Randy Dunlap
Signed-off-by: Jeff Layton
Signed-off-by: Steve French
03 Dec, 2010
1 commit
-
Currently, the attribute cache timeout for CIFS is hardcoded to 1 second. This
means that the client might have to issue a QPATHINFO/QFILEINFO call every 1
second to verify if something has changes, which seems too expensive. On the
other hand, if the timeout is hardcoded to a higher value, workloads that
expect strict cache coherency might see unexpected results.Making attribute cache timeout as a tunable will allow us to make a tradeoff
between performance and cache metadata correctness depending on the
application/workload needs.Add 'actimeo' tunable that can be used to tune the attribute cache timeout.
The default timeout is set to 1 second. Also, display actimeo option value in
/proc/mounts.It appears to me that 'actimeo' and the proposed (but not yet merged)
'strictcache' option cannot coexist, so care must be taken that we reset the
other option if one of them is set.Changes since last post:
- fix option parsing and handle possible values correclyReviewed-by: Jeff Layton
Signed-off-by: Suresh Jayaraman
Signed-off-by: Steve French
30 Nov, 2010
2 commits
-
Change the name of function mode_to_acl to mode_to_cifs_acl.
Handle return code in functions mode_to_cifs_acl and
cifs_acl_to_fattr.Signed-off-by: Shirish Pargaonkar
Signed-off-by: Steve French -
Only the callers check whether the invalid_mapping flag is set and not
cifs_invalidate_mapping().Signed-off-by: Suresh Jayaraman
Signed-off-by: Steve French
11 Nov, 2010
1 commit
-
cifs_root_iget allocates full_path through
cifs_build_path_to_root, but fails to kfree it upon
cifs_get_inode_info* failure.Make all failure exit paths traverse clean up
handling at the end of the function.Signed-off-by: Oskar Schirmer
Reviewed-by: Jesper Juhl
Cc: stable@kernel.org
Signed-off-by: Steve French
09 Nov, 2010
1 commit
-
Andrew Hendry reported a kmemleak warning in 2.6.37-rc1 while editing a
text file with gedit over cifs.unreferenced object 0xffff88022ee08b40 (size 32):
comm "gedit", pid 2524, jiffies 4300160388 (age 2633.655s)
hex dump (first 32 bytes):
5c 2e 67 6f 75 74 70 75 74 73 74 72 65 61 6d 2d \.goutputstream-
35 42 41 53 4c 56 00 de 09 00 00 00 2c 26 78 ee 5BASLV......,&x.
backtrace:
[] kmemleak_alloc+0x2d/0x60
[] __kmalloc+0xe3/0x1d0
[] build_path_from_dentry+0xf0/0x230 [cifs]
[] cifs_setattr+0x9e/0x770 [cifs]
[] notify_change+0x170/0x2e0
[] sys_fchmod+0x10b/0x140
[] system_call_fastpath+0x16/0x1b
[] 0xffffffffffffffffThe commit 1025774c that removed inode_setattr() seems to have introduced this
memleak by returning early without freeing 'full_path'.Reported-by: Andrew Hendry
Cc: Christoph Hellwig
Reviewed-by: Jeff Layton
Signed-off-by: Suresh Jayaraman
Signed-off-by: Steve French
25 Oct, 2010
1 commit
-
write_behind_rc is redundant and just adds complexity to the code. What
we really want to do instead is to use mapping_set_error to reset the
flags on the mapping when we find a writeback error and can't report it
to userspace yet.For cifs_flush and cifs_fsync, we shouldn't reset the flags since errors
returned there do get reported to userspace.Signed-off-by: Jeff Layton
Reviewed-by: Suresh Jayaraman
Reviewed-by: Dave Kleikamp
Signed-off-by: Steve French
12 Oct, 2010
1 commit
-
commit 3aa1c8c2900065a51268430ab48a1b42fdfe5b45 made cifs_getattr set
the ownership of files to current_fsuid/current_fsgid when multiuser
mounts were in use and when mnt_uid/mnt_gid were non-zero.It should have instead based that decision on the
CIFS_MOUNT_OVERR_UID/GID flags.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
08 Oct, 2010
2 commits
-
...when unix extensions aren't enabled. This makes everything on the
mount appear to be owned by the current user.This version of the patch differs from previous versions however in that
the admin can still force the ownership of all files to appear as a
single user via the uid=/gid= options.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
07 Oct, 2010
3 commits
-
When we implement multiuser mounts, we'll need to filter filehandles
by fsuid. Add a flag for multiuser mounts and code to filter by
fsuid when it's set.Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
reference to it. Change it to keep a pointer to a tcon_link instead and
hold a reference to it.That will keep the tcon from being freed until the file is closed.
Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
Eventually, we'll need to track the use of tcons on a per-sb basis, so that
we know when it's ok to tear them down. Begin this conversion by adding a
new "tcon_link" struct and accessors that get it. For now, the core data
structures are untouched -- cifs_sb still just points to a single tcon and
the pointers are just cast to deal with the accessor functions. A later
patch will flesh this out.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
30 Sep, 2010
5 commits
-
Testing on very recent kernel (2.6.36-rc6) made this warning pop:
WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x65/0x70()
Hardware name:
Dirtiable inode bdi default != sb bdi cifs...the following patch fixes it and seems to be the obviously correct
thing to do for cifs.Cc: stable@kernel.org
Acked-by: Dave Kleikamp
Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
At mount time, we'll always need to create a tcon that will serve as a
template for others that are associated with the mount. This tcon is
known as the "master" tcon.In some cases, we'll need to use that tcon regardless of who's accessing
the mount. Add an accessor function for the master tcon and go ahead and
switch the appropriate places to use it.Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
When we convert cifs to do multiple sessions per mount, we'll need more
than one tcon per superblock. At that point "cifs_sb->tcon" will make
no sense. Add a new accessor function that gets a tcon given a cifs_sb.
For now, it just returns cifs_sb->tcon. Later it'll do more.Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
...where it's available and appropriate.
Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
If configured, Minshall+French Symlinks are used against
all servers. If the server supports UNIX Extensions,
we still create Minshall+French Symlinks on write,
but on read we fallback to UNIX Extension symlinks.Signed-off-by: Stefan Metzmacher
Signed-off-by: Steve French
