11 Oct, 2007
5 commits
-
Fix problems detected by sparse:
1. whole chunk of MAC code was for defined and never used
2. hook for running ext intr in workqueue wasn't being usedSigned-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
These have been superceded by the new ->get_sset_count() hook.
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller -
For the operations
get-tx-csum
get-sg
get-tso
get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case. Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.[ Resolved conflicts with set/get value ethtool patch... -DaveM ]
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller -
It's been a useless no-op for long enough in 2.6 so I figured it's time to
remove it. The number of people that could object because they're
maintaining unified 2.4 and 2.6 drivers is probably rather small.[ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]
Signed-off-by: Ralf Baechle
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller -
Several devices have multiple independant RX queues per net
device, and some have a single interrupt doorbell for several
queues.In either case, it's easier to support layouts like that if the
structure representing the poll is independant from the net
device itself.The signature of the ->poll() call back goes from:
int foo_poll(struct net_device *dev, int *budget)
to
int foo_poll(struct napi_struct *napi, int budget)
The caller is returned the number of RX packets processed (or
the number of "NAPI credits" consumed if you want to get
abstract). The callee no longer messes around bumping
dev->quota, *budget, etc. because that is all handled in the
caller upon return.The napi_struct is to be embedded in the device driver private data
structures.Furthermore, it is the driver's responsibility to disable all NAPI
instances in it's ->stop() device close handler. Since the
napi_struct is privatized into the driver's private data structures,
only the driver knows how to get at all of the napi_struct instances
it may have per-device.With lots of help and suggestions from Rusty Russell, Roland Dreier,
Michael Chan, Jeff Garzik, and Jamal Hadi Salim.Bug fixes from Thomas Graf, Roland Dreier, Peter Zijlstra,
Joseph Fannin, Scott Wood, Hans J. Koch, and Michael Chan.[ Ported to current tree and all drivers converted. Integrated
Stephen's follow-on kerneldoc additions, and restored poll_list
handling to the old style to fix mutual exclusion issues. -DaveM ]Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
03 Jun, 2007
1 commit
-
Many drivers had code that did kill_vid, but they weren't doing vlan
filtering. With new API the stub is unneeded unless device sets
NETIF_F_HW_VLAN_FILTER.Bad habit: I couldn't resist fixing a couple of nearby style things
in acenic, and forcedeth.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
25 May, 2007
1 commit
-
Hello,
Balanance parenthesis in chelsio header file.
Signed-off-by: Mariusz Kozlowski
drivers/net/chelsio/suni1x10gexp_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Jeff Garzik
28 Apr, 2007
3 commits
-
There are several uses of _ops structure in this driver that
can be converted to const.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Convert some initialized structures to C99 style.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Some code for Chelsio 1G boards was put in the driver
based on the vendor version (minus TOE). Well some of those board
versions are only supported with TOE on the vendor driver, so additional
dead code was added.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
26 Apr, 2007
7 commits
-
To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.Signed-off-by: Arnaldo Carvalho de Melo
-
To clearly state the intent of copying from linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.Signed-off-by: Arnaldo Carvalho de Melo
-
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
For the quite common 'skb->nh.raw - skb->data' sequence.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
One less thing for drivers writers to worry about.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
03 Mar, 2007
1 commit
-
This patch splits the vlan_group struct into a multi-allocated struct. On
x86_64, the size of the original struct is a little more than 32KB, causing
a 4-order allocation, which is prune to problems caused by buddy-system
external fragmentation conditions.I couldn't just use vmalloc() because vfree() cannot be called in the
softirq context of the RCU callback.Signed-off-by: Dan Aloni
Acked-by: Jeff Garzik
Signed-off-by: David S. Miller
27 Feb, 2007
1 commit
-
Chelsio without NAPI enabled has been broken (won't compile) since
3de00b89 ("chelsio: NAPI speed improvement"):drivers/net/chelsio/sge.c: In function `t1_interrupt`:
drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)The change below seems to add back in the declaration and
initialization of `Q` that was removed by mistake, and at least makes
the driver compile for me, although I have no hardware and hence no
way to test whether this actually works.Signed-off-by: Roland Dreier
Signed-off-by: Jeff Garzik
06 Feb, 2007
10 commits
-
Cc: "Sunil Naidu"
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Cleanup receive processing some more:
* do the reserve padding of skb during setup
* don't pass constants to get_packet
* do smart prefetch of skb
* make copybreak a module parameterSigned-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Speedup and cleanup the receive processing by eliminating the
mmio read and a lock round trip.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Let's try to avoid some code duplication.
- cxgb2
The data are contiguous. Use plain memcpy.- ixf1010/pm3393/vsc7326
The cast of &mac->stats to (u64 *) is not wonderful but it is not clear
if it is worth to add an ad-hoc union under the struct cmac_statistics.vsc7326_reg.h suggests that more statistics could be available.
Signed-off-by: Francois Romieu
-
- duplicated code in sge::free_cmdQ_buffers ;
- NET_IP_ALIGN is already defined in (included) ;
- pci_alloc_consistent() returns void * ;
- pci_alloc_consistent() returns a zeroed chunk of memory ;
- early return in restart_tx_queues.Signed-off-by: Francois Romieu
-
pci_get_drvadata() is necessarily distinct from NULL if
cxgb2::init_one succeeded. cxgb2::remove_one is solely
issued through the PCI device callback.Signed-off-by: Francois Romieu
-
Signed-off-by: Francois Romieu
-
Signed-off-by: Francois Romieu
-
Signed-off-by: Francois Romieu
-
Signed-off-by: Francois Romieu
09 Jan, 2007
1 commit
-
Fix handling of allocation failure.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
11 Dec, 2006
1 commit
-
This driver tries to enable/disable NAPI at runtime, but
does so in an unsafe manner, and the NAPI interrupt handling is
a mess. Replace it with a compile time selected NAPI implementation.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
06 Dec, 2006
1 commit
-
Fix up arch-specific work items where possible to use the new work_struct and
delayed_work structs.Three places that enqueue bits of their stack and then return have been marked
with #error as this is not permitted.Signed-Off-By: David Howells
05 Dec, 2006
1 commit
-
Conflicts:
drivers/infiniband/core/iwcm.c
drivers/net/chelsio/cxgb2.c
drivers/net/wireless/bcm43xx/bcm43xx_main.c
drivers/net/wireless/prism54/islpci_eth.c
drivers/usb/core/hub.h
drivers/usb/input/hid-core.c
net/core/netpoll.cFix up merge failures with Linus's head and fix new compilation failures.
Signed-Off-By: David Howells
02 Dec, 2006
7 commits
-
If transmit lock is contended on, then push return code back
and retry at higher level.Bugfix: If buffer is reallocated because of lack of headroom
and the send is blocked, then drop packet. This is necessary
because caller would end up requeuing a freed skb.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Cleanup statistics management:
* Get rid of duplicate or unused statistics
* Convert high volume stats to per-cpu and 64 bitSigned-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Using MSI can avoid sharing IRQ and associated overhead.
Tested on PCI-X.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Replace driver crc calculation with existing library.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Replace macro with function for updating RMON values
Cleanups:
* remove unused enum's
* Fix comment formatSigned-off-by: Stephen HEmminger
Signed-off-by: Jeff Garzik -
Add support for 1G versions of Chelsio devices.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Add support for other versions of the 10G Chelsio boards.
This is basically a port of the vendor driver with the
TOE features removed.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik