13 Oct, 2007

7 commits

  • menuconfig currently represents options implied by another option ('select'
    directive in Kconfig) by prefixing them with '---'. Unfortunately the same
    notation is used for comments. If the implied option is module capable,
    user can still switch between Y and M, all without any feedback until she
    visits option's help. (try saying M to MAC80211 and then toggling
    CFG80211)

    This patch changes notation of selected-by-another items by introducing 2
    new representations for implied options: {*} or {M} for options selected by
    another modularized one, thus builtin or module capable, -*- or -M- for
    options that cannot be at the moment changed by user.

    The idea is to represent actual capability of the option by braces (dashes)
    around and to always report actual state by * or M inside.

    Signed-off-by: Matej Laitl
    Acked-by: Randy Dunlap
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Matej Laitl
     
  • Change kconfig behavior so that mixing bool and tristate config settings in
    a choice is possible and has the desired effect of offering just the
    tristate options individually if the choice gets set to M, and a normal
    boolean selection if the choice gets set to Y.

    Signed-off-by: Jan Beulich
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Jan Beulich
     
  • Update _shipped files so regular user does not
    need to have bison/flex/gperf installed.
    Code changes were contained in previous commit.

    Used following program versions (on fedora):
    bison (GNU Bison) 2.3
    flex 2.5.33
    GNU gperf 3.0.2

    Cc: Adrian Bunk
    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Remove the following redundant and never or rarely used kconfig syntax:

    - "def_boolean" (same as "def_bool")
    - "requires" (same as "depends on")
    - "depends" (same as "depends on")

    This patch contains the code changes and Kconfig updates.
    The shipped files are in next patch to let actual codechange stand out.

    Signed-off-by: Adrian Bunk
    Cc: "Randy.Dunlap"
    Cc: Bryan Wu
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Cc: Dmitry Torokhov
    Cc: "John W. Linville"
    Cc: Roman Zippel
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Adrian Bunk
     
  • With specific configurations requesting help for certain
    menu lines caused menuconfig to crash.
    This was tracked down to a null pointer bug.
    Thanks to "Miles Lane" for inital reporting
    and to Gabriel C for the backtrace
    that helped me locating the bug.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Matěj Laitl noticed that there was no way
    to distingush between comments and un-selectable menu lines.
    This patch marks comments with *** comment ***

    Cc: Matěj Laitl
    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • cygwin provides the header file but the lib file needs
    to be added manually. A generic fix is to check if
    we can compile and link a program that uses gettext()
    and if it fails fall back to NO_NLS.

    International users of cygwin may have to specify
    HOST_LOADLIBES := "-lintl" on the make command line.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

01 Sep, 2007

1 commit

  • Avoid setting the value if the symbol doesn't need to be changed or can't
    be changed. Later choices may change the dependencies and thus the
    possible input range.

    make oldconfig from a 2.6.22 .config with CONFIG_HOTPLUG_CPU not set
    was in some configurations setting CONFIG_HOTPLUG_CPU=y without asking,
    even when there was no actual requirement for CONFIG_HOTPLUG_CPU.
    This was triggered by SUSPEND_SMP that does a select HOTPLUG_CPU.

    Signed-off-by: Roman Zippel
    Tested-by: Hugh Dickins
    Signed-off-by: Sam Ravnborg

    Roman Zippel
     

26 Jul, 2007

2 commits

  • dep and dep2 in struct symbol was unused - remove them.

    Signed-off-by: Sam Ravnborg
    Cc: Roman Zippel

    Sam Ravnborg
     
  • Roman Zippel wrote:
    > A simple example would be
    > help texts, right now they are per symbol, but they should really be per
    > menu, so archs can provide different help texts for something.

    This patch does this and at the same time introduce a few API
    funtions used to access the help text.

    The relevant api functions are introduced in the various frontends.

    Signed-off-by: Sam Ravnborg
    Cc: Roman Zippel

    Sam Ravnborg
     

17 Jul, 2007

4 commits

  • Normally generated values (Kconfig entries without a prompt) are cleared as
    they are regenerated anyway and so they appear as new should they become
    visible and defaults work as expected (once a value is set defaults aren't
    used anymore).

    The detection whether a value is generated or not is only based on its
    visibility status, which can quickly change for a lot of symbols by just
    removing a single line from .config or adding a dependency to Kconfig as you
    noticed.

    The patch now suppresses this logic when .config and Kconfig aren't in sync
    and .config needs to be updated, so that you can remove now a random value
    from .config and oldconfig won't reask for many other values.

    Signed-off-by: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Roman Zippel
     
  • Modify the ncurses configuration tool ('make menuconfig') in a way that the
    user can enter the search string (/) both with or without the leading
    'CONFIG_'.

    This simplifies using copy & paste from .config files because you can
    select the whole word.

    Signed-off-by: Bernhard Walle
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Bernhard Walle
     
  • Massimo Maiurana reported that
    update-po-config was broken:
    1) spelling errors in Makefile so arch/um failed
    2) UTF-8 was not supported

    The following patch address the above problems.
    kxgettext now append the output to the .pot file
    generated by xgettext - so we have a header.
    In all places UFT-8 is specifed so we now flawlessly
    support UTF-8.
    The Kconfig files had an empty string in a few cases -
    these are now supressed in kxgettext.

    With this the translators can now pick up where they left
    and get it all translated.
    There are ~11000 strings to be translated...

    Signed-off-by: Sam Ravnborg
    Cc: Massimo Maiurana
    Cc: Arnaldo Carvalho de Melo

    Sam Ravnborg
     
  • The "==" operator is not in POSIX, so use -eq instead.

    Signed-off-by: Mike Frysinger
    Signed-off-by: Sam Ravnborg

    Mike Frysinger
     

19 May, 2007

1 commit


06 May, 2007

2 commits

  • I have found small bug in mconf, when you run it without any argument it
    will sigsegv.

    Without patch:
    $ scripts/kconfig/mconf
    Segmentation fault

    With patch:
    $ scripts/kconfig/mconf
    can't find file (null)

    Signed-off-by: Marcin Garski
    Signed-off-by: Sam Ravnborg

    Marcin Garski
     
  • Sample:
    config FOO
    bool "This is foo"
    depends on BAR

    config BAR
    bool "This is bar"
    depends on FOO

    This will result in following error message:
    error: found recursive dependency: FOO -> BAR -> FOO

    And will then exit with exit code equal 1 so make will stop.
    Inspired by patch from: Adrian Bunk

    Signed-off-by: Sam Ravnborg
    Cc: Adrian Bunk
    Cc: Roman Zippel

    Sam Ravnborg
     

03 May, 2007

8 commits


15 Feb, 2007

5 commits


12 Jan, 2007

1 commit


06 Jan, 2007

1 commit


14 Dec, 2006

4 commits

  • Clean up a little.

    Signed-off-by: Karsten Wiese
    Cc: Sam Ravnborg
    Cc: Roman Zippel
    Acked-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Wiese
     
  • Added function sets "void (*conf_changed_callback)(void)". Call it, if
    .config's changed state changes. Use above in qconf.cc to set gui's
    save-widget's sensitvity.

    Signed-off-by: Karsten Wiese
    Cc: Sam Ravnborg
    Cc: Roman Zippel
    Acked-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Wiese
     
  • Those two functions are
    void sym_set_change_count(int count)
    and
    void sym_add_change_count(int count)

    All write accesses to sym_change_count are replaced by calls to above
    functions.

    Variable and changer-functions are moved to confdata.c. IMO thats ok, as
    sym_change_count is an attribute of the .config's change state.

    Signed-off-by: Karsten Wiese
    Cc: Sam Ravnborg
    Cc: Roman Zippel
    Acked-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Wiese
     
  • Run "make xconfig" on a freshly untarred kernel-tree. Look at the floppy disk
    icon of the qt application, that has just started: Its in a normal, active
    state.

    Mouse click on it: .config is being saved.

    This patch series changes things so taht
    after the mouse click on the floppy disk icon, the icon is greyed out.
    If you mouse click on it now, nothing happens.

    If you change some CONFIG_*, the floppy disk icon returns to "active state",
    that is, if you mouse click it now, .config is written.

    This patch:

    Returns sym_change_count to reflect the .config's change state.
    All read only accesses of
    sym_change_count
    are replaced by calls to
    conf_get_changed()
    .
    mconfig.c is manipulated to ask for saving only when
    conf_get_changed() returned true.

    Signed-off-by: Karsten Wiese
    Cc: Sam Ravnborg
    Cc: Roman Zippel
    Acked-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Wiese
     

08 Dec, 2006

1 commit


26 Nov, 2006

2 commits

  • On Mon, 13 Nov 2006, Phil Oester wrote:
    > In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
    > color scheme was changed to bluetitle. This breaks the highlighting
    > of the selected item for me with TERM=vt100. The only way I can see
    > which item is selected is via:
    >
    > make MENUCONFIG_COLOR=mono menuconfig
    >
    > Which restores the pre-2.6.19 white on black highlighting.

    Fix.

    Cc: Phil Oester
    Signed-off-by: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roman Zippel
     
  • Fixes a segfault reported by Randy.

    Cc: Randy Dunlap
    Signed-off-by: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roman Zippel
     

13 Nov, 2006

1 commit

  • Prevent git from reporting this useless status:

    On branch refs/heads/master
    Untracked files:
    (use "git add" to add to commit)

    TAGS
    scripts/kconfig/lkc_defs.h
    scripts/kconfig/qconf.moc
    nothing to commit

    Signed-off-by: Franck Bui-Huu
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Franck Bui-Huu