20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
14 Mar, 2014
1 commit
-
Static analysis from cppcheck issued the following warning:
[drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
inside sizeof().The current size calculation is not obvious and is easy to
miscomprehend, so re-work the size of the allocation based
on the size of the struct pointer and quantity to allocate.Signed-off-by: Colin Ian King
Signed-off-by: Lee Jones
21 Jan, 2014
1 commit
-
pm_runtime_get/put_sync() can sleep so don't hold spinlock while
calling them.This patch prevents a BUG() during system suspend when
CONFIG_DEBUG_ATOMIC_SLEEP is enabled.Bug is present in Kernel versions v3.9 onwards.
Reported-by: Tomi Valkeinen
Signed-off-by: Roger Quadros
Tested-by: Tomi Valkeinen
Signed-off-by: Lee Jones
06 Jan, 2014
1 commit
-
All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
Need to use endian neutral functions to read/write h/w registers.
I.e instead of __raw_read[lw] and __raw_write[lw] functions code
need to use read[lw]_relaxed and write[lw]_relaxed functions.
If the first simply reads/writes register, the second will byteswap
it if host operates in BE mode.Changes are trivial sed like replacement of __raw_xxx functions
with xxx_relaxed variant.Signed-off-by: Victor Kamensky
Signed-off-by: Taras Kondratiuk
Signed-off-by: Lee Jones
23 Oct, 2013
2 commits
-
This should fix the following warning at boot on OMAP5 uEVM
[ 8.783155] WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:883 __clk_enable+0x94/0xa4()Signed-off-by: Roger Quadros
Signed-off-by: Lee Jones -
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.Signed-off-by: Sachin Kamat
Signed-off-by: Lee Jones
09 Apr, 2013
3 commits
-
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.Signed-off-by: Sachin Kamat
Acked-by: Roger Quadros
Signed-off-by: Samuel Ortiz -
Allows the OMAP USB TLL module to be specified via device tree.
Signed-off-by: Roger Quadros
Signed-off-by: Samuel Ortiz -
This is because we want to get rid of platform_data usage from probe().
The only information we need is PORT_MODE, and this can be supplied
to us by the user (i.e. omap-usb-host.c).We also move channel clock management from runtime PM handlers into
omap_tll_enable/disable().Signed-off-by: Roger Quadros
Signed-off-by: Samuel Ortiz
13 Feb, 2013
9 commits
-
The TLL module on OMAP5 has 3 channels.
HSIC mode requires the TLL channel to be in Transparent UTMI mode.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Get rid of the unnecessary spin_lock_irqsave/restore() as there is
no interrupt handler for this driver. Instead we serialize access
to tll_dev using a global spinlock.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
omap_enable/disable_tll() can fail if TLL device is not
initialized. It could be due to multiple reasons and not only
due to missing platform data.Also make local variables static and use 'struct device *'
instead of 'struct platform_device *' for global reference.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
No need to check for missing platform data in runtime_suspend/resume
as it makes more sense to do it in the probe function.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
This is a handy macro to check if the port requires the
USB TLL module or not. Use it to Enable the TLL module and manage
the clocks.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Every channel has a functional clock that is similarly named.
It makes sense to use a for loop to manage these clocks as OMAPs
can come with up to 3 channels.Dynamically allocate and get channel clocks depending on the
number of clocks avaiable on the platform.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
Acked-by: Russell King -
Use devm_ variants of kzalloc() and ioremap(). Simplify the error path.
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Fix channel count detecion for REV2. Also, don't give up
if we don't recognize the IP Revision. We assume the default
number of channels (i.e. 3) for unrecognized IPs.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Let's have a single platform data structure for the OMAP's High-Speed
USB host subsystem instead of having 3 separate ones i.e. one for
board data, one for USB Host (UHH) module and one for USB-TLL module.This makes the code much simpler and avoids creating multiple copies of
platform data.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
For the ehci-omap.c part:
Acked-by: Alan Stern
13 Dec, 2012
1 commit
-
Pull ARM SoC Header cleanups from Olof Johansson:
"This is a collection of header file cleanups, mostly for OMAP and
AT91, that keeps moving the platforms in the direction of
multiplatform by removing the need for mach-dependent header files
used in drivers and other places."Fix up mostly trivial conflicts as per Olof.
* tag 'headers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (106 commits)
ARM: OMAP2+: Move iommu/iovmm headers to platform_data
ARM: OMAP2+: Make some definitions local
ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c
ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
ARM: OMAP2+: Move iopgtable header to drivers/iommu/
ARM: OMAP: Merge iommu2.h into iommu.h
atmel: move ATMEL_MAX_UART to platform_data/atmel.h
ARM: OMAP: Remove omap_init_consistent_dma_size()
arm: at91: move at91rm9200 rtc header in drivers/rtc
arm: at91: move reset controller header to arm/arm/mach-at91
arm: at91: move pit define to the driver
arm: at91: move at91_shdwc.h to arch/arm/mach-at91
arm: at91: move board header to arch/arm/mach-at91
arn: at91: move at91_tc.h to arch/arm/mach-at91
arm: at91 move at91_aic.h to arch/arm/mach-at91
arm: at91 move board.h to arch/arm/mach-at91
arm: at91: move platfarm_data to include/linux/platform_data/atmel.h
arm: at91: drop machine defconfig
ARM: OMAP: Remove NEED_MACH_GPIO_H
ARM: OMAP: Remove unnecessary mach and plat includes
...
29 Nov, 2012
3 commits
-
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.Signed-off-by: Bill Pemberton
Cc: Srinidhi Kasagar
Cc: Peter Tyser
Cc: Daniel Walker
Cc: Bryan Huntsman
Acked-by: David Brown
Acked-by: Linus Walleij
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Srinidhi Kasagar
Cc: Peter Tyser
Cc: Daniel Walker
Cc: Bryan Huntsman
Acked-by: David Brown
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Srinidhi Kasagar
Cc: Peter Tyser
Cc: Daniel Walker
Cc: Bryan Huntsman
Acked-by: David Brown
Acked-by: Linus Walleij
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman
25 Oct, 2012
1 commit
-
In order to make single zImage work for ARM architecture,
we need to make sure we don't depend on private headers.Move USB platform_data to
and add a minimal drivers/mfd/usb-omap.h.Cc: Samuel Ortiz
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Cc: Partha Basak
Cc: Keshava Munegowda
Cc: linux-usb@vger.kernel.org
Signed-off-by: Felipe Balbi
[tony@atomide.com: updated for local mfd/usb-omap.h]
Signed-off-by: Tony Lindgren
22 Sep, 2012
1 commit
-
The platform driver for the TLL component of the OMAP USB host controller
is implemented. Depending on the TLL hardware revision , the TLL channels
are configured. The USB HS core driver uses this driver through exported
APIs from the TLL platform driver.
usb_tll_enable and usb_tll_disble are the exported APIs of the USB TLL
platform driver.Signed-off-by: Keshava Munegowda
Reviewed-by: Partha Basak
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
