22 Sep, 2015
2 commits
-
According to lp8727 bindings[*], charging parameter is optional.
So parsing can be skipped in case those properties are undefined.
However, 'debounce-ms' should be read prior to checking the properties.
Otherwise, 'debounce-ms' property will be ignored even it is configured
inside the DT.
So, counting child is processed after updating 'debounce-ms'.[*] Documentation/devicetree/bindings/power_supply/lp8727_charger.txt
Cc: Dmitry Eremin-Solenikov
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim
Signed-off-by: Sebastian Reichel -
Currently, lp8727 charger driver parses the DT and copies values into the
'cl->dev.platform_data' if 'of_node' exists.
This may have architectural issue. Platform data is configurable through
the DT or I2C board info inside the platform area.
However, lp8727 driver changes this configuration when it is loaded.The driver should get data from the platform side and use the private
data, 'lp8727_chg->pdata' instead of changing the original platform data._probe() procedure is changed as follows.
1. lp8727_parse_dt() returns the pointer of lp8727_platform_data.
The driver uses this allocated platform data. So it should keep
original platform data, 'dev->platform_data'.
2. In _probe(), check the return value of lp8727_parse_dt().
If an error is found, then exit as PTR_ERR(pdata).
3. If 'of_node' is not found, then the driver just gets the platform data
from the I2C device structure.
4. Map the platform data to private data structure.Cc: Dmitry Eremin-Solenikov
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim
Signed-off-by: Sebastian Reichel
14 Mar, 2015
2 commits
-
Change the ownership of power_supply structure from each driver
implementing the class to the power supply core.The patch changes power_supply_register() function thus all drivers
implementing power supply class are adjusted.Each driver provides the implementation of power supply. However it
should not be the owner of power supply class instance because it is
exposed by core to other subsystems with power_supply_get_by_name().
These other subsystems have no knowledge when the driver will unregister
the power supply. This leads to several issues when driver is unbound -
mostly because user of power supply accesses freed memory.Instead let the core own the instance of struct 'power_supply'. Other
users of this power supply will still access valid memory because it
will be freed when device reference count reaches 0. Currently this
means "it will leak" but power_supply_put() call in next patches will
solve it.This solves invalid memory references in following race condition
scenario:Thread 1: charger manager
Thread 2: power supply driver, used by charger managerTHREAD 1 (charger manager) THREAD 2 (power supply driver)
========================== ==============================
psy = power_supply_get_by_name()
Driver unbind, .remove
power_supply_unregister()
Device fully removed
psy->get_property()The 'get_property' call is executed in invalid context because the driver was
unbound and struct 'power_supply' memory was freed.This could be observed easily with charger manager driver (here compiled
with max17040 fuel gauge):$ cat /sys/devices/virtual/power_supply/cm-battery/capacity &
$ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind
[ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[ 55.732584] pgd = d98d4000
[ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000
[ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM
[ 55.746210] Modules linked in:
[ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496
[ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000
[ 55.771647] PC is at 0x0
[ 55.774182] LR is at charger_get_property+0x2f4/0x36c
[ 55.779201] pc : [] lr : [] psr: 60000013
[ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000
[ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68
[ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000
[ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68
[ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user
[ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015
[ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210)
[ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000)
[ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8
[ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4
[ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80
[ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001
[ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000
[ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000
[ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124
[ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550
[ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364
[ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c
[ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000
[ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000
[ 55.929744] [] (charger_get_property) from [] (power_supply_show_property+0x48/0x20c)
[ 55.939286] [] (power_supply_show_property) from [] (dev_attr_show+0x1c/0x48)
[ 55.948130] [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x84/0x104)
[ 55.956298] [] (sysfs_kf_seq_show) from [] (kernfs_seq_show+0x24/0x28)
[ 55.964536] [] (kernfs_seq_show) from [] (seq_read+0x1b0/0x484)
[ 55.972172] [] (seq_read) from [] (__vfs_read+0x18/0x4c)
[ 55.979188] [] (__vfs_read) from [] (vfs_read+0x7c/0x100)
[ 55.986304] [] (vfs_read) from [] (SyS_read+0x40/0x8c)
[ 55.993164] [] (SyS_read) from [] (ret_fast_syscall+0x0/0x48)
[ 56.000626] Code: bad PC value
[ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]---Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Bartlomiej Zolnierkiewicz[for the nvec part]
Reviewed-by: Marc Dietrich[for compal-laptop.c]
Acked-by: Darren Hart[for the mfd part]
Acked-by: Lee Jones[for the hid part]
Acked-by: Jiri Kosina[for the acpi part]
Acked-by: Rafael J. WysockiSigned-off-by: Sebastian Reichel
-
Add new structure 'power_supply_config' for holding run-time
initialization data like of_node, supplies and private driver data.The power_supply_register() function is changed so all power supply
drivers need updating.When registering the power supply this new 'power_supply_config' should be
used instead of directly initializing 'struct power_supply'. This allows
changing the ownership of power_supply structure from driver to the
power supply core in next patches.When a driver does not use of_node or supplies then it should use NULL
as config. If driver uses of_node or supplies then it should allocate
config on stack and initialize it with proper values.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Bartlomiej Zolnierkiewicz
Acked-by: Pavel Machek[for the nvec part]
Reviewed-by: Marc Dietrich[for drivers/platform/x86/compal-laptop.c]
Reviewed-by: Darren Hart[for drivers/hid/*]
Reviewed-by: Jiri KosinaSigned-off-by: Sebastian Reichel
07 Jun, 2013
1 commit
-
The interrupt and charging parameters are configurable in the device tree
structure. In the board test, a GPIO is used for handling LP8727
interrupts. The device tree binding documentation is added also.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov
03 Feb, 2013
1 commit
-
"pdata" and "pchg->pdata" are the same. Changing the function call to
pdata->get_batt_present() makes it match the check and it's a little
cleaner.Signed-off-by: Dan Carpenter
Acked-by: Milo Kim
Signed-off-by: Anton Vorontsov
29 Nov, 2012
2 commits
-
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.Signed-off-by: Bill Pemberton
Cc: Anton Vorontsov
Cc: David Woodhouse
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Anton Vorontsov
Cc: David Woodhouse
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman
21 Sep, 2012
23 commits
-
This is really minor, but it improves the readability.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Fix the warning on MODULE_AUTHOR.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Add description and relocate data.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Declare a variable at one line and align lines.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Declare a variable at one line. Just return when no charger exists to make
code simpler.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
If the charger is pulled out, just return as DISCHARGING. Then no need for
additional 'else' statement.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Charger has only one valid property - ONLINE. If the property is not
ONLINE, then just return quickly.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Just return with lp8727_write_byte(), no need to check its value.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Change return type to boolean. Remove unnecessary check routine for NULL
string. (Power supply name is always valid when the function is executed.)Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Add new LP8727_ICHG_SHIFT definition and replace a magic number. Reuse
definition for the size of interrupt register buffer.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
All definitions should be unique, since they're in the gloabl namespace.
So the prefix LP8727_ are added. Additionally, use BIT() macro for bit
masks. Remove unnecessary definitions such as SW_DM1_U1 and SW_DP2_U2.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Enum lp8727_chg_state can be removed because only one charger status is
used - EOC(End Of Charge).To check whether the EOC is reached or not, use simple comparison rather
than shift-operation.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
For better understanding, use specific function and definitions rather
than magic numbers. New enum type for die temperature is matched with hex
codes. Specific temperature names are better than 0x1, 0x2 and 0x3.And lp8727_is_high_temperature() function has better readability than
comparing raw register values.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
To initialize the device, previous interrupts need to be cleared while
loading the driver.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
For better understanding, function name is changed. (lp8727_intr_config()
is replaced with lp8727_setup_irq().)The private IRQ number is set when the IRQ is allocated successfully. This
data is used for releasing the IRQ on unloading the driver. Even the IRQ
number is not defined, the driver should be operated. In this case, just
return as 0.In additional function lp8727_release_irq(), the workqueue is canceled and
the allocated IRQ is released.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
LP8727 has two IRQ threads. One is the I2C HW IRQ pin, the other is for
delayed interrupt processing. But this delayed processing can be handled
without additional single thread by using schedule_delayed_work() with
jiffies time value.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Debounce time is configurable in the platform side. If it is not defined,
the default value is 270ms.Platform data is msec unit, and this time is converted to jiffies
internally. The workqueue uses this jiffies time in the interrupt
handling. So debounce_jiffies is added in the private data.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
LP8727 platform data is optional, so the driver should work even the
platform data is NULL.To check the platform data, charging parameter data should be changed to
the pointer type.Fix NULL point access problem when getting the battery properties. When
the data is NULL, just return as invalid value.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
If the lp8727_register_psy() gets failed, registered interrupt handler
should be freed, but this is not complete solution. It has still problem.
Assume that the IRQ occurs while unregistering power supply devices. Then
the ISR will access to freed IRQ.From Anton's opinion, it can be resolved if re-ordering the call sequence.
Register power supplies first, then create interrupt handler. Then no need
to free the IRQ in _probe(). Additionally goto statements can be removed
because those can be replaced with return statements.The _remove() should be changed the sequence - in reverse order of
_probe()Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Use devm_kzalloc() rather than kzalloc()/kfree() to make
allocating/freeing the private data simpler.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request
with IRQF_ONESHOTSigned-off-by: Fengguang Wu
Acked-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov
23 Aug, 2012
1 commit
-
if usb power supply registration fails,
we wont unregister the ac power supply
if battery power supply registration fails,
we wont unregister the usb, and ac supply,take care of those things and also no need of goto -err_mem: at the fail case of
kzalloc simply can have return -ENOMEMSigned-off-by: Devendra Naga
Signed-off-by: Anton Vorontsov
14 Jul, 2012
1 commit
-
The lp8727 header can be used only in the platform side, so it can be
moved to the platform_data directory.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov
27 Mar, 2012
7 commits
-
Factor out some boilerplate code for i2c driver registration
into module_i2c_driver.Signed-off-by: Axel Lin
Cc: Woogyom Kim
Cc: Daniel Jeong
Cc: Minkyu Kang
Cc: Peter Edwards
Acked-by: Milo(Woogyom) Kim
Acked-by: Rhyland Klein
Acked-by: Ryan Mallon
Signed-off-by: Anton Vorontsov -
Add MODULE_DEVICE_TABLE to setup modalias for lp8727. Allows auto
modprobing.Signed-off-by: Axel Lin
Signed-off-by: Anton Vorontsov -
intergrated charger -> integrated charger
^Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Definition of STATUS2
: remove space before tabs.Return code of lp8727_is_dedicated_charger(), lp8727_is_usb_charger()
: remove parentheses when return is not a function.MODULE_AUTHOR section
: remove space at the start of a line.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
On writing single byte via i2c, use i2c_smbus_write_byte_data()
rather than i2c_smbus_write_i2c_block_data().Name changes :
lp8727_i2c_read() -> lp8727_read_bytes()
lp8727_i2c_write() -> removed
lp8727_i2c_read_byte() -> lp8727_read_byte()
lp8727_i2c_write_byte() -> lp8727_write_byte()Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Add error checking on initializing registers and interrupt handler.
Initializing registers - lp8727_init_device()
: check i2c error during probing the driver.Initializing interrupt handler - lp8727_intr_config()
: check an error on creating the irq thread.If an error occurs on probing lp8727 driver, allocated lp8727 driver memory is freed.
Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov -
Add 'Texas Instruments' because TI acquired National semiconductor at 2011.
And the driver information is added in the header file.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Anton Vorontsov
