Eric Lee / smarc-fsl-linux-kernel

18 Oct, 2015

2 commits

  • cc2aaabfd   tty: Remove tty_port::close_wait ... Browse Code »

    With the removal of tty_wait_until_sent_from_close(), tty drivers
    no longer wait during open for parallel closes to complete (instead,
    the tty core waits before calling the driver open() method). Thus,
    the close_wait waitqueue is no longer used for waiting.

    Remove struct tty_port::close_wait.

    Signed-off-by: Peter Hurley
    Signed-off-by: Greg Kroah-Hartman

    Peter Hurley
     
  • fef062cbf   tty: Remove ASYNC_CLOSING checks in open()/hangup() methods ... Browse Code »

    Since at least before 2.6.30, tty drivers that do not drop the tty lock
    while closing cannot observe ASYNC_CLOSING set while holding the
    tty lock; this includes the tty driver's open() and hangup() methods,
    since the tty core calls these methods holding the tty lock.

    For these drivers, waiting for ASYNC_CLOSING to clear while opening
    is not required, since this condition cannot occur. Similarly, even
    when the open() method drops and reacquires the tty lock after
    blocking, ASYNC_CLOSING cannot be set (again, for drivers that
    do not drop the tty lock while closing).

    Now that tty port drivers no longer drop the tty lock while closing
    (since 'tty: Remove tty_wait_until_sent_from_close()'), the same
    conditions apply: waiting for ASYNC_CLOSING to clear while opening
    is not required, nor is re-checking ASYNC_CLOSING after dropping and
    reacquiring the tty lock while blocking (eg., in *_block_til_ready()).

    Note: The ASYNC_CLOSING flag state is still maintained since several
    bitrotting drivers use it for (dubious) other purposes.

    Signed-off-by: Peter Hurley
    Signed-off-by: Greg Kroah-Hartman

    Peter Hurley
     

10 Jan, 2015

1 commit

09 Dec, 2013

1 commit

21 May, 2013

1 commit

  • 416187cae   TTY: rocket, fix more no-PCI warnings ... Browse Code »

    Commit "TTY: rocket, fix compilation warning" fixed a compilation
    warning, but there was still a problem with !CONFIG_PCI configs. So
    fix them for good by coupling the PCI functions together and moving
    them inside a common #ifdef.

    Signed-off-by: Jiri Slaby
    Reported-by: kbuild test robot
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

16 Apr, 2013

1 commit

  • f678c4400   TTY: rocket, fix compilation warning ... Browse Code »

    When CONFIG_PCI is unset, we see these warnings in rocket:
    drivers/tty/rocket.c:3140:13: warning: 'rmSpeakerReset' defined but not used
    drivers/tty/rocket.c:2599:12: warning: 'sPCIInitController' defined but not used

    Fix those by moving the functions to one place and make them depend on
    CONFIG_PCI.

    Signed-off-by: Jiri Slaby
    Reported-by: Toralf Foerster
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

19 Mar, 2013

2 commits

  • ee7970690   TTY: cleanup tty->hw_stopped uses ... Browse Code »

    tty->hw_stopped is set only by drivers to remember HW state. If it is
    never set to 1 in a particular driver, there is no need to check it in
    the driver at all. Remove such checks.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • aa27a094e   TTY: add tty_port_tty_hangup helper ... Browse Code »

    It allows for cleaning up on a considerable amount of places. They did
    port_get, hangup, kref_put. Now the only thing needed is to call
    tty_port_tty_hangup which does exactly that. And they can also decide
    whether to consider CLOCAL or completely ignore that.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

18 Jan, 2013

1 commit

16 Jan, 2013

4 commits

  • 37c44b52b   tty: add parenthesis to macro POLL_PERIOD in rocket.c ... Browse Code »

    Macros should be enclosed in parenthesis

    Signed-off-by: Cong Ding
    Signed-off-by: Greg Kroah-Hartman

    Cong Ding
     
  • 2e124b4a3   TTY: switch tty_flip_buffer_push ... Browse Code »

    Now, we start converting tty buffer functions to actually use
    tty_port. This will allow us to get rid of the need of tty in many
    call sites. Only tty_port will needed and hence no more
    tty_port_tty_get in those paths.

    Now, the one where most of tty_port_tty_get gets removed:
    tty_flip_buffer_push.

    IOW we also closed all the races in drivers not using tty_port_tty_get
    at all yet.

    Also we move tty_flip_buffer_push declaration from include/linux/tty.h
    to include/linux/tty_flip.h to all others while we are changing it
    anyway.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • 92a19f9ce   TTY: switch tty_insert_flip_char ... Browse Code »

    Now, we start converting tty buffer functions to actually use
    tty_port. This will allow us to get rid of the need of tty in many
    call sites. Only tty_port will needed and hence no more
    tty_port_tty_get in those paths.

    tty_insert_flip_char is the next one to proceed. This one is used all
    over the code, so the patch is huge.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • 2f6933571   TTY: convert more flipping functions ... Browse Code »

    Now, we start converting tty buffer functions to actually use
    tty_port. This will allow us to get rid of the need of tty pointer in
    many call sites. Only tty_port will be needed and hence no more
    tty_port_tty_get calls in those paths.

    Now 4 string flipping ones are on turn:
    * tty_insert_flip_string_flags
    * tty_insert_flip_string_fixed_flag
    * tty_prepare_flip_string
    * tty_prepare_flip_string_flags

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

22 Nov, 2012

1 commit

16 Nov, 2012

1 commit

  • 191c5f102   TTY: call tty_port_destroy in the rest of drivers ... Browse Code »

    After commit "TTY: move tty buffers to tty_port", the tty buffers are
    not freed in some drivers. This is because tty_port_destructor is not
    called whenever a tty_port is freed. This was an assumption I counted
    with but was unfortunately untrue. So fix the drivers to fulfil this
    assumption.

    To be sure, the TTY buffers (and later some stuff) are gone along with
    the tty_port, we have to call tty_port_destroy at tear-down places.
    This is mostly where the structure containing a tty_port is freed.
    This patch does exactly that -- put tty_port_destroy at those places.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

14 Aug, 2012

1 commit

  • 734cc1783   TTY: use tty_port_register_device ... Browse Code »

    Currently we have no way to assign tty->port while performing tty
    installation. There are two ways to provide the link tty_struct =>
    tty_port. Either by calling tty_port_install from tty->ops->install or
    tty_port_register_device called instead of tty_register_device when
    the device is being set up after connected.

    In this patch we modify most of the drivers to do the latter. When the
    drivers use tty_register_device and we have tty_port already, we
    switch to tty_port_register_device. So we have the tty_struct =>
    tty_port link for free for those.

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

17 Jul, 2012

1 commit

  • adc8d746c   tty: move the termios object into the tty ... Browse Code »

    This will let us sort out a whole pile of tty related races. The
    alternative would be to keep points and refcount the termios objects.
    However
    1. They are tiny anyway
    2. Many devices don't use the stored copies
    3. We can remove a pty special case

    Signed-off-by: Alan Cox
    Signed-off-by: Greg Kroah-Hartman

    Alan Cox
     

09 Mar, 2012

2 commits

  • 410235fd4   TTY: remove unneeded tty->index checks ... Browse Code »

    Checking if tty->index is in bounds is not needed. The tty has the
    index set in the initial open. This is done in get_tty_driver. And it
    can be only in interval num).

    So remove the tests which check exactly this interval. Some are
    left untouched as they check against the current backing device count.
    (Leaving apart that the check is racy in most of the cases.)

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • 2f16669d3   TTY: remove re-assignments to tty_driver members ... Browse Code »

    All num, magic and owner are set by alloc_tty_driver. No need to
    re-set them on each allocation site.

    pti driver sets something different to what it passes to
    alloc_tty_driver. It is not a bug, since we don't use the lines
    parameter in any way. Anyway this is fixed, and now we do the right
    thing.

    Signed-off-by: Jiri Slaby
    Acked-by: Tilman Schmidt
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

13 Jan, 2012

1 commit

27 Jul, 2011

1 commit

  • 60063497a   atomic: use <linux/atomic.h> ... Browse Code »

    This allows us to move duplicated code in
    (atomic_inc_not_zero() for now) to

    Signed-off-by: Arun Sharma
    Reviewed-by: Eric Dumazet
    Cc: Ingo Molnar
    Cc: David Miller
    Cc: Eric Dumazet
    Acked-by: Mike Frysinger
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arun Sharma
     

20 Apr, 2011

1 commit

  • d65c57f4e   TTY: rocket, remove unused variables ... Browse Code »

    drivers/tty/rocket.c:1393:2: warning: Value stored to 'cp' is never read
    cp = &info->channel;
    ^ ~~~~~~~~~~~~~~
    drivers/tty/rocket.c:1412:2: warning: Value stored to 'cp' is never read
    cp = &info->channel;
    ^ ~~~~~~~~~~~~~~
    drivers/tty/rocket.c:1730:2: warning: Value stored to 'cp' is never read
    cp = &info->channel;
    ^ ~~~~~~~~~~~~~~
    drivers/tty/rocket.c:1825:3: warning: Value stored to 'str' is never read
    str = "8";
    ^ ~~~
    [many 'str' warnings stripped]
    drivers/tty/rocket.c:2037:3: warning: Value stored to 'board_type' is never read
    board_type = "RocketModem";
    ^ ~~~~~~~~~~~~~
    [some 'board_type' warnings stripped]

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

31 Mar, 2011

1 commit

23 Feb, 2011

1 commit