11 Jan, 2015

2 commits


08 Jan, 2015

1 commit

  • There is no need to repeat the work that is already done in the PCI
    driver core. The patch removes excerpts from suspend and resume
    callbacks.

    Note that there is no more calls performed to enable or disable a PCI
    device during suspend-resume cycle. Nowadays they seems to be
    superflous. Someone can read more in [1].

    [1] https://www.kernel.org/doc/ols/2009/ols2009-pages-319-330.pdf

    Signed-off-by: Andy Shevchenko
    Signed-off-by: Takashi Iwai

    Andy Shevchenko
     

07 Jan, 2015

2 commits


02 Jan, 2015

1 commit

  • snd_fm801_pcm() takes a pointer to a pointer of a PCM where if this
    parameter is provided the newly allocated PCM is stored. All callers pass
    NULL though, so remove the parameter. This makes the code a bit cleaner and
    shorter.

    Signed-off-by: Lars-Peter Clausen
    Signed-off-by: Takashi Iwai

    Lars-Peter Clausen
     

21 Oct, 2014

1 commit


13 Aug, 2014

1 commit

  • We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

19 May, 2014

1 commit


29 Apr, 2014

2 commits


26 Feb, 2014

1 commit


12 Feb, 2014

1 commit


18 Aug, 2013

1 commit


29 May, 2013

1 commit

  • As drvdata is cleared to NULL at probe failure or at removal by the
    driver core, we don't have to call pci_set_drvdata(pci, NULL) any
    longer in each driver.

    The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
    hda_intel.c. Since this function itself releases the card instance,
    we need to clear drvdata here as well, so that it won't be released
    doubly in the remove callback.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

07 Dec, 2012

1 commit

  • CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Signed-off-by: Takashi Iwai

    Bill Pemberton
     

14 Nov, 2012

1 commit


07 Sep, 2012

1 commit


15 Aug, 2012

1 commit


03 Jul, 2012

1 commit


26 Jun, 2012

1 commit

  • Pull media fixes from Mauro Carvalho Chehab.

    Trivial conflict due to new USB HID ID's being added next to each other
    (Baanto vs Axentia).

    * 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (44 commits)
    [media] smia: Fix compile failures
    [media] Fix VIDIOC_DQEVENT docbook entry
    [media] s5p-fimc: Fix control creation function
    [media] s5p-mfc: Fix checkpatch error in s5p_mfc_shm.h file
    [media] s5p-mfc: Fix setting controls
    [media] v4l/s5p-mfc: added image size align in VIDIOC_TRY_FMT
    [media] v4l/s5p-mfc: corrected encoder v4l control definitions
    [media] v4l: mem2mem_testdev: Fix race conditions in driver
    [media] s5p-mfc: Bug fix of timestamp/timecode copy mechanism
    [media] cxd2820r: Fix an incorrect modulation type bitmask
    [media] em28xx: Show a warning if the board does not support remote controls
    [media] em28xx: Add remote control support for Terratec's Cinergy HTC Stick HD
    [media] USB: Staging: media: lirc: initialize spinlocks before usage
    [media] Revert "[media] media: mx2_camera: Fix mbus format handling"
    [media] bw-qcam: driver and pixfmt documentation fixes
    [media] cx88: fix firmware load on big-endian systems
    [media] cx18: support big-endian systems
    [media] ivtv: fix support for big-endian systems
    [media] tuner-core: return the frequency range of the correct tuner
    [media] v4l2-dev.c: fix g_parm regression in determine_valid_ioctls()
    ...

    Linus Torvalds
     

12 Jun, 2012

1 commit

  • Before this patch the owner field of the /dev/radio# device fops was set to
    the snd-tea575x-tuner module itself. Meaning that the module which was using
    it could be rmmod-ed while the device is open, and then BAD things happen.

    I know, as I found out the hard way :)

    Note that there is no need to also somehow increase the refcount of the
    snd-tea575x-tuner module itself, since any drivers using it will have
    symbolic references to it.

    Signed-off-by: Hans de Goede
    CC: Ondrej Zary
    Signed-off-by: Mauro Carvalho Chehab

    Hans de Goede
     

24 Apr, 2012

1 commit


19 Mar, 2012

1 commit

  • The tea575x-tuner module has been updated to use the latest V4L2 framework
    functionality. This also required changes in the drivers that rely on it.

    The tea575x changes are:

    - The drivers must provide a v4l2_device struct to the tea module.
    - The radio_nr module parameter must be part of the actual radio driver,
    and not of the tea module.
    - Changed the frequency range to the normal 76-108 MHz range instead of
    50-150.
    - Add hardware frequency seek support.
    - Fix broken rxsubchans/audmode handling.
    - The application can now select between stereo and mono.
    - Support polling for control events.
    - Add V4L2 priority handling.

    And radio-sf16fmr2.c now uses the isa bus kernel framework.

    Signed-off-by: Hans Verkuil
    Thanks-to: Ondrej Zary
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     

19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

1 commit


23 Sep, 2011

1 commit


22 Sep, 2011

3 commits

  • Takashi Iwai
     
  • Commit 9676001559fce06e37c7dc230ab275f605556176
    ("ALSA: fm801: add error handling if auto-detect fails") seems to
    break systems that were previously working without a tuner.

    As a bonus, this should fix init and cleanup for the case where the
    tuner is explicitly disabled.

    Reported-and-tested-by: Hor Jiun Shyong
    References: http://bugs.debian.org/641946
    Signed-off-by: Ben Hutchings
    Cc: stable@kernel.org [v3.0+]
    Signed-off-by: Takashi Iwai

    Ben Hutchings
     
  • Commit 9676001559fce06e37c7dc230ab275f605556176
    ("ALSA: fm801: add error handling if auto-detect fails") added
    incorrect error handling.

    Once we have successfully called snd_device_new(), the cleanup
    function fm801_free() will automatically be called by snd_card_free()
    and we must *not* also call fm801_free() directly.

    Reported-by: Hor Jiun Shyong
    References: http://bugs.debian.org/641946
    Signed-off-by: Ben Hutchings
    Cc: stable@kernel.org [v3.0+]
    Signed-off-by: Takashi Iwai

    Ben Hutchings
     

14 Sep, 2011

1 commit

  • The semantics of snd_mpu401_uart_new()'s interrupt parameters are
    somewhat counterintuitive: To prevent the function from allocating its
    own interrupt, either the irq number must be invalid, or the irq_flags
    parameter must be zero. At the same time, the irq parameter being
    invalid specifies that the mpu401 code has to work without an interrupt
    allocated by the caller. This implies that, if there is an interrupt
    and it is allocated by the caller, the irq parameter must be set to
    a valid-looking number which then isn't actually used.

    With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
    which forces us to handle the parameters differently.

    This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
    device interrupt is handled by the caller, and makes the allocation of
    the interrupt to depend only on the irq parameter. As suggested by
    Takashi, the irq_flags parameter was dropped because, when used, it had
    the constant value IRQF_DISABLED.

    Signed-off-by: Clemens Ladisch
    Signed-off-by: Takashi Iwai

    Clemens Ladisch
     

10 Jun, 2011

2 commits

  • The name argument of request_irq() appears in /proc/interrupts, and
    it's quite ugly when the name entry contains a space or special letters.
    In general, it's simpler and more readable when the module name appears
    there, so let's replace all entries with KBUILD_MODNAME.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • The convention for pci_driver.name entry in kernel drivers seem to be
    the module name or equivalent ones. But, so far, almost all PCI sound
    drivers use more verbose name like "ABC Xyz (12)", and these are fairly
    confusing when appearing as a file name.

    This patch converts the all pci_driver.name entries in sound/pci/* to
    use KBUILD_MODNAME for more unified appearance.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

03 Jun, 2011

1 commit


15 May, 2011

1 commit


14 May, 2011

3 commits


11 May, 2011

1 commit


10 May, 2011

1 commit

  • Use common functions to access TEA575x tuner - remove original read/write
    functions and provide new pin manipulation functions instead.

    Also convert the original triple implementation to a simple GPIO pin map.

    Tested with SF256-PCP and SF64-PCR (added the GPIO pin for MO/ST signal
    for them).
    SF256-PCS untested (pin for MO/ST signal is a guess).

    Signed-off-by: Ondrej Zary
    Signed-off-by: Takashi Iwai

    Ondrej Zary