02 Jan, 2015

1 commit

  • Most callers of snd_wss_pcm(), snd_wss_timer() and snd_cs4236_pcm() pass
    NULL as the last parameter, some callers pass a pointer but never use it
    after the function has been called and only a few callers pass a pointer and
    actually use it. The later is only the case for snd_wss_pcm() for
    snd_cs4236_pcm() and it is possible to get the same PCM object by accessing
    the pcm field of the snd_wss struct that was passed as the first parameter.

    This function removes the last parameters from the functions mentioned above
    and updates the callers which used it to use chip->pcm instead. This allows
    us to slightly simplify the functions since they don't have to check and set
    the last parameter anymore which makes the code slightly shorter and
    cleaner.

    Signed-off-by: Lars-Peter Clausen
    Signed-off-by: Takashi Iwai

    Lars-Peter Clausen
     

03 Oct, 2012

1 commit


06 Nov, 2009

1 commit

  • The cs4236 was two step detection with call to the snd_wss_free()
    between two steps. The snd_wss_free() did not free a sound device
    created in the snd_wss_create(). This caused an OOPS during module
    removal as the same sound device was released twice. The same OOPS
    happened if the cs4236 module loading failed.

    Fix this by adapting the snd_cs4236_create() to correctly work with
    chips less capable then cs4236. The snd_cs4236_create() behaves the
    same as the snd_wss_create() if the chip is less capable than the cs4236.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

17 Feb, 2009

1 commit

  • cs4232 and cs4236 driver merge to solve PnP BIOS detection.

    Also, the patch adds recognition if the chip is cs4236b+
    or earlier part. This unifies drivers for both cs4232
    and cs4236+ chips. It allows to use the PnP BIOS
    detection for the cs4236+ chips. Previously, only
    the snd-cs4232 could be detected by the PnP BIOS.

    The cs4232+ cards reports two separate PnP BIOS ids.

    The patch adds search for the second id to find out
    resources assigned to a control port.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

06 Aug, 2008

6 commits