11 May, 2015

1 commit


05 Aug, 2010

1 commit

  • Add fb ops to handle enter/exit of the kernel debugger. If present, the
    fb core will register them with KGDB and they'll be called when the
    debugger is entered and exited. The new functions are responsible for
    switching to an appropriate debug framebuffer and restoring the
    interrupted state at exit time.

    Signed-off-by: Jesse Barnes
    Signed-off-by: Jason Wessel

    Jesse Barnes
     

03 Oct, 2008

1 commit

  • Commit 22af89aa0c0b4012a7431114a340efd3665a7617 ("fbcon: replace mono_col
    macro with static inline") changed the order of operations for computing
    monochrome color values. This generates 0xffff000f instead of 0x0000000f
    for a 4 bit monochrome color, leading to image corruption if it is passed
    to cfb_imageblit or other similar functions. Fix it up.

    Cc: Harvey Harrison
    Cc: "Antonino A. Daplas"
    Cc: Krzysztof Helt
    Cc: [2.6.26.x]
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Winn
     

12 Aug, 2008

1 commit

  • This reverts commit 2d04a4a72d7e1519b4838f24bdd4b5d0f3f426dc, which made
    it impossible to make the softcursor use the highlight colors.

    Yes, the fourth bit should be "blinking", but since we cannot reasonably
    blink in fbcon, highlighting it with a bright background is preferable.

    Reported-by: Pavel Machek
    Cc: Stefano Stabellini
    Cc: Krzysztof Helt
    Cc: Antonino A. Daplas
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

25 Jul, 2008

2 commits

  • [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Jan Beulich
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Beulich
     
  • The fourth bit of the background color is the blink property bit, not the
    intensity bit, as for the foreground color. Therefore it shouldn't be
    included in the background color.

    Signed-off-by: Stefano Stabellini
    Cc: Krzysztof Helt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stefano Stabellini
     

28 Apr, 2008

1 commit

  • Use __u32 for max_len to match the declaration of length in the struct
    fb_bitfield.

    Suppresses sparse shadowed variable warnings from the nested max()
    macros:
    drivers/video/console/fbcon.h:130:8: warning: symbol '_x' shadows an earlier one
    drivers/video/console/fbcon.h:130:8: originally declared here
    drivers/video/console/fbcon.h:130:8: warning: symbol '_x' shadows an earlier one
    drivers/video/console/fbcon.h:130:8: originally declared here
    drivers/video/console/fbcon.h:130:8: warning: symbol '_y' shadows an earlier one
    drivers/video/console/fbcon.h:130:8: originally declared here

    [akpm@linux-foundation.org: fix constness]
    Signed-off-by: Harvey Harrison
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     

07 Feb, 2008

1 commit

  • The current attr_fgcol_ec / attr_bgcol_ec macros do a simple shift of bits
    to get the color from vc_video_erase_char. For a monochrome display
    however the attribute does not contain any color, only attribute bits.
    Furthermore the reverse bit is lost because it is shifted out, the
    resulting color is always 0.

    This can bee seen on a monochrome console either directly or by setting it
    to inverse mode via "setterm -inversescreen on" . Text is written with
    correct color, fb_fillrects from a bit_clear / bit_clear_margins will get
    wrong colors.

    Signed-off-by: Thomas Pfaff
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Thomas Pfaff
     

01 Jun, 2007

1 commit

  • Move the forward declaration of fb_class from drivers/video/console/fbcon.h to
    , together with the other forward declarations related to
    drivers/video/fbmem.c.

    This kills the following sparse warning:
    | drivers/video/fbmem.c:1363:14: warning: symbol 'fb_class' was not declared. Should it be static?

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Geert Uytterhoeven
     

13 Feb, 2007

1 commit


03 Oct, 2006

1 commit

  • Every time the console cursor blinks, we do a kmalloc/kfree pair. This
    patch turns that into a single allocation.

    This allocation was the most frequent kmalloc I saw on my test box.

    [adaplas]
    Per Alan's suggestion, move global variables to fbcon's private structure.
    This would also avoid resource leaks when fbcon is unloaded.

    Signed-off-by: Dave Jones
    Acked-by: Alan Cox
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave Jones
     

01 Jul, 2006

1 commit


27 Jun, 2006

1 commit

  • In order for this feature to work, an interface will be needed. The most
    appropriate is sysfs. However, the framebuffer console has no sysfs entry
    yet. This will create a sysfs class device entry for fbcon under
    /sys/class/graphics.

    Add a class_device entry 'fbcon' under class 'graphics'. Console-specific
    attributes which where previously under class/graphics/fb[x] are moved to
    class/graphics/fbcon. These attributes, 'con_rotate' and 'con_rotate_all',
    are also renamed to 'rotate' and 'rotate_all' respectively.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

11 Jan, 2006

1 commit


14 Nov, 2005

1 commit

  • Exporting struct fb_display produces this warning error on depmod:

    WARNING: Module
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/fbcon_ud.ko
    ignored, due to loop
    WARNING: Module
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/fbcon_rotate.ko
    ignored, due to loop
    WARNING: Module
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/fbcon_cw.ko
    ignored, due to loop
    WARNING: Module
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/fbcon_ccw.ko
    ignored, due to loop
    WARNING: Module
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/fbcon.ko ignored,
    due to loop
    WARNING: Loop detected:
    /lib/modules/2.6.14-mm2/kernel/drivers/video/console/bitblit.ko needs

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

09 Nov, 2005

2 commits

  • Add support to rotate the font bitmap. To save on processing time, the entire
    fontdata will be rotated on a console switch, then stored in a buffer private
    to fbcon. To further save on processing, the fontdata will only be rotated if
    the font has changed or if the angle of rotation has changed. Only a single
    copy of the rotated fontdata will be kept.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • This patch series implements generic code to rotate the console at 90, 180,
    and 270 degrees. The implementation is completely done in the framebuffer
    console level, thus no changes to the framebuffer layer or to the drivers
    are needed.

    Console rotation is required by some Sharp-based devices where the natural
    orientation of the display is not at 0 degrees. Also, users that have
    displays that can pivot will benefit by having a console in portrait mode
    if they so desire.

    The choice to implement the code in the console layer rather than in the
    framebuffer layer is due to the following reasons:

    - it's fast
    - it does not require driver changes
    - it can coexist with devices that can rotate the display at the hardware level
    - it complements graphics applications that can do display rotation

    The changes to core fbcon are minimal-- recognition of the console
    rotation angle so it can swap directions, origins and axes (xres vs yres,
    xpanstep vs ypanstep, xoffset vs yoffset, etc) and storage of the rotation
    angle per display. The bulk of the code that does the actual drawing to the
    screen are placed in separate files. Each angle of rotation has separate
    methods (bmove, clear, putcs, cursor, update_start which is derived from
    update_var, and clear_margins). To mimimize processing time, the fontdata
    are pre-rotated at each console switch (only if the font or the angle has
    changed).

    The option can be compiled out (CONFIG_FRAMEBUFFER_CONSOLE_ROTATION = n) if
    rotation is not needed.

    Choosing the rotation angle can be done in several ways:

    1. boot option fbcon=rotate:n, where
    n = 0 - normal
    n = 1 - 90 degrees (clockwise)
    n = 2 - 180 degrees (upside down)
    n = 3 - 270 degrees (counterclockwise)

    2. echo n > /sys/class/graphics/fb[num]/con_rotate

    where n is the same as described above. It sets the angle of rotation
    of the current console

    3 echo n > /sys/class/graphics/fb[num]/con_rotate_all

    where n is the same as described above. Globally sets the angle of
    rotation.

    GOTCHAS:

    The option, especially at angles of 90 and 270 degrees, will exercise
    the least used code of drivers. Namely, at these angles, panning is done
    in the x-axis, so it can reveal bugs in the driver if xpanstep is set
    incorrectly. A workaround is to set xpanstep = 0.

    Secondly, at these angles, the framebuffer memory access can be
    unaligned if (fontheight * bpp) % 32 ~= 0 which can reveal bugs in the drivers
    imageblit, fillrect and copyarea functions. (I think cfbfillrect may have
    this buglet). A workaround is to use a standard 8x16 font.

    Speed:

    The scrolling speed difference between 0 and 180 degrees is minimal,
    somewhere areound 1-2%. At 90 or 270 degress, speed drops down to a vicinity
    of 30-40%. This is understandable because the blit direction is across the
    framebuffer "direction." Scrolling will be helped at these angles if xpanstep
    is not equal to zero, use of 8x16 fonts, and setting xres_virtual >= xres * 2.

    Note: The code is tested on little-endian only, so I don't know if it will
    work in big-endian. Please let me know, it will take only less than a minute
    of your time.

    This patch prepares fbcon for console rotation and contains the following
    changes:

    - add rotate field in struct fbcon_ops to keep fbcon's current rotation
    angle

    - add con_rotate field in struct display to store per-display rotation angle

    - create a private copy of the current var to fbcon. This will prevent
    fbcon from directly manipulating info->var, especially the fields xoffset,
    yoffset and vmode.

    - add ability to swap pertinent axes (xres, yres; xpanstep, ypanstep; etc)
    depending on the rotation angle

    - change global update_var() (function that sets the screen start address)
    as an fbcon method update_start. This is required because the axes, start
    offset, and/or direction can be reversed depending on the rotation angle.

    - add fbcon method rotate_font() which will rotate each character bitmap to
    the correct angle of rotation.

    - add fbcon boot option 'rotate' to select the angle of rotation at bootime.
    Currently does nothing until all patches are applied.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

07 Nov, 2005

1 commit

  • According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
    drivers that do not support hardware cursors is redundant. The soft_cursor
    function is usable by all drivers because it is just a wrapper around
    fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
    moved to the console directory.

    Thus, drivers that do not support hardware cursors can leave the fb_cursor
    field blank. For drivers that do, they can fill up this field with their own
    version.

    The end result is a smaller code size. And if the framebuffer console is not
    loaded, module/kernel size is also reduced because the soft_cursor module will
    also not be loaded.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

13 Sep, 2005

1 commit

  • const-ify the font control structures and data, to make somewhat better
    guarantees that these are not modified anywhere in the kernel.
    Specifically for a kernel debugger to share this information from the
    normal kernel code, such a guarantee seems rather desirable.

    Signed-off-by: Jan Beulich
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Beulich
     

10 Sep, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds