18 Nov, 2013
1 commit
-
I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.Either the device is enumerated and the driver already has a module
alias (e.g. PCI, USB etc.) that will get the right driver loaded
automatically.Or the device is not enumerated and loading its driver will lead to
more or less intrusive hardware poking. Such hardware poking should be
limited to a bare minimum, so the user should really decide which
drivers should be tried and in what order. Trying them all in
arbitrary order can't do any good.On top of that, loading that many drivers at once bloats the kernel
log. Also many drivers will stay loaded afterward, bloating the output
of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
loaded as a dependency) can't even be unloaded!If defining char-major-10-130 is needed then it should happen in
user-space.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
Cc: Stephen Warren
Cc: Mike Frysinger
Cc: Wan ZongShun
Cc: Ben Dooks
Cc: Kukjin Kim
Cc: Zwane Mwaikambo
Cc: Jim Cromie
28 Mar, 2012
2 commits
-
nowayout is actually a boolean value.
So make it bool for all watchdog device drivers.Signed-off-by: Wim Van Sebroeck
-
Use the current logging styles.
Make sure all output has a prefix.
Add missing newlines.
Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
Coalesce formats.Signed-off-by: Joe Perches
Signed-off-by: Wim Van Sebroeck
27 Jul, 2011
1 commit
-
remove unneeded pci.h include.
and include ioport.h to avoid build errors for the region functions.Reported-by: Randy Dunlap
Signed-off-by: Wim Van Sebroeck
22 Jul, 2011
1 commit
-
Changes the it87 watchdog drivers to use "request_muxed_region".
Serialize access to the hardware by using "request_muxed_region" macro defined
by Alan Cox. Call to this macro will hold off the requestor if the resource is
currently busy.The use of the above macro makes it possible to get rid of
spinlocks in it8712f_wdt.c and it87_wdt.c watchdog drivers.
This also greatly simplifies the implementation of it87_wdt.c driver."superio_enter" will return an error if call to "request_muxed_region" fails.
Rest of the code change is to ripple an error return from superio_enter to
the top level.Signed-off-by: Nat Gurumoorthy
Signed-off-by: Wim Van Sebroeck
16 Mar, 2011
1 commit
-
cleanup spaces before tabs in drivers/watchdog/
Signed-off-by: Wim Van Sebroeck
29 Oct, 2010
2 commits
-
On iEi PCISA-9652-R10 (BIOS version 1.5) single board computer reads
from the game port do not seem to reset the watchdog timer. This patch
adds a module parameter wdt_config_reg to specify alternative reset
sources. At least WDT_RESET_KBD has been tested, even just runningwhile true; do
setleds -L +scroll
sleep 1
setleds -L -scroll
sleep 1
doneis enough to keep the watchdog happy.
Signed-off-by: Timo Juhani Lindfors
Signed-off-by: Wim Van Sebroeck -
Signed-off-by: Timo Juhani Lindfors
Signed-off-by: Wim Van Sebroeck
07 Mar, 2010
1 commit
-
make the watchdog_info struct const where possible.
Signed-off-by: Wim Van Sebroeck
18 Jun, 2009
1 commit
-
Make sure that when the WDIOF_MAGICCLOSE flag is set we also
support the magic-close feature...Signed-off-by: Wim Van Sebroeck
07 Aug, 2008
1 commit
-
More coding style clean-up's.
Signed-off-by: Wim Van Sebroeck
06 Aug, 2008
1 commit
-
This brings the watchdog drivers into line with coding style.
This patch takes cares of the indentation as described in chapter 1.
Main changes:
* Re-structure the ioctl switch call for all drivers as follows:
switch (cmd) {
case WDIOC_GETSUPPORT:
case WDIOC_GETSTATUS:
case WDIOC_GETBOOTSTATUS:
case WDIOC_GETTEMP:
case WDIOC_SETOPTIONS:
case WDIOC_KEEPALIVE:
case WDIOC_SETTIMEOUT:
case WDIOC_GETTIMEOUT:
case WDIOC_GETTIMELEFT:
default:
}This to make the migration from the drivers to the uniform watchdog
device driver easier in the future.Signed-off-by: Wim Van Sebroeck
05 Aug, 2008
1 commit
-
Signed-off-by: Andrew Morton
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
07 Apr, 2008
1 commit
-
I noticed this while testing the latest code. I'm not sure if it is required,
but the normal (or LSB) timeout value is set to zero, so the MSB should
be as well to stay consistent.If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero
when disabling the watchdog in it8712f_wdt_disable().Signed-off-by: Andrew Paprocki
Signed-off-by: Wim Van Sebroeck
Signed-off-by: Andrew Morton
02 Apr, 2008
1 commit
-
This patch corrects an error in the driver it8712f_wdt. You cannot set
the 16-bit WDT_TIMEOUT access as a 16-bit outw, because the byte
ordering will be wrong. So just do the high 8 bits as a separate
access.Signed-off-by: Oliver Schuster
Signed-off-by: Linus Torvalds
06 Mar, 2008
1 commit
-
This patch adds support for 16-bit watchdog timeout values which are
available in chip revisions >= 0x08. Values
Signed-off-by: Wim Van Sebroeck
26 Jan, 2008
1 commit
-
"static struct file_operations" should be
"static const struct file_operations".Signed-off-by: Jan Engelhardt
Signed-off-by: Wim Van Sebroeck
20 Nov, 2007
1 commit
-
This patch adds support for the ITE Tech Inc. IT8712F EC-LPC Super I/O
chipset found on many Pentium III and AMD motherboards. Developed using code
from other watchdog drivers and the datasheet on ITE Tech homepage.Signed-off-by: Jorge Boncompte
Signed-off-by: Wim Van Sebroeck
