23 Dec, 2010
1 commit
-
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller
21 Dec, 2010
1 commit
-
Using static const generally increases object text and decreases data size.
It also generally decreases overall object size.Signed-off-by: Joe Perches
14 Dec, 2010
20 commits
-
Since this driver is implemented as NAPI,
netif_receive_skb must be used not netif_rx.Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
Add setting TEC/REC statistics processing.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
For reduce "if" condition, easy to read/understand the code,
optimize "if" condition in rx/tx processing.Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
Fix incorrect return processing.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Currently, in case this driver is integrated as module, and when this
module is re-installed, no interrupts is to be occurred.
For the above issue, move MSI processing to open/release processing.Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Comment optimization
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Modify miss-setting status issue at suspend.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Modify like use calculated value directly passed by CAN core module.
Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
Delete unnecessary/redundant code
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Fix coding rule violation.
Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
For easy to readable, use netdev_dbg instead of dev_dbg partly
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Currently, Copyright and module description are not formal.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
For improve tx/rx speed, reduce register access.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Currently, these two functions spec(returned value) is unnatural.
Thus, change the return value's specSigned-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
For easy to read/understand, Rename function/macro name.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Currently, in case CONFIG_PM is disabled, compiler outputs warnings.
Move six functions which are used only CONFIG_PM is enabled,
into "#ifdef CONFIG_PM" area.Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Replace complex "goto" to "do~while".
For easy to read/understand, it divides a rx function into some functions.Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
there is endianness issue both Tx and Rx.
Currently, data is set like below.
Register:
MSB--LSB
x x D0 D1
x x D2 D3
x x D4 D5
x x D6 D7But Data to be sent must be set like below.
Register:
MSB--LSB
x x D1 D0
x x D3 D2
x x D5 D4
x x D7 D6 (x means reserved area.)Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
To easy to read/understand, divide poll function into two sub-functions.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
Currently, there is no flow control processing.
Thus, Add flow control processing as
when there is no empty of tx buffer,
netif_stop_queue is called.
When there is empty buffer, netif_wake_queue is called.Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller
12 Dec, 2010
1 commit
-
janz-ican3, sh_eth, skge and vxge don't use workqueue at all and there
is no reason to flush the system_wq. Drop flush_scheduled_work()
calls and references to workqueue.Signed-off-by: Tejun Heo
Cc: "David S. Miller"
Cc: Wolfgang Grandegger
Cc: Stephen Hemminger
Cc: Ramkrishna Vepa
Cc: Sivakumar Subramani
Cc: Sreenivasa Honnur
Cc: Jon Mason
Cc: netdev@vger.kernel.org
09 Dec, 2010
2 commits
-
drivers/net/can/slcan.c: In function 'slcan_open':
drivers/net/can/slcan.c:568: error: dereferencing pointer to incomplete typeReported-by: Stephen Rothwell
Signed-off-by: David S. Miller -
This patch adds support for serial/USB-serial CAN adapters implementing the
LAWICEL ASCII protocol for CAN frame transport over serial lines.The driver implements the SLCAN line discipline and is heavily based on the
slip.c driver. Therefore the code style remains similar to slip.c to be able
to apply changes of the SLIP driver to the SLCAN driver easily.For more details see the slcan Kconfig entry.
Signed-off-by: Oliver Hartkopp
Signed-off-by: David S. Miller
03 Dec, 2010
4 commits
-
Delete unnecessary spin_lock for accessing Message Object.
Since all message objects are divided into tx/rx area completely,
spin_lock processing is unnecessary.Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
For easy to readable, LEC #define macros are replaced to enums.
Signed-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
For easy to readable, add Message Object index like below.
PCH_RX_OBJ_START
PCH_RX_OBJ_END
PCH_TX_OBJ_START
PCH_TX_OBJ_ENDSigned-off-by: Tomoya MORINAGA
Signed-off-by: David S. Miller -
CAN register of Intel PCH EG20T has 2 sets of interface register.
To reduce whole of code size, separate interface register.
As a result, the number of function also can be reduced.Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller
19 Nov, 2010
2 commits
-
Replace bit assignment value to BIT(X).
For easy to readable/identifiable, replace all bit assigned macros to BIT(X)Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
For easy to readable/identifiable, add prefix "PCH_" to all of #define macros.
Signed-off-by: Tomoya MORINAGA
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller
18 Nov, 2010
1 commit
-
Using %pR standardizes the struct resource output.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
10 Nov, 2010
1 commit
-
Add missing newlines.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
31 Oct, 2010
3 commits
-
My old mail address doesn't exist anymore. This changes all occurrences
to my new address.Signed-off-by: Hans J. Koch
Signed-off-by: David S. Miller -
This patch fixes the following section mismatch warning:
WARNING: drivers/net/can/pch_can.o(.data+0x18):
Section mismatch in reference from the variable pch_can_pcidev
to the variable .devinit.rodata:pch_pci_tbl
The variable pch_can_pcidev references
the variable __devinitconst pch_pci_tblThis is actually a false positive which is fixed by giving the offending
variable a whitelisted name, it's renamed to "pch_can_pci_driver".
This makes sense because the variable is of the type "struct pci_driver".Signed-off-by: Marc Kleine-Budde
Acked-by: Uwe Kleine-König
Signed-off-by: David S. Miller -
This patch fixes the following sparse warning:
drivers/net/can/pch_can.c:231:26: warning: incorrect type in argument 1 (different address spaces)
drivers/net/can/pch_can.c:231:26: expected unsigned int [usertype] *addr
drivers/net/can/pch_can.c:231:26: got unsigned int [noderef] *Let pch_can_bit_{set,clear} first parameter be a void __iomem pointer.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: David S. Miller
27 Oct, 2010
2 commits
-
This patch sets the missing CAN_RTR_FLAG if a standard RTR frame is
received.
(For extended frames the CAN_RTR_FLAG was already set correctly.)Signed-off-by: Marc Kleine-Budde
Signed-off-by: David S. Miller -
The priv is part of the memory allocated by alloc_candev().
This patch moved the free it after last usage of priv.Signed-off-by: Marc Kleine-Budde
Signed-off-by: David S. Miller
26 Oct, 2010
1 commit
-
Fix pch_can build when CONFIG_PCI is not enabled. It uses pci interfaces
and data structures, so it should depend on PCI.drivers/net/can/pch_can.c:1044: error: implicit declaration of function 'pci_enable_msi'
drivers/net/can/pch_can.c:1079: error: implicit declaration of function 'pci_disable_msi'Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller
25 Oct, 2010
1 commit
-
Add driver for Technologic Systems TS-CAN1 PC104 peripheral boards.
Signed-off-by: Andre B. Oliveira
Acked-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
Signed-off-by: David S. Miller
