15 Nov, 2006

1 commit

  • Resolve the panic on failed mount of an autofs filesystem originally
    reported by Mao Bibo.

    It addresses two issues that happen after the mount fail. The first a NULL
    pointer reference to a field (pipe) in the autofs superblock info structure
    and second the lack of super block cleanup by the autofs and autofs4
    modules.

    Signed-off-by: Ian Kent
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ian Kent
     

14 Nov, 2006

2 commits

  • * git://oss.sgi.com:8090/xfs/xfs-2.6:
    [XFS] Remove KERNEL_VERSION macros from xfs_dmapi.h
    [XFS] Prevent a deadlock when xfslogd unpins inodes.
    [XFS] Clean up i_flags and i_flags_lock handling.
    [XFS] 956664: dm_read_invis() changes i_atime
    [XFS] rename uio_read() to xfs_uio_read()
    [XFS] Keep lockdep happy.
    [XFS] 956618: Linux crashes on boot with XFS-DMAPI filesystem when

    Linus Torvalds
     
  • * master.kernel.org:/pub/scm/linux/kernel/git/sfrench/cifs-2.6:
    [CIFS] Fix minor problem with previous patch
    [CIFS] Fix mount failure when domain not specified
    [CIFS] Explicitly set stat->blksize
    [CIFS] NFS stress test generates flood of "close with pending write" messages

    Linus Torvalds
     

11 Nov, 2006

7 commits


10 Nov, 2006

1 commit


09 Nov, 2006

4 commits

  • Commit 6264d69d7df654ca64f625e9409189a0e50734e9 modified the nfsd_create()
    error handling in such a way that nfsd_create will usually return
    nfserr_perm even when succesful, if the export has the async export option.

    This introduced a regression that could cause mkdir() to always return a
    permissions error, even though the directory in question was actually
    succesfully created.

    Signed-off-by: J. Bruce Fields
    Acked-by: NeilBrown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     
  • In the case where an open creates the file, we shouldn't be rechecking
    permissions to open the file; the open succeeds regardless of what the new
    file's mode bits say.

    This patch fixes the problem, but only by introducing yet another parameter
    to nfsd_create_v3. This is ugly. This will be fixed by later patches.

    Signed-off-by: J. Bruce Fields
    Acked-by: Neil Brown
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     
  • Minor rearrangement, cleanup of do_open_lookup(). No change in behavior.

    Signed-off-by: J. Bruce Fields
    Acked-by: Neil Brown
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     
  • Fixes Samba bugzilla #4176

    When users do not specify their domain on mount, 2.6.18 started sending
    default domain instead of a null domain (which was the only way on some
    servers to use a default domain). Users of 2.6.18 who did not specify
    their domain name on mounts to certain common Windows servers that were
    members of a domain, but not the domain controller, would get mount
    failures which they did not get in 2.6.18

    This fixes that issue and should remove complaints about mount
    behavior changing.

    Signed-off-by: Steve French

    Steve French
     

08 Nov, 2006

2 commits


07 Nov, 2006

1 commit


06 Nov, 2006

6 commits

  • Now that the lockspace struct is freed when the last sysfs object is released
    this patch prevents use of that lockspace by sysfs. We attempt to re-get the
    lockspace from the lockspace list and fail the request if it has been removed.

    Signed-Off-By: Patrick Caulfield
    Signed-off-by: Steven Whitehouse

    Patrick Caulfield
     
  • This patch fixes the recounting on the lockspace kobject. Previously the lockspace was freed while userspace could have had a
    reference to one of its sysfs files, causing an oops in kref_put.

    Now the lockspace kfree is moved into the kobject release() function

    Signed-Off-By: Patrick Caulfield
    Signed-off-by: Steven Whitehouse

    Patrick Caulfield
     
  • Fix the OOM error handling in inode.c where it was possible for
    a NULL pointer to be dereferenced.

    Signed-off-by: Steven Whitehouse

    Steven Whitehouse
     
  • This adds a sync_fs superblock operation for GFS2 and removes
    the journal flush from write_super in favour of sync_fs where it
    ought to be. This is more or less identical to the way in which ext3
    does this.

    This bug was pointed out by Russell Cattelan

    Cc: Russell Cattelan
    Signed-off-by: Steven Whitehouse

    Steven Whitehouse
     
  • First, SLAB_PANIC is unjustified. Second, all error propagating and backing out
    is in place.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Steven Whitehouse

    Alexey Dobriyan
     
  • This patch takes the CTL_UNNUMBERD concept from NFS and makes it available to
    all new sysctl users.

    At the same time the sysctl binary interface maintenance documentation is
    updated to mention and to describe what is needed to successfully maintain the
    sysctl binary interface.

    Signed-off-by: Eric W. Biederman
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric W. Biederman
     

05 Nov, 2006

2 commits


04 Nov, 2006

8 commits

  • The user.* extended attributes are only allowed on regular files and
    directories. Sticky directories further restrict write access to the owner
    and privileged users. (See the attr(5) man page for an explanation.)

    The original check in ext2/ext3 when user.* xattrs were merged was more
    restrictive than intended, and when the xattr permission checks were moved
    into the VFS, read access to user.* attributes on sticky directores ended
    up being denied in addition.

    Originally-from: Gerard Neil
    Signed-off-by: Andreas Gruenbacher
    Cc: Dave Kleikamp
    Cc: Jan Engelhardt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andreas Gruenbacher
     
  • Callers after reiserfs_init_bitmap_cache() expect errval to contain -EINVAL
    until much later. If a condition fails before errval is reset later,
    reiserfs_fill_super() will mistakenly return 0, causing an Oops in
    do_add_mount(). This patch resets errval to -EINVAL after the call.

    I view this as a temporary fix and real error codes should be used
    throughout reiserfs_fill_super().

    Signed-off-by: Jeff Mahoney
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Mahoney
     
  • When I was performing some operations on NFS, I got below error on server
    side.

    =============================================
    [ INFO: possible recursive locking detected ]
    2.6.19-prep #1
    ---------------------------------------------
    nfsd4/3525 is trying to acquire lock:
    (&inode->i_mutex){--..}, at: [] mutex_lock+0x21/0x24

    but task is already holding lock:
    (&inode->i_mutex){--..}, at: [] mutex_lock+0x21/0x24

    other info that might help us debug this:
    2 locks held by nfsd4/3525:
    #0: (client_mutex){--..}, at: [] mutex_lock+0x21/0x24
    #1: (&inode->i_mutex){--..}, at: [] mutex_lock+0x21/0x24

    stack backtrace:
    [] show_trace_log_lvl+0x58/0x16a
    [] show_trace+0xd/0x10
    [] dump_stack+0x19/0x1b
    [] __lock_acquire+0x778/0x99c
    [] lock_acquire+0x4b/0x6d
    [] __mutex_lock_slowpath+0xbc/0x20a
    [] mutex_lock+0x21/0x24
    [] vfs_rmdir+0x76/0xf8
    [] nfsd4_clear_clid_dir+0x2c/0x41 [nfsd]
    [] nfsd4_remove_clid_dir+0xb1/0xe8 [nfsd]
    [] laundromat_main+0x9b/0x1c3 [nfsd]
    [] run_workqueue+0x7a/0xbb
    [] worker_thread+0xd2/0x107
    [] kthread+0xc3/0xf2
    [] kernel_thread_helper+0x5/0xb
    ===================================================================

    Cause for this problem was,2 successive mutex_lock calls on 2 diffrent inodes ,as shown below

    static int
    nfsd4_clear_clid_dir(struct dentry *dir, struct dentry *dentry)
    {
    int status;

    /* For now this directory should already be empty, but we empty it of
    * any regular files anyway, just in case the directory was created by
    * a kernel from the future.... */
    nfsd4_list_rec_dir(dentry, nfsd4_remove_clid_file);
    mutex_lock(&dir->d_inode->i_mutex);
    status = vfs_rmdir(dir->d_inode, dentry);
    ...

    int vfs_rmdir(struct inode *dir, struct dentry *dentry)
    {
    int error = may_delete(dir, dentry, 1);

    if (error)
    return error;

    if (!dir->i_op || !dir->i_op->rmdir)
    return -EPERM;

    DQUOT_INIT(dir);

    mutex_lock(&dentry->d_inode->i_mutex);
    ...

    So I have developed the patch to overcome this problem.

    Signed-off-by: Srinivasa DS
    Cc: Neil Brown
    Cc: Peter Zijlstra
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Srinivasa Ds
     
  • This just ignore the remaining pages, and remove unneeded unlock_pages().

    Signed-off-by: OGAWA Hirofumi
    Cc: Steven French
    Cc: Miklos Szeredi
    Acked-by: Steven Whitehouse
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    OGAWA Hirofumi
     
  • This just ignore the remaining pages.

    Signed-off-by: OGAWA Hirofumi
    Cc: Steven French
    Cc: Miklos Szeredi
    Cc: Steven Whitehouse
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    OGAWA Hirofumi
     
  • This just ignore the remaining pages, and will fix a forgot put_pages_list().

    Signed-off-by: OGAWA Hirofumi
    Cc: Steven French
    Cc: Miklos Szeredi
    Cc: Steven Whitehouse
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    OGAWA Hirofumi
     
  • 758333458aa719bfc26ec16eafd4ad3a9e96014d fixes the not checked copy_to_user
    return value of compat_sys_pselect7. I ran into this too because of an old
    source tree, but my fix would look quite a bit different to Andi's fix.

    The reason is that the compat function IMHO should behave the very same as
    the non-compat function if possible. Since sys_pselect7 does not return
    -EFAULT in this specific case, change the compat code so it behaves like
    sys_pselect7.

    Cc: David Woodhouse
    Cc: Andi Kleen
    Signed-off-by: Heiko Carstens
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Heiko Carstens
     
  • I missed a pointer dereference in this kmalloc result check.

    Signed-off-by: Michael Halcrow
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Halcrow
     

03 Nov, 2006

3 commits


02 Nov, 2006

1 commit


01 Nov, 2006

2 commits