18 Jul, 2019
1 commit
-
Pull RTC updates from Alexandre Belloni:
"A quiet cycle this time.- ds1307: properly handle oscillator failure flags
- imx-sc: alarm support
- pcf2123: alarm support, correct offset handling
- sun6i: add R40 support
- simplify getting the adapter of an i2c client"
* tag 'rtc-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (37 commits)
rtc: wm831x: Add IRQF_ONESHOT flag
rtc: stm32: remove one condition check in stm32_rtc_set_alarm()
rtc: pcf2123: Fix build error
rtc: interface: Change type of 'count' from int to u64
rtc: pcf8563: Clear event flags and disable interrupts before requesting irq
rtc: pcf8563: Fix interrupt trigger method
rtc: pcf2123: fix negative offset rounding
rtc: pcf2123: add alarm support
rtc: pcf2123: use %ptR
rtc: pcf2123: port to regmap
rtc: pcf2123: remove sysfs register view
rtc: rx8025: simplify getting the adapter of a client
rtc: rx8010: simplify getting the adapter of a client
rtc: rv8803: simplify getting the adapter of a client
rtc: m41t80: simplify getting the adapter of a client
rtc: fm3130: simplify getting the adapter of a client
rtc: tegra: Drop MODULE_ALIAS
rtc: sun6i: Add R40 compatible
dt-bindings: rtc: sun6i: Add the R40 RTC compatible
dt-bindings: rtc: Convert Allwinner A31 RTC to a schema
...
19 Jun, 2019
1 commit
-
Based on 2 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundationthis program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 4122 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Enrico Weigelt
Reviewed-by: Kate Stewart
Reviewed-by: Allison Randal
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman
09 Jun, 2019
1 commit
-
We have a dedicated pointer for that, so use it. Much easier to read and
less computation involved.Signed-off-by: Wolfram Sang
Signed-off-by: Alexandre Belloni
12 Apr, 2019
1 commit
-
The commit 1921cab11723 ("rtc: rx8025: Switch to use %ptR") converted
the driver to use new %p extension, but actually used wrong type of
the parameter in one case.Fix a parameter to %ptR in rx8025_read_alarm().
Reported-by: Dan Carpenter
Signed-off-by: Andy Shevchenko
Signed-off-by: Alexandre Belloni
11 Dec, 2018
1 commit
-
Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.Signed-off-by: Andy Shevchenko
Signed-off-by: Alexandre Belloni
02 Mar, 2018
1 commit
-
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni
02 Sep, 2016
1 commit
-
Check for rtc_class_ops structures that are only passed to
devm_rtc_device_register, rtc_device_register,
platform_device_register_data, all of which declare the corresponding
parameter as const. Declare rtc_class_ops structures that have these
properties as const.The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)//
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct rtc_class_ops i@p = { ... };@ok@
identifier r.i;
expression e1,e2,e3,e4;
position p;
@@
(
devm_rtc_device_register(e1,e2,&i@p,e3)
|
rtc_device_register(e1,e2,&i@p,e3)
|
platform_device_register_data(e1,e2,e3,&i@p,e4)
)@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct rtc_class_ops i = { ... };
//Signed-off-by: Julia Lawall
Acked-by: Baruch Siach
Acked-by: Hans Ulli Kroll
Acked-by: Linus Walleij
Acked-by: Thierry Reding
Signed-off-by: Alexandre Belloni
09 Jul, 2016
1 commit
-
Since commit d68778b80dd7 ("rtc: initialize output parameter for read
alarm to "uninitialized"") there is no need to explicitly set
unsupported members to -1. So drop the respective assignments from
drivers.Signed-off-by: Uwe Kleine-König
Signed-off-by: Alexandre Belloni
18 Mar, 2016
1 commit
-
Pull trivial tree updates from Jiri Kosina.
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial:
drivers/rtc: broken link fix
drm/i915 Fix typos in i915_gem_fence.c
Docs: fix missing word in REPORTING-BUGS
lib+mm: fix few spelling mistakes
MAINTAINERS: add git URL for APM driver
treewide: Fix typo in printk
15 Mar, 2016
4 commits
-
The alarm for rx8025 only has a minute accuracy, so unsupport UIE mode.
pcf8563 and hym8563 also have a minute accuracy and unsupport it.
Signed-off-by: Akinobu Mita
Cc: Wolfgang Grandegger
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Signed-off-by: Alexandre Belloni -
The alarm for rx8025 only has a minute accuracy, so round up to nearest
minute when setting alarm. Without doing this, rtctest blocks one day
after setting alarm to 5 seconds later.pcf8563 and hym8563 also have similar handling.
Signed-off-by: Akinobu Mita
Cc: Wolfgang Grandegger
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Signed-off-by: Alexandre Belloni -
The ctrl1 register is accessed by alarm operations. But it is updated
in threaded interrupt handler without acquiring rtc->ops_lock.Signed-off-by: Akinobu Mita
Cc: Wolfgang Grandegger
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Signed-off-by: Alexandre Belloni -
When IRQ line for this chips is connected, devm_request_threaded_irq()
refuses to register irq handler with the following message.genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq
Signed-off-by: Akinobu Mita
Cc: Wolfgang Grandegger
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Signed-off-by: Alexandre Belloni
15 Feb, 2016
1 commit
-
In drivers/rtc/rtc-rx8025.c is a broken link that is supposed to
lead to a form allowing users to subscribe to the lm-sensors mailing list.The link leads
to a page with a 404 error. I believe the link should be replaced
with .Signed-off-by: Leslie Lau
Signed-off-by: Jiri Kosina
05 Feb, 2016
1 commit
-
The rv8803 has its own driver that should be used. Remove its id from
the rx8025 driver.Fixes: b1f9d790b59dc04f8813a49a92ddd8651770ffee
Signed-off-by: Alexandre Belloni
08 Nov, 2015
1 commit
-
braces {} are not necessary for single statement blocks
Signed-off-by: Alexandre Belloni
05 Sep, 2015
17 commits
-
Check time validity when reading time as this is when we need to know.
Signed-off-by: Alexandre Belloni
-
RX8025_BIT_CTRL2_CTFG was set to 0 only when it was already 0.
Signed-off-by: Alexandre Belloni
-
irq_freq is already initialized to 1 in rtc_device_register()
Signed-off-by: Alexandre Belloni
-
Wait for the user to set the time to reset the validity bits. Until then,
the time may be invalid.Signed-off-by: Alexandre Belloni
-
rx8025_init_client is modifying ctrl[0] and writing it to RX8025_REG_CTRL2
but ctrl[0] is actually RX8025_REG_CTRL1.Signed-off-by: Alexandre Belloni
-
Instead of bailing out, disable alarms and continue when
devm_request_threaded_irq() fails. This allows to still provide some
functionality.Signed-off-by: Alexandre Belloni
-
Remove useless error messages, at that point, the user already knows
something went wrong but will not be able to do anything about it anyway.
It is also highly unlikely that some registers are readable/writable
but not some other ones.Also, transform rx8025_read_reg to be more resemblant to
i2c_smbus_read_byte_data()Signed-off-by: Alexandre Belloni
-
Stop setting the time to epoch when it is invalid. The proper way to handle
that is to return an error when it is invalid instead of returning an
incorrect value.Signed-off-by: Alexandre Belloni
-
The datasheet specifies that transfer mode must be 0 for write and either
0x4 (simplified read) or 0 (standard read). 0x8 is not specified, use
standard mode.Signed-off-by: Alexandre Belloni
-
The hardware is only capable of handling dates between 2000 and 2099,
enforce that.Signed-off-by: Alexandre Belloni
-
Use BIT() instead of hand coding.
Signed-off-by: Alexandre Belloni
-
It is useless to print a message when probe fails as the user is already
aware that it failed.Signed-off-by: Alexandre Belloni
-
Use devm_request_threaded_irq() so it is not necessary to call free_irq()
explicitly.Signed-off-by: Alexandre Belloni
-
The driver currently emulates the concept of threaded IRQ using a
workqueue, switch to threaded IRQ instead.Signed-off-by: Alexandre Belloni
-
Remove the useless includes and order the remaining ones alphabetically.
Signed-off-by: Alexandre Belloni
-
Since commit e6229bec25be ("rtc: make rtc_update_irq callable with irqs
enabled") rtc_update_irq() is callable with irqs enabled.Signed-off-by: Henri Roosen
Signed-off-by: Alexandre Belloni -
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Alexandre Belloni
04 Apr, 2014
1 commit
-
The site-specific OOM messages are unnecessary, because they duplicate
the MM subsystem generic OOM message.Signed-off-by: Jingoo Han
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 Jul, 2013
1 commit
-
Use devm_*() functions to make cleanup paths simpler.
Signed-off-by: Jingoo Han
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Cc: Alessandro Zummo
Cc: Srinidhi Kasagar
Cc: Linus Walleij
Cc: Mike Frysinger
Cc: Wan ZongShun
Cc: Guan Xuetao
Cc: Mark Brown
Signed-off-by: Greg Kroah-Hartman
24 Mar, 2012
1 commit
-
Factor out some boilerplate code for i2c driver registration into
module_i2c_driver.Signed-off-by: Axel Lin
Cc: Piotr Ziecik
Cc: Alessandro Zummo
Cc: Scott Wood
Cc: Srikanth Srinivasan
Cc: Mike Rapoport
Cc: Sergey Lapin
Cc: Roman Fietze
Cc: Herbert Valerio Riedel
Cc: Alexander Bigga
Cc: Dale Farnsworth
Cc: Gregory Hermant
Cc: Wolfgang Grandegger
Cc: Martyn Welch
Cc: Byron Bradley
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
10 Mar, 2011
1 commit
-
With PIE mode interrupts now emulated in generic code via an hrtimer,
no one calls rtc_class_ops->irq_set_state(), so this patch removes it
along with driver implementations.CC: Thomas Gleixner
CC: Alessandro Zummo
CC: Marcelo Roberto Jimenez
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz
24 Dec, 2010
1 commit
-
flush_scheduled_work() is deprecated and scheduled to be removed. On
removal, directly cancel the work, and flush the uie_task in
rtc-dev.c::clear_uie().Signed-off-by: Tejun Heo
Cc: Alessandro Zummo
Cc: rtc-linux@googlegroups.com
19 Jul, 2010
1 commit
-
Fix typo in comments. Replace charater with character.
Characteristics too.Signed-off-by: Thomas Weber
Signed-off-by: Jiri Kosina
