06 May, 2019

1 commit

• c5bf68fe0   *: convert stream-like files from nonseekable_open -> stream_open ... Browse Code »

  Using scripts/coccinelle/api/stream_open.cocci added in 10dce8af3422
  ("fs: stream_open - opener for stream-like files so that read and write
  can run simultaneously without deadlock"), search and convert to
  stream_open all in-kernel nonseekable_open users for which read and
  write actually do not depend on ppos and where there is no other methods
  in file_operations which assume @offset access.

  I've verified each generated change manually - that it is correct to convert -
  and each other nonseekable_open instance left - that it is either not correct
  to convert there, or that it is not converted due to current stream_open.cocci
  limitations. The script also does not convert files that should be valid to
  convert, but that currently have .llseek = noop_llseek or generic_file_llseek
  for unknown reason despite file being opened with nonseekable_open (e.g.
  drivers/input/mousedev.c)

  Among cases converted 14 were potentially vulnerable to read vs write deadlock
  (see details in 10dce8af3422):

  drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.

  and the rest were just safe to convert to stream_open because their read and
  write do not use ppos at all and corresponding file_operations do not
  have methods that assume @offset file access(*):

  arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

  One can also recheck/review the patch via generating it with explanation comments included via

  $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain"

  (*) This second group also contains cases with read/write deadlocks that
  stream_open.cocci don't yet detect, but which are still valid to convert to
  stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c
  calls wait_for_completion_interruptible() in its .read, but stream_open.cocci
  currently detects only "wait_event*" as blocking.

  Cc: Michael Kerrisk
  Cc: Yongzhi Pan
  Cc: Jonathan Corbet
  Cc: David Vrabel
  Cc: Juergen Gross
  Cc: Miklos Szeredi
  Cc: Tejun Heo
  Cc: Kirill Tkhai
  Cc: Arnd Bergmann
  Cc: Christoph Hellwig
  Cc: Greg Kroah-Hartman
  Cc: Julia Lawall
  Cc: Nikolaus Rath
  Cc: Han-Wen Nienhuys
  Cc: Anatolij Gustschin
  Cc: Jeff Dike
  Cc: Richard Weinberger
  Cc: Anton Ivanov
  Cc: Borislav Petkov
  Cc: Thomas Gleixner
  Cc: Ingo Molnar
  Cc: "James R. Van Zandt"
  Cc: Corey Minyard
  Cc: Harald Welte
  Acked-by: Lubomir Rintel [scr24x_cs]
  Cc: Stefan Richter
  Cc: Johan Hovold
  Cc: David Herrmann
  Cc: Jiri Kosina
  Cc: Benjamin Tissoires
  Cc: Jean Delvare
  Acked-by: Guenter Roeck [watchdog/* hwmon/*]
  Cc: Rudolf Marek
  Cc: Dmitry Torokhov
  Cc: Karsten Keil
  Cc: Jacek Anaszewski
  Cc: Pavel Machek
  Cc: Mauro Carvalho Chehab
  Cc: Kurt Schwemmer
  Acked-by: Logan Gunthorpe [drivers/pci/switch/switchtec]
  Acked-by: Bjorn Helgaas [drivers/pci/switch/switchtec]
  Cc: Benson Leung
  Acked-by: Enric Balletbo i Serra [platform/chrome]
  Cc: Alessandro Zummo
  Acked-by: Alexandre Belloni [rtc/*]
  Cc: Mark Brown
  Cc: Wim Van Sebroeck
  Cc: Florian Fainelli
  Cc: bcm-kernel-feedback-list@broadcom.com
  Cc: Wan ZongShun
  Cc: Zwane Mwaikambo
  Cc: Marek Lindner
  Cc: Simon Wunderlich
  Cc: Antonio Quartulli
  Cc: "David S. Miller"
  Cc: Johannes Berg
  Cc: Jaroslav Kysela
  Cc: Takashi Iwai
  Signed-off-by: Kirill Smelkov

  Kirill Smelkov

  2019-05-06 22:46:41 +0800  

24 Dec, 2018

1 commit

• d2b911db8   watchdog: mtx-1: Convert to use GPIO descriptor ... Browse Code »

  This converts the MTX-1 driver to grab a GPIO descriptor
  associated with the device instead of using a resource with
  a global GPIO number. Augment the driver and the boardfile.

  Cc: Ralf Baechle
  Cc: Paul Burton
  Cc: James Hogan
  Cc: linux-mips@linux-mips.org
  Cc: Florian Fainelli
  Reviewed-by: Florian Fainelli
  Signed-off-by: Linus Walleij
  Acked-by: Paul Burton
  Reviewed-by: Guenter Roeck
  Signed-off-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck

  Linus Walleij

  2018-12-24 15:27:56 +0800  

24 Mar, 2018

1 commit

• 2e62c4988   watchdog: add SPDX identifiers for watchdog subsystem ... Browse Code »

  - Add SPDX identifier
  - Remove boiler plate license text
  - If MODULE_LICENSE and boiler plate does not match, go for boiler plate
  license

  Signed-off-by: Marcus Folkesson
  Acked-by: Adam Thomson
  Acked-by: Baruch Siach
  Acked-by: Charles Keepax
  Acked-by: Keiji Hayashibara
  Acked-by: Johannes Thumshirn
  Acked-by: Florian Fainelli
  Acked-by: Mans Rullgard
  Acked-by: Matthias Brugger
  Acked-by: Michal Simek
  Acked-by: Neil Armstrong
  Acked-by: Nicolas Ferre
  Acked-by: Thierry Reding
  Acked-by: Tomas Winkler
  Acked-by: Patrice Chotard
  Acked-by: William Breathitt Gray
  Reviewed-by: Eric Anholt
  Reviewed-by: Guenter Roeck
  Signed-off-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck

  Marcus Folkesson

  2018-03-24 17:19:40 +0800  

22 Nov, 2017

1 commit

• e99e88a9d   treewide: setup_timer() -> timer_setup() ... Browse Code »

  This converts all remaining cases of the old setup_timer() API into using
  timer_setup(), where the callback argument is the structure already
  holding the struct timer_list. These should have no behavioral changes,
  since they just change which pointer is passed into the callback with
  the same available pointers after conversion. It handles the following
  examples, in addition to some other variations.

  Casting from unsigned long:

  void my_callback(unsigned long data)
  {
  struct something *ptr = (struct something *)data;
  ...
  }
  ...
  setup_timer(&ptr->my_timer, my_callback, ptr);

  and forced object casts:

  void my_callback(struct something *ptr)
  {
  ...
  }
  ...
  setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);

  become:

  void my_callback(struct timer_list *t)
  {
  struct something *ptr = from_timer(ptr, t, my_timer);
  ...
  }
  ...
  timer_setup(&ptr->my_timer, my_callback, 0);

  Direct function assignments:

  void my_callback(unsigned long data)
  {
  struct something *ptr = (struct something *)data;
  ...
  }
  ...
  ptr->my_timer.function = my_callback;

  have a temporary cast added, along with converting the args:

  void my_callback(struct timer_list *t)
  {
  struct something *ptr = from_timer(ptr, t, my_timer);
  ...
  }
  ...
  ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;

  And finally, callbacks without a data assignment:

  void my_callback(unsigned long data)
  {
  ...
  }
  ...
  setup_timer(&ptr->my_timer, my_callback, 0);

  have their argument renamed to verify they're unused during conversion:

  void my_callback(struct timer_list *unused)
  {
  ...
  }
  ...
  timer_setup(&ptr->my_timer, my_callback, 0);

  The conversion is done with the following Coccinelle script:

  spatch --very-quiet --all-includes --include-headers \
  -I ./arch/x86/include -I ./arch/x86/include/generated \
  -I ./include -I ./arch/x86/include/uapi \
  -I ./arch/x86/include/generated/uapi -I ./include/uapi \
  -I ./include/generated/uapi --include ./include/linux/kconfig.h \
  --dir . \
  --cocci-file ~/src/data/timer_setup.cocci

  @fix_address_of@
  expression e;
  @@

  setup_timer(
  -&(e)
  +&e
  , ...)

  // Update any raw setup_timer() usages that have a NULL callback, but
  // would otherwise match change_timer_function_usage, since the latter
  // will update all function assignments done in the face of a NULL
  // function initialization in setup_timer().
  @change_timer_function_usage_NULL@
  expression _E;
  identifier _timer;
  type _cast_data;
  @@

  (
  -setup_timer(&_E->_timer, NULL, _E);
  +timer_setup(&_E->_timer, NULL, 0);
  |
  -setup_timer(&_E->_timer, NULL, (_cast_data)_E);
  +timer_setup(&_E->_timer, NULL, 0);
  |
  -setup_timer(&_E._timer, NULL, &_E);
  +timer_setup(&_E._timer, NULL, 0);
  |
  -setup_timer(&_E._timer, NULL, (_cast_data)&_E);
  +timer_setup(&_E._timer, NULL, 0);
  )

  @change_timer_function_usage@
  expression _E;
  identifier _timer;
  struct timer_list _stl;
  identifier _callback;
  type _cast_func, _cast_data;
  @@

  (
  -setup_timer(&_E->_timer, _callback, _E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, &_callback, _E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, _callback, (_cast_data)_E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, (_cast_func)_callback, _E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E._timer, _callback, (_cast_data)_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, _callback, (_cast_data)&_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, &_callback, (_cast_data)_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
  +timer_setup(&_E._timer, _callback, 0);
  |
  _E->_timer@_stl.function = _callback;
  |
  _E->_timer@_stl.function = &_callback;
  |
  _E->_timer@_stl.function = (_cast_func)_callback;
  |
  _E->_timer@_stl.function = (_cast_func)&_callback;
  |
  _E._timer@_stl.function = _callback;
  |
  _E._timer@_stl.function = &_callback;
  |
  _E._timer@_stl.function = (_cast_func)_callback;
  |
  _E._timer@_stl.function = (_cast_func)&_callback;
  )

  // callback(unsigned long arg)
  @change_callback_handle_cast
  depends on change_timer_function_usage@
  identifier change_timer_function_usage._callback;
  identifier change_timer_function_usage._timer;
  type _origtype;
  identifier _origarg;
  type _handletype;
  identifier _handle;
  @@

  void _callback(
  -_origtype _origarg
  +struct timer_list *t
  )
  {
  (
  ... when != _origarg
  _handletype *_handle =
  -(_handletype *)_origarg;
  +from_timer(_handle, t, _timer);
  ... when != _origarg
  |
  ... when != _origarg
  _handletype *_handle =
  -(void *)_origarg;
  +from_timer(_handle, t, _timer);
  ... when != _origarg
  |
  ... when != _origarg
  _handletype *_handle;
  ... when != _handle
  _handle =
  -(_handletype *)_origarg;
  +from_timer(_handle, t, _timer);
  ... when != _origarg
  |
  ... when != _origarg
  _handletype *_handle;
  ... when != _handle
  _handle =
  -(void *)_origarg;
  +from_timer(_handle, t, _timer);
  ... when != _origarg
  )
  }

  // callback(unsigned long arg) without existing variable
  @change_callback_handle_cast_no_arg
  depends on change_timer_function_usage &&
  !change_callback_handle_cast@
  identifier change_timer_function_usage._callback;
  identifier change_timer_function_usage._timer;
  type _origtype;
  identifier _origarg;
  type _handletype;
  @@

  void _callback(
  -_origtype _origarg
  +struct timer_list *t
  )
  {
  + _handletype *_origarg = from_timer(_origarg, t, _timer);
  +
  ... when != _origarg
  - (_handletype *)_origarg
  + _origarg
  ... when != _origarg
  }

  // Avoid already converted callbacks.
  @match_callback_converted
  depends on change_timer_function_usage &&
  !change_callback_handle_cast &&
  !change_callback_handle_cast_no_arg@
  identifier change_timer_function_usage._callback;
  identifier t;
  @@

  void _callback(struct timer_list *t)
  { ... }

  // callback(struct something *handle)
  @change_callback_handle_arg
  depends on change_timer_function_usage &&
  !match_callback_converted &&
  !change_callback_handle_cast &&
  !change_callback_handle_cast_no_arg@
  identifier change_timer_function_usage._callback;
  identifier change_timer_function_usage._timer;
  type _handletype;
  identifier _handle;
  @@

  void _callback(
  -_handletype *_handle
  +struct timer_list *t
  )
  {
  + _handletype *_handle = from_timer(_handle, t, _timer);
  ...
  }

  // If change_callback_handle_arg ran on an empty function, remove
  // the added handler.
  @unchange_callback_handle_arg
  depends on change_timer_function_usage &&
  change_callback_handle_arg@
  identifier change_timer_function_usage._callback;
  identifier change_timer_function_usage._timer;
  type _handletype;
  identifier _handle;
  identifier t;
  @@

  void _callback(struct timer_list *t)
  {
  - _handletype *_handle = from_timer(_handle, t, _timer);
  }

  // We only want to refactor the setup_timer() data argument if we've found
  // the matching callback. This undoes changes in change_timer_function_usage.
  @unchange_timer_function_usage
  depends on change_timer_function_usage &&
  !change_callback_handle_cast &&
  !change_callback_handle_cast_no_arg &&
  !change_callback_handle_arg@
  expression change_timer_function_usage._E;
  identifier change_timer_function_usage._timer;
  identifier change_timer_function_usage._callback;
  type change_timer_function_usage._cast_data;
  @@

  (
  -timer_setup(&_E->_timer, _callback, 0);
  +setup_timer(&_E->_timer, _callback, (_cast_data)_E);
  |
  -timer_setup(&_E._timer, _callback, 0);
  +setup_timer(&_E._timer, _callback, (_cast_data)&_E);
  )

  // If we fixed a callback from a .function assignment, fix the
  // assignment cast now.
  @change_timer_function_assignment
  depends on change_timer_function_usage &&
  (change_callback_handle_cast ||
  change_callback_handle_cast_no_arg ||
  change_callback_handle_arg)@
  expression change_timer_function_usage._E;
  identifier change_timer_function_usage._timer;
  identifier change_timer_function_usage._callback;
  type _cast_func;
  typedef TIMER_FUNC_TYPE;
  @@

  (
  _E->_timer.function =
  -_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E->_timer.function =
  -&_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E->_timer.function =
  -(_cast_func)_callback;
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E->_timer.function =
  -(_cast_func)&_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E._timer.function =
  -_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E._timer.function =
  -&_callback;
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E._timer.function =
  -(_cast_func)_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  |
  _E._timer.function =
  -(_cast_func)&_callback
  +(TIMER_FUNC_TYPE)_callback
  ;
  )

  // Sometimes timer functions are called directly. Replace matched args.
  @change_timer_function_calls
  depends on change_timer_function_usage &&
  (change_callback_handle_cast ||
  change_callback_handle_cast_no_arg ||
  change_callback_handle_arg)@
  expression _E;
  identifier change_timer_function_usage._timer;
  identifier change_timer_function_usage._callback;
  type _cast_data;
  @@

  _callback(
  (
  -(_cast_data)_E
  +&_E->_timer
  |
  -(_cast_data)&_E
  +&_E._timer
  |
  -_E
  +&_E->_timer
  )
  )

  // If a timer has been configured without a data argument, it can be
  // converted without regard to the callback argument, since it is unused.
  @match_timer_function_unused_data@
  expression _E;
  identifier _timer;
  identifier _callback;
  @@

  (
  -setup_timer(&_E->_timer, _callback, 0);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, _callback, 0L);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E->_timer, _callback, 0UL);
  +timer_setup(&_E->_timer, _callback, 0);
  |
  -setup_timer(&_E._timer, _callback, 0);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, _callback, 0L);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_E._timer, _callback, 0UL);
  +timer_setup(&_E._timer, _callback, 0);
  |
  -setup_timer(&_timer, _callback, 0);
  +timer_setup(&_timer, _callback, 0);
  |
  -setup_timer(&_timer, _callback, 0L);
  +timer_setup(&_timer, _callback, 0);
  |
  -setup_timer(&_timer, _callback, 0UL);
  +timer_setup(&_timer, _callback, 0);
  |
  -setup_timer(_timer, _callback, 0);
  +timer_setup(_timer, _callback, 0);
  |
  -setup_timer(_timer, _callback, 0L);
  +timer_setup(_timer, _callback, 0);
  |
  -setup_timer(_timer, _callback, 0UL);
  +timer_setup(_timer, _callback, 0);
  )

  @change_callback_unused_data
  depends on match_timer_function_unused_data@
  identifier match_timer_function_unused_data._callback;
  type _origtype;
  identifier _origarg;
  @@

  void _callback(
  -_origtype _origarg
  +struct timer_list *unused
  )
  {
  ... when != _origarg
  }

  Signed-off-by: Kees Cook

  Kees Cook

  2017-11-22 07:57:07 +0800  

31 Mar, 2014

1 commit

• 8126334b2   watchdog: delete non-required instances of include <linux/init.h> ... Browse Code »

  None of these files are actually using any __init type directives
  and hence don't need to include . Most are just a
  left over from __devinit and __cpuinit removal, or simply due to
  code getting copied from one driver to the next.

  Signed-off-by: Paul Gortmaker
  Reviewed-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck
  Cc: linux-watchdog@vger.kernel.org

  Paul Gortmaker

  2014-03-31 19:22:45 +0800  

18 Nov, 2013

1 commit

• 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

  I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
  and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

  Either the device is enumerated and the driver already has a module
  alias (e.g. PCI, USB etc.) that will get the right driver loaded
  automatically.

  Or the device is not enumerated and loading its driver will lead to
  more or less intrusive hardware poking. Such hardware poking should be
  limited to a bare minimum, so the user should really decide which
  drivers should be tried and in what order. Trying them all in
  arbitrary order can't do any good.

  On top of that, loading that many drivers at once bloats the kernel
  log. Also many drivers will stay loaded afterward, bloating the output
  of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
  loaded as a dependency) can't even be unloaded!

  If defining char-major-10-130 is needed then it should happen in
  user-space.

  Signed-off-by: Jean Delvare
  Acked-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck
  Cc: Stephen Warren
  Cc: Mike Frysinger
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Cc: Zwane Mwaikambo
  Cc: Jim Cromie

  Jean Delvare

  2013-11-18 02:38:13 +0800  

12 Jul, 2013

1 commit

• d3a33a950   watchdog: mtx1-wdt: use devm_gpio_request_one() ... Browse Code »

  Use devm_gpio_request_one() to make cleanup paths simpler.

  Signed-off-by: Jingoo Han
  Reviewed-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck

  Jingoo Han

  2013-07-12 03:04:05 +0800  

29 Nov, 2012

3 commits

• 4b12b896c   watchdog: remove use of __devexit ... Browse Code »

  CONFIG_HOTPLUG is going away as an option so __devexit is no
  longer needed.

  Signed-off-by: Bill Pemberton
  Cc: Wim Van Sebroeck
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Acked-by: Mark Brown
  Signed-off-by: Greg Kroah-Hartman

  Bill Pemberton

  2012-11-29 04:00:24 +0800  
• 2d991a164   watchdog: remove use of __devinit ... Browse Code »

  CONFIG_HOTPLUG is going away as an option so __devinit is no longer
  needed.

  Signed-off-by: Bill Pemberton
  Cc: Wim Van Sebroeck
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Acked-by: Mark Brown
  Signed-off-by: Greg Kroah-Hartman

  Bill Pemberton

  2012-11-29 04:00:24 +0800  
• 82268714b   watchdog: remove use of __devexit_p ... Browse Code »

  CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
  needed.

  Signed-off-by: Bill Pemberton
  Cc: Wim Van Sebroeck
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Acked-by: Mark Brown
  Signed-off-by: Greg Kroah-Hartman

  Bill Pemberton

  2012-11-29 04:00:24 +0800  

06 Jan, 2012

1 commit

• b8ec61189   watchdog: convert drivers/watchdog/* to use module_platform_driver() ... Browse Code »

  This patch converts the drivers in drivers/watchdog/* to use the
  module_platform_driver() macro which makes the code smaller and a bit
  simpler.

  Signed-off-by: Axel Lin
  Cc: Nicolas Thill
  Cc: Florian Fainelli
  Cc: "David S. Miller"
  Cc: Paul Cercueil
  Cc: Marc Zyngier
  Cc: Wan ZongShun
  Cc: Alejandro Cabrera
  Cc: "George G. Davis"
  Cc: Sylver Bruneau
  Cc: Vitaly Wool
  Cc: Mika Westerberg
  Cc: Timo Kokkonen
  Signed-off-by: Wim Van Sebroeck

  Axel Lin

  2012-01-06 22:17:25 +0800  

22 Jul, 2011

1 commit

• fad0a9dd0   watchdog: mtx1-wdt: use dev_{err,info} instead of printk() ... Browse Code »

  use dev_{err,info} instead of printk(KERN_{ERR,INFO} ...)

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck

  Florian Fainelli

  2011-07-22 16:59:43 +0800  

28 Jun, 2011

3 commits

• db98f89a2   watchdog: mtx1-wdt: fix section mismatch ... Browse Code »

  Fix section mismatch and remove unused variable 'tmp'.

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck

  Florian Fainelli

  2011-06-28 15:42:40 +0800  
• 2ea4e76e9   watchdog: mtx1-wdt: fix GPIO toggling ... Browse Code »

  Commit e391be76 (MIPS: Alchemy: Clean up GPIO registers and accessors)
  changed the way the GPIO was toggled. Prior to this patch, we would
  always actively drive the GPIO output to either 0 or 1, this patch
  drove the GPIO active to 0, and put the GPIO in tristate to drive it
  to 1, unfortunately this does not work, revert back to active driving.

  Using a signed variable (gstate) to hold the gpio state and using a bit-
  wise operation on it also resulted in toggling value from 1 to -2 since
  the variable is signed. This value was then passed on to gpio_direction_
  output, which always perform a if (value) ... to set the value to the
  gpio, so we were always writing a 1 to this GPIO instead of 1 -> 0 -> 1 ...

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck
  Cc: stable

  Florian Fainelli

  2011-06-28 15:42:30 +0800  
• 9b19d40aa   watchdog: mtx1-wdt: request gpio before using it ... Browse Code »

  Otherwise, the gpiolib autorequest feature will produce a WARN_ON():

  WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
  autorequest GPIO-215
  [...]

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck
  Cc: stable

  Florian Fainelli

  2011-06-28 15:42:23 +0800  

19 May, 2011

1 commit

• b7f720d68   MIPS: Alchemy: Clean up GPIO registers and accessors ... Browse Code »

  remove au_readl/au_writel, remove the predefined GPIO1/2 KSEG1 register
  addresses and fix the fallout in all boards and drivers.

  This also fixes a bug in the mtx-1_wdt driver which was introduced by
  commit 6ea8115bb6f359df4f45152f2b40e1d4d1891392
  ("Convert mtx1 wdt to be a platform device and use generic GPIO API")
  before this patch mtx-1_wdt only modified GPIO215, the patch then
  used the gpio resource information as bit index into the GPIO2 register
  but the conversion to the GPIO API didn't realize that.
  With this patch the drivers original behaviour is restored and GPIO15
  is left alone.

  Signed-off-by: Manuel Lauss
  Cc: Florian Fainelli
  To: Linux-MIPS
  Cc: linux-watchdog@vger.kernel.org
  Cc: Wim Van Sebroeck
  Patchwork: https://patchwork.linux-mips.org/patch/2381/
  Signed-off-by: Ralf Baechle <ralf@linux-mips.org

  Manuel Lauss

  2011-05-19 16:55:46 +0800  

16 Mar, 2011

1 commit

• 5f3b27569   watchdog: cleanup spaces before tabs ... Browse Code »

  cleanup spaces before tabs in drivers/watchdog/

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2011-03-16 00:02:27 +0800  

18 Jun, 2009

1 commit

• b6bf291f1   [WATCHDOG] move platform probe and remove function to devinit and devexit ... Browse Code »

  A pointer to probe and remove functions is passed to the core via
  platform_driver_register and so the function must not disappear when the
  .init sections are discarded. Otherwise (if also having HOTPLUG=y)
  unbinding and binding a device to the driver via sysfs will result in an
  oops as does a device being registered late.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2009-06-18 15:30:44 +0800  

25 Mar, 2009

1 commit

• 143a2e54b   [WATCHDOG] More coding-style and trivial clean-up ... Browse Code »

  Some more cleaning-up of the watchdog drivers.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2009-03-25 17:07:04 +0800  

21 Nov, 2008

1 commit

• f80e919bb   [WATCHDOG] fix mtx1_wdt compilation failure ... Browse Code »

  Using spin_lock_irqsave with a local variable called flags without
  declaring is a bad idea, fix this by declaring it.

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck

  Florian Fainelli

  2008-11-21 16:20:49 +0800  

07 Aug, 2008

1 commit

• 7944d3a5a   [WATCHDOG] more coding style clean-up's ... Browse Code »

  More coding style clean-up's.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-07 04:19:41 +0800  

06 Aug, 2008

1 commit

• 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

  This brings the watchdog drivers into line with coding style.
  This patch takes cares of the indentation as described in chapter 1.
  Main changes:
  * Re-structure the ioctl switch call for all drivers as follows:
  switch (cmd) {
  case WDIOC_GETSUPPORT:
  case WDIOC_GETSTATUS:
  case WDIOC_GETBOOTSTATUS:
  case WDIOC_GETTEMP:
  case WDIOC_SETOPTIONS:
  case WDIOC_KEEPALIVE:
  case WDIOC_SETTIMEOUT:
  case WDIOC_GETTIMEOUT:
  case WDIOC_GETTIMELEFT:
  default:
  }

  This to make the migration from the drivers to the uniform watchdog
  device driver easier in the future.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-06 21:21:09 +0800  

14 Jun, 2008

1 commit

• ed78c2da1   [WATCHDOG 28/57] mtx-1_wdt: clean up, coding style, unlocked ioctl ... Browse Code »

  Review and switch to unlocked_ioctl

  Signed-off-by: Alan Cox
  Signed-off-by: Wim Van Sebroeck

  Alan Cox

  2008-06-14 03:58:05 +0800  

11 Apr, 2008

1 commit

• f37d193c7   watchdog: fix platform driver hotplug/coldplug ... Browse Code »

  Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is
  prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable watchdog
  drivers, to re-enable auto loading.

  [dbrownell@users.sourceforge.net: more drivers; registration fixes]
  Signed-off-by: Kay Sievers
  Signed-off-by: David Brownell
  Cc: Wim Van Sebroeck
  Cc: Greg KH
  Signed-off-by: Andrew Morton
  Signed-off-by: Linus Torvalds

  Kay Sievers

  2008-04-11 23:06:44 +0800  

06 Mar, 2008

1 commit

• 996d62d44   [WATCHDOG] Remove volatiles from watchdog device structures ... Browse Code »

  Remove the volatile since those are useless in such a structure.

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck

  Florian Fainelli

  2008-03-06 19:30:32 +0800  

19 Feb, 2008

1 commit

• 6ea8115bb   [WATCHDOG] Convert mtx1 wdt to be a platform device and use generic GPIO API ... Browse Code »

  This patch converts the MTX-1 to be a platform device, use the available
  generic GPIO API for the MTX-1 board and register the miscdev alias.

  Signed-off-by: Florian Fainelli
  Signed-off-by: Wim Van Sebroeck

  Florian Fainelli

  2008-02-19 00:54:02 +0800  

26 Jan, 2008

1 commit

• b47a166ed   [WATCHDOG] constify function pointer tables ... Browse Code »

  "static struct file_operations" should be
  "static const struct file_operations".

  Signed-off-by: Jan Engelhardt
  Signed-off-by: Wim Van Sebroeck

  Jan Engelhardt

  2008-01-26 04:41:30 +0800  

18 Oct, 2007

1 commit

• b7e04f8c6   mv watchdog tree under drivers ... Browse Code »

  move watchdog tree from drivers/char/watchdog to drivers/watchdog.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2007-10-18 18:39:03 +0800