30 Aug, 2011

1 commit

  • * 'fixes' of master.kernel.org:/home/rmk/linux-2.6-arm:
    ARM: pm: avoid writing the auxillary control register for ARMv7
    ARM: pm: some ARMv7 requires a dsb in resume to ensure correctness
    ARM: pm: arm920/926: fix number of registers saved
    ARM: pm: CPU specific code should not overwrite r1 (v:p offset)
    ARM: 7066/1: proc-v7: disable SCTLR.TE when disabling MMU
    ARM: 7065/1: kexec: ensure new kernel is entered in ARM state
    ARM: 7003/1: vexpress: Add clock definition for the SP805.
    ARM: 7051/1: cpuimx* boards: fix mach-types errors
    ARM: 7019/1: Footbridge: select CLKEVT_I8253 for ARCH_NETWINDER
    ARM: 7015/1: ARM errata: Possible cache data corruption with hit-under-miss enabled
    ARM: 7014/1: cache-l2x0: Fix L2 Cache size calculation.
    ARM: 6967/1: ep93xx: ts72xx: fix board model detection
    ARM: 6965/1: ep93xx: add model detection for ts-7300 and ts-7400 boards
    ARM: cache: detect VIPT aliasing I-cache on ARMv6
    ARM: twd: register clockevents device before enabling PPI
    ARM: realview: ensure visibility of writes during reset
    ARM: perf: make name of arm_pmu_type consistent
    ARM: perf: fix prototype of release_pmu
    ARM: fix perf build with uclibc toolchains

    Linus Torvalds
     

26 Aug, 2011

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/brodo/cpupowerutils:
    cpupower: use man(1) when calling "cpupower help subcommand"
    cpupower: make NLS truly optional
    cpupower: fix Makefile typo
    cpupower: Make monitor command -c/--cpu aware
    cpupower: Better detect offlined CPUs
    cpupower: Do not show an empty Idle_Stats monitor if no idle driver is available
    cpupower: mperf monitor - Use TSC to calculate max frequency if possible
    cpupower: avoid using symlinks

    Linus Torvalds
     

19 Aug, 2011

3 commits


18 Aug, 2011

5 commits

  • Group event scheduling command line option is missing in perf
    record/stat.

    Add it to perf record/stat, which is same as in perf top.

    Reported-by: Andi Kleen
    Cc: Andi Kleen
    Cc: Ingo Molnar
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1313577727.2754.5.camel@hp6530s
    Signed-off-by: Lin Ming
    Signed-off-by: Arnaldo Carvalho de Melo

    Lin Ming
     
  • Upstream glibc commit 295e904 added a definition for __attribute_const__
    to cdefs.h. This causes the following error when building perf:

    util/include/linux/compiler.h:8:0: error: "__attribute_const__"
    redefined [-Werror] /usr/include/sys/cdefs.h:226:0: note: this is the
    location of the previous definition

    Wrap __attribute_const__ in #ifndef as we do for __always_inline.

    Cc: Ingo Molnar
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110818113720.GL2227@zod.bos.redhat.com
    Signed-off-by: Josh Boyer
    Signed-off-by: Arnaldo Carvalho de Melo

    Josh Boyer
     
  • There was a problem with the parse_events() code not printing the
    correct event name when an event was unknown and starting with an 'r'.
    The source of the problem was the way raw notation was parsed.

    Without the patch:
    $ perf stat -e retired_foo
    invalid event modifier: 'tired_foo'

    With the patch:
    $ perf stat -e retired_foo
    invalid or unsupported event: 'retired_foo'

    This also covers the case where the name of the event was not printed at
    all when perf was linked with libpfm4.

    Cc: Ingo Molnar
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110723021043.GA20178@quad
    Signed-off-by: Stephane Eranian
    Signed-off-by: Arnaldo Carvalho de Melo

    Stephane Eranian
     
  • When no event is given to perf record, perf top, a default event is
    initialized (cycles). However, perf_evlist__add_default() was not
    setting the symbolic name for the event. Perf top worked simply because
    it was reconstructing the name from the event code. But it should not
    have to do this. This patch initializes the evsel->name field properly.

    This second version improves the code flow on the non error path.

    Cc: Ingo Molnar
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110607161936.GA8163@quad
    Signed-off-by: Stephane Eranian
    [committer note: Use perf_evsel__delete() instead of plain free()]
    Signed-off-by: Arnaldo Carvalho de Melo

    Stephane Eranian
     
  • This patch fixes an issue with the exit value of perf list:

    $ perf list; echo $?
    129

    perf list returns an error exit code even though there is no error.

    There was a stray exit(129) in print_events(). This patch removes this
    exit().

    $ perf list; echo $?
    0

    $ perf list hw sw
    cpu-cycles OR cycles [Hardware event]
    stalled-cycles-frontend OR idle-cycles-frontend [Hardware event]
    stalled-cycles-backend OR idle-cycles-backend [Hardware event]
    instructions [Hardware event]
    cache-references [Hardware event]
    cache-misses [Hardware event]
    branch-instructions OR branches [Hardware event]
    branch-misses [Hardware event]
    bus-cycles [Hardware event]

    cpu-clock [Software event]
    task-clock [Software event]
    page-faults OR faults [Software event]
    minor-faults [Software event]
    major-faults [Software event]
    context-switches OR cs [Software event]
    cpu-migrations OR migrations [Software event]
    alignment-faults [Software event]
    emulation-faults [Software event]
    $ echo $?
    0

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110523123917.GA31060@quad
    Signed-off-by: Stephane Eranian
    Signed-off-by: Arnaldo Carvalho de Melo

    Stephane Eranian
     

16 Aug, 2011

5 commits


14 Aug, 2011

1 commit


13 Aug, 2011

1 commit


12 Aug, 2011

11 commits

  • libio.h is not provided by uClibc, in order to be able to test the
    definition of __UCLIBC__ we need to include stdlib.h, which also
    includes stddef.h, providing the definition of 'NULL'.

    Signed-off-by: Florian Fainelli
    Signed-off-by: Will Deacon

    Florian Fainelli
     
  • With gcc4.6, some instances of concrete inlined function looks redundant
    and broken, because it appears inside of a concrete instance and its
    call_file and call_line are same as the original abstruct's decl_file
    and decl_line respectively.

    e.g.
    [ d1aa] subprogram
    external (flag) Yes
    name (strp) "add_timer"
    decl_file (data1) 2 ;here is original
    decl_line (data2) 847 ;line and file
    prototyped (flag) Yes
    inline (data1) inlined (1)
    sibling (ref4) [ d1c6]
    ...
    [ 11d84] subprogram
    abstract_origin (ref4) [ d1aa] ; concrete instance
    low_pc (addr) .text+0x000000000000246f
    high_pc (addr) .text+0x000000000000248b
    frame_base (block1) [ 0] call_frame_cfa
    sibling (ref4) [ 11dd9]
    [ 11d9f] formal_parameter
    abstract_origin (ref4) [ d1b9]
    location (data4) location list [ 701b]
    [ 11da8] inlined_subroutine
    abstract_origin (ref4) [ d1aa] ; redundant instance
    low_pc (addr) .text+0x000000000000247e
    high_pc (addr) .text+0x0000000000002480
    call_file (data1) 2 ; call line and file
    call_line (data2) 847 ; are same as above

    Those redundant instances leads unwilling results;

    e.g. find probe points inside of functions even if we specify
    a function entry as below;

    $ perf probe -V add_timer
    Available variables at add_timer
    @
    struct timer_list* timer
    @
    (No matched variables)

    So, this filters out those redundant instances based on call-site and
    decl-site information.

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110317.19900.59525.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • gcc 4.6 generates a concrete out-of-line instance when there is a
    function which is implicitly inlined somewhere but also has its own
    instance. The concrete out-of-line instance means that it has an
    abstract origin of the function which is referred by not only
    inlined-subroutines but also a concrete subprogram.

    Since current dwarf_func_inline_instances() can find only instances of
    inlined-subroutines, this introduces new die_walk_instances() to find
    both of subprogram and inlined-subroutines.

    e.g. without this,
    Available variables at sched_group_rt_period
    @
    struct task_group* tg

    perf probe failed to find actual subprogram instance of
    sched_group_rt_period().

    With this,

    Available variables at sched_group_rt_period
    @
    struct task_group* tg
    @
    struct task_group* tg

    Now it found the sched_group_rt_period() itself.

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110311.19900.63997.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix variable searching logic to search one in inner than local scope or
    global(CU) scope. In the other words, skip searching in intermediate
    scopes.

    e.g., in the following code,

    int var1;

    void inline infunc(int i)
    {
    i++; without.vars

    With this:
    $ perf probe -V pre_schedule --externs > with.vars

    Check the diff:
    $ diff without.vars with.vars
    88d87
    < int cpu
    133d131
    < long unsigned int* switch_count

    These vars are actually in the scope of schedule(), the caller of
    pre_schedule().

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110305.19900.94374.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix perf probe to search local variables in appropriate local inlined
    function scope. For example, pre_schedule() has only 2 local variables,
    as below;

    $ perf probe -L pre_schedule

    0 static inline void pre_schedule(struct rq *rq, struct task_struct *prev)
    {
    2 if (prev->sched_class->pre_schedule)
    3 prev->sched_class->pre_schedule(rq, prev);
    }

    However, current perf probe shows 4 local variables on pre_schedule(),
    because it searches variables in the caller(schedule()) scope.

    $ perf probe -V pre_schedule
    Available variables at pre_schedule
    @
    int cpu
    long unsigned int* switch_count
    struct rq* rq
    struct task_struct* prev

    This patch fixes this issue by searching variables in the local scope of
    the instance of inlined function. Here is the result.

    $ perf probe -V pre_schedule
    Available variables at pre_schedule
    @
    struct rq* rq
    struct task_struct* prev

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110259.19900.85664.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Check multiple --lines option and print warning informing that only the
    first specified --line option is valid.

    Changes from the 1st post:

    - Accept only the first option instead of the last.
    - Fix warning message according to David's comment.
    - Mark as a bugfix.

    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110253.19900.96192.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix line-range collector to walk all instances of inlined function,
    because some execution paths can be optimized out depending on the
    function argument of instances.

    E.g.)
    inline_func (arg) {
    if (arg)
    do_something;
    else
    do_another;
    }

    func_A() {
    inline_func(1)
    }

    func_B() {
    inline_func(0)
    }

    In this case, func_A may have only do_something code and func_B may have
    only do_another.

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Masami Hiramatsu
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110247.19900.93702.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix perf probe to walk through the lines of all nested inlined function
    call sites and declared lines when a whole CU is passed to the line
    walker.

    The die_walk_lines() can have two different type of DIEs, subprogram (or
    inlined-subroutine) DIE and CU DIE.

    If a caller passes a subprogram DIE, this means that the walker walk on
    lines of given subprogram. In this case, it just needs to search on
    direct children of DIE tree for finding call-site information of inlined
    function which directly called from given subprogram.

    On the other hand, if a caller passes a CU DIE to the walker, this means
    that the walker have to walk on all lines in the source files included
    in given CU DIE. In this case, it has to search whole DIE trees of all
    subprograms to find the call-site information of all nested inlined
    functions.

    Without this patch:

    $ perf probe --line kernel/cpu.c:151-157

    static int cpu_notify(unsigned long val, void *v)
    {
    154 return __cpu_notify(val, v, -1, NULL);
    }

    With this:
    $ perf probe --line kernel/cpu.c:151-157

    152 static int cpu_notify(unsigned long val, void *v)
    {
    154 return __cpu_notify(val, v, -1, NULL);
    }

    As you can see, --line option with source line range shows the declared
    lines as probe-able.

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110241.19900.34994.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix line walker to check whether a given DIE is CU or not.

    Actually this function accepts CU, subprogram and inlined_subroutine
    DIEs.

    Without this fix, perf probe always fails to analyze lines on inlined
    functions;

    $ perf probe -L pre_schedule
    Debuginfo analysis failed. (-2)
    Error: Failed to show lines. (-2)

    This fixes that bug, as below.

    $ perf probe -L pre_schedule

    0 static inline void pre_schedule(struct rq *rq, struct task_struct *prev
    {
    2 if (prev->sched_class->pre_schedule)
    3 prev->sched_class->pre_schedule(rq, prev);
    }

    /* rq->lock is NOT held, but preemption is disabled */

    Changes from v1:
    - Update against current tip tree.(Fix dwarf-aux.c)

    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Masami Hiramatsu
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110235.19900.20614.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • Fix a memory leak for scopes array when it finds a variable in the
    global scope.

    Reviewed-by: Pekka Enberg
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: yrl.pp-manager.tt@hitachi.com
    Link: http://lkml.kernel.org/r/20110811110229.19900.63019.stgit@fedora15
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Arnaldo Carvalho de Melo

    Masami Hiramatsu
     
  • A file in /tmp/ might be a symlink, so lstat() should be used instead of
    stat().

    Acked-by: Pekka Enberg
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Pekka Enberg
    Cc: Peter Zijlstra
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110811205537.GA22864@albatros
    Signed-off-by: Vasiliy Kulikov
    Signed-off-by: Arnaldo Carvalho de Melo

    Vasiliy Kulikov
     

11 Aug, 2011

1 commit

  • If we bring the recorded perf data together with kernel binary from another
    machine using:

    on server A:
    perf archive

    on server B:
    tar xjvf perf.data.tar.bz2 -C ~/.debug

    the build_id kernel dso is not properly recognized during the "perf report"
    command on server B.

    The reason is, that build_id dsos are added during the session initialization,
    while the kernel maps are created during the sample event processing.

    The machine__create_kernel_maps functions ends up creating new dso object for
    kernel, but it does not check if we already have one added by build_id
    processing.

    Also the build_id reading ABI quirk added in commit:

    - commit b25114817a73bbd2b84ce9dba02ee1ef8989a947
    perf build-id: Add quirk to deal with perf.data file format breakage

    populates the "struct build_id_event::pid" with 0, which
    is later interpreted as DEFAULT_GUEST_KERNEL_ID.

    This is not always correct, so it's better to guess the pid
    value based on the "struct build_id_event::header::misc" value.

    - Tested with data generated on x86 kernel version v2.6.34
    and reported back on x86_64 current kernel.
    - Not tested for guest kernel case.

    Note the problem stays for PERF_RECORD_MMAP events recorded by perf that
    does not use proper pid (HOST_KERNEL_ID/DEFAULT_GUEST_KERNEL_ID). They are
    misinterpreted within the current perf code. Probably there's not much we
    can do about that.

    Cc: Avi Kivity
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Yanmin Zhang
    Link: http://lkml.kernel.org/r/20110601194346.GB1934@jolsa.brq.redhat.com
    Signed-off-by: Jiri Olsa
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

10 Aug, 2011

5 commits


09 Aug, 2011

2 commits


08 Aug, 2011

4 commits

  • Adding install-python_ext target to install python extension related
    files. Installation directory is governed by python distutils package
    and follows the DESTDIR variable settings.

    Also moving python extension build output into '$(O)python_ext_build'
    directory and making it configurable via PYTHON_EXTBUILD variable.

    Keeping the '$(O)python/perf.so' file, so it could be used for testing
    as of until now.

    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110722113307.GA1931@jolsa.brq.redhat.com
    Signed-off-by: Jiri Olsa
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • In addition to /etc/perfconfig and $HOME/.perfconfig, perf looks for
    configuration in the file ./config, imitating git which looks at
    $GIT_DIR/config. If ./config is not a perf configuration file, it
    fails, or worse, treats it as a configuration file and changes behavior
    in some unexpected way.

    "config" is not an unusual name for a file to be lying around and perf
    does not have a private directory dedicated for its own use, so let's
    just stop looking for configuration in the cwd. Callers needing
    context-sensitive configuration can use the PERF_CONFIG environment
    variable.

    Requested-by: Christian Ohm
    Cc: 632923@bugs.debian.org
    Cc: Ben Hutchings
    Cc: Christian Ohm
    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110805165838.GA7237@elie.gateway.2wire.net
    Signed-off-by: Jonathan Nieder
    Signed-off-by: Arnaldo Carvalho de Melo

    Jonathan Nieder
     
  • Use LIB_OBJS and BUILTIN_OBJS for .o files.

    LIB_FILE is already prefixed with OUTPUT.

    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/20110807083932.9C0E514C03B@msa103.auone-net.jp
    Signed-off-by: Kusanagi Kouichi
    Signed-off-by: Arnaldo Carvalho de Melo

    Kusanagi Kouichi
     
  • Looks to me like the :r modifier is not supported anymore, so remove it
    from the list of events. Without this fix 'perf lock record' doesn't
    work.

    Cc: Ingo Molnar
    Cc: Paul Mackerras
    Cc: Zhu Yanhai
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1312035232-9534-1-git-send-email-gaoyang.zyh@taobao.com
    Signed-off-by: Zhu Yanhai
    Signed-off-by: Arnaldo Carvalho de Melo

    Zhu Yanhai