24 Aug, 2011
1 commit
-
Function i5k_channel_pci_id looks like it can fail, while a better
code design would make it more obvious that it can't. We can even get
rid of the function.Signed-off-by: Jean Delvare
Acked-by: Darrick J. Wong
Signed-off-by: Guenter Roeck
23 Aug, 2011
1 commit
-
Replace unnecessary if with else statement.
This fixes the following (false) compile warning reported with some combinations
of C compiler version and configuration.drivers/hwmon/ntc_thermistor.c: In function 'ntc_show_temp':
drivers/hwmon/ntc_thermistor.c:225: warning: 'low' may be used uninitialized in
this function
drivers/hwmon/ntc_thermistor.c:225: note: 'low' was declared here
drivers/hwmon/ntc_thermistor.c:225: warning: 'high' may be used uninitialized in
this function
drivers/hwmon/ntc_thermistor.c:225: note: 'high' was declared here
drivers/hwmon/ntc_thermistor.c:294: warning: 'temp' may be used uninitialized in
this functionSigned-off-by: Guenter Roeck
Acked-by: Jean Delvare
12 Aug, 2011
3 commits
-
rs_resp is dynamically allocated in aem_read_sensor(), so it should be freed
before exiting in every case. This collects the kfree and the return at
the end of the function.Signed-off-by: Julia Lawall
Signed-off-by: Guenter Roeck
Cc: stable@kernel.org # 2.6.27+ -
pmbus_clear_faults() attempts to clear faults on non-existing real pages.
As a result, the command error bit in the status register is set, and faults
are not really cleared.All byte writes to non-zero pages are requests to clear the status register
on that page. Since non-zero pages are virtual and do not exist on the chip,
there is nothing to do, and such requests have to be ignored. This fixes
above problem.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
With virtual pages and to be able to handle more chips, it is necessary to
virtualise pmbus_write_byte().Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson
31 Jul, 2011
1 commit
-
* 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging: (24 commits)
hwmon: (lm90) Refactor reading of config2 register
hwmon: (lm90) Make SA56004 detection more robust
hwmon: (lm90) Simplify handling of extended local temp register
hwmon: (pmbus) Add client driver for LM25066, LM5064, and LM5066
hwmon: (max34440) Add support for peak attributes
hwmon: (max8688) Add support for peak attributes
hwmon: (max16064) Add support for peak attributes
hwmon: (adm1275) Add support for peak attributes
hwmon: (pmbus) Add support for peak attributes
hwmon: Add new attributes to sysfs ABI
hwmon: (pmbus) Strengthen check for status register existence
hwmon: (pmbus) Add support for virtual pages
hwmon: (pmbus) Support reading and writing of word registers in device specific code
hwmon: (pmbus) Increase attribute name size
hwmon: (pmbus) Add ADP4000, NCP4200 and NCP4208 to list of supported devices
hwmon: (pmbus) Add support for VID output voltage mode
hwmon: (pmbus) Move PMBus drivers to drivers/hwmon/pmbus
hwmon: (coretemp) Add core/pkg threshold support to Coretemp
hwmon: (lm95241) Add support for LM95231
hwmon: LM95245 driver
...
29 Jul, 2011
16 commits
-
Several vendors implement a second configuration register, which we
check during device detection. Refactor the code to avoid duplication.Signed-off-by: Jean Delvare
Cc: Stijn Devriendt
Cc: Guenter Roeck
Signed-off-by: Guenter Roeck -
With a device ID register value of 0, the SA56004 detection is rather
weak. Check several other register too to confirm the detection, as we
do for other supported devices.Signed-off-by: Jean Delvare
Cc: Stijn Devriendt
Cc: Guenter Roeck
Acked-by: Stijn Devriendt
Signed-off-by: Guenter Roeck -
The optional extended local temperature register can never have
address 0, as this address is already used by another register. Thus
we can get rid of flag LM90_HAVE_LOCAL_EXT and simply rely on
reg_local_ext being non-zero to determine if a given chip has this
extension or not. This makes the code more simple.Signed-off-by: Jean Delvare
Cc: Stijn Devriendt
Cc: Guenter Roeck
Signed-off-by: Guenter Roeck -
PMBus client driver supporting National Semiconductor LM25066, LM5064, and LM5066.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage, current, and temperature peak (historic maximum)
attributes.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage, current, and temperature peak (historic maximum)
attributes.Signed-off-by: Guenter Roeck
-
Add support for voltage and temperature peak (historic maximum) attributes.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage and current peak (historic maximum) attributes.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Most PMBus devices provide manufacturer specific commands to read low and/or
high peak values for some or all of its sensors.To support providing those values as lowest/highest attributes to the user,
introduce virtual PMBus commands. Those commands reside outside the normal
command set and have to be implemented in device specific code, which map the
virtual commands to device specific commands.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
With virtual register page support, it is now possible that the status register
on virtual pages does not exist or is itself virtual. To take this into account
when creating alarm attributes, generate those attributes only if the status
register on the respective page is known to exist.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some PMBus chips have non-standard sensor registers. An easy way to
support such sensors is to introduce virtual pages and map the non-standard
registers into standard registers on an extra page.For this to work, the code verifying if the configured number of pages exists
has to be removed. Since a wrong number of pages can only be configured in a
front-end driver, this should not have a practical impact since the resulting
errors should be found during development and testing.Also, functions to read the chip status while checking if a command register
exists must be modified to no longer set the page register before reading the
status, since the physical page associated with the checked register may not
exist. This does not make a functional difference since the page was already set
when the attempt to read the register was made.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some PMBus devices use non-standard registers for some of the sensors and/or
limits. To support such devices, add code to support reading and writing of word
size registers in device specific code.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some hwmon sysfs attributes have a length of 20 bytes (plus terminating 0).
I2C_NAME_SIZE is defined as 20 and thus can not be used to define the length
of hwmon sysfs attributes. Replace it with PMBUS_NAME_SIZE, set to 24.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add ADP4000, NCP4200 and NCP4208 to the list of devices supported by the generic
PMBus driver, and add device IDs to enable explicit instantiation.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson
Acked-by: Jean Delvare -
In VID mode, output voltages are measured and reported as VID values, and
have to be converted to voltages using VID conversion tables or functions.
Support is added for VR11 only at this time.This patch enables support for PMBus devices supporting VID VR11 based output
voltage selection such as NCP4200 and NCP4208.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Since the number of PMBus drivers is getting large, move them into
directory drivers/hwmon/pmbus to improve readability and scalability.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson
28 Jul, 2011
7 commits
-
This patch adds the core and pkg support to coretemp.
These thresholds can be configured via the sysfs interfaces tempX_max
and tempX_max_hyst. An interrupt is generated when CPU temperature reaches
or crosses above tempX_max OR drops below tempX_max_hyst.This patch is based on the documentation in IA Manual vol 3A, that can be
downloaded from here:
http://download.intel.com/design/processor/manuals/253668.pdfSigned-off-by: Durgadoss R
Signed-off-by: Guenter Roeck -
LM95231 is fully compatible to LM95241; only necessary change is to add
chip detection.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare -
A hwmon driver for the National Semiconductor LM95245 dual temperature
sensors chip.Signed-off-by: Alexander Stein
Signed-off-by: Guenter Roeck -
Add support for Philips SA56004, an LM86 compatible temperature sensor.
Signed-off-by: Stijn Devriendt
Signed-off-by: Guenter Roeck -
Add support for NTC Thermistor series. In this release, the
following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473,
and NCP15WL333. This driver is based on the datasheet of MURATA.The driver in the patch does conversion from the raw ADC value
(either voltage or resistence) to temperature. In order to use
voltage values as input, the circuit schematics should be provided
with the platform data. A compensation table for each type of thermistor
is provided for the conversion.Signed-off-by: Donggeun Kim
Signed-off-by: MyungJoo Ham
Signed-off-by: KyungMin Park
Reviewed-by: Shubhrajyoti D
Signed-off-by: Guenter Roeck -
MAX1668 and compatibles have several external temperature sensors, but only a
single FAULT status bit. If a fault occurs, the temperature reported on the
affected sensors is 127 degrees C. Use this knowledge to report fault on
external sensors.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare -
This patch adds support for MAX1668 and compatible temperature sensors.
Signed-off-by: David George
[guenter.roeck@ericsson.com: minor cleanup of probe error path]
Signed-off-by: Guenter Roeck
27 Jul, 2011
1 commit
-
This allows us to move duplicated code in
(atomic_inc_not_zero() for now) toSigned-off-by: Arun Sharma
Reviewed-by: Eric Dumazet
Cc: Ingo Molnar
Cc: David Miller
Cc: Eric Dumazet
Acked-by: Mike Frysinger
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
26 Jul, 2011
10 commits
-
* 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging:
hwmon: (lm78) Become the maintainer
hwmon: (lm78) Make ISA interface depend on CONFIG_ISA
hwmon: (lm78) Avoid forward declarations
hwmon: (sht15) Correct a comment mistake
hwmon: (max1111) Avoid extra memory allocations
hwmon: (it87) Add chassis intrusion detection support
hwmon: (via-cputemp) Add VID reporting support
hwmon-vid: Add support for VIA family 6 model D CPU
hwmon: New driver sch5636
hwmon: (sch5627) Factor out some code shared with sch5636 driver -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
fs: Merge split strings
treewide: fix potentially dangerous trailing ';' in #defined values/expressions
uwb: Fix misspelling of neighbourhood in comment
net, netfilter: Remove redundant goto in ebt_ulog_packet
trivial: don't touch files that are removed in the staging tree
lib/vsprintf: replace link to Draft by final RFC number
doc: Kconfig: `to be' -> `be'
doc: Kconfig: Typo: square -> squared
doc: Konfig: Documentation/power/{pm => apm-acpi}.txt
drivers/net: static should be at beginning of declaration
drivers/media: static should be at beginning of declaration
drivers/i2c: static should be at beginning of declaration
XTENSA: static should be at beginning of declaration
SH: static should be at beginning of declaration
MIPS: static should be at beginning of declaration
ARM: static should be at beginning of declaration
rcu: treewide: Do not use rcu_read_lock_held when calling rcu_dereference_check
Update my e-mail address
PCIe ASPM: forcedly -> forcibly
gma500: push through device driver tree
...Fix up trivial conflicts:
- arch/arm/mach-ep93xx/dma-m2p.c (deleted)
- drivers/gpio/gpio-ep93xx.c (renamed and context nearby)
- drivers/net/r8169.c (just context changes) -
Declare myself the maintainer of the lm78 driver. I still have a
running system with one of these chips.Also count myself as a co-author of the driver. With 34 commits over
6 years, it seems fair.Signed-off-by: Jean Delvare
-
We should only include support for the ISA interface of the LM78/LM79
if CONFIG_ISA is set. Not only this makes the driver somewhat smaller
on most architectures, but this also avoids poking at random I/O
ports on these architectures.This is very similiar to what was done for the w83781d driver in
October 2008.Signed-off-by: Jean Delvare
Cc: Dean Nelson -
Move code around to avoid several forward declarations. Also group
ISA-related functions together, to make future changes easier.Signed-off-by: Jean Delvare
Cc: Dean Nelson -
sht15_store_heater() is called on _write_ access to heater_enable.
Signed-off-by: Vivien Didelot
Signed-off-by: Jean Delvare -
We can allocate the tx and rx buffers as part of our data structure.
Doing so is faster and spares memory.Signed-off-by: Jean Delvare
Tested-by: Stanislav Brabec -
Add chassis intrusion detection support for all supported devices,
using the standard interface.Signed-off-by: Jean Delvare
-
At least VIA family 6 model D CPU report the VID settings in a MSR,
so expose the value to user-space. Not sure about model A.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Tested-by: Jeff Rickman -
The VIA family 6 model D CPU (C7-D, Eden 90 nm) can use two different
VID tables, we have to check the value of a MSR to decide which one to
use.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Tested-by: Jeff Rickman
