13 Apr, 2012

22 commits

  • commit 2a15cd2ff488a9fdb55e5e34060f499853b27c77 upstream.

    With runtime PM, if the ethernet cable is disconnected, the device is
    transitioned to D3 state to conserve energy. If the system is shutdown
    in this state, any register accesses in rtl_shutdown are dropped on
    the floor. As the device was programmed by .runtime_suspend() to wake
    on link changes, it is thus brought back up as soon as the link recovers.

    Resuming every suspended device through the driver core would slow things
    down and it is not clear how many devices really need it now.

    Original report and D0 transition patch by Sameer Nanda. Patch has been
    changed to comply with advices by Rafael J. Wysocki and the PM folks.

    Reported-by: Sameer Nanda
    Signed-off-by: Francois Romieu
    Cc: Rafael J. Wysocki
    Cc: Hayes Wang
    Cc: Alan Stern
    Acked-by: Rafael J. Wysocki
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    françois romieu
     
  • commit 25e341cfc33d94435472983825163e97fe370a6c upstream.

    Somehow the BIOS manages to screw things up when copying the VBT
    around, because the one we scrap from the VBIOS rom actually works.

    Tested-by: Markus Heinz
    Acked-by: Chris Wilson
    Reviewed-by: Rodrigo Vivi
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=28812
    Signed-Off-by: Daniel Vetter
    Signed-off-by: Greg Kroah-Hartman

    Daniel Vetter
     
  • commit 927a2f119e8235238a2fc64871051b16c9bdae75 upstream.

    i915_drm_thaw was not locking the mode_config lock when calling
    drm_helper_resume_force_mode. When there were multiple wake sources,
    this caused FDI training failure on SNB which in turn corrupted the
    display.

    Signed-off-by: Sean Paul
    Reviewed-by: Chris Wilson
    Signed-Off-by: Daniel Vetter
    Signed-off-by: Greg Kroah-Hartman

    Sean Paul
     
  • commit f47166d2b0001fcb752b40c5a2d4db986dfbea68 upstream.

    Quoting the BSpec from time immemorial:

    PIPEACONF, bits 28:27: Frame Start Delay (Debug)

    Used to delay the frame start signal that is sent to the display planes.
    Care must be taken to insure that there are enough lines during VBLANK
    to support this setting.

    An instance of the BIOS leaving these bits set was found in the wild,
    where it caused our modesetting to go all squiffy and skewiff.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47271
    Reported-and-tested-by: Eva Wang
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43012
    Reported-and-tested-by: Carl Richell
    Signed-off-by: Chris Wilson
    Signed-off-by: Daniel Vetter
    Signed-off-by: Greg Kroah-Hartman

    Chris Wilson
     
  • commit 97effadb65ed08809e1720c8d3ee80b73a93665c upstream.

    This hardware doesn't have an LVDS, it's a desktop box. Fix incorrect
    LVDS detection.

    Signed-off-by: Anisse Astier
    Acked-by: Chris Wilson
    Signed-off-by: Daniel Vetter
    Signed-off-by: Greg Kroah-Hartman

    Anisse Astier
     
  • commit 402976fe51b2d1a58a29ba06fa1ca5ace3a4cdcd upstream.

    On pre-R600 asics, the SpeedFanControl table is not
    executed as part of ASIC_Init as it is on newer asics.

    Fixes:
    https://bugzilla.kernel.org/show_bug.cgi?id=29412

    Signed-off-by: Alex Deucher
    Reviewed-by: Michel Dänzer
    Signed-off-by: Dave Airlie
    Signed-off-by: Greg Kroah-Hartman

    Alex Deucher
     
  • commit 62fb376e214d3c1bfdf6fbb77dac162f6da04d7e upstream.

    mplayer -vo fbdev tries to create a screen that is twice as tall as the
    allocated framebuffer for "doublebuffering". By default, and all in-tree
    users, only sufficient memory is allocated and mapped to satisfy the
    smallest framebuffer and the virtual size is no larger than the actual.
    For these users, we should therefore reject any userspace request to
    create a screen that requires a buffer larger than the framebuffer
    originally allocated.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=38138
    Signed-off-by: Chris Wilson
    Reviewed-by: Daniel Vetter
    Signed-off-by: Dave Airlie
    Signed-off-by: Greg Kroah-Hartman

    Chris Wilson
     
  • commit 643c61e119459e9d750087b7b34be94491efebf9 upstream.

    In https://bugzilla.redhat.com/show_bug.cgi?id=770207, slowdowns of driver
    rtl8192ce are reported. One fix (commit a9b89e2) has already been applied,
    and it helped, but the maximum RX speed would still drop to 1 Mbps. As in
    the previous fix, the initial gain was determined to be the problem; however,
    the problem arises from a setting of the gain when scans are started.

    Driver rtl8192de also has the same code structure - this one is fixed as well.

    Reported-and-Tested-by: Ivan Pesin
    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville
    Signed-off-by: Greg Kroah-Hartman

    Larry Finger
     
  • commit 3e80acd1af40fcd91a200b0416a7616b20c5d647 upstream.

    commit 64b3db22c04586997ab4be46dd5a5b99f8a2d390 (2.6.39),
    "Remove use of unreliable FADT revision field" causes regression
    for old P4 systems because now cst_control and other fields are
    not reset to 0.

    The effect is that acpi_processor_power_init will notice
    cst_control != 0 and a write to CST_CNT register is performed
    that should not happen. As result, the system oopses after the
    "No _CST, giving up" message, sometimes in acpi_ns_internalize_name,
    sometimes in acpi_ns_get_type, usually at random places. May be
    during migration to CPU 1 in acpi_processor_get_throttling.

    Every one of these settings help to avoid this problem:
    - acpi=off
    - processor.nocst=1
    - maxcpus=1

    The fix is to update acpi_gbl_FADT.header.length after
    the original value is used to check for old revisions.

    https://bugzilla.kernel.org/show_bug.cgi?id=42700
    https://bugzilla.redhat.com/show_bug.cgi?id=727865

    Signed-off-by: Julian Anastasov
    Acked-by: Bob Moore
    Signed-off-by: Len Brown
    Cc: Jonathan Nieder
    Cc: Josh Boyer
    Signed-off-by: Greg Kroah-Hartman

    Julian Anastasov
     
  • commit 89e96ada572fb216e582dbe3f64e1a6939a37f74 upstream.

    During testing pci root bus removal, found some root bus bridge is not freed.
    If booting with pnpacpi=off, those hostbridge could be freed without problem.
    It turns out that some devices reference are not released during acpi_pnp_match.
    that match should not hold one device ref during every calling.
    Add pu_device calling before returning.

    Signed-off-by: Yinghai Lu
    Signed-off-by: Len Brown
    Signed-off-by: Greg Kroah-Hartman

    Yinghai Lu
     
  • commit 2815ab92ba3ab27556212cc306288dc95692824b upstream.

    On Intel CPUs the processor typically uses the highest frequency
    set by any logical CPU. When the system overheats
    Linux first forces the frequency to the lowest available one
    to lower the temperature.

    However this was done only per logical CPU, which means all
    logical CPUs in a package would need to go through this before
    the frequency is actually lowered.

    Worse this delay actually prevents real throttling, because
    the real throttle code only proceeds when the lowest frequency
    is already reached.

    So when a throttle event happens force the lowest frequency
    for all CPUs in the package where it happened. The per CPU
    state is now kept per package, not per logical CPU. An alternative
    would be to do it per cpufreq unit, but since we want to bring
    down the temperature of the complete chip it's better
    to do it for all.

    In principle it may even make sense to do it for all CPUs,
    but I kept it on the package for now.

    With this change the frequency is actually lowered, which
    in terms also allows real throttling to proceed.

    I also removed an unnecessary per cpu variable initialization.

    v2: Fix package mapping

    Signed-off-by: Andi Kleen
    Signed-off-by: Len Brown
    Signed-off-by: Greg Kroah-Hartman

    Andi Kleen
     
  • commit b54f47c8bcfc5f766bf13ec31bd7dd1d4726d33b upstream.

    Using UBI on m25p80 can give messages like:

    UBI error: io_init: bad write buffer size 0 for 1 min. I/O unit

    We need to initialize writebufsize; I think "page_size" is the correct
    "bufsize", although I'm not sure. Comments?

    Signed-off-by: Brian Norris
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Brian Norris
     
  • commit fcc44a07dae0af16e84e93425fc8afe642ddc603 upstream.

    The writebufsize concept was introduce by commit
    "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
    the maximum amount of data the device writes to the media at a time. This is
    an important parameter for UBIFS which is used during recovery and which
    basically defines how big a corruption caused by a power cut can be.

    Set writebufsize to 4 because this drivers writes at max 4 bytes at a time.

    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Artem Bityutskiy
     
  • commit b604387411ec6a072e95910099262616edd2bd2f upstream.

    The writebufsize concept was introduce by commit
    "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
    the maximum amount of data the device writes to the media at a time. This is
    an important parameter for UBIFS which is used during recovery and which
    basically defines how big a corruption caused by a power cut can be.

    However, we forgot to set this parameter for block2mtd. Set it to PAGE_SIZE
    because this is actually the amount of data we write at a time.

    Signed-off-by: Artem Bityutskiy
    Acked-by: Joern Engel
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Artem Bityutskiy
     
  • commit c4cc625ea5958d065c21cc0fcea29e9ed8f3d2bc upstream.

    The writebufsize concept was introduce by commit
    "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
    the maximum amount of data the device writes to the media at a time. This is
    an important parameter for UBIFS which is used during recovery and which
    basically defines how big a corruption caused by a power cut can be.

    Set writebufsize to the flash page size because it is the maximum amount of
    data it writes at a time.

    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Artem Bityutskiy
     
  • commit 5289966ea576a062b80319975b31b661c196ff9d upstream.

    This has been moved from .options to .bbt_options meanwhile. So, it
    currently checks for something totally different (NAND_OWN_BUFFERS) and
    decides according to that.

    Artem Bityutskiy: the options were moved in
    a40f734 mtd: nand: consolidate redundant flash-based BBT flags

    Artem Bityutskiy: CCing -stable

    Signed-off-by: Wolfram Sang
    Acked-by: Huang Shijie
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Wolfram Sang
     
  • commit bf011f2ed53d587fdd8148c173c4f09ed77bdf1a upstream.

    Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
    command line parsing of MTD partitions does not work anymore.

    Signed-off-by: Daniel Schwierzeck
    Signed-off-by: John Crispin
    Signed-off-by: Artem Bityutskiy
    Acked-by: John Crispin
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Daniel Schwierzeck
     
  • commit a3c1e3b732b3708a80e4035b9d845f3f7c7dd0c9 upstream.

    In commit "c797533 mtd: abstract last MTD partition parser argument" the
    third argument of "mtd_device_parse_register()" changed from start address
    of the MTD device to a pointer to a struct.

    The "ixp4xx_flash_probe()" function was not converted properly, causing
    an oops during boot.

    This patch fixes the problem by filling the needed information into a
    "struct mtd_part_parser_data" and passing it to
    "mtd_device_parse_register()".

    Signed-off-by: Marc Kleine-Budde
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Signed-off-by: Greg Kroah-Hartman

    Marc Kleine-Budde
     
  • [ Upstream commit 464b57da56910c8737ede75ad820b9a7afc46b3e ]

    The merge done in commit b26e478f undid bug fix in commit c3e072f8
    ("net: fsl_pq_mdio: fix non tbi phy access"), with the result that non
    TBI (e.g. MDIO) PHYs cannot be accessed.

    Signed-off-by: Kenth Eriksson
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    Kenth Eriksson
     
  • [ Upstream commit 78fb72f7936c01d5b426c03a691eca082b03f2b9 ]

    Make CDC EEM recalculate the hard_mtu after adjusting the
    hard_header_len.

    Without this, usbnet adjusts the MTU down to 1494 bytes, and the host is
    unable to receive standard 1500-byte frames from the device.

    Tested with the Linux USB Ethernet gadget.

    Cc: Oliver Neukum
    Signed-off-by: Rabin Vincent
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    Rabin Vincent
     
  • [ Upstream commit 2240eb4ae3dc4acff20d1a8947c441c451513e37 ]

    This patch corrects a bug in function sky2_open() of the Marvell Yukon 2 driver
    in which the settings for PHY quick link are overwritten.

    Signed-off-by: Lino Sanfilippo
    Acked-by: Stephen Hemminger
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    Lino Sanfilippo
     
  • [ Upstream commit 085f1afc56619bda424941412fdeaff1e32c21dc ]

    If port 0 of a 5717 serdes device powers down, it hides the phy from
    port 1. This patch works around the problem by keeping port 0's phy
    powered up.

    Signed-off-by: Matt Carlson
    Signed-off-by: Michael Chan
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    Matt Carlson
     

03 Apr, 2012

18 commits

  • commit c9651e70ad0aa499814817cbf3cc1d0b806ed3a1 upstream.

    Since 3.2.12 and 3.3, some systems are failing to boot with a BUG_ON.
    Some other systems using the pata_jmicron driver fail to boot because no
    disks are detected. Passing pcie_aspm=force on the kernel command line
    works around it.

    The cause: commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking when
    ASPM is disabled") changed the behaviour of pcie_aspm_sanity_check() to
    always return 0 if aspm is disabled, in order to avoid cases where we
    changed ASPM state on pre-PCIe 1.1 devices.

    This skipped the secondary function of pcie_aspm_sanity_check which was
    to avoid us enabling ASPM on devices that had non-PCIe children, causing
    trouble later on. Move the aspm_disabled check so we continue to honour
    that scenario.

    Addresses https://bugzilla.kernel.org/show_bug.cgi?id=42979 and
    http://bugs.debian.org/665420

    Reported-by: Romain Francoise # kernel panic
    Reported-by: Chris Holland # disk detection trouble
    Signed-off-by: Matthew Garrett
    Tested-by: Hatem Masmoudi # Dell Latitude E5520
    Tested-by: janek # pata_jmicron with JMB362/JMB363
    [jn: with more symptoms in log message]
    Signed-off-by: Jonathan Nieder
    Signed-off-by: Linus Torvalds
    Signed-off-by: Greg Kroah-Hartman

    Matthew Garrett
     
  • commit 49d4bcaddca977fffdea8b0b71f6e5da96dac78e upstream.

    When DMA is enabled, sh-sci transfer begins with
    uart_start()
    sci_start_tx()
    if (cookie_tx < 0) schedule_work()
    Then, starts DMA when wq scheduled, -- (A)
    process_one_work()
    work_fn_rx()
    cookie_tx = desc->submit_tx()
    And finishes when DMA transfer ends, -- (B)
    sci_dma_tx_complete()
    async_tx_ack()
    cookie_tx = -EINVAL
    (possible another schedule_work())

    This A to B sequence is not reentrant, since controlling variables
    (for example, cookie_tx above) are not queues nor lists. So, they
    must be invoked as A B A B..., otherwise results in kernel crash.

    To ensure the sequence, sci_start_tx() seems to test if cookie_tx < 0
    (represents "not used") to call schedule_work().
    But cookie_tx will not be set (to a cookie, also means "used") until
    in the middle of work queue scheduled function work_fn_tx().

    This gap between the test and set allows the breakage of the sequence
    under the very frequently call of uart_start().
    Another gap between async_tx_ack() and another schedule_work() results
    in the same issue, too.

    This patch introduces a new condition "cookie_tx == 0" just to mark
    it is "busy" and assign it within spin-locked region to fill the gaps.

    Signed-off-by: Takashi Yoshii
    Reviewed-by: Guennadi Liakhovetski
    Signed-off-by: Paul Mundt
    Signed-off-by: Greg Kroah-Hartman

    Yoshii Takashi
     
  • commit 4a649903f91232d02284d53724b0a45728111767 upstream.

    Richard Weinberger noticed that on some RTC hardware that
    doesn't support UIE mode, due to coarse granular alarms
    (like 1minute resolution), the current virtualized RTC
    support doesn't properly error out when UIE is enabled.

    Instead the current code queues an alarm for the next second,
    but it won't fire until up to a miniute later.

    This patch provides a generic way to flag this sort of hardware
    and fixes the issue on the mpc5121 where Richard noticed the
    problem.

    Reported-by: Richard Weinberger
    Tested-by: Richard Weinberger
    Signed-off-by: John Stultz
    Signed-off-by: Greg Kroah-Hartman

    John Stultz
     
  • [ Upstream commit 5676cc7bfe1e388e87843f71daa229610385b41e ]

    Some BIOS's don't setup power management correctly (what else is
    new) and don't allow use of PCI Express power control. Add a special
    exception module parameter to allow working around this issue.
    Based on slightly different patch by Knut Petersen.

    Reported-by: Arkadiusz Miskiewicz
    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller
    Signed-off-by: Greg Kroah-Hartman

    stephen hemminger
     
  • commit 3fa016a0b5c5237e9c387fc3249592b2cb5391c6 upstream.

    Looking at hibernate overwriting I though it looked like a cursor,
    so I tracked down this missing piece to stop the cursor blink
    timer. I've no idea if this is sufficient to fix the hibernate
    problems people are seeing, but please test it.

    Both radeon and nouveau have done this for a long time.

    I've run this personally all night hib/resume cycles with no fails.

    Reviewed-by: Keith Packard
    Reported-by: Petr Tesarik
    Reported-by: Stanislaw Gruszka
    Reported-by: Lots of misc segfaults after hibernate across the world.
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=37142
    Tested-by: Dave Airlie
    Tested-by: Bojan Smojver
    Tested-by: Andreas Hartmann
    Signed-off-by: Dave Airlie
    Signed-off-by: Greg Kroah-Hartman

    Dave Airlie
     
  • commit fa0fb93f2ac308a76fa64eb57c18511dadf97089 upstream.

    For high-speed/super-speed isochronous endpoints, the bInterval
    value is used as exponent, 2^(bInterval-1). Luckily we have
    usb_fill_int_urb() function that handles it correctly. So we just
    call this function to fill in the RX URB.

    Cc: Marcel Holtmann
    Signed-off-by: Bing Zhao
    Acked-by: Marcel Holtmann
    Signed-off-by: Gustavo F. Padovan
    Signed-off-by: Greg Kroah-Hartman

    Bing Zhao
     
  • commit 8da00edc1069f01c34510fa405dc15d96c090a3f upstream.

    Fix typo in drivers/video/backlight/tosa_lcd.c
    "tosa_lcd_reume" should be "tosa_lcd_resume".

    Signed-off-by: Masanari Iida
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds
    Signed-off-by: Greg Kroah-Hartman

    Masanari Iida
     
  • commit 6f94a4c45a6f744383f9f695dde019998db3df55 upstream.

    Avoid using the bi_next field for the holder of a cell when deferring
    bios because a stacked device below might change it. Store the
    holder in a new field in struct cell instead.

    When a cell is created, the bio that triggered creation (the holder) was
    added to the same bio list as subsequent bios. In some cases we pass
    this holder bio directly to devices underneath. If those devices use
    the bi_next field there will be trouble...

    This also simplifies some code that had to work out which bio was the
    holder.

    Signed-off-by: Joe Thornber
    Signed-off-by: Mike Snitzer
    Signed-off-by: Alasdair G Kergon
    Signed-off-by: Greg Kroah-Hartman

    Joe Thornber
     
  • commit b0988900bae9ecf968a8a8d086a9eec671a9517a upstream.

    When we remove an entry from a node we sometimes rebalance with it's
    two neighbours. This wasn't being done correctly; in some cases
    entries have to move all the way from the right neighbour to the left
    neighbour, or vice versa. This patch pretty much re-writes the
    balancing code to fix it.

    This code is barely used currently; only when you delete a thin
    device, and then only if you have hundreds of them in the same pool.
    Once we have discard support, which removes mappings, this will be used
    much more heavily.

    Signed-off-by: Joe Thornber
    Signed-off-by: Mike Snitzer
    Signed-off-by: Alasdair G Kergon
    Signed-off-by: Greg Kroah-Hartman

    Joe Thornber
     
  • commit aadbe266f2f89ccc68b52f4effc7b3a8b29521ef upstream.

    Call the correct exit function on failure in dm_exception_store_init.

    Signed-off-by: Andrei Warkentin
    Acked-by: Mike Snitzer
    Signed-off-by: Alasdair G Kergon
    Signed-off-by: Greg Kroah-Hartman

    Andrei Warkentin
     
  • commit 72c6e7afc43e19f68a31dea204fc366624d6eee9 upstream.

    Always set io->error to -EIO when an error is detected in dm-crypt.

    There were cases where an error code would be set only if we finish
    processing the last sector. If there were other encryption operations in
    flight, the error would be ignored and bio would be returned with
    success as if no error happened.

    This bug is present in kcryptd_crypt_write_convert, kcryptd_crypt_read_convert
    and kcryptd_async_done.

    Signed-off-by: Mikulas Patocka
    Reviewed-by: Milan Broz
    Signed-off-by: Alasdair G Kergon
    Signed-off-by: Greg Kroah-Hartman

    Mikulas Patocka
     
  • commit aeb2deae2660a1773c83d3c6e9e6575daa3855d6 upstream.

    This patch fixes a possible deadlock in dm-crypt's mempool use.

    Currently, dm-crypt reserves a mempool of MIN_BIO_PAGES reserved pages.
    It allocates first MIN_BIO_PAGES with non-failing allocation (the allocation
    cannot fail and waits until the mempool is refilled). Further pages are
    allocated with different gfp flags that allow failing.

    Because allocations may be done in parallel, this code can deadlock. Example:
    There are two processes, each tries to allocate MIN_BIO_PAGES and the processes
    run simultaneously.
    It may end up in a situation where each process allocates (MIN_BIO_PAGES / 2)
    pages. The mempool is exhausted. Each process waits for more pages to be freed
    to the mempool, which never happens.

    To avoid this deadlock scenario, this patch changes the code so that only
    the first page is allocated with non-failing gfp mask. Allocation of further
    pages may fail.

    Signed-off-by: Mikulas Patocka
    Signed-off-by: Milan Broz
    Signed-off-by: Alasdair G Kergon
    Signed-off-by: Greg Kroah-Hartman

    Mikulas Patocka
     
  • commit 81b279d80a63628e580c71a31d30a8c3b3047ad4 upstream.

    Unbanked GPIO IRQ handling code made a copy of just
    the irq_chip structure for GPIO IRQ lines which caused
    problems after the generic IRQ chip conversion because
    there was no valid irq_chip_type structure with the
    right "regs" populated. irq_gc_mask_set_bit() was
    therefore accessing random addresses.

    Fix it by making a copy of irq_chip_type structure
    instead. This will ensure sane register offsets.

    Reported-by: Jon Povey
    Tested-by: Jon Povey
    Signed-off-by: Sekhar Nori
    Signed-off-by: Grant Likely
    Signed-off-by: Greg Kroah-Hartman

    Sekhar Nori
     
  • commit ab2dde9924dd1ddb791fa8b14aa52e1df681e20c upstream.

    Unbanked GPIO irq setup code was overwriting chip_data leading
    to the following oops on request_irq()

    Unable to handle kernel paging request at virtual address febfffff
    pgd = c22dc000
    [febfffff] *pgd=00000000
    Internal error: Oops: 801 [#1] PREEMPT
    Modules linked in: mcu(+) edmak irqk cmemk
    CPU: 0 Not tainted (3.0.0-rc7+ #93)
    PC is at irq_gc_mask_set_bit+0x68/0x7c
    LR is at vprintk+0x22c/0x484
    pc : [] lr : [] psr: 60000093
    sp : c33e3ba0 ip : c33e3af0 fp : c33e3bc4
    r10: c04555bc r9 : c33d4340 r8 : 60000013
    r7 : 0000002d r6 : c04555bc r5 : fec67010 r4 : 00000000
    r3 : c04734c8 r2 : fec00000 r1 : ffffffff r0 : 00000026
    Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user
    Control: 0005317f Table: 822dc000 DAC: 00000015
    Process modprobe (pid: 526, stack limit = 0xc33e2270)
    Stack: (0xc33e3ba0 to 0xc33e4000)
    3ba0: 00000000 c007d3d4 c33e3bcc c04555bc c04555bc c33d4340 c33e3bdc c33e3bc8
    3bc0: c007f5f8 c0080bb4 00000000 c04555bc c33e3bf4 c33e3be0 c007f654 c007f5c0
    3be0: 00000000 c04555bc c33e3c24 c33e3bf8 c007e6e8 c007f618 c01f2284 c0350af8
    3c00: c0405214 bf016c98 00000001 00000000 c33dc008 0000002d c33e3c54 c33e3c28
    3c20: c007e888 c007e408 00000001 c23ef880 c33dc000 00000000 c33dc080 c25caa00
    3c40: c0487498 bf017078 c33e3c94 c33e3c58 bf016b44 c007e7d4 bf017078 c33dc008
    3c60: c25caa08 c33dc008 c33e3c84 bf017484 c25caa00 c25caa00 c01f5f48 c25caa08
    3c80: c0496d60 bf017484 c33e3ca4 c33e3c98 c022a698 bf01692c c33e3cd4 c33e3ca8
    3ca0: c01f5d88 c022a688 00000000 bf017484 c25caa00 c25caa00 c01f5f48 c25caa08
    3cc0: c0496d60 00000000 c33e3cec c33e3cd8 c01f5f8c c01f5d10 00000000 c33e3cf0
    3ce0: c33e3d14 c33e3cf0 c01f5210 c01f5f58 c303cb48 c25ecf94 c25caa00 c25caa00
    3d00: c25caa34 c33e3dd8 c33e3d34 c33e3d18 c01f6044 c01f51b8 c0496d3c c25caa00
    3d20: c044e918 c33e3dd8 c33e3d44 c33e3d38 c01f4ff4 c01f5fcc c33e3d94 c33e3d48
    3d40: c01f3d10 c01f4fd8 00000000 c044e918 00000000 00000000 c01f52c0 c034d570
    3d60: c33e3d84 c33e3d70 c022bf84 c25caa00 00000000 c044e918 c33e3dd8 c25c2e00
    3d80: c0496d60 bf01763c c33e3db4 c33e3d98 c022b1a0 c01f384c c25caa00 c33e3dd8
    3da0: 00000000 c33e3dd8 c33e3dd4 c33e3db8 c022b27c c022b0e8 00000000 bf01763c
    3dc0: c0451c80 c33e3dd8 c33e3e34 c33e3dd8 bf016f60 c022b210 5f75636d 746e6f63
    3de0: 006c6f72 00000000 00000000 00000000 00000000 00000000 00000000 bf0174bc
    3e00: 00000000 00989680 00000000 00000020 c0451c80 c0451c80 bf0174dc c01f5eb0
    3e20: c33f0f00 bf0174dc c33e3e44 c33e3e38 c01f72f4 bf016e2c c33e3e74 c33e3e48
    3e40: c01f5d88 c01f72e4 00000000 c0451c80 c0451cb4 bf0174dc c01f5eb0 c33f0f00
    3e60: c0473100 00000000 c33e3e94 c33e3e78 c01f5f44 c01f5d10 00000000 c33e3e98
    3e80: bf0174dc c01f5eb0 c33e3ebc c33e3e98 c01f5534 c01f5ec0 c303c038 c3061c30
    3ea0: 00003cd8 00098258 bf0174dc c0462ac8 c33e3ecc c33e3ec0 c01f5bec c01f54dc
    3ec0: c33e3efc c33e3ed0 c01f4d30 c01f5bdc bf0173a0 c33e2000 00003cd8 00098258
    3ee0: bf0174dc c33e2000 c00301a4 bf019000 c33e3f1c c33e3f00 c01f6588 c01f4c8c
    3f00: 00003cd8 00098258 00000000 c33e2000 c33e3f2c c33e3f20 c01f777c c01f6524
    3f20: c33e3f3c c33e3f30 bf019014 c01f7740 c33e3f7c c33e3f40 c002f3ec bf019010
    3f40: 00000000 00003cd8 00098258 bf017518 00000000 00003cd8 00098258 bf017518
    3f60: 00000000 c00301a4 c33e2000 00000000 c33e3fa4 c33e3f80 c007b934 c002f3c4
    3f80: c00b307c c00b2f48 00003cd8 00000000 00000003 00000080 00000000 c33e3fa8
    3fa0: c0030020 c007b8b8 00003cd8 00000000 00098288 00003cd8 00098258 00098240
    3fc0: 00003cd8 00000000 00000003 00000080 00098008 00098028 00098288 00000001
    3fe0: be892998 be892988 00013d7c 40178740 60000010 00098288 09089041 00200845
    Backtrace:
    [] (irq_gc_mask_set_bit+0x0/0x7c) from [] (irq_enable+0x48/0x58)
    r6:c33d4340 r5:c04555bc r4:c04555bc
    [] (irq_enable+0x0/0x58) from [] (irq_startup+0x4c/0x54)
    r5:c04555bc r4:00000000
    [] (irq_startup+0x0/0x54) from [] (__setup_irq+0x2f0/0x3cc)
    r5:c04555bc r4:00000000
    [] (__setup_irq+0x0/0x3cc) from [] (request_threaded_irq+0xc4/0x110)
    r8:0000002d r7:c33dc008 r6:00000000 r5:00000001 r4:bf016c98
    [] (request_threaded_irq+0x0/0x110) from [] (mcu_spi_probe+0x228/0x37c [mcu])
    [] (mcu_spi_probe+0x0/0x37c [mcu]) from [] (spi_drv_probe+0x20/0x24)
    [] (spi_drv_probe+0x0/0x24) from [] (driver_probe_device+0x88/0x1b0)
    [] (driver_probe_device+0x0/0x1b0) from [] (__device_attach+0x44/0x48)
    [] (__device_attach+0x0/0x48) from [] (bus_for_each_drv+0x68/0x94)
    r5:c33e3cf0 r4:00000000
    [] (bus_for_each_drv+0x0/0x94) from [] (device_attach+0x88/0xa0)
    r7:c33e3dd8 r6:c25caa34 r5:c25caa00 r4:c25caa00
    [] (device_attach+0x0/0xa0) from [] (bus_probe_device+0x2c/0x4c)
    r7:c33e3dd8 r6:c044e918 r5:c25caa00 r4:c0496d3c
    [] (bus_probe_device+0x0/0x4c) from [] (device_add+0x4d4/0x648)
    [] (device_add+0x0/0x648) from [] (spi_add_device+0xc8/0x128)
    [] (spi_add_device+0x0/0x128) from [] (spi_new_device+0x7c/0xb4)
    r7:c33e3dd8 r6:00000000 r5:c33e3dd8 r4:c25caa00
    [] (spi_new_device+0x0/0xb4) from [] (mcu_probe+0x144/0x224 [mcu])
    r7:c33e3dd8 r6:c0451c80 r5:bf01763c r4:00000000
    [] (mcu_probe+0x0/0x224 [mcu]) from [] (platform_drv_probe+0x20/0x24)
    [] (platform_drv_probe+0x0/0x24) from [] (driver_probe_device+0x88/0x1b0)
    [] (driver_probe_device+0x0/0x1b0) from [] (__driver_attach+0x94/0x98)
    [] (__driver_attach+0x0/0x98) from [] (bus_for_each_dev+0x68/0x94)
    r7:c01f5eb0 r6:bf0174dc r5:c33e3e98 r4:00000000
    [] (bus_for_each_dev+0x0/0x94) from [] (driver_attach+0x20/0x28)
    r7:c0462ac8 r6:bf0174dc r5:00098258 r4:00003cd8
    [] (driver_attach+0x0/0x28) from [] (bus_add_driver+0xb4/0x258)
    [] (bus_add_driver+0x0/0x258) from [] (driver_register+0x74/0x158)
    [] (driver_register+0x0/0x158) from [] (platform_driver_register+0x4c/0x60)
    r7:c33e2000 r6:00000000 r5:00098258 r4:00003cd8
    [] (platform_driver_register+0x0/0x60) from [] (mcu_init+0x14/0x20 [mcu])
    [] (mcu_init+0x0/0x20 [mcu]) from [] (do_one_initcall+0x38/0x170)
    [] (do_one_initcall+0x0/0x170) from [] (sys_init_module+0x8c/0x1a4)
    [] (sys_init_module+0x0/0x1a4) from [] (ret_fast_syscall+0x0/0x2c)
    r7:00000080 r6:00000003 r5:00000000 r4:00003cd8
    Code: e1844003 e585400c e596300c e5932064 (e7814002)

    Fix the issue.

    Reported-by: Jon Povey
    Signed-off-by: Sekhar Nori
    Signed-off-by: Grant Likely
    Signed-off-by: Greg Kroah-Hartman

    Sekhar Nori
     
  • commit 8276536cec38bc6bde30d0aa67716f22b9b9705a upstream.

    This function should be capable of both enabling and disabling interrupts
    based upon the *enable* parameter. Right now the function only enables
    the interrupt and *enable* is not used at all. So add the interrupt
    disable capability also using the parameter.

    Signed-off-by: Tarun Kanti DebBarma
    Reviewed-by: Santosh Shilimkar
    Acked-by: Felipe Balbi
    Reviewed-by: Kevin Hilman
    Signed-off-by: Kevin Hilman
    Signed-off-by: Greg Kroah-Hartman

    Tarun Kanti DebBarma
     
  • commit 3be5bb71fbf18f83cb88b54a62a78e03e5a4f30a upstream.

    Remove unnecessary register access in mxl111sf_ep6_streaming_ctrl()

    This code breaks driver operation in kernel 3.3 and later, although
    it works properly in 3.2 Disable register access to 0x12 for now.

    Signed-off-by: Michael Krufky
    Signed-off-by: Mauro Carvalho Chehab
    Signed-off-by: Greg Kroah-Hartman

    Michael Krufky
     
  • commit 9ab2393fc3e460cd2040de1483918eb17abb822f upstream.

    The D1F5 revision of the WinTV HVR-1900 uses a tda18271c2 tuner
    instead of a tda18271c1 tuner as used in revision D1E9. To
    account for this, we must hardcode the frontend configuration
    to use the same IF frequency configuration for both revisions
    of the device.

    6MHz DVB-T is unaffected by this issue, as the recommended
    IF Frequency configuration for 6MHz DVB-T is the same on both
    c1 and c2 revisions of the tda18271 tuner.

    Signed-off-by: Michael Krufky
    Cc: Mike Isely
    Signed-off-by: Mauro Carvalho Chehab
    Signed-off-by: Greg Kroah-Hartman

    Michael Krufky
     
  • commit 34817174fca0c5512c2d5b6ea0fc37a0337ce1d8 upstream.

    The error handling in lgdt3303_read_status() and lgdt330x_read_ucblocks()
    doesn't work, because i2c_read_demod_bytes() returns a u8 and (err < 0)
    is always false.

    err = i2c_read_demod_bytes(state, 0x58, buf, 1);
    if (err < 0)
    return err;

    Change the return type of i2c_read_demod_bytes() to int. Also change
    the return value on error to -EIO to make (err < 0) work.

    Signed-off-by: Xi Wang
    Signed-off-by: Mauro Carvalho Chehab
    Signed-off-by: Greg Kroah-Hartman

    Xi Wang