09 Sep, 2016
35 commits
-
The vsp1 driver supports tri-planar formats, but the DRM API only passes
two memory addresses. Add a third one.Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
Instead of hardcoding the media device model and hardware revision to
"VSP1" and 0 respectively, report the actual hardware device model and
IP version number.Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
The FCP must be powered up for the FDP1 to function, even when the FDP1
does not make use of the FCNL features. Extend the compatible list
to allow us to use the power domain and runtime-pm support.Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
The Renesas multimedia drivers use ret to store return values, fix the
only exception in the rcar-fcp driver to keep the coding style
consistent.Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
The S_FMT and TRY_FMT handlers in multiplane mode attempt at clearing
the reserved fields of the v4l2_format structure after the pix_mp
member. However, the reserved fields are inside pix_mp, not after it.Signed-off-by: Laurent Pinchart
Tested-by: Kieran Bingham
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab -
The driver used integers for what boolean would have been a better fit.
Use boolean instead.Signed-off-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab -
This will allow adding new operations without increasing the
media_device structure size for drivers that don't implement any media
device operation.Signed-off-by: Laurent Pinchart
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
SMIA++ supports 14 and 16 bits per pixel formats as well. Add support to
these formats in the driver.Signed-off-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab -
As reported by smatch:
drivers/media/platform/pxa_camera.c: In function 'pxa_dma_start_channels':
drivers/media/platform/pxa_camera.c:457:21: warning: variable 'active' set but not used [-Wunused-but-set-variable]
struct pxa_buffer *active;
^~~~~~Signed-off-by: Mauro Carvalho Chehab
-
As warned by smatch:
drivers/media/platform/pxa_camera.c:283:39: warning: no previous prototype for 'soc_mbus_xlate_by_fourcc' [-Wmissing-prototypes]
const struct soc_camera_format_xlate *soc_mbus_xlate_by_fourcc(
^~~~~~~~~~~~~~~~~~~~~~~~Signed-off-by: Mauro Carvalho Chehab
-
Allow building this driver if COMPILE_TEST is set.
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This is a tiny fix for a switch case which quiets 2 checkpatch harmless
warnings. The generated code is not affected.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
As the conversion to a v4l2 standalone device is finished, move
pxa_camera one directory up and finish severing any dependency to
soc_camera.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Instead of the legacy behavior where it was required to wait for all
video buffers to be finished by the hardware, use a cancel like strategy
: as soon as the stop_streaming() call is done, abort all DMA transfers,
report the already buffers as failed and return.This makes stop_streaming() more a "cancel capture" than a "wait for end
of capture" semantic.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Add pxa_camera registers access through advanced video debugging.
Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This patch removes the soc_camera API dependency from pxa_camera.
In the current status :
- all previously captures are working the same on pxa270
- the s_crop() call was removed, judged not working
(see what happens soc_camera_s_crop() when get_crop() == NULL)
- if the pixel clock is provided by then sensor, ie. not MCLK, the dual
stage change is not handled yet.
=> there is no in-tree user of this, so I'll let it that way- the MCLK is not yet finished, it's as in the legacy way,
ie. activated at video device opening and closed at video device
closing.
In a subsequence patch pxa_camera_mclk_ops should be used, and
platform data MCLK ignored. It will be the sensor's duty to request
the clock and enable it, which will end in pxa_camera_mclk_ops.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This is to be seen as a regression as the set_selection (former
set_crop) function is removed. This is a temporary situation in the v4l2
porting, and will have to be added later.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Add sequence numbers to completed buffers.
Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Make all print consistent by always using :
- dev_xxx(pcdev_to_dev(pcdev), ....)This prepares the soc_camera adherence removal by making these call rely
on only pcdev, and not the soc_camera icd structure.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Introduce sensor_call(), which will be used for all sensor invocations.
This is a preparation move to v4l2 device conversion, ie. soc_camera
adherence removal.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Move the functions in the file to be regrouped into meaningful blocks :
1. pxa camera core handling functions, manipulating the herdware
2. videobuf2 functions, dealing with video buffers
3. video ioctl (vidioc) related functions
4. driver probing, removal, suspend and resumeThis patch doesn't modify a single line of code.
Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Convert pxa_camera from videobuf to videobuf2.
As the soc_camera was already compatible with videobuf2, the port is
quite straightforward.The special case of this code in which the vb2 to prepare is "too
big" in terms of size for the new capture format, the pxa_camera will
fail.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
As the mt9m111 is now working as a standalone v4l2 subdevice sensor,
move it out of soc_camera directory and sever its dependency on
soc_camera.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
mt9m111 being a camera sensor, its colorspace should always be SRGB, for
both RGB based formats or YCbCr based ones.Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Remove the soc_camera adherence. Mostly the change removes the power
manipulation provided by soc_camera, and instead :
- powers on the sensor when the s_power control is activated
- powers on the sensor in initial probe
- enables and disables the MCLK provided to it in power on/offThis patch also drops support for inverters on synchronisation and clock
lines. It is assumed, if any board ever needs such inverters, support
for them can be added in the futureAcked-by: Guennadi Liakhovetski
Signed-off-by: Robert Jarzmik
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This patch adds the H.264 video encoding capability in the V4L2 HVA
video encoder driver for STMicroelectronics SoC (hva-h264.c).The main supported features are:
- profile: baseline, main, high, stereo high
- level: up to 4.2
- bitrate mode: CBR, VBR
- entropy mode: CABAC, CAVLC
- video aspect: 1x1 onlySigned-off-by: Yannick Fertre
Signed-off-by: Jean-Christophe Trotin
Acked-by: Peter Griffin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder
driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework.This patch only contains the core parts of the driver:
- the V4L2 interface with the userland (hva-v4l2.c)
- the hardware services (hva-hw.c)
- the memory management utilities (hva-mem.c)This patch doesn't include the support of specific codec (e.g. H.264)
video encoding: this support is part of subsequent patches.Signed-off-by: Yannick Fertre
Signed-off-by: Jean-Christophe Trotin
Acked-by: Peter Griffin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
There are several functions documented at the C file. Move
them to the header, as this is the one used to build the
media books.Signed-off-by: Mauro Carvalho Chehab
-
There are several functions that were documented at the .c
file. As we only include the headers, we need to move them to
there, in order to have documentation.Signed-off-by: Mauro Carvalho Chehab
-
Several routines are somewhat documented at v4l2-mem2mem.c
file. Move what's there to the header file.Signed-off-by: Mauro Carvalho Chehab
-
The kernel-doc parser didn't handle well the private:
tag. Rewrite it.Signed-off-by: Mauro Carvalho Chehab
-
demux.h was lacking documentation for the DMX_FE_ENTRY macro:
./drivers/media/dvb-core/demux.h:511: WARNING: c:func reference target not found: DMX_FE_ENTRYWhile here, get rid of unused parameters and fix a few minor issues
at the header file.Signed-off-by: Mauro Carvalho Chehab
-
There are a few define macros not documented, because the ReST
output was causing more warnings.Now that this got fixed, document them. While here, fix the
remaining coding style issues.Signed-off-by: Mauro Carvalho Chehab
-
Instead of keeping those notes at the file on a non-structured
way, move them to dtv-core.rst, using the proper ReST tags.Signed-off-by: Mauro Carvalho Chehab
-
There are several functions there there weren't properly
documented. Add documentation for them.While here, make checkpatch.pl happier.
Signed-off-by: Mauro Carvalho Chehab
07 Sep, 2016
5 commits
-
Update the cobalt EDID, fixing various incorrect values (wrong name,
product code, various video capabilities).Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Update the vivid EDID, fixing various incorrect values (wrong name,
product code, various video capabilities).Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
As warned by smatch:
drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags'
drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags'Two different spinlocks are obtained, so having two calls is correct,
but second irqsave is superfluous, and using same "flags" variable is
just wrong.Reported-by: Mauro Carvalho Chehab
Signed-off-by: Andrey Utkin
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
This reverts commit 617e901a12ad ("[media] tw5864: remove double irq lock code").
That commit was rejected by Andrey Utkin ,
but it had already been merged. Revert and apply Andrey's corrected
patch next.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Fix some small things:
- clean up setup function
- use MSGEND instead of 0xfe
- don't assign "return value" from cec_phys_addr to err,
it has return type void.Signed-off-by: Johan Fjeldtvedt
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
