16 Jun, 2007

1 commit

  • This patch fixes a problem that occurs when packets cannot be sent across
    the ieee1394 bus and we return NETDEV_TX_BUSY in the net driver "hard start
    xmit" routine ether1394_tx. When we return NETDEV_TX_BUSY the stack will
    call ether1394_tx again with the same skb. So we need to restore the header
    to look like it did before we munged it for xmit over ieee1394.

    [Stefan Richter: changed whitespace, deleted a local variable]

    Signed-off-by: Stefan Richter

    Carlos E. Ugarte
     

28 May, 2007

3 commits

  • This adds a real parent device to eth1394's ethX device like in Linux
    2.6.20 and older. However, due to unfinished conversion of the ieee1394
    away from class_device, we now refer to the FireWire controller's PCI
    device as the parent, not to the ieee1394 driver's fw-host device.

    Having a real parent device instead of a virtual one allows udev scripts
    to distinguish eth1394 interfaces from networking bridges, bondings and
    the likes.

    Fixes a regression since 2.6.21:
    https://bugs.gentoo.org/show_bug.cgi?id=177199

    Signed-off-by: Stefan Richter

    Stefan Richter
     
  • When eth1394 was unable to acquire a transaction label, it just dropped
    outgoing packets without attempt to resend them later.

    The transmit queue is now halted if no tlabel is available to
    ->hard_start_xmit(). A workqueue job is then scheduled to catch the
    moment when ieee1394 recycled the next lot of tlabels.

    Fixes http://bugzilla.kernel.org/show_bug.cgi?id=8402

    Signed-off-by: Stefan Richter

    Stefan Richter
     
  • When we are within hard_start_xmit, the queue is already awake.

    Signed-off-by: Stefan Richter

    Stefan Richter
     

30 Apr, 2007

21 commits


26 Apr, 2007

2 commits


23 Mar, 2007

1 commit


15 Feb, 2007

1 commit

  • After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

08 Dec, 2006

2 commits

  • This patch consolidates some bookkeeping for driver registering. It
    closely models what pci_register_driver() does. The main addition is
    that the owner of the driver is set, so we get a proper symlink
    for /sys/bus/ieee1394/driver/*/module.

    Also moves setting of name and bus type into nodemgr. Because of this,
    we can remove the EXPORT_SYMBOL for ieee1394_bus_type, since it's now
    only used in ieee1394.ko.

    Signed-off-by: Stefan Richter

    Ben Collins
     
  • Replace all uses of kmem_cache_t with struct kmem_cache.

    The patch was generated using the following script:

    #!/bin/sh
    #
    # Replace one string by another in all the kernel sources.
    #

    set -e

    for file in `find * -name "*.c" -o -name "*.h"|xargs grep -l $1`; do
    quilt add $file
    sed -e "1,\$s/$1/$2/g" $file >/tmp/$$
    mv /tmp/$$ $file
    quilt refresh
    done

    The script was run like this

    sh replace kmem_cache_t "struct kmem_cache"

    Signed-off-by: Christoph Lameter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Lameter
     

31 Oct, 2006

1 commit

  • Several u64 objects are derefernced in situations where the
    pointer is not guarenteed to be aligned correctly. Use
    get_unaligned() as needed.

    Thanks to Will Simoneau for lots of testing and debugging
    help.

    Signed-off-by: David S. Miller
    Acked-by: Stefan Richter

    David S. Miller
     

18 Sep, 2006

1 commit


04 Jul, 2006

1 commit


27 Jun, 2006

1 commit

  • This patch converts the combination of list_del(A) and list_add(A, B) to
    list_move(A, B) under drivers/.

    Acked-by: Corey Minyard
    Cc: Ben Collins
    Acked-by: Roland Dreier
    Cc: Alasdair Kergon
    Cc: Gerd Knorr
    Cc: Paul Mackerras
    Cc: Frank Pavlic
    Acked-by: Matthew Wilcox
    Cc: Andrew Vasquez
    Cc: Mikael Starvik
    Cc: Greg Kroah-Hartman
    Signed-off-by: Akinobu Mita
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     

13 Jun, 2006

4 commits

  • ...and __constant_ntohs, __constant_ntohl, __constant_cpu_to_be32 too
    where possible. Htons and friends are resolved to constants in these
    places anyway. Also fix an endianess glitch in a log message, spotted
    by Alexey Dobriyan.

    Signed-off-by: Stefan Richter
    Signed-off-by: Ben Collins

    Ben Collins
     
  • Replace occurrences of the magic value ~(u64)0 for invalid
    CSR address spaces by a named constant for better readability.

    Signed-off-by: Stefan Richter
    Signed-off-by: Ben Collins

    Ben Collins
     
  • Signed-off-by: Alexey Dobriyan
    Signed-off-by: Ben Collins

    Ben Collins
     
  • Add support for the following types of hardware:
    + nodes that have a link speed < PHY speed
    + 1394b PHYs that are less than S800 capable
    + 1394b/1394a adapter cable between two 1394b PHYs
    Also, S1600 and S3200 are now supported if IEEE1394_SPEED_MAX is raised.

    A probing function is added to nodemgr's config ROM fetching routine
    which adjusts the allowable speed if an access problem was encountered.
    Pros and Cons of the approach:
    + minimum code footprint to support this less widely used hardware
    + nearly no overhead for unaffected hardware
    - ineffective before nodemgr began to read the ROM of affected nodes
    - ineffective if ieee1394 is loaded with disable_nodemgr=1
    The speed map CSRs which are published to the bus are not touched by the
    patch.

    Signed-off-by: Stefan Richter
    Cc: Hakan Ardo
    Cc: Calculex
    Cc: Robert J. Kosinski
    Signed-off-by: Ben Collins

    Ben Collins
     

07 Nov, 2005

1 commit

  • dv1394, eth1394, ieee1394, ohci1394, pcilynx, raw1394, sbp2c, video1394:
    - use kzalloc
    - provide safer size arguments to kmalloc and kzalloc
    - omit some casts

    Signed-off-by: Stefan Richter
    Signed-off-by: Jody McIntyre

    Stefan Richter