Eric Lee / smarc-fsl-linux-kernel

06 Aug, 2010

1 commit

02 Aug, 2010

1 commit

13 Jul, 2010

1 commit

19 Jun, 2010

1 commit

  • 5030c8079   ieee1394: remove unused variables ... Browse Code »

    which caused gcc 4.6 to warn about
    variable 'XYZ' set but not used.

    sbp2.c, unit_characteristics:

    The underlying problem which was spotted here --- an incomplete
    implementation --- is already 50% fixed in drivers/firewire/sbp2.c which
    observes mgt_ORB_timeout but not yet ORB_size.

    raw1394.c, length_conflict; dv1394.c, ts_off:

    Impossible to tell why these variables are there. We can safely remove
    them though because we don't need a compiler warning to realize that we
    are dealing with (at least stylistically) flawed code here.

    dv1394.c, packet_time:

    This was used in debug macro that is only compiled in with
    DV1394_DEBUG_LEVEL >= 2 defined at compile-time. Just drop it since
    nobody debugs dv1394 anymore. Avoids noise in regular kernel builds.

    dv1394.c, ohci; eth1394.c, priv:

    These variables clearly can go away. Somebody wanted to use them but
    then didn't (or not anymore).

    Note, all of this code is considered to be at its end of life and is
    thus not really meant to receive janitorial updates anymore. But if we
    can easily remove noisy warnings from kernel builds, we should.

    Reported-by: Justin P. Mattock
    Signed-off-by: Stefan Richter

    Stefan Richter
     

01 Jun, 2010

1 commit

28 May, 2010

1 commit

  • 55ddf14b0   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
    ieee1394: schedule for removal
    firewire: core: use separate timeout for each transaction
    firewire: core: Fix tlabel exhaustion problem
    firewire: core: make transaction label allocation more robust
    firewire: core: clean up config ROM related defined constants
    ieee1394: mark char device files as not seekable
    firewire: cdev: mark char device files as not seekable
    firewire: ohci: cleanups and fix for nonstandard build without debug facility
    firewire: ohci: wait for PHY register accesses to complete
    firewire: ohci: fix up configuration of TI chips
    firewire: ohci: enable 1394a enhancements
    firewire: ohci: do not clear PHY interrupt status inadvertently
    firewire: ohci: add a function for reading PHY registers

    Trivial conflicts in Documentation/feature-removal-schedule.txt

    Linus Torvalds
     

10 Apr, 2010

1 commit

  • 7cfe21aae   ieee1394: mark char device files as not seekable ... Browse Code »

    The
    - raw1394 (/dev/raw1394),
    - video1394 (/dev/video1394/*),
    - dv1394 (/dev/dv1394/*)
    character device file ABIs do not make any use of lseek(), pread(), or
    pwrite(). Therefore use nonseekable_open() and, redundantly, set
    file_operations.llseek to no_llseek to remove any doubt whether the BKL-
    grabbing default_llseek handler is used.

    Although all this is legacy code which should be left in peace until it
    is eventually removed (as it is superseded by firewire-core's
    ABI), this change seems still worth doing to
    further minimize the presence of BKL usage in the kernel.

    Signed-off-by: Stefan Richter

    Stefan Richter
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

13 Mar, 2010

1 commit

  • c32da0234   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (56 commits)
    doc: fix typo in comment explaining rb_tree usage
    Remove fs/ntfs/ChangeLog
    doc: fix console doc typo
    doc: cpuset: Update the cpuset flag file
    Fix of spelling in arch/sparc/kernel/leon_kernel.c no longer needed
    Remove drivers/parport/ChangeLog
    Remove drivers/char/ChangeLog
    doc: typo - Table 1-2 should refer to "status", not "statm"
    tree-wide: fix typos "ass?o[sc]iac?te" -> "associate" in comments
    No need to patch AMD-provided drivers/gpu/drm/radeon/atombios.h
    devres/irq: Fix devm_irq_match comment
    Remove reference to kthread_create_on_cpu
    tree-wide: Assorted spelling fixes
    tree-wide: fix 'lenght' typo in comments and code
    drm/kms: fix spelling in error message
    doc: capitalization and other minor fixes in pnp doc
    devres: typo fix s/dev/devm/
    Remove redundant trailing semicolons from macros
    fix typo "definetly" -> "definitely" in comment
    tree-wide: s/widht/width/g typo in comments
    ...

    Fix trivial conflict in Documentation/laptops/00-INDEX

    Linus Torvalds
     

08 Mar, 2010

2 commits

  • 318ae2edc   Merge branch 'for-next' into for-linus ... Browse Code »

    Conflicts:
    Documentation/filesystems/proc.txt
    arch/arm/mach-u300/include/mach/debug-macro.S
    drivers/net/qlge/qlge_ethtool.c
    drivers/net/qlge/qlge_main.c
    drivers/net/typhoon.c

    Jiri Kosina
     
  • 8e9394ce2   Driver core: create lock/unlock functions for struct device ... Browse Code »

    In the future, we are going to be changing the lock type for struct
    device (once we get the lockdep infrastructure properly worked out) To
    make that changeover easier, and to possibly burry the lock in a
    different part of struct device, let's create some functions to lock and
    unlock a device so that no out-of-core code needs to be changed in the
    future.

    This patch creates the device_lock/unlock/trylock() functions, and
    converts all in-tree users to them.

    Cc: Thomas Gleixner
    Cc: Jean Delvare
    Cc: Dave Young
    Cc: Ming Lei
    Cc: Jiri Kosina
    Cc: Phil Carmody
    Cc: Arjan van de Ven
    Cc: Cornelia Huck
    Cc: Rafael J. Wysocki
    Cc: Pavel Machek
    Cc: Len Brown
    Cc: Magnus Damm
    Cc: Alan Stern
    Cc: Randy Dunlap
    Cc: Stefan Richter
    Cc: David Brownell
    Cc: Vegard Nossum
    Cc: Jesse Barnes
    Cc: Alex Chiang
    Cc: Kenji Kaneshige
    Cc: Andrew Morton
    Cc: Andrew Patterson
    Cc: Yu Zhao
    Cc: Dominik Brodowski
    Cc: Samuel Ortiz
    Cc: Wolfram Sang
    Cc: CHENG Renquan
    Cc: Oliver Neukum
    Cc: Frans Pop
    Cc: David Vrabel
    Cc: Kay Sievers
    Cc: Sarah Sharp
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

26 Feb, 2010

1 commit

  • 086fa5ff0   block: Rename blk_queue_max_sectors to blk_queue_max_hw_sectors ... Browse Code »

    The block layer calling convention is blk_queue_.
    blk_queue_max_sectors predates this practice, leading to some confusion.
    Rename the function to appropriately reflect that its intended use is to
    set max_hw_sectors.

    Also introduce a temporary wrapper for backwards compability. This can
    be removed after the merge window is closed.

    Signed-off-by: Martin K. Petersen
    Signed-off-by: Jens Axboe

    Martin K. Petersen
     

05 Feb, 2010

1 commit

30 Dec, 2009

1 commit

  • 5d7db0499   firewire, ieee1394: update Kconfig help ... Browse Code »

    Update the Kconfig help texts of both stacks to encourage a general move
    from the older to the newer drivers. However, do not label ieee1394 as
    "Obsolete" yet, as the newer drivers have not been deployed as default
    stack in the majority of Linux distributions yet, and those who start
    doing so now may still want to install the old drivers as fallback for
    unforeseen issues.

    Since Linux 2.6.32, FireWire audio devices can be driven by the newer
    firewire driver stack too, hence remove an outdated comment about audio
    devices. Also remove comments about library versions since the 2nd
    generation of libraw1394 and libdc1394 is now in common use; details on
    library versions can be read at the wiki link from the help texts.

    Signed-off-by: Stefan Richter

    Stefan Richter
     

10 Dec, 2009

1 commit

  • 4ef58d4e2   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)
    tree-wide: fix misspelling of "definition" in comments
    reiserfs: fix misspelling of "journaled"
    doc: Fix a typo in slub.txt.
    inotify: remove superfluous return code check
    hdlc: spelling fix in find_pvc() comment
    doc: fix regulator docs cut-and-pasteism
    mtd: Fix comment in Kconfig
    doc: Fix IRQ chip docs
    tree-wide: fix assorted typos all over the place
    drivers/ata/libata-sff.c: comment spelling fixes
    fix typos/grammos in Documentation/edac.txt
    sysctl: add missing comments
    fs/debugfs/inode.c: fix comment typos
    sgivwfb: Make use of ARRAY_SIZE.
    sky2: fix sky2_link_down copy/paste comment error
    tree-wide: fix typos "couter" -> "counter"
    tree-wide: fix typos "offest" -> "offset"
    fix kerneldoc for set_irq_msi()
    spidev: fix double "of of" in comment
    comment typo fix: sybsystem -> subsystem
    ...

    Linus Torvalds
     

09 Dec, 2009

1 commit

  • bb592cf47   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
    ieee1394: Use hweight32
    firewire: cdev: reduce stack usage by ioctl_dispatch
    firewire: ohci: 0 may be a valid DMA address
    firewire: core: WARN on wrong usage of core transaction functions
    firewire: core: optimize Topology Map creation
    firewire: core: clarify generate_config_rom usage
    firewire: optimize config ROM creation
    firewire: cdev: normalize variable names
    firewire: normalize style of queue_work wrappers
    firewire: cdev: fix memory leak in an error path

    Linus Torvalds
     

04 Dec, 2009

1 commit

  • af901ca18   tree-wide: fix assorted typos all over the place ... Browse Code »

    That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

19 Nov, 2009

1 commit

12 Oct, 2009

1 commit

28 Sep, 2009

1 commit

24 Sep, 2009

1 commit

  • ff830b8e5   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
    ieee1394: sbp2: remove a workaround for Momobay FX-3A
    firewire: sbp2: remove a workaround for Momobay FX-3A
    firewire: sbp2: fix status reception
    firewire: core: fix topology map response handler
    firewire: core: fix race with parallel PCI device probe
    firewire: core: header file cleanup
    firewire: ohci: fix Self ID Count register mask (safeguard against buffer overflow)
    ieee1394: raw1394: Do not leak memory on failed trylock.

    Linus Torvalds
     

12 Sep, 2009

2 commits

03 Sep, 2009

1 commit

02 Sep, 2009

1 commit

01 Sep, 2009

1 commit

07 Jul, 2009

1 commit

03 Jul, 2009

1 commit

23 Jun, 2009

1 commit

  • 105341406   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
    firewire: new stack is no longer experimental
    firewire: net: better FIFO address range check and rcodes
    firewire: net: fix card driver reloading
    firewire: core: fix iso context shutdown on card removal
    firewire: core: fix DMA unmapping in iso buffer removal
    firewire: net: adjust net_device ops
    firewire: net: remove unused code
    firewire: net: allow for unordered unit discovery
    firewire: net: style changes
    firewire: net: add Kconfig item, rename driver
    firewire: add IPv4 support

    Linus Torvalds
     

21 Jun, 2009

1 commit

  • 0c53decdd   firewire: new stack is no longer experimental ... Browse Code »

    The new stack is now recommended over the old one if used for industrial
    video (IIDC/DCAM) or for storage devices (SBP-2) due to better
    performance, improved compatibility, added features, and security. It
    should also be functionally on par with and is more secure than the old
    ieee1394 stack in the use case of consumer video devices.

    IP-over-1394 support for the new stack is currently emerging, and a
    backend of the firedtv DVB driver to the new stack should be available
    soon.

    The one remaining area where the old stack is still required are audio
    devices, as the new stack is not yet able to support the FFADO FireWire
    audio framework.

    Signed-off-by: Stefan Richter

    Stefan Richter
     

17 Jun, 2009

1 commit

  • b3fec0fe3   Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/vegard/kmemcheck ... Browse Code »

    * 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/vegard/kmemcheck: (39 commits)
    signal: fix __send_signal() false positive kmemcheck warning
    fs: fix do_mount_root() false positive kmemcheck warning
    fs: introduce __getname_gfp()
    trace: annotate bitfields in struct ring_buffer_event
    net: annotate struct sock bitfield
    c2port: annotate bitfield for kmemcheck
    net: annotate inet_timewait_sock bitfields
    ieee1394/csr1212: fix false positive kmemcheck report
    ieee1394: annotate bitfield
    net: annotate bitfields in struct inet_sock
    net: use kmemcheck bitfields API for skbuff
    kmemcheck: introduce bitfield API
    kmemcheck: add opcode self-testing at boot
    x86: unify pte_hidden
    x86: make _PAGE_HIDDEN conditional
    kmemcheck: make kconfig accessible for other architectures
    kmemcheck: enable in the x86 Kconfig
    kmemcheck: add hooks for the page allocator
    kmemcheck: add hooks for page- and sg-dma-mappings
    kmemcheck: don't track page tables
    ...

    Linus Torvalds
     

16 Jun, 2009

1 commit

  • bab030595   ieee1394: remove driver_data direct access of struct device ... Browse Code »

    In the near future, the driver core is going to not allow direct access
    to the driver_data pointer in struct device. Instead, the functions
    dev_get_drvdata() and dev_set_drvdata() should be used. These functions
    have been around since the beginning, so are backwards compatible with
    all older kernel versions.

    Cc: linux1394-devel@lists.sourceforge.net
    Acked-by: Stefan Richter
    Cc: Ben Collins
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

15 Jun, 2009

2 commits

14 Jun, 2009

1 commit

12 Jun, 2009

1 commit

  • 9fd5746fd   fs: Remove i_cindex from struct inode ... Browse Code »

    The only user of the i_cindex element in the inode structure is used
    is by the firewire drivers. As part of an attempt to slim down the
    inode structure to save memory --- since a typical Linux system will
    have hundreds of thousands if not millions of inodes cached, a
    reduction in the size inode has high leverage.

    The firewire driver does not need i_cindex in any fast path, so it's
    simple enough to calculate when it is needed, instead of wasting space
    in the inode structure.

    Signed-off-by: "Theodore Ts'o"
    Cc: krh@redhat.com
    Cc: stefanr@s5r6.in-berlin.de
    Cc: linux-fsdevel@vger.kernel.org
    Signed-off-by: Al Viro

    Theodore Ts'o
     

07 Apr, 2009

1 commit

28 Mar, 2009

1 commit

  • febb02bdf   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6: (53 commits)
    DVB: firedtv: FireDTV S2 problems with tuning solved
    DVB: firedtv: fix printk format mismatch
    ieee1394: constify device ID tables
    ieee1394: raw1394: add sparse annotations to raw1394_compat_write
    ieee1394: Storage class should be before const qualifier
    ieee1394: sbp2: follow up on "ieee1394: inherit ud vendor_id from node vendor_id"
    firewire: core: optimize propagation of BROADCAST_CHANNEL
    firewire: core: simplify broadcast channel allocation
    firewire: core: increase bus manager grace period
    firewire: core: drop unused call parameters of close_transaction
    firewire: cdev: add closure to async stream ioctl
    firewire: cdev: simplify FW_CDEV_IOC_SEND_REQUEST return value
    firewire: cdev: fix race of ioctl_send_request with bus reset
    firewire: cdev: secure add_descriptor ioctl
    firewire: cdev: amendment to "add ioctl to query maximum transmission speed"
    firewire: broadcast channel support
    firewire: implement asynchronous stream transmission
    firewire: core: normalize a function argument name
    firewire: normalize a variable name
    firewire: core: remove condition which is always false
    ...

    Linus Torvalds
     

25 Mar, 2009

2 commits

  • c64094684   ieee1394: constify device ID tables ... Browse Code »

    Signed-off-by: Stefan Richter

    Stefan Richter
     
  • 421696887   ieee1394: raw1394: add sparse annotations to raw1394_compat_write ... Browse Code »

    Eliminate the following warnings in raw1394_compat_write()'s error
    return path, seen on x86-64 with CONFIG_COMPAT=y:

    drivers/ieee1394/raw1394.c:381:17: warning: incorrect type in return expression (different address spaces)
    drivers/ieee1394/raw1394.c:381:17: expected char const [noderef] *
    drivers/ieee1394/raw1394.c:381:17: got void *
    drivers/ieee1394/raw1394.c:2252:14: warning: incorrect type in argument 1 (different address spaces)
    drivers/ieee1394/raw1394.c:2252:14: expected void const *ptr
    drivers/ieee1394/raw1394.c:2252:14: got char const [noderef] *[assigned] buffer
    drivers/ieee1394/raw1394.c:2253:19: warning: incorrect type in argument 1 (different address spaces)
    drivers/ieee1394/raw1394.c:2253:19: expected void const *ptr
    drivers/ieee1394/raw1394.c:2253:19: got char const [noderef] *[assigned] buffer

    Signed-off-by: Stefan Richter

    Stefan Richter