Eric Lee / smarc-fsl-linux-kernel

16 Aug, 2019

1 commit

  • 35c35493b   printk: Replace strncmp() with str_has_prefix() ... Browse Code »

    strncmp(str, const, len) is error-prone because len is easy to have typo.
    An example is the hard-coded len has counting error or sizeof(const)
    forgets - 1.

    So we prefer using newly introduced str_has_prefix() to substitute
    such strncmp() to make code better.

    Link: http://lkml.kernel.org/r/20190809071034.17279-1-hslester96@gmail.com
    Cc: "Steven Rostedt"
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Chuhong Yuan
    Reviewed-by: Sergey Senozhatsky
    [pmladek@suse.com: Slightly updated and reformatted the commit message.]
    Signed-off-by: Petr Mladek

    Chuhong Yuan
     

02 Nov, 2017

1 commit

  • b24413180   License cleanup: add SPDX GPL-2.0 license identifier to files with no license ... Browse Code »

    Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

31 Mar, 2017

1 commit

  • 2ed2b8621   braille-console: Fix value returned by _braille_console_setup ... Browse Code »

    commit bbeddf52adc1 ("printk: move braille console support into
    separate braille.[ch] files") introduced _braille_console_setup()
    to outline the braille initialization code. There was however some
    confusion over the value it was supposed to return. commit 2cfe6c4ac7ee
    ("printk: Fix return of braille_register_console()") tried to fix it
    but failed to.

    This fixes and documents the returned value according to the use
    in printk.c: non-zero return means a parsing error, and thus this
    console configuration should be ignored.

    Signed-off-by: Samuel Thibault
    Cc: Aleksey Makarov
    Cc: Joe Perches
    Cc: Ming Lei
    Cc: Steven Rostedt
    Acked-by: Petr Mladek
    Signed-off-by: Greg Kroah-Hartman

    Samuel Thibault
     

27 Aug, 2016

1 commit

  • ae6c33ba6   printk: fix parsing of "brl=" option ... Browse Code »

    Commit bbeddf52adc1 ("printk: move braille console support into separate
    braille.[ch] files") moved the parsing of braille-related options into
    _braille_console_setup(), changing the type of variable str from char*
    to char**. In this commit, memcmp(str, "brl,", 4) was correctly updated
    to memcmp(*str, "brl,", 4) but not memcmp(str, "brl=", 4).

    Update the code to make "brl=" option work again and replace memcmp()
    with strncmp() to make the compiler able to detect such an issue.

    Fixes: bbeddf52adc1 ("printk: move braille console support into separate braille.[ch] files")
    Link: http://lkml.kernel.org/r/20160823165700.28952-1-nicolas.iooss_linux@m4x.org
    Signed-off-by: Nicolas Iooss
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Nicolas Iooss
     

07 Aug, 2013

1 commit

  • 2cfe6c4ac   printk: Fix return of braille_register_console() ... Browse Code »

    Some of my configs I test with have CONFIG_A11Y_BRAILLE_CONSOLE set.
    When I started testing against v3.11-rc4 my console went bonkers. Using
    ktest to bisect the issue, it came down to:

    commit bbeddf52a "printk: move braille console support into separate
    braille.[ch] files"

    Looking into the patch I found the problem. It's with the return of
    braille_register_console(). As anything other than NULL is considered a
    failure.

    But for those of us that have CONFIG_A11Y_BRAILLE_CONSOLE set but do not
    define a "brl" or "brl=" on the command line, we still may want a
    console that those with sight can still use.

    Return NULL (success) if "brl" or "brl=" is not on the console line.

    Signed-off-by: Steven Rostedt
    Acked-by: Joe Perches
    Cc: Andrew Morton
    Signed-off-by: Linus Torvalds

    Steven Rostedt
     

01 Aug, 2013

1 commit