01 Jan, 2009

1 commit


29 Oct, 2008

1 commit


15 Oct, 2008

1 commit

  • This fixes Bug 11399:
    if ibwdt_set_heartbeat(int t) is called with value 30 then
    the check "if ((t < 0) || (t > 30))" in ibwdt_set_heartbeat
    is not going to fail because t == 30, but in the loop, the
    check wd_times[i] > t is never going to be true because
    none of the wd_times are greater than the value of t (i.e. 30).
    So we are exiting the loop with i == -1 and therefore setting
    wd_margin to -1 which is wrong.

    Reported-by: Zvonimir Rakamaric
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

07 Aug, 2008

1 commit


06 Aug, 2008

2 commits

  • This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1.
    Main changes:
    * Re-structure the ioctl switch call for all drivers as follows:
    switch (cmd) {
    case WDIOC_GETSUPPORT:
    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    case WDIOC_GETTEMP:
    case WDIOC_SETOPTIONS:
    case WDIOC_KEEPALIVE:
    case WDIOC_SETTIMEOUT:
    case WDIOC_GETTIMEOUT:
    case WDIOC_GETTIMELEFT:
    default:
    }

    This to make the migration from the drivers to the uniform watchdog
    device driver easier in the future.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • Use #include instead of
    Use #include instead of
    Clean-up includes.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

28 May, 2008

1 commit


03 Nov, 2007

1 commit

  • Some watchdog drivers initialize global spinlocks in module's init function
    which is tolerable, but some do it in PCI probe function. So, switch to
    static initialization to fix theoretical bugs and, more importantly, stop
    giving people bad examples.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Wim Van Sebroeck
    Signed-off-by: Andrew Morton

    Alexey Dobriyan
     

18 Oct, 2007

1 commit