21 Aug, 2019
1 commit
-
task_active_pid_ns() is wrong API to check PID namespace because it
posses some restrictions and return PID namespace where the process
was allocated. It created mismatches with current namespace, which
can be different.Rewrite whole rdma_is_visible_in_pid_ns() logic to provide reliable
results without any relation to allocated PID namespace.Fixes: 8be565e65fa9 ("RDMA/nldev: Factor out the PID namespace check")
Fixes: 6a6c306a09b5 ("RDMA/restrack: Make is_visible_in_pid_ns() as an API")
Reviewed-by: Mark Zhang
Signed-off-by: Leon Romanovsky
Link: https://lore.kernel.org/r/20190815083834.9245-4-leon@kernel.org
Signed-off-by: Doug Ledford
09 Jul, 2019
1 commit
-
5.4-rc1 will have new compile time debugging to test that headers can be
compiled stand alone. Many rdma headers are already broken and excluded
from the mechanism, however to avoid compile failures during the merge
window fix enough so that the newly added header compiles clean.Fixes: 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")
Reported-by: Stephen Rothwell
Signed-off-by: Jason Gunthorpe
Signed-off-by: Mark Zhang
05 Jul, 2019
1 commit
-
Introduce statistic counter as a new resource. It allows a user to monitor
specific objects (e.g., QPs) by binding to a counter.In some cases a user counter resource is created with task other then
"current", because its creation is done as part of rdmatool call.Signed-off-by: Mark Zhang
Reviewed-by: Majd Dibbiny
Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
19 Feb, 2019
4 commits
-
There is no need to expose internals of restrack DB to IB/core.
Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe -
XArray uses internal lock for updates to XArray. This means that our
external RW lock is needed to ensure that entry is not deleted while we
are performing iteration over list.Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe -
Add new general helper to get restrack entry given by ID and their
respective type.Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe -
The additions of .doit callbacks posses new access pattern to the resource
entries by some user visible index. Back then, the legacy DB was
implemented as hash because per-index access wasn't needed and XArray
wasn't accepted yet.Acceptance of XArray together with per-index access requires the refresh
of DB implementation.Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
31 Jan, 2019
2 commits
-
As preparation to hide rdma_restrack_root, refactor the code to use the
ops structure instead of a special callback which is hidden in
rdma_restrack_root.Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe -
In the current implementation, we have one restrack root per-device and
all users are simply providing it directly. Let's simplify the interface
and have callers provide the ib_device and internally access the
restrack_root.Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
19 Dec, 2018
1 commit
-
Having uobject pointer embedded in ib core objects is not aligned with a
future shared ib_x model. The resource tracker only does this to keep
track of user/kernel objects - track this directly instead.Signed-off-by: Shamir Rabinovitch
Signed-off-by: Jason Gunthorpe
04 Dec, 2018
1 commit
-
Add ability to track allocated ib_ucontext, which are limited
resource and worth to be visible by users.Signed-off-by: Leon Romanovsky
Signed-off-by: Doug Ledford
06 Oct, 2018
2 commits
-
Unify task update and kernel name set in one place.
Reviewed-by: Artemy Kovalyov
Reviewed-by: Yossi Itigin
Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
Signed-off-by: Jason Gunthorpe -
Prepare rdma_restrack_set_task() call to accommodate more
code by moving its implementation from *.h to *.c.Reviewed-by: Artemy Kovalyov
Reviewed-by: Yossi Itigin
Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
Signed-off-by: Jason Gunthorpe
06 Jun, 2018
1 commit
-
Resource tracking is supposed to be dual licensed: GPL-2.0 and
OpenIB, but the SPDX tag was not compliant to it. Update the tag to
properly reflect license.Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
04 May, 2018
2 commits
-
These help rdma drivers to fill out the driver entries.
Signed-off-by: Steve Wise
Signed-off-by: Doug Ledford -
Each driver can register a "fill entry" function with the restrack core.
This function will be called when filling out a resource, allowing the
driver to add driver-specific details. The details consist of a
nltable of nested attributes, that are in the form of tuples. Both key and value attributes are mandatory. The key
nlattr must be a string, and the value nlattr can be one of the driver
attributes that are generic, but typed, allowing the attributes to be
validated. Currently the driver nlattr types include string, s32,
u32, s64, and u64. The print-type nlattr allows a driver to specify
an alternative display format for user tools displaying the attribute.
For example, a u32 attribute will default to "%u", but a print-type
attribute can be included for it to be displayed in hex. This allows
the user tool to print the number in the format desired by the driver
driver.More attrs can be defined as they become needed by drivers.
Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
Signed-off-by: Doug Ledford
23 Mar, 2018
1 commit
-
The restrack clean routine had simple, but powerful WARN_ON check
to see if all resources are cleared prior to releasing device.The WARN_ON check performed very well, but lack of information
which device caused to resource leak, the object type and origin
made debug to be fun and challenging at the same time.The fact that all dumps were the same because restrack_clean() is
called in dealloc() didn't help either.So let's fix spelling error and convert WARN_ON to be more debug
friendly. The dmesg cut below gives example of how the output
will look output for the case fixed in patch [1][ 438.421372] restrack: ------------[ cut here ]------------
[ 438.423448] restrack: BUG: RESTRACK detected leak of resources on mlx5_2
[ 438.425600] restrack: Kernel PD object allocated by mlx5_ib is not freed
[ 438.427753] restrack: Kernel CQ object allocated by mlx5_ib is not freed
[ 438.429660] restrack: ------------[ cut here ]------------[1] https://patchwork.kernel.org/patch/10298695/
Cc: Michal Kalderon
Cc: Chuck Lever
Reviewed-by: Mark Bloch
Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
09 Mar, 2018
2 commits
-
Implement the RDMA nldev netlink interface for dumping detailed
MR information.Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
Signed-off-by: Doug Ledford -
Implement RDMA nldev netlink interface to get detailed CM_ID information.
Because cm_id's are attached to rdma devices in various work queue
contexts, the pid and task information at restrak_add() time is sometimes
not useful. For example, an nvme/f host connection cm_id ends up being
bound to a device in a work queue context and the resulting pid at attach
time no longer exists after connection setup. So instead we mark all
cm_id's created via the rdma_ucm as "user", and all others as "kernel".
This required tweaking the restrack code a little. It also required
wrapping some rdma_cm functions to allow passing the module name string.Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
Signed-off-by: Doug Ledford
16 Feb, 2018
1 commit
-
Resource tracking of XRCD objects is not implemented in current
version of restrack and hence can be removed.Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
Signed-off-by: Leon Romanovsky
Signed-off-by: Jason Gunthorpe
30 Jan, 2018
1 commit
-
The RDMA subsystem has very strict set of objects to work with, but it
completely lacks tracking facilities and has no visibility of resource
utilization.The following patch adds such infrastructure to keep track of RDMA
resources to help with debugging of user space applications. The primary
user of this infrastructure is RDMA nldev netlink (following patches), to
be exposed to userspace via rdmatool, but it is not limited too that.At this stage, the main three objects (PD, CQ and QP) are added, and more
will be added later.Reviewed-by: Mark Bloch
Signed-off-by: Leon Romanovsky
Reviewed-by: Steve Wise
Signed-off-by: Jason Gunthorpe