21 Oct, 2008
1 commit
-
Change debug variable name to one more unique to this driver.
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Jesse Barnes
21 Apr, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Greg Kroah-Hartman
02 Feb, 2008
1 commit
-
Fix presentation of the slot number in the /sys/bus/pci/slots
directory to match that used in the majority of other drivers.> Greg said:
> How is anyone supposed to write sane managability tools in the
> presence
> of such anarchy?
>
> > ~ # cat /sys/bus/pci/slots/0000:00:02.2/phy_location
> > U787A.001.DNZ00Z5-P1-C2
>
> Right. This should look like:
>
> # cat /sys/bus/pci/slots/U787A.001.DNZ00Z5-P1-C2/address
> 0000:00:02This patch implements exactly what you describe. Boot tested.
I assume you really mean it -- if so, then please review and
ack the patch !?I have absolutely no clue if this breaks any existing IBM tools.
I'm pretty sure it doesn't ... but attention Mike Strosaker! does it?Signed-off-by: Linas Vepstas
Cc: Kristen Carlson Accardi
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
29 Nov, 2007
1 commit
-
acpiphp.h: not using kernel-doc, so change /** to /*
acpiphp_core.c: lots of kernel-doc cleanups
acpiphp_glue.c: lots of kernel-doc cleanups
acpiphp_ibm.c: lots of kernel-doc cleanups
cpqphp_core.c: lots of kernel-doc cleanups
cpqphp_ctrl.c: lots of kernel-doc cleanups
fakephp.c: correct kernel-doc notation
pciehp_ctrl.c: correct kernel-doc notation
rpadlpar_core.c: correct function names & kernel-doc notation
rpaphp_core.c: correct kernel-doc notation
shpchp_ctrl.c: correct kernel-doc notationSigned-off-by: Randy Dunlap
Cc: Kristen Accardi
Signed-off-by: Greg Kroah-Hartman
03 May, 2007
8 commits
-
Rename rpaphp_register_pci_slot() because its easy to confuse
with rpaphp_register_slot() even though it does something
completely different. Rename it to rpaphp_enable_slot() because
its almost identical to enbale_slot().Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
Eliminate the tail call to rpaphp_register_slot()
by placing it in the caller. This will help later
dis-entanglement.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
The debug function print_slot_pci_funcs() is a large wrapper
around two debug print statements. Just invoke these directly.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
The setup_pci_slot() routine appears to be nothing else than
a big, complicated wrapper around pcibios_add_pci_devices().
Remove the wrapping, and call pcibios_add_pci_devices() directly.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
Remove another stove-pipe; this funcion was called from
two different places, with a compile-time const that is
then run-time checked to perform two different things.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
Remove another stovepipe: a call which wraps another call, and
just adds printks.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
Remove a stove-pipe-- a function that is called from only one place,
does nothing but wraps another function with debug printk's.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman -
The routine that called an alloc should be the same routine that
calles the mathcing free, if anything in the middle failed.Signed-off-by: Linas Vepstas
Cc: John Rose
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman
01 Feb, 2006
7 commits
-
Minor cleanup. Add the prefix rpaphp_* to several generic-sounding routines.
Remove rpaphp_remove_slot(), which is a one-liner.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
Remove general baroqueness. The function rpaphp_enable_pci_slot()
has a fairly simple logic structure, once all of the debug printk's
are removed. Its called from only one place, and that place also
has a very simple structure once he printk's are removed. Merge
the two together.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
Remove general baroqueness. The function rpaphp_unconfig_pci_adapter()
is really just three lines of code, once all the dbg printks are removed.
And its called in only one place. So replace the call by the thre lines.
Also, provide proper semaphore locking in the affected function
disable_slot()Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The function rpaphp_eeh_remove_bus_device() is a dupe of
eeh_remove_bus_device(). Remove it.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
Remove general baroqueness. The function rpaphp_config_pci_adapter()
is really just one line of code, once all the dbg printks are removed.
And its called in only one place. So replace the call by the one line.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The function rpaphp_fixup_new_pci_devices() has been migrated to
pcibios_fixup_new_pci_devices() in
arch/powerpc/platforms/pseries/pci_dlpar.c
This patch removes the old version.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The function rpaphp_find_pci_bus() has been migrated to
pcibios_find_pci_bus() in arch/powerpc/platforms/pseries/pci_dlpar.c
This patch removes the old version.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman
10 Jan, 2006
3 commits
-
Here's a small patch to reduce the nr. of pointer dereferences in
drivers/pci/hotplug/rpaphp_pci.cBenefits:
- micro speed optimization due to fewer pointer derefs
- generated code should be slightly smaller
- better readabilitynote: due to lack of both hardware and cross-compile tools this patch is,
unfortunately, completely untested.Signed-off-by: Jesper Juhl
Signed-off-by: Greg Kroah-Hartman -
The RPAPHP code contains two routines that appear to be gratuitous copies
of very similar pci code. In particular,rpaphp_claim_resource ~~ pci_claim_resource
(there is a minor, non-functional difference)rpadlpar_claim_one_bus == pcibios_claim_one_bus
(the code is identical)This patch removes the rpaphp versions of the code.
Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The RPAPHP code contains a routine that duplicates some existing code.
This patch removes the rpaphp version of the code.Signed-off-by: Linas Vepstas
Acked-by: John Rose
Signed-off-by: Greg Kroah-Hartman
14 Nov, 2005
1 commit
-
(akpm: _machine is some ppc64 thing - this is a powerpc-only driver)
Signed-off-by: Serge Hallyn
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Nov, 2005
1 commit
-
This patch contains the driver bits for enabling DLPAR and PCI Hotplug
for the new OF-based PCI probe. This functionality was regressed when
the new PCI approach was introduced. Please apply if appropriate.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman
31 Oct, 2005
1 commit
-
I recently picked up my older work to remove unnecessary #includes of
sched.h, starting from a patch by Dave Jones to not include sched.h
from module.h. This reduces the number of indirect includes of sched.h
by ~300. Another ~400 pointless direct includes can be removed after
this disentangling (patch to follow later).
However, quite a few indirect includes need to be fixed up for this.In order to feed the patches through -mm with as little disturbance as
possible, I've split out the fixes I accumulated up to now (complete for
i386 and x86_64, more archs to follow later) and post them before the real
patch. This way this large part of the patch is kept simple with only
adding #includes, and all hunks are independent of each other. So if any
hunk rejects or gets in the way of other patches, just drop it. My scripts
will pick it up again in the next round.Signed-off-by: Tim Schmielau
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
29 Oct, 2005
1 commit
-
This is a minor patch to the ppc64 PCI hotplug code; it makes the call to
rpaphp_unconfig_pci_adapter() symmetric with respect to the call to
rpaphp_config_pci_adapter(). I discussed this with John Rose, who
had provided the last round of changes for these functions; he
appearently had this patch but somehow failed to mail it out.Tested. (added/removed device).
Signed-off-by: Linas Vepstas
drivers/pci/hotplug/rpaphp.h | 3 ++-
drivers/pci/hotplug/rpaphp_core.c | 5 ++++-
drivers/pci/hotplug/rpaphp_pci.c | 11 +++--------
3 files changed, 9 insertions(+), 10 deletions(-)
09 Sep, 2005
7 commits
-
This patch pulls the PCI-related junk out of struct device_node and
puts it in a separate structure, struct pci_dn. The device_node now
just has a void * pointer in it, which points to a struct pci_dn for
nodes that represent PCI devices. It could potentially be used in
future for device-specific data for other sorts of devices, such as
virtual I/O devices.Signed-off-by: Paul Mackerras
-
Currently rpaphp registers the following bus types as hotplug slots:
1) Actual PCI Hotplug slots
2) Embedded/Internal PCI slots
3) PCI Host BridgesThe second and third bus types are not actually direct parents of
removable adapters. As such, the rpaphp has special case code to fake
results for attributes like power, adapter status, etc. This patch
removes types 2 and 3 from the rpaphp module.This patch also changes the DLPAR module so that slots can be
DLPAR-added/removed without having been designated as hotplug-capable.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
This patch exports rpaphp_config_pci_adapter() for use by the rpadlpar
module. It also changes this function by removing any dependencies on
struct slot. The patch also changes the RPA DLPAR-add path to enable
newly-added slots in a separate step from that which registers them as
hotplug slots.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The rpaphp module currently uses a fragile method to find a pci device
by its device node. This function is unnecessary, so this patch scraps
it.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
The slot structure in the rpaphp module currently references the PCI
contents of the slot using the PCI device of the parent bridge. This
is unnecessary, since the module is actually interested in the
subordinate bus of the bridge. The dependency on a PCI bridge device
also prohibits the module from registering hotplug slots that have a
root bridge as a parent, since root bridges on PPC64 don't have PCI
devices.This patch changes struct slot to reference the PCI subsystem using a
pci_bus rather than a pci_dev.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
Currently, rpaphp registers Virtual I/O slots as hotplug slots. The
only purpose of this registration is to ensure that the VIO subsystem
is notified of new VIO buses during DLPAR adds. Similarly, rpaphp
notifies the VIO subsystem when a VIO bus is DLPAR-removed. The rpaphp
module has special case code to fake results for attributes like power,
adapter status, etc.The VIO register/unregister functions could just as easily be made from
the DLPAR module. This patch moves the VIO registration calls to the
DLPAR module, and removes the VIO fluff from rpaphp altogether.Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman -
Subject line says it all :)
Signed-off-by: John Rose
Signed-off-by: Greg Kroah-Hartman
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
