01 Sep, 2020

1 commit

  • The only usage of these are to assign their address to the ops field in
    the regulator_desc struct, which is a const pointer. Make them const to
    allow the compiler to put them in read-only memory.

    Signed-off-by: Rikard Falkeborn
    Link: https://lore.kernel.org/r/20200829221104.20870-7-rikard.falkeborn@gmail.com
    Signed-off-by: Mark Brown

    Rikard Falkeborn
     

19 Jun, 2019

1 commit

  • Based on 2 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation #

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 4122 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

20 Apr, 2018

1 commit


23 Jul, 2015

1 commit

  • of_regulator_match.driver_data is (void *). tps6586x uses it to store an
    anonymous enum value (those TPS6586X_ID_ values).

    Later, it tries to extract the ID by casting directly to an int, which is a
    no-no ([-Wpointer-to-int-cast]):

    drivers/regulator/tps6586x-regulator.c: In function 'tps6586x_parse_regulator_dt':
    drivers/regulator/tps6586x-regulator.c:430:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    id = (int)tps6586x_matches[i].driver_data;
    ^

    Instead of casting to int, uintptr_t is better suited for receiving and
    comparing integers extracted from void *. This is especially true on
    64-bit systems where sizeof(void *) != sizeof(int).

    Signed-off-by: Daniel Kurtz
    Signed-off-by: Mark Brown

    Daniel Kurtz
     

20 Oct, 2014

1 commit


06 Jun, 2014

1 commit


27 May, 2014

1 commit


26 May, 2014

2 commits


13 Mar, 2014

1 commit


20 Feb, 2014

1 commit


21 Jan, 2014

1 commit

  • Depending on the regulator version, the voltage table might be
    different. Use version specific regulator tables in order to select
    correct voltage table. For the following regulator versions different
    voltage tables are now used:

    * TPS658623: Use correct voltage table for SM2
    * TPS658643: New voltage table for SM2

    Both versions are in use on the Colibri T20 module. Make use of the
    correct tables by requesting the correct SM2 voltage of 1.8V.

    This change is not backward compatible since an old driver is not able
    to correctly set that value. The value 1.8V is out of range for the old
    driver and will refuse to probe the device. The regulator starts with
    default settings and the driver shows appropriate error messages.

    On Colibri T20, the old value used to work with TPS658623 since the
    driver applied a wrong voltage table too. However, the TPS658643 used
    on V1.2 devices uses yet another voltage table and those broke that
    pseudo-compatibility. The regulator driver now has the correct voltage
    table for both regulator versions and those the correct voltage can be
    used in the device tree.

    Signed-off-by: Stefan Agner
    Reviewed-by: Thierry Reding
    Acked-by: Mark Brown
    Acked-by: Stephen Warren
    Signed-off-by: Lee Jones

    Stefan Agner
     

24 Oct, 2013

1 commit


10 Oct, 2013

1 commit

  • As per the devicetree binding document of TPS6586x, the "regulators"
    subnode should be under the parent node, not outside of parent node.
    Hence to get the regulator node, the correct call is
    of_get_child_by_name() rather than of_find_node_by_name() which searches
    the "regulators" node from the parent node to end of DTS file.

    Signed-off-by: Laxman Dewangan
    Signed-off-by: Mark Brown

    Laxman Dewangan
     

17 Sep, 2013

1 commit


24 Jun, 2013

1 commit


28 Apr, 2013

1 commit


23 Apr, 2013

1 commit


04 Mar, 2013

2 commits


25 Dec, 2012

1 commit


10 Dec, 2012

1 commit


28 Nov, 2012

1 commit

  • When building the driver in debug mode, it generates
    warning as

    drivers/regulator/tps6586x-regulator.c: In function 'tps6586x_regulator_probe':
    drivers/regulator/tps6586x-regulator.c:392:9: warning: 'id' is used uninitialized in this function [-Wuninitialized]

    Fix this warning.

    Signed-off-by: Laxman Dewangan
    Reported-by: Stephen Warren
    Signed-off-by: Mark Brown

    Laxman Dewangan
     

20 Nov, 2012

4 commits


15 Nov, 2012

1 commit

  • Moving regulator node parsing to regulator driver in place
    of parsing it on mfd driver.
    The motivation for this change are:
    - MFD core driver should not depends on regulator and able
    to instantiate device without regulator.
    - The API for matching regulators are in regulator core and
    it is good that regulator driver only calls this API.
    - Regulator specific support should be in regulator driver only
    to ease any enhancement/modification for regulators.
    - The regulator driver is now registered as mfd sub device and
    all regulator registration is done from single probe call.

    Signed-off-by: Laxman Dewangan
    Signed-off-by: Mark Brown

    Laxman Dewangan
     

28 Sep, 2012

1 commit


06 Sep, 2012

1 commit

  • Device have SYS rail which is always ON. It is system power bus. LDO5
    and LDO_RTC get powered through this rail internally. Add support for
    this rail and make the LDO5/LDO_RTC supply by it. Update document
    accordingly.

    [swarren: Instantiate the sys regulator from board-harmony-power.c to
    avoid regression.]

    Signed-off-by: Laxman Dewangan
    Signed-off-by: Stephen Warren
    Signed-off-by: Mark Brown

    Laxman Dewangan
     

29 Aug, 2012

1 commit


08 Aug, 2012

1 commit

  • As per datasheet, the vin pin for the regulator is named
    as vin_sm0, vin_sm1, vin_sm2 for sm0, sm1 and sm2 respectively.

    Correcting the names in driver and documentation to match with
    datasheet.

    Signed-off-by: Laxman Dewangan
    Reported-by: Stephen Warren
    Acked-by: Stephen Warren
    Signed-off-by: Mark Brown

    Laxman Dewangan
     

13 Jul, 2012

1 commit


08 Jun, 2012

1 commit


04 May, 2012

1 commit


10 Apr, 2012

1 commit


09 Apr, 2012

1 commit

  • Rather than adding new arguments to regulator_register() every time we
    want to add a new bit of dynamic information at runtime change the function
    to take these via a struct. By doing this we avoid needing to do further
    changes like the recent addition of device tree support which required each
    regulator driver to be updated to take an additional parameter.

    The regulator_desc which should (mostly) be static data is still passed
    separately as most drivers are able to configure this statically at build
    time.

    Signed-off-by: Mark Brown

    Mark Brown
     

01 Apr, 2012

3 commits