16 Jul, 2020

1 commit

  • When use goldfish rtc, the "hwclock" command fails with "select() to
    /dev/rtc to wait for clock tick timed out". This is because "hwclock"
    need the set_alarm() hook to enable interrupt when alrm->enabled is
    true. This operation is missing in goldfish rtc (but other rtc drivers,
    such as cmos rtc, enable interrupt here), so add it.

    Signed-off-by: Huacai Chen
    Signed-off-by: Jiaxun Yang
    Signed-off-by: Alexandre Belloni
    Link: https://lore.kernel.org/r/1592654683-31314-1-git-send-email-chenhc@lemote.com

    Huacai Chen
     

30 May, 2020

1 commit


07 Oct, 2019

1 commit

  • Simplify probe by using a known wrapper function.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring
    Link: https://lore.kernel.org/r/4552ef52-f218-93b1-6dfa-668d137676f8@web.de
    Link: https://lore.kernel.org/r/5ecfcf43-d6b2-1a38-dee8-b8806f30bc83@web.de
    Link: https://lore.kernel.org/r/25448e11-c43f-9ae0-4c43-6f789accc026@web.de
    Reviewed-by: Akinobu Mita
    Link: https://lore.kernel.org/r/8c17a59c-82ff-aa6b-5653-a38d786d3e83@web.de
    Signed-off-by: Alexandre Belloni

    Markus Elfring
     

04 Apr, 2019

6 commits


14 Feb, 2018

1 commit

  • Fix the following warning in MIPS allmodconfig by adding a
    MODULE_LICENSE() at the end of rtc-goldfish.c, based on the file header
    comment which says GNU General Public License version 2:

    WARNING: modpost: missing MODULE_LICENSE() in drivers/rtc/rtc-goldfish.o

    Fixes: f22d9cdcb5eb ("rtc: goldfish: Add RTC driver for Android emulator")
    Signed-off-by: James Hogan
    Cc: Miodrag Dinic
    Cc: Alessandro Zummo
    Cc: Alexandre Belloni
    Cc: linux-rtc@vger.kernel.org
    Signed-off-by: Alexandre Belloni

    James Hogan
     

01 Sep, 2017

1 commit