Eric Lee / smarc-fsl-linux-kernel

26 Oct, 2020

1 commit

  • 23224e450   mm: remove kzfree() compatibility definition ... Browse Code »

    Commit 453431a54934 ("mm, treewide: rename kzfree() to
    kfree_sensitive()") renamed kzfree() to kfree_sensitive(),
    but it left a compatibility definition of kzfree() to avoid
    being too disruptive.

    Since then a few more instances of kzfree() have slipped in.

    Just get rid of them and remove the compatibility definition
    once and for all.

    Signed-off-by: Eric Biggers
    Signed-off-by: Linus Torvalds

    Eric Biggers
     

16 Oct, 2020

1 commit

  • ade7afe3e   Merge tag 'staging-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging ... Browse Code »

    Pull staging / IIO driver updates from Greg KH:
    "Here is the large set of staging and IIO driver updates for 5.10-rc1.

    Included in here are:

    - new IIO drivers

    - new IIO driver frameworks

    - various IIO driver fixes and updates

    - IIO device tree conversions to yaml

    - so many minor staging driver coding style cleanups

    - most cdev driver moved out of staging

    - no staging drivers added or removed

    Full details are in the shortlog.

    All of these have been in linux-next for a while with no reported
    issues"

    * tag 'staging-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (476 commits)
    staging: comedi: check validity of wMaxPacketSize of usb endpoints found
    staging: wfx: improve robustness of wfx_get_hw_rate()
    staging: wfx: drop unicode characters from strings
    staging: wfx: gpiod_get_value() can return an error
    staging: wfx: increase robustness of hif_generic_confirm()
    staging: wfx: wfx_init_common() returns NULL on error
    staging: wfx: standardize the error when vif does not exist
    staging: wfx: check memory allocation
    staging: wfx: improve error handling of hif_join()
    staging: dpaa2-switch: add a dpaa2_switch prefix to all functions in ethsw.c
    staging: dpaa2-switch: add a dpaa2_switch_ prefix to all functions in ethsw-ethtool.c
    staging: rtl8188eu: Fix long lines
    dt-bindings: staging: wfx: silabs,wfx yaml conversion
    staging: wfx: update copyrights dates
    staging: wfx: fix QoS priority for slow buses
    staging: wfx: fix BA sessions for older firmwares
    staging: wfx: remove remaining code of 'secure link' feature
    staging: wfx: fix handling of MMIC error
    staging: vchiq: Fix list_for_each exit tests
    staging: greybus: use __force when assigning __u8 value to snd_ctl_elem_type_t
    ...

    Linus Torvalds
     

20 Sep, 2020

2 commits

16 Sep, 2020

4 commits

  • 02c426071   staging: rtl8192e: fix kconfig dependency warning for RTLLIB_CRYPTO_WEP ... Browse Code »

    When RTLLIB_CRYPTO_WEP is enabled and CRYPTO is disabled, it results in
    the following Kbuild warning:

    WARNING: unmet direct dependencies detected for CRYPTO_ARC4
    Depends on [n]: CRYPTO [=n]
    Selected by [m]:
    - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]

    The reason is that RTLLIB_CRYPTO_WEP selects CRYPTO_ARC4 without depending
    on or selecting CRYPTO while CRYPTO_ARC4 is subordinate to CRYPTO.

    Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

    Fixes: e0e3daddad36 ("staging: r8192e: Fix possible error in configuration")
    Signed-off-by: Necip Fazil Yildiran
    Link: https://lore.kernel.org/r/20200915094209.22664-1-fazilyildiran@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Necip Fazil Yildiran
     
  • 243d040a6   staging: rtl8192e: fix kconfig dependency warning for RTLLIB_CRYPTO_TKIP ... Browse Code »

    When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, it results in
    the following Kbuild warning:

    WARNING: unmet direct dependencies detected for CRYPTO_ARC4
    Depends on [n]: CRYPTO [=n]
    Selected by [m]:
    - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]

    WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
    Depends on [n]: CRYPTO [=n]
    Selected by [m]:
    - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]

    The reason is that RTLLIB_CRYPTO_TKIP selects CRYPTO_ARC4 and
    CRYPTO_MICHAEL_MIC without depending on or selecting CRYPTO while both
    CRYPTO_ARC4 and CRYPTO_MICHAEL_MIC are subordinate to CRYPTO.

    Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

    Fixes: e0e3daddad36 ("staging: r8192e: Fix possible error in configuration")
    Signed-off-by: Necip Fazil Yildiran
    Link: https://lore.kernel.org/r/20200915093033.20130-1-fazilyildiran@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Necip Fazil Yildiran
     
  • 5f08dede6   staging: rtl8192e: fix kconfig dependency warning for RTLLIB_CRYPTO_CCMP ... Browse Code »

    When RTLLIB_CRYPTO_CCMP is enabled and CRYPTO is disabled, it results in
    the following Kbuild warning:

    WARNING: unmet direct dependencies detected for CRYPTO_CCM
    Depends on [n]: CRYPTO [=n]
    Selected by [m]:
    - RTLLIB_CRYPTO_CCMP [=m] && STAGING [=y] && RTLLIB [=m]

    WARNING: unmet direct dependencies detected for CRYPTO_AES
    Depends on [n]: CRYPTO [=n]
    Selected by [m]:
    - RTLLIB_CRYPTO_CCMP [=m] && STAGING [=y] && RTLLIB [=m]

    The reason is that RTLLIB_CRYPTO_CCMP selects CRYPTO_CCM and CRYPTO_AES
    without depending on or selecting CRYPTO while both CRYPTO_CCM and
    CRYPTO_ARC4 are subordinate to CRYPTO.

    Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

    Fixes: e0e3daddad36 ("staging: r8192e: Fix possible error in configuration")
    Signed-off-by: Necip Fazil Yildiran
    Link: https://lore.kernel.org/r/20200915095408.28092-1-fazilyildiran@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Necip Fazil Yildiran
     
  • 49391bf28   staging: rtl8192e: convert tasklets to use new tasklet_setup() API ... Browse Code »

    In preparation for unconditionally passing the
    struct tasklet_struct pointer to all tasklet
    callbacks, switch to using the new tasklet_setup()
    and from_tasklet() to pass the tasklet pointer explicitly.

    Signed-off-by: Romain Perier
    Signed-off-by: Allen Pais
    Link: https://lore.kernel.org/r/20200916062054.58084-1-allen.lkml@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Allen Pais
     

11 Sep, 2020

1 commit

18 Aug, 2020

1 commit

28 Jul, 2020

1 commit

  • 49e86ae13   staging: rtl8192e: Use fallthrough pseudo-keyword ... Browse Code »

    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1].

    [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva
    Link: https://lore.kernel.org/r/20200727191006.GA30474@embeddedor
    Signed-off-by: Greg Kroah-Hartman

    Gustavo A. R. Silva
     

21 Jul, 2020

2 commits

  • 846fbc621   staging: rtl8192e: add proper code indent ... Browse Code »

    As the code indent for a conditional statement is
    not according to the preferred coding style for
    the linux kernel, add code indent as necessary
    after a conditional statement.

    Signed-off-by: Darshan D V
    Link: https://lore.kernel.org/r/20200720091442.19532-2-darshandv10@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Darshan D V
     
  • 77cedcc0b   staging: rtl8192e: add space before open parenthesis ... Browse Code »

    Fix the coding style error by adding a space before
    open parenthesis '(' in a conditional statement.

    Signed-off-by: Darshan D V
    Link: https://lore.kernel.org/r/20200720091442.19532-1-darshandv10@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Darshan D V
     

13 Jul, 2020

2 commits

  • 8aaeac5be   staging: rtl8192e: rtl_core: Remove pci-dma-compat wrapper APIs. ... Browse Code »

    The legacy API wrappers in include/linux/pci-dma-compat.h
    should go away as it creates unnecessary midlayering
    for include/linux/dma-mapping.h APIs, instead use dma-mapping.h
    APIs directly.

    The patch has been generated with the coccinelle script below
    and compile-tested.

    @@@@
    - PCI_DMA_BIDIRECTIONAL
    + DMA_BIDIRECTIONAL

    @@@@
    - PCI_DMA_TODEVICE
    + DMA_TO_DEVICE

    @@@@
    - PCI_DMA_FROMDEVICE
    + DMA_FROM_DEVICE

    @@@@
    - PCI_DMA_NONE
    + DMA_NONE

    @@ expression E1, E2, E3; @@
    - pci_alloc_consistent(E1, E2, E3)
    + dma_alloc_coherent(&E1->dev, E2, E3, GFP_ATOMIC)

    @@ expression E1, E2, E3; @@
    - pci_zalloc_consistent(E1, E2, E3)
    + dma_alloc_coherent(&E1->dev, E2, E3, GFP_ATOMIC)

    @@ expression E1, E2, E3, E4; @@
    - pci_free_consistent(E1, E2, E3, E4)
    + dma_free_coherent(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_map_single(E1, E2, E3, E4)
    + dma_map_single(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_single(E1, E2, E3, E4)
    + dma_unmap_single(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4, E5; @@
    - pci_map_page(E1, E2, E3, E4, E5)
    + dma_map_page(&E1->dev, E2, E3, E4, E5)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_page(E1, E2, E3, E4)
    + dma_unmap_page(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_map_sg(E1, E2, E3, E4)
    + dma_map_sg(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_sg(E1, E2, E3, E4)
    + dma_unmap_sg(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_single_for_cpu(E1, E2, E3, E4)
    + dma_sync_single_for_cpu(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_single_for_device(E1, E2, E3, E4)
    + dma_sync_single_for_device(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_sg_for_cpu(E1, E2, E3, E4)
    + dma_sync_sg_for_cpu(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_sg_for_device(E1, E2, E3, E4)
    + dma_sync_sg_for_device(&E1->dev, E2, E3, E4)

    @@ expression E1, E2; @@
    - pci_dma_mapping_error(E1, E2)
    + dma_mapping_error(&E1->dev, E2)

    @@ expression E1, E2; @@
    - pci_set_consistent_dma_mask(E1, E2)
    + dma_set_coherent_mask(&E1->dev, E2)

    @@ expression E1, E2; @@
    - pci_set_dma_mask(E1, E2)
    + dma_set_mask(&E1->dev, E2)

    Signed-off-by: Suraj Upadhyay
    Link: https://lore.kernel.org/r/20200711132349.GA21618@blackclown
    Signed-off-by: Greg Kroah-Hartman

    Suraj Upadhyay
     
  • e4c9b73ba   staging: rtl8192e: rtl8192E_dev: Remove pci-dma-compat wrapper APIs. ... Browse Code »

    The legacy API wrappers in include/linux/pci-dma-compat.h
    should go away as it creates unnecessary midlayering
    for include/linux/dma-mapping.h APIs, instead use dma-mapping.h
    APIs directly.

    The patch has been generated with the coccinelle script below
    and compile-tested.

    @@@@
    - PCI_DMA_BIDIRECTIONAL
    + DMA_BIDIRECTIONAL

    @@@@
    - PCI_DMA_TODEVICE
    + DMA_TO_DEVICE

    @@@@
    - PCI_DMA_FROMDEVICE
    + DMA_FROM_DEVICE

    @@@@
    - PCI_DMA_NONE
    + DMA_NONE

    @@ expression E1, E2, E3; @@
    - pci_alloc_consistent(E1, E2, E3)
    + dma_alloc_coherent(&E1->dev, E2, E3, GFP_ATOMIC)

    @@ expression E1, E2, E3; @@
    - pci_zalloc_consistent(E1, E2, E3)
    + dma_alloc_coherent(&E1->dev, E2, E3, GFP_ATOMIC)

    @@ expression E1, E2, E3, E4; @@
    - pci_free_consistent(E1, E2, E3, E4)
    + dma_free_coherent(&E1->dev, E2, E3, E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_map_single(E1, E2, E3, E4)
    + dma_map_single(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_single(E1, E2, E3, E4)
    + dma_unmap_single(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4, E5; @@
    - pci_map_page(E1, E2, E3, E4, E5)
    + dma_map_page(&E1->dev, E2, E3, E4, (enum dma_data_direction)E5)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_page(E1, E2, E3, E4)
    + dma_unmap_page(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_map_sg(E1, E2, E3, E4)
    + dma_map_sg(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_unmap_sg(E1, E2, E3, E4)
    + dma_unmap_sg(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_single_for_cpu(E1, E2, E3, E4)
    + dma_sync_single_for_cpu(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_single_for_device(E1, E2, E3, E4)
    + dma_sync_single_for_device(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_sg_for_cpu(E1, E2, E3, E4)
    + dma_sync_sg_for_cpu(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2, E3, E4; @@
    - pci_dma_sync_sg_for_device(E1, E2, E3, E4)
    + dma_sync_sg_for_device(&E1->dev, E2, E3, (enum dma_data_direction)E4)

    @@ expression E1, E2; @@
    - pci_dma_mapping_error(E1, E2)
    + dma_mapping_error(&E1->dev, E2)

    @@ expression E1, E2; @@
    - pci_set_consistent_dma_mask(E1, E2)
    + dma_set_coherent_mask(&E1->dev, E2)

    @@ expression E1, E2; @@
    - pci_set_dma_mask(E1, E2)
    + dma_set_mask(&E1->dev, E2)

    Signed-off-by: Suraj Upadhyay
    Link: https://lore.kernel.org/r/20200711131623.GA20537@blackclown
    Signed-off-by: Greg Kroah-Hartman

    Suraj Upadhyay
     

01 Jul, 2020

1 commit

  • 0c90789ad   staging: rtl8192e: use generic power management ... Browse Code »

    The structure of working of PM hooks for source files is:
    drivers/staging/rtl8192e/rtl8192e/rtl_pm.h : callbacks declared
    drivers/staging/rtl8192e/rtl8192e/rtl_pm.c : callbacks defined
    drivers/staging/rtl8192e/rtl8192e/rtl_core.c : callbacks used

    Drivers should not use legacy power management as they have to manage power
    states and related operations, for the device, themselves. This driver was
    handling them with the help of PCI helper functions like
    pci_save/restore_state(), pci_enable/disable_device(), etc.

    With generic PM, all essentials will be handled by the PCI core. Driver
    needs to do only device-specific operations.

    The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
    device_wakeup_disable() instead. Use device_set_wakeup_enable() where WOL
    is decided by the value of a variable during runtime.

    Compile-tested only.

    Signed-off-by: Vaibhav Gupta
    Link: https://lore.kernel.org/r/20200629082819.216405-3-vaibhavgupta40@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Vaibhav Gupta
     

27 May, 2020

2 commits

21 May, 2020

1 commit

13 Apr, 2020

1 commit

12 Mar, 2020

1 commit

24 Feb, 2020

2 commits

  • df08620ea   staging: rtl8192e: remove redundant initialization of variable init_status ... Browse Code »

    The pointer init_status is being initialized with a value that is never
    read, it is being updated later on. The initialization is redundant
    and can be removed.

    Addresses-Coverity: ("Unused value")
    Signed-off-by: Colin Ian King
    Link: https://lore.kernel.org/r/20200222200105.201869-1-colin.king@canonical.com
    Signed-off-by: Greg Kroah-Hartman

    Colin Ian King
     
  • 5979afa2c   staging: Replace zero-length array with flexible-array member ... Browse Code »

    The current codebase makes use of the zero-length array language
    extension to the C90 standard, but the preferred mechanism to declare
    variable-length types such as these ones is a flexible array member[1][2],
    introduced in C99:

    struct foo {
    int stuff;
    struct boo array[];
    };

    By making use of the mechanism above, we will get a compiler warning
    in case the flexible array does not occur last in the structure, which
    will help us prevent some kind of undefined behavior bugs from being
    inadvertently introduced[3] to the codebase from now on.

    Also, notice that, dynamic memory allocations won't be affected by
    this change:

    "Flexible array members have incomplete type, and so the sizeof operator
    may not be applied. As a quirk of the original implementation of
    zero-length arrays, sizeof evaluates to zero."[1]

    This issue was found with the help of Coccinelle.

    [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
    [2] https://github.com/KSPP/linux/issues/21
    [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

    Signed-off-by: Gustavo A. R. Silva
    Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedor
    Signed-off-by: Greg Kroah-Hartman

    Gustavo A. R. Silva
     

10 Feb, 2020

1 commit

30 Jan, 2020

1 commit

  • 7ba31c3f2   Merge tag 'staging-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging ... Browse Code »

    Pull staging and IIO updates from Greg KH:
    "Here is the big staging/iio driver patches for 5.6-rc1

    Included in here are:

    - lots of new IIO drivers and updates for that subsystem

    - the usual huge quantity of minor cleanups for staging drivers

    - removal of the following staging drivers:
    - isdn/avm
    - isdn/gigaset
    - isdn/hysdn
    - octeon-usb
    - octeon ethernet

    Overall we deleted far more lines than we added, removing over 40k of
    old and obsolete driver code.

    All of these changes have been in linux-next for a while with no
    reported issues"

    * tag 'staging-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (353 commits)
    staging: most: usb: check for NULL device
    staging: next: configfs: fix release link
    staging: most: core: fix logging messages
    staging: most: core: remove container struct
    staging: most: remove struct device core driver
    staging: most: core: drop device reference
    staging: most: remove device from interface structure
    staging: comedi: drivers: fix spelling mistake "to" -> "too"
    staging: exfat: remove fs_func struct.
    staging: wilc1000: avoid mutex unlock without lock in wilc_wlan_handle_txq()
    staging: wilc1000: return zero on success and non-zero on function failure
    staging: axis-fifo: replace spinlock with mutex
    staging: wilc1000: remove unused code prior to throughput enhancement in SPI
    staging: wilc1000: added 'wilc_' prefix for 'struct assoc_resp' name
    staging: wilc1000: move firmware API struct's to separate header file
    staging: wilc1000: remove use of infinite loop conditions
    staging: kpc2000: rename variables with kpc namespace
    staging: vt6656: Remove memory buffer from vnt_download_firmware.
    staging: vt6656: Just check NEWRSR_DECRYPTOK for RX_FLAG_DECRYPTED.
    staging: vt6656: Use vnt_rx_tail struct for tail variables.
    ...

    Linus Torvalds
     

29 Jan, 2020

1 commit

  • bd2463ac7   Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next ... Browse Code »

    Pull networking updates from David Miller:

    1) Add WireGuard

    2) Add HE and TWT support to ath11k driver, from John Crispin.

    3) Add ESP in TCP encapsulation support, from Sabrina Dubroca.

    4) Add variable window congestion control to TIPC, from Jon Maloy.

    5) Add BCM84881 PHY driver, from Russell King.

    6) Start adding netlink support for ethtool operations, from Michal
    Kubecek.

    7) Add XDP drop and TX action support to ena driver, from Sameeh
    Jubran.

    8) Add new ipv4 route notifications so that mlxsw driver does not have
    to handle identical routes itself. From Ido Schimmel.

    9) Add BPF dynamic program extensions, from Alexei Starovoitov.

    10) Support RX and TX timestamping in igc, from Vinicius Costa Gomes.

    11) Add support for macsec HW offloading, from Antoine Tenart.

    12) Add initial support for MPTCP protocol, from Christoph Paasch,
    Matthieu Baerts, Florian Westphal, Peter Krystad, and many others.

    13) Add Octeontx2 PF support, from Sunil Goutham, Geetha sowjanya, Linu
    Cherian, and others.

    * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next: (1469 commits)
    net: phy: add default ARCH_BCM_IPROC for MDIO_BCM_IPROC
    udp: segment looped gso packets correctly
    netem: change mailing list
    qed: FW 8.42.2.0 debug features
    qed: rt init valid initialization changed
    qed: Debug feature: ilt and mdump
    qed: FW 8.42.2.0 Add fw overlay feature
    qed: FW 8.42.2.0 HSI changes
    qed: FW 8.42.2.0 iscsi/fcoe changes
    qed: Add abstraction for different hsi values per chip
    qed: FW 8.42.2.0 Additional ll2 type
    qed: Use dmae to write to widebus registers in fw_funcs
    qed: FW 8.42.2.0 Parser offsets modified
    qed: FW 8.42.2.0 Queue Manager changes
    qed: FW 8.42.2.0 Expose new registers and change windows
    qed: FW 8.42.2.0 Internal ram offsets modifications
    MAINTAINERS: Add entry for Marvell OcteonTX2 Physical Function driver
    Documentation: net: octeontx2: Add RVU HW and drivers overview
    octeontx2-pf: ethtool RSS config support
    octeontx2-pf: Add basic ethtool support
    ...

    Linus Torvalds
     

22 Jan, 2020

1 commit

06 Jan, 2020

1 commit

13 Dec, 2019

1 commit

  • 0290bd291   netdev: pass the stuck queue to the timeout handler ... Browse Code »

    This allows incrementing the correct timeout statistic without any mess.
    Down the road, devices can learn to reset just the specific queue.

    The patch was generated with the following script:

    use strict;
    use warnings;

    our $^I = '.bak';

    my @work = (
    ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"],
    ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"],
    ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"],
    ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"],
    ["drivers/char/pcmcia/synclink_cs.c", "hdlcdev_tx_timeout"],
    ["drivers/infiniband/ulp/ipoib/ipoib_main.c", "ipoib_timeout"],
    ["drivers/infiniband/ulp/ipoib/ipoib_main.c", "ipoib_timeout"],
    ["drivers/message/fusion/mptlan.c", "mpt_lan_tx_timeout"],
    ["drivers/misc/sgi-xp/xpnet.c", "xpnet_dev_tx_timeout"],
    ["drivers/net/appletalk/cops.c", "cops_timeout"],
    ["drivers/net/arcnet/arcdevice.h", "arcnet_timeout"],
    ["drivers/net/arcnet/arcnet.c", "arcnet_timeout"],
    ["drivers/net/arcnet/com20020.c", "arcnet_timeout"],
    ["drivers/net/ethernet/3com/3c509.c", "el3_tx_timeout"],
    ["drivers/net/ethernet/3com/3c515.c", "corkscrew_timeout"],
    ["drivers/net/ethernet/3com/3c574_cs.c", "el3_tx_timeout"],
    ["drivers/net/ethernet/3com/3c589_cs.c", "el3_tx_timeout"],
    ["drivers/net/ethernet/3com/3c59x.c", "vortex_tx_timeout"],
    ["drivers/net/ethernet/3com/3c59x.c", "vortex_tx_timeout"],
    ["drivers/net/ethernet/3com/typhoon.c", "typhoon_tx_timeout"],
    ["drivers/net/ethernet/8390/8390.h", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/8390.h", "eip_tx_timeout"],
    ["drivers/net/ethernet/8390/8390.c", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/8390p.c", "eip_tx_timeout"],
    ["drivers/net/ethernet/8390/ax88796.c", "ax_ei_tx_timeout"],
    ["drivers/net/ethernet/8390/axnet_cs.c", "axnet_tx_timeout"],
    ["drivers/net/ethernet/8390/etherh.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/8390/hydra.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/8390/mac8390.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/8390/mcf8390.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/8390/lib8390.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/8390/ne2k-pci.c", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/pcnet_cs.c", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/smc-ultra.c", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/wd.c", "ei_tx_timeout"],
    ["drivers/net/ethernet/8390/zorro8390.c", "__ei_tx_timeout"],
    ["drivers/net/ethernet/adaptec/starfire.c", "tx_timeout"],
    ["drivers/net/ethernet/agere/et131x.c", "et131x_tx_timeout"],
    ["drivers/net/ethernet/allwinner/sun4i-emac.c", "emac_timeout"],
    ["drivers/net/ethernet/alteon/acenic.c", "ace_watchdog"],
    ["drivers/net/ethernet/amazon/ena/ena_netdev.c", "ena_tx_timeout"],
    ["drivers/net/ethernet/amd/7990.h", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/7990.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/a2065.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/am79c961a.c", "am79c961_timeout"],
    ["drivers/net/ethernet/amd/amd8111e.c", "amd8111e_tx_timeout"],
    ["drivers/net/ethernet/amd/ariadne.c", "ariadne_tx_timeout"],
    ["drivers/net/ethernet/amd/atarilance.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/au1000_eth.c", "au1000_tx_timeout"],
    ["drivers/net/ethernet/amd/declance.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/lance.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/mvme147.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/ni65.c", "ni65_timeout"],
    ["drivers/net/ethernet/amd/nmclan_cs.c", "mace_tx_timeout"],
    ["drivers/net/ethernet/amd/pcnet32.c", "pcnet32_tx_timeout"],
    ["drivers/net/ethernet/amd/sunlance.c", "lance_tx_timeout"],
    ["drivers/net/ethernet/amd/xgbe/xgbe-drv.c", "xgbe_tx_timeout"],
    ["drivers/net/ethernet/apm/xgene-v2/main.c", "xge_timeout"],
    ["drivers/net/ethernet/apm/xgene/xgene_enet_main.c", "xgene_enet_timeout"],
    ["drivers/net/ethernet/apple/macmace.c", "mace_tx_timeout"],
    ["drivers/net/ethernet/atheros/ag71xx.c", "ag71xx_tx_timeout"],
    ["drivers/net/ethernet/atheros/alx/main.c", "alx_tx_timeout"],
    ["drivers/net/ethernet/atheros/atl1c/atl1c_main.c", "atl1c_tx_timeout"],
    ["drivers/net/ethernet/atheros/atl1e/atl1e_main.c", "atl1e_tx_timeout"],
    ["drivers/net/ethernet/atheros/atlx/atl.c", "atlx_tx_timeout"],
    ["drivers/net/ethernet/atheros/atlx/atl1.c", "atlx_tx_timeout"],
    ["drivers/net/ethernet/atheros/atlx/atl2.c", "atl2_tx_timeout"],
    ["drivers/net/ethernet/broadcom/b44.c", "b44_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bcmsysport.c", "bcm_sysport_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bnx2.c", "bnx2_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h", "bnx2x_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c", "bnx2x_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c", "bnx2x_tx_timeout"],
    ["drivers/net/ethernet/broadcom/bnxt/bnxt.c", "bnxt_tx_timeout"],
    ["drivers/net/ethernet/broadcom/genet/bcmgenet.c", "bcmgenet_timeout"],
    ["drivers/net/ethernet/broadcom/sb1250-mac.c", "sbmac_tx_timeout"],
    ["drivers/net/ethernet/broadcom/tg3.c", "tg3_tx_timeout"],
    ["drivers/net/ethernet/calxeda/xgmac.c", "xgmac_tx_timeout"],
    ["drivers/net/ethernet/cavium/liquidio/lio_main.c", "liquidio_tx_timeout"],
    ["drivers/net/ethernet/cavium/liquidio/lio_vf_main.c", "liquidio_tx_timeout"],
    ["drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c", "lio_vf_rep_tx_timeout"],
    ["drivers/net/ethernet/cavium/thunder/nicvf_main.c", "nicvf_tx_timeout"],
    ["drivers/net/ethernet/cirrus/cs89x0.c", "net_timeout"],
    ["drivers/net/ethernet/cisco/enic/enic_main.c", "enic_tx_timeout"],
    ["drivers/net/ethernet/cisco/enic/enic_main.c", "enic_tx_timeout"],
    ["drivers/net/ethernet/cortina/gemini.c", "gmac_tx_timeout"],
    ["drivers/net/ethernet/davicom/dm9000.c", "dm9000_timeout"],
    ["drivers/net/ethernet/dec/tulip/de2104x.c", "de_tx_timeout"],
    ["drivers/net/ethernet/dec/tulip/tulip_core.c", "tulip_tx_timeout"],
    ["drivers/net/ethernet/dec/tulip/winbond-840.c", "tx_timeout"],
    ["drivers/net/ethernet/dlink/dl2k.c", "rio_tx_timeout"],
    ["drivers/net/ethernet/dlink/sundance.c", "tx_timeout"],
    ["drivers/net/ethernet/emulex/benet/be_main.c", "be_tx_timeout"],
    ["drivers/net/ethernet/ethoc.c", "ethoc_tx_timeout"],
    ["drivers/net/ethernet/faraday/ftgmac100.c", "ftgmac100_tx_timeout"],
    ["drivers/net/ethernet/fealnx.c", "fealnx_tx_timeout"],
    ["drivers/net/ethernet/freescale/dpaa/dpaa_eth.c", "dpaa_tx_timeout"],
    ["drivers/net/ethernet/freescale/fec_main.c", "fec_timeout"],
    ["drivers/net/ethernet/freescale/fec_mpc52xx.c", "mpc52xx_fec_tx_timeout"],
    ["drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c", "fs_timeout"],
    ["drivers/net/ethernet/freescale/gianfar.c", "gfar_timeout"],
    ["drivers/net/ethernet/freescale/ucc_geth.c", "ucc_geth_timeout"],
    ["drivers/net/ethernet/fujitsu/fmvj18x_cs.c", "fjn_tx_timeout"],
    ["drivers/net/ethernet/google/gve/gve_main.c", "gve_tx_timeout"],
    ["drivers/net/ethernet/hisilicon/hip04_eth.c", "hip04_timeout"],
    ["drivers/net/ethernet/hisilicon/hix5hd2_gmac.c", "hix5hd2_net_timeout"],
    ["drivers/net/ethernet/hisilicon/hns/hns_enet.c", "hns_nic_net_timeout"],
    ["drivers/net/ethernet/hisilicon/hns3/hns3_enet.c", "hns3_nic_net_timeout"],
    ["drivers/net/ethernet/huawei/hinic/hinic_main.c", "hinic_tx_timeout"],
    ["drivers/net/ethernet/i825xx/82596.c", "i596_tx_timeout"],
    ["drivers/net/ethernet/i825xx/ether1.c", "ether1_timeout"],
    ["drivers/net/ethernet/i825xx/lib82596.c", "i596_tx_timeout"],
    ["drivers/net/ethernet/i825xx/sun3_82586.c", "sun3_82586_timeout"],
    ["drivers/net/ethernet/ibm/ehea/ehea_main.c", "ehea_tx_watchdog"],
    ["drivers/net/ethernet/ibm/emac/core.c", "emac_tx_timeout"],
    ["drivers/net/ethernet/ibm/emac/core.c", "emac_tx_timeout"],
    ["drivers/net/ethernet/ibm/ibmvnic.c", "ibmvnic_tx_timeout"],
    ["drivers/net/ethernet/intel/e100.c", "e100_tx_timeout"],
    ["drivers/net/ethernet/intel/e1000/e1000_main.c", "e1000_tx_timeout"],
    ["drivers/net/ethernet/intel/e1000e/netdev.c", "e1000_tx_timeout"],
    ["drivers/net/ethernet/intel/fm10k/fm10k_netdev.c", "fm10k_tx_timeout"],
    ["drivers/net/ethernet/intel/i40e/i40e_main.c", "i40e_tx_timeout"],
    ["drivers/net/ethernet/intel/iavf/iavf_main.c", "iavf_tx_timeout"],
    ["drivers/net/ethernet/intel/ice/ice_main.c", "ice_tx_timeout"],
    ["drivers/net/ethernet/intel/ice/ice_main.c", "ice_tx_timeout"],
    ["drivers/net/ethernet/intel/igb/igb_main.c", "igb_tx_timeout"],
    ["drivers/net/ethernet/intel/igbvf/netdev.c", "igbvf_tx_timeout"],
    ["drivers/net/ethernet/intel/ixgb/ixgb_main.c", "ixgb_tx_timeout"],
    ["drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c", "adapter->netdev->netdev_ops->ndo_tx_timeout(adapter->netdev);"],
    ["drivers/net/ethernet/intel/ixgbe/ixgbe_main.c", "ixgbe_tx_timeout"],
    ["drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c", "ixgbevf_tx_timeout"],
    ["drivers/net/ethernet/jme.c", "jme_tx_timeout"],
    ["drivers/net/ethernet/korina.c", "korina_tx_timeout"],
    ["drivers/net/ethernet/lantiq_etop.c", "ltq_etop_tx_timeout"],
    ["drivers/net/ethernet/marvell/mv643xx_eth.c", "mv643xx_eth_tx_timeout"],
    ["drivers/net/ethernet/marvell/pxa168_eth.c", "pxa168_eth_tx_timeout"],
    ["drivers/net/ethernet/marvell/skge.c", "skge_tx_timeout"],
    ["drivers/net/ethernet/marvell/sky2.c", "sky2_tx_timeout"],
    ["drivers/net/ethernet/marvell/sky2.c", "sky2_tx_timeout"],
    ["drivers/net/ethernet/mediatek/mtk_eth_soc.c", "mtk_tx_timeout"],
    ["drivers/net/ethernet/mellanox/mlx4/en_netdev.c", "mlx4_en_tx_timeout"],
    ["drivers/net/ethernet/mellanox/mlx4/en_netdev.c", "mlx4_en_tx_timeout"],
    ["drivers/net/ethernet/mellanox/mlx5/core/en_main.c", "mlx5e_tx_timeout"],
    ["drivers/net/ethernet/micrel/ks8842.c", "ks8842_tx_timeout"],
    ["drivers/net/ethernet/micrel/ksz884x.c", "netdev_tx_timeout"],
    ["drivers/net/ethernet/microchip/enc28j60.c", "enc28j60_tx_timeout"],
    ["drivers/net/ethernet/microchip/encx24j600.c", "encx24j600_tx_timeout"],
    ["drivers/net/ethernet/natsemi/sonic.h", "sonic_tx_timeout"],
    ["drivers/net/ethernet/natsemi/sonic.c", "sonic_tx_timeout"],
    ["drivers/net/ethernet/natsemi/jazzsonic.c", "sonic_tx_timeout"],
    ["drivers/net/ethernet/natsemi/macsonic.c", "sonic_tx_timeout"],
    ["drivers/net/ethernet/natsemi/natsemi.c", "ns_tx_timeout"],
    ["drivers/net/ethernet/natsemi/ns83820.c", "ns83820_tx_timeout"],
    ["drivers/net/ethernet/natsemi/xtsonic.c", "sonic_tx_timeout"],
    ["drivers/net/ethernet/neterion/s2io.h", "s2io_tx_watchdog"],
    ["drivers/net/ethernet/neterion/s2io.c", "s2io_tx_watchdog"],
    ["drivers/net/ethernet/neterion/vxge/vxge-main.c", "vxge_tx_watchdog"],
    ["drivers/net/ethernet/netronome/nfp/nfp_net_common.c", "nfp_net_tx_timeout"],
    ["drivers/net/ethernet/nvidia/forcedeth.c", "nv_tx_timeout"],
    ["drivers/net/ethernet/nvidia/forcedeth.c", "nv_tx_timeout"],
    ["drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c", "pch_gbe_tx_timeout"],
    ["drivers/net/ethernet/packetengines/hamachi.c", "hamachi_tx_timeout"],
    ["drivers/net/ethernet/packetengines/yellowfin.c", "yellowfin_tx_timeout"],
    ["drivers/net/ethernet/pensando/ionic/ionic_lif.c", "ionic_tx_timeout"],
    ["drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c", "netxen_tx_timeout"],
    ["drivers/net/ethernet/qlogic/qla3xxx.c", "ql3xxx_tx_timeout"],
    ["drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c", "qlcnic_tx_timeout"],
    ["drivers/net/ethernet/qualcomm/emac/emac.c", "emac_tx_timeout"],
    ["drivers/net/ethernet/qualcomm/qca_spi.c", "qcaspi_netdev_tx_timeout"],
    ["drivers/net/ethernet/qualcomm/qca_uart.c", "qcauart_netdev_tx_timeout"],
    ["drivers/net/ethernet/rdc/r6040.c", "r6040_tx_timeout"],
    ["drivers/net/ethernet/realtek/8139cp.c", "cp_tx_timeout"],
    ["drivers/net/ethernet/realtek/8139too.c", "rtl8139_tx_timeout"],
    ["drivers/net/ethernet/realtek/atp.c", "tx_timeout"],
    ["drivers/net/ethernet/realtek/r8169_main.c", "rtl8169_tx_timeout"],
    ["drivers/net/ethernet/renesas/ravb_main.c", "ravb_tx_timeout"],
    ["drivers/net/ethernet/renesas/sh_eth.c", "sh_eth_tx_timeout"],
    ["drivers/net/ethernet/renesas/sh_eth.c", "sh_eth_tx_timeout"],
    ["drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c", "sxgbe_tx_timeout"],
    ["drivers/net/ethernet/seeq/ether3.c", "ether3_timeout"],
    ["drivers/net/ethernet/seeq/sgiseeq.c", "timeout"],
    ["drivers/net/ethernet/sfc/efx.c", "efx_watchdog"],
    ["drivers/net/ethernet/sfc/falcon/efx.c", "ef4_watchdog"],
    ["drivers/net/ethernet/sgi/ioc3-eth.c", "ioc3_timeout"],
    ["drivers/net/ethernet/sgi/meth.c", "meth_tx_timeout"],
    ["drivers/net/ethernet/silan/sc92031.c", "sc92031_tx_timeout"],
    ["drivers/net/ethernet/sis/sis190.c", "sis190_tx_timeout"],
    ["drivers/net/ethernet/sis/sis900.c", "sis900_tx_timeout"],
    ["drivers/net/ethernet/smsc/epic100.c", "epic_tx_timeout"],
    ["drivers/net/ethernet/smsc/smc911x.c", "smc911x_timeout"],
    ["drivers/net/ethernet/smsc/smc9194.c", "smc_timeout"],
    ["drivers/net/ethernet/smsc/smc91c92_cs.c", "smc_tx_timeout"],
    ["drivers/net/ethernet/smsc/smc91x.c", "smc_timeout"],
    ["drivers/net/ethernet/stmicro/stmmac/stmmac_main.c", "stmmac_tx_timeout"],
    ["drivers/net/ethernet/sun/cassini.c", "cas_tx_timeout"],
    ["drivers/net/ethernet/sun/ldmvsw.c", "sunvnet_tx_timeout_common"],
    ["drivers/net/ethernet/sun/niu.c", "niu_tx_timeout"],
    ["drivers/net/ethernet/sun/sunbmac.c", "bigmac_tx_timeout"],
    ["drivers/net/ethernet/sun/sungem.c", "gem_tx_timeout"],
    ["drivers/net/ethernet/sun/sunhme.c", "happy_meal_tx_timeout"],
    ["drivers/net/ethernet/sun/sunqe.c", "qe_tx_timeout"],
    ["drivers/net/ethernet/sun/sunvnet.c", "sunvnet_tx_timeout_common"],
    ["drivers/net/ethernet/sun/sunvnet_common.c", "sunvnet_tx_timeout_common"],
    ["drivers/net/ethernet/sun/sunvnet_common.h", "sunvnet_tx_timeout_common"],
    ["drivers/net/ethernet/synopsys/dwc-xlgmac-net.c", "xlgmac_tx_timeout"],
    ["drivers/net/ethernet/ti/cpmac.c", "cpmac_tx_timeout"],
    ["drivers/net/ethernet/ti/cpsw.c", "cpsw_ndo_tx_timeout"],
    ["drivers/net/ethernet/ti/cpsw_priv.c", "cpsw_ndo_tx_timeout"],
    ["drivers/net/ethernet/ti/cpsw_priv.h", "cpsw_ndo_tx_timeout"],
    ["drivers/net/ethernet/ti/davinci_emac.c", "emac_dev_tx_timeout"],
    ["drivers/net/ethernet/ti/netcp_core.c", "netcp_ndo_tx_timeout"],
    ["drivers/net/ethernet/ti/tlan.c", "tlan_tx_timeout"],
    ["drivers/net/ethernet/toshiba/ps3_gelic_net.h", "gelic_net_tx_timeout"],
    ["drivers/net/ethernet/toshiba/ps3_gelic_net.c", "gelic_net_tx_timeout"],
    ["drivers/net/ethernet/toshiba/ps3_gelic_wireless.c", "gelic_net_tx_timeout"],
    ["drivers/net/ethernet/toshiba/spider_net.c", "spider_net_tx_timeout"],
    ["drivers/net/ethernet/toshiba/tc35815.c", "tc35815_tx_timeout"],
    ["drivers/net/ethernet/via/via-rhine.c", "rhine_tx_timeout"],
    ["drivers/net/ethernet/wiznet/w5100.c", "w5100_tx_timeout"],
    ["drivers/net/ethernet/wiznet/w5300.c", "w5300_tx_timeout"],
    ["drivers/net/ethernet/xilinx/xilinx_emaclite.c", "xemaclite_tx_timeout"],
    ["drivers/net/ethernet/xircom/xirc2ps_cs.c", "xirc_tx_timeout"],
    ["drivers/net/fjes/fjes_main.c", "fjes_tx_retry"],
    ["drivers/net/slip/slip.c", "sl_tx_timeout"],
    ["include/linux/usb/usbnet.h", "usbnet_tx_timeout"],
    ["drivers/net/usb/aqc111.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/asix_devices.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/asix_devices.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/asix_devices.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/ax88172a.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/ax88179_178a.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/catc.c", "catc_tx_timeout"],
    ["drivers/net/usb/cdc_mbim.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/cdc_ncm.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/dm9601.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/hso.c", "hso_net_tx_timeout"],
    ["drivers/net/usb/int51x1.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/ipheth.c", "ipheth_tx_timeout"],
    ["drivers/net/usb/kaweth.c", "kaweth_tx_timeout"],
    ["drivers/net/usb/lan78xx.c", "lan78xx_tx_timeout"],
    ["drivers/net/usb/mcs7830.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/pegasus.c", "pegasus_tx_timeout"],
    ["drivers/net/usb/qmi_wwan.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/r8152.c", "rtl8152_tx_timeout"],
    ["drivers/net/usb/rndis_host.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/rtl8150.c", "rtl8150_tx_timeout"],
    ["drivers/net/usb/sierra_net.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/smsc75xx.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/smsc95xx.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/sr9700.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/sr9800.c", "usbnet_tx_timeout"],
    ["drivers/net/usb/usbnet.c", "usbnet_tx_timeout"],
    ["drivers/net/vmxnet3/vmxnet3_drv.c", "vmxnet3_tx_timeout"],
    ["drivers/net/wan/cosa.c", "cosa_net_timeout"],
    ["drivers/net/wan/farsync.c", "fst_tx_timeout"],
    ["drivers/net/wan/fsl_ucc_hdlc.c", "uhdlc_tx_timeout"],
    ["drivers/net/wan/lmc/lmc_main.c", "lmc_driver_timeout"],
    ["drivers/net/wan/x25_asy.c", "x25_asy_timeout"],
    ["drivers/net/wimax/i2400m/netdev.c", "i2400m_tx_timeout"],
    ["drivers/net/wireless/intel/ipw2x00/ipw2100.c", "ipw2100_tx_timeout"],
    ["drivers/net/wireless/intersil/hostap/hostap_main.c", "prism2_tx_timeout"],
    ["drivers/net/wireless/intersil/hostap/hostap_main.c", "prism2_tx_timeout"],
    ["drivers/net/wireless/intersil/hostap/hostap_main.c", "prism2_tx_timeout"],
    ["drivers/net/wireless/intersil/orinoco/main.c", "orinoco_tx_timeout"],
    ["drivers/net/wireless/intersil/orinoco/orinoco_usb.c", "orinoco_tx_timeout"],
    ["drivers/net/wireless/intersil/orinoco/orinoco.h", "orinoco_tx_timeout"],
    ["drivers/net/wireless/intersil/prism54/islpci_dev.c", "islpci_eth_tx_timeout"],
    ["drivers/net/wireless/intersil/prism54/islpci_eth.c", "islpci_eth_tx_timeout"],
    ["drivers/net/wireless/intersil/prism54/islpci_eth.h", "islpci_eth_tx_timeout"],
    ["drivers/net/wireless/marvell/mwifiex/main.c", "mwifiex_tx_timeout"],
    ["drivers/net/wireless/quantenna/qtnfmac/core.c", "qtnf_netdev_tx_timeout"],
    ["drivers/net/wireless/quantenna/qtnfmac/core.h", "qtnf_netdev_tx_timeout"],
    ["drivers/net/wireless/rndis_wlan.c", "usbnet_tx_timeout"],
    ["drivers/net/wireless/wl3501_cs.c", "wl3501_tx_timeout"],
    ["drivers/net/wireless/zydas/zd1201.c", "zd1201_tx_timeout"],
    ["drivers/s390/net/qeth_core.h", "qeth_tx_timeout"],
    ["drivers/s390/net/qeth_core_main.c", "qeth_tx_timeout"],
    ["drivers/s390/net/qeth_l2_main.c", "qeth_tx_timeout"],
    ["drivers/s390/net/qeth_l2_main.c", "qeth_tx_timeout"],
    ["drivers/s390/net/qeth_l3_main.c", "qeth_tx_timeout"],
    ["drivers/s390/net/qeth_l3_main.c", "qeth_tx_timeout"],
    ["drivers/staging/ks7010/ks_wlan_net.c", "ks_wlan_tx_timeout"],
    ["drivers/staging/qlge/qlge_main.c", "qlge_tx_timeout"],
    ["drivers/staging/rtl8192e/rtl8192e/rtl_core.c", "_rtl92e_tx_timeout"],
    ["drivers/staging/rtl8192u/r8192U_core.c", "tx_timeout"],
    ["drivers/staging/unisys/visornic/visornic_main.c", "visornic_xmit_timeout"],
    ["drivers/staging/wlan-ng/p80211netdev.c", "p80211knetdev_tx_timeout"],
    ["drivers/tty/n_gsm.c", "gsm_mux_net_tx_timeout"],
    ["drivers/tty/synclink.c", "hdlcdev_tx_timeout"],
    ["drivers/tty/synclink_gt.c", "hdlcdev_tx_timeout"],
    ["drivers/tty/synclinkmp.c", "hdlcdev_tx_timeout"],
    ["net/atm/lec.c", "lec_tx_timeout"],
    ["net/bluetooth/bnep/netdev.c", "bnep_net_timeout"]
    );

    for my $p (@work) {
    my @pair = @$p;
    my $file = $pair[0];
    my $func = $pair[1];
    print STDERR $file , ": ", $func,"\n";
    our @ARGV = ($file);
    while () {
    if (m/($func\s*\(struct\s+net_device\s+\*[A-Za-z_]?[A-Za-z-0-9_]*)(\))/) {
    print STDERR "found $1+$2 in $file\n";
    }
    if (s/($func\s*\(struct\s+net_device\s+\*[A-Za-z_]?[A-Za-z-0-9_]*)(\))/$1, unsigned int txqueue$2/) {
    print STDERR "$func found in $file\n";
    }
    print;
    }
    }

    where the list of files and functions is simply from:

    git grep ndo_tx_timeout, with manual addition of headers
    in the rare cases where the function is from a header,
    then manually changing the few places which actually
    call ndo_tx_timeout.

    Signed-off-by: Michael S. Tsirkin
    Acked-by: Heiner Kallweit
    Acked-by: Jakub Kicinski
    Acked-by: Shannon Nelson
    Reviewed-by: Martin Habets

    changes from v9:
    fixup a forward declaration
    changes from v9:
    more leftovers from v3 change
    changes from v8:
    fix up a missing direct call to timeout
    rebased on net-next
    changes from v7:
    fixup leftovers from v3 change
    changes from v6:
    fix typo in rtl driver
    changes from v5:
    add missing files (allow any net device argument name)
    changes from v4:
    add a missing driver header
    changes from v3:
    change queue # to unsigned
    Changes from v2:
    added headers
    Changes from v1:
    Fix errors found by kbuild:
    generalize the pattern a bit, to pick up
    a couple of instances missed by the previous
    version.

    Signed-off-by: David S. Miller

    Michael S. Tsirkin
     

18 Nov, 2019

1 commit

  • 04254066a   staging: rtl8192e: remove set but not used variable 'frag' ... Browse Code »

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In function _rtl92e_process_phyinfo:
    drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1689:15: warning: variable frag set but not used [-Wunused-but-set-variable]

    It is introduced by commit 3d461c912462 ("rtl8192e:
    Split into two directories"), but never used, so remove it.

    Reported-by: Hulk Robot
    Signed-off-by: zhengbin
    Link: https://lore.kernel.org/r/1574063901-87429-1-git-send-email-zhengbin13@huawei.com
    Signed-off-by: Greg Kroah-Hartman

    zhengbin
     

16 Nov, 2019

1 commit

  • 6cfed5984   staging: rtl*: Remove tasklet callback casts ... Browse Code »

    In order to make the entire kernel usable under Clang's Control Flow
    Integrity protections, function prototype casts need to be avoided
    because this will trip CFI checks at runtime (i.e. a mismatch between
    the caller's expected function prototype and the destination function's
    prototype). Many of these cases can be found with -Wcast-function-type,
    which found that the rtl wifi drivers had a bunch of needless function
    casts. Remove function casts for tasklet callbacks in the various drivers.

    Signed-off-by: Kees Cook
    Reviewed-by: Dan Carpenter
    Link: https://lore.kernel.org/r/201911150926.2894A4F973@keescook
    Signed-off-by: Greg Kroah-Hartman

    Kees Cook
     

06 Nov, 2019

1 commit

  • b7aa39a2e   staging: rtl8192e: fix potential use after free ... Browse Code »

    The variable skb is released via kfree_skb() when the return value of
    _rtl92e_tx is not zero. However, after that, skb is accessed again to
    read its length, which may result in a use after free bug. This patch
    fixes the bug by moving the release operation to where skb is never
    used later.

    Signed-off-by: Pan Bian
    Reviewed-by: Dan Carpenter
    Cc: stable
    Link: https://lore.kernel.org/r/1572965351-6745-1-git-send-email-bianpan2016@163.com
    Signed-off-by: Greg Kroah-Hartman

    Pan Bian
     

01 Oct, 2019

1 commit

05 Sep, 2019

1 commit

22 Aug, 2019

2 commits

  • 6808f8cf5   staging: rtl8192e: remove set but not used variable 'data_len' ... Browse Code »

    Fixes gcc '-Wunused-but-set-variable' warning:

    In function ieee80211_ccmp_encrypt:
    drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:162:6:
    warning: variable data_len set but not used [-Wunused-but-set-variable]

    It is not used since commit 5ee5265674ce ("staging:
    rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)")

    Reported-by: Hulk Robot
    Signed-off-by: YueHaibing
    Link: https://lore.kernel.org/r/20190821122802.44028-1-yuehaibing@huawei.com
    Signed-off-by: Greg Kroah-Hartman

    YueHaibing
     
  • 4a67342ea   staging: rtl8192e: remove two set but not used variables ... Browse Code »

    Fixes gcc '-Wunused-but-set-variable' warning:

    In function '_rtl92e_dm_tx_power_tracking_callback_tssi':
    drivers/staging/rtl8192e/rtl8192e/rtl_dm.c:621:7:
    warning: variable 'bHighpowerstate' set but not used [-Wunused-but-set-variable]
    In function '_rtl92e_dm_rx_path_sel_byrssi':
    drivers/staging/rtl8192e/rtl8192e/rtl_dm.c:1904:32:
    warning: variable 'cck_rx_ver2_min_index' set but not used [-Wunused-but-set-variable]

    They are never used, so can be removed.

    Reported-by: Hulk Robot
    Signed-off-by: YueHaibing
    Link: https://lore.kernel.org/r/20190821122556.37636-1-yuehaibing@huawei.com
    Signed-off-by: Greg Kroah-Hartman

    YueHaibing
     

18 Aug, 2019

1 commit

05 Aug, 2019

1 commit

  • 36d042bd6   staging: rtl8192e: Make use kmemdup ... Browse Code »

    As kmemdup API does kmalloc + memcpy . We can make use of it instead of
    calling kmalloc and memcpy independetly.

    Signed-off-by: Hariprasad Kelam
    Link: https://lore.kernel.org/r/20190804024832.GA14352@hari-Inspiron-1545
    Signed-off-by: Greg Kroah-Hartman

    Hariprasad Kelam
     

30 Jul, 2019

1 commit

25 Jul, 2019

1 commit