Eric Lee / smarc-fsl-linux-kernel

25 Jan, 2019

1 commit

02 Nov, 2017

1 commit

  • b24413180   License cleanup: add SPDX GPL-2.0 license identifier to files with no license ... Browse Code »

    Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

25 Apr, 2017

1 commit

06 Aug, 2015

1 commit

  • 8011de7ab   perf tools: Remove trail argument to color vsprintf ... Browse Code »

    Seems like it's always '\n' through color_fprintf_ln, which is not used
    at all, removing.. ;-)

    Signed-off-by: Jiri Olsa
    Cc: Andi Kleen
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/r/1438649408-20807-2-git-send-email-andi@firstfloor.org
    Signed-off-by: Andi Kleen
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

22 Jan, 2015

1 commit

  • c8defe249   perf tools: Remove some unused functions from color.c ... Browse Code »

    Removes some functions that are not used anywhere:

    color_parse_mem()
    color_parse()

    This was partially found by using a static code analysis program called cppcheck.

    Signed-off-by: Rickard Strandqvist
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Ramkumar Ramachandra
    Link: http://lkml.kernel.org/r/1419079865-354-1-git-send-email-rickard_strandqvist@spectrumdigital.se
    [ Remove now unused parse_{attr,color} routines too ]
    Signed-off-by: Arnaldo Carvalho de Melo

    Rickard Strandqvist
     

12 Aug, 2014

1 commit

  • d675107ce   perf tools: Make __hpp__fmt() receive an additional len argument ... Browse Code »

    So that it can properly handle alignment requirements later. To do
    that, add percent_color_len_snprintf() fucntion to help coloring of
    overhead columns.

    Signed-off-by: Namhyung Kim
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1406785662-5534-3-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Namhyung Kim
     

13 Jan, 2014

1 commit

  • 1f513b2c1   perf diff: Color the Ratio column ... Browse Code »

    In

    $ perf diff -c ratio

    color the Ratio column using value_color_snprintf(), a new function that
    operates exactly like percent_color_snprintf().

    At first glance, it looks like percent_color_snprintf() can be turned
    into a non-variadic function simplifying things; however, 53805ec (perf
    tools: Remove cast of non-variadic function to variadic, 2013-10-31)
    explains why it needs to be a variadic function.

    Signed-off-by: Ramkumar Ramachandra
    Acked-by: Jiri Olsa
    Cc: Jiri Olsa
    Link: http://lkml.kernel.org/r/1388388861-7931-4-git-send-email-artagnon@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Ramkumar Ramachandra
     

01 Nov, 2013

1 commit

  • 53805eca3   perf tools: Remove cast of non-variadic function to variadic ... Browse Code »

    The 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) cset introduced
    a cast of percent_color_snprintf to a function pointer type with
    varargs. Change percent_color_snprintf to be variadic and remove the
    cast.

    The symptom of this was all percentages being reported as 0.00% in perf
    report --stdio output on the armhf arch.

    Signed-off-by: Michael Hudson-Doyle
    Acked-by: Namhyung Kim
    Acked-by: Will Deacon
    Cc: Jean Pihet
    Cc: Jiri Olsa
    Cc: Will Deacon
    Cc: stable@vger.kernel.org
    Link: http://lkml.kernel.org/r/87zjppvw7y.fsf@canonical.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Michael Hudson-Doyle
     

03 Apr, 2010

1 commit

  • a4e3b956a   perf hist: Replace ->print() routines by ->snprintf() equivalents ... Browse Code »

    Then hist_entry__fprintf will just us the newly introduced
    hist_entry__snprintf, add the newline and fprintf it to the supplied
    FILE descriptor.

    This allows us to remove the use_browser checking in the color_printf
    routines, that now got color_snprintf variants too.

    The newt TUI browser (and other GUIs that may come in the future) don't
    have to worry about stdio specific stuff in the strings they get from
    the se->snprintf routines and instead use whatever means to do the
    equivalent.

    Also the newt TUI browser don't have to use the fmemopen() hack, instead
    it can use the se->snprintf routines directly. For now tho use the
    hist_entry__snprintf routine to reduce the patch size.

    Cc: Frédéric Weisbecker
    Cc: Mike Galbraith
    Cc: Peter Zijlstra
    Cc: Paul Mackerras
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     

25 Sep, 2009

1 commit

17 Aug, 2009

1 commit

  • 8f28827a1   perf tools: Librarize trace_event() helper ... Browse Code »

    Librarize trace_event() helper so that perf trace can use it
    too. Also clean up the debug.h includes a bit.

    It's not good to have it included in perf.h because it doesn't
    make it flexible against other headers it may need (headers
    that can also depend on perf.h and then create a recursive
    header dependency).

    Signed-off-by: Frederic Weisbecker
    Cc: Peter Zijlstra
    Cc: Arnaldo Carvalho de Melo
    Cc: Mike Galbraith
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Frederic Weisbecker
     

16 Aug, 2009

1 commit

  • 83a0944fa   perf: Enable more compiler warnings ... Browse Code »

    Related to a shadowed variable bug fix Valdis Kletnieks noticed
    that perf does not get built with -Wshadow, which could have
    helped us avoid the bug.

    So enable -Wshadow and also enable the following warnings on
    perf builds, in addition to the already enabled -Wall -Wextra
    -std=gnu99 warnings:

    -Wcast-align
    -Wformat=2
    -Wshadow
    -Winit-self
    -Wpacked
    -Wredundant-decls
    -Wstack-protector
    -Wstrict-aliasing=3
    -Wswitch-default
    -Wswitch-enum
    -Wno-system-headers
    -Wundef
    -Wvolatile-register-var
    -Wwrite-strings
    -Wbad-function-cast
    -Wmissing-declarations
    -Wmissing-prototypes
    -Wnested-externs
    -Wold-style-definition
    -Wstrict-prototypes
    -Wdeclaration-after-statement

    And change/fix the perf code to build cleanly under GCC 4.3.2.

    The list of warnings enablement is rather arbitrary: it's based
    on my (quick) reading of the GCC manpages and trying them on
    perf.

    I categorized the warnings based on individually enabling them
    and looking whether they trigger something in the perf build.
    If i liked those warnings (i.e. if they trigger for something
    that arguably could be improved) i enabled the warning.

    If the warnings seemed to come from language laywers spamming
    the build with tons of nuisance warnings i generally kept them
    off. Most of the sign conversion related warnings were in
    this category. (A second patch enabling some of the sign
    warnings might be welcome - sign bugs can be nasty.)

    I also kept warnings that seem to make sense from their manpage
    description and which produced no actual warnings on our code
    base. These warnings might still be turned off if they end up
    being a nuisance.

    I also left out a few warnings that are not supported in older
    compilers.

    [ Note that these changes might break the build on older
    compilers i did not test, or on non-x86 architectures that
    produce different warnings, so more testing would be welcome. ]

    Reported-by: Valdis.Kletnieks@vt.edu
    Cc: Peter Zijlstra
    Cc: Mike Galbraith
    Cc: Paul Mackerras
    Cc: Arnaldo Carvalho de Melo
    Cc: Frederic Weisbecker
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ingo Molnar
     

03 Jul, 2009

1 commit

  • 1e11fd82d   perf_counter tools: Provide helper to print percents color ... Browse Code »

    Among perf annotate, perf report and perf top, we can find the
    common colored printing of percents according to the following
    rules:

    High overhead = > 5%, colored in red
    Mid overhead = > 0.5%, colored in green
    Low overhead = < 0.5%, default color

    Factorize these multiple checks in a single function named
    percent_color_fprintf() and also provide a get_percent_color()
    for sites which print percentages and other things at the same
    time.

    Signed-off-by: Frederic Weisbecker
    Cc: Peter Zijlstra
    Cc: Mike Galbraith
    Cc: Paul Mackerras
    Cc: Anton Blanchard
    Cc: Arnaldo Carvalho de Melo
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Frederic Weisbecker
     

07 Jun, 2009

1 commit