17 Mar, 2006

1 commit

  • Jiri Benc reported that modpost would stop with SIGABRT if
    used with long filepaths.
    The error looked like:
    > Building modules, stage 2.
    > MODPOST
    > *** glibc detected *** scripts/mod/modpost: realloc(): invalid next size:
    +0x0809f588 ***
    > [...]

    Fix this by allocating at least the required memory + SZ bytes each time.
    Before we sometimes ended up allocating too little memory resuting in the
    glibc detected bug above. Based on patch originally submitted by: Jiri
    Benc

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sam Ravnborg
     

07 Mar, 2006

1 commit


10 Feb, 2006

1 commit


08 Feb, 2006

1 commit


06 Feb, 2006

1 commit

  • On a system where libintl.h is present, but the NLS functionality is
    supplied by a separate library instead of the system C library, an attempt
    to "make config" or "make menuconfig" will fail with link errors, ex:

    scripts/kconfig/mconf.o:mconf.c:(.text+0xf63): undefined reference to
    `_libintl_gettext'

    This patch attempts to correct the problem by detecting whether or not NLS
    support requires linking with libintl.

    Signed-off-by: Samuel J Robb
    Cc: Roman Zippel
    Cc: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robb, Sam
     

02 Feb, 2006

3 commits


21 Jan, 2006

1 commit

  • While running "make menuconfig" and "make mrproper"
    some people experienced that /dev/null suddenly changed
    permissions or suddenly became a regular file.
    The main reason was that /dev/null was used as output
    to gcc in the check-lxdialog.sh script and gcc did
    some strange things with the output file; in this
    case /dev/null when it errorred out.

    Following patch implements a suggestion
    from Bryan O'Sullivan to
    use gcc -print-file-name=libxxx.so.

    Also the Makefile is adjusted to not resolve value of
    HOST_EXTRACFLAGS and HOST_LOADLIBES until they are actually used.
    This prevents us from calling gcc when running make *clean/mrproper

    Thanks to Eyal Lebedinsky and
    Jean Delvare for the first error reports.

    Signed-off-by: Sam Ravnborg
    ---

    Sam Ravnborg
     

16 Jan, 2006

1 commit

  • To enable 'make kernelrelease' earlier now create .kernelrelease when
    one of the *config targets are used.
    Also introduce KERNELVERSION - only user is kconfig.
    KERNELVERSION was needed to display kernel version in menuconfig -
    KERNELRELEASE is not valid until configuration has completed.
    kconfig files modified to use KERNELVERSION.
    Bug reported by: Rene Rebe

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

15 Jan, 2006

1 commit

  • scripts/kconfig/lxdialog/check-lxdialog.sh uses gcc to check for
    what libraries are present. Redirect output to /dev/null
    so we do not generate an a.out.
    Also included support for ncursesw - so if present prefer that
    instead of ncurses.
    The order is now (first is preferred):
    1) ncursesw
    2) ncurses
    3) curses

    The latter is to support SunOS.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

11 Jan, 2006

2 commits


10 Jan, 2006

1 commit


09 Jan, 2006

7 commits

  • This is a rewrite of Andi Kleen's bloat-o-meter with sorting and reporting of
    gainers/decliners. Sample output:

    add/remove: 0/8 grow/shrink: 2/0 up/down: 88/-4424 (-4336)
    function old new delta
    __copy_to_user_ll 59 103 +44
    __copy_from_user_ll 59 103 +44
    fill_note 32 - -32
    maydump 58 - -58
    dump_seek 67 - -67
    writenote 180 - -180
    elf_dump_thread_status 274 - -274
    fill_psinfo 308 - -308
    fill_prstatus 466 - -466
    elf_core_dump 3039 - -3039

    The summary line says:
    no functions added, 8 removed
    two functions grew, none shrunk
    we gained 88 bytes and lost 4424 (or -4336 net)

    This work was sponsored in part by CE Linux Forum

    Signed-off-by: Matt Mackall
    Cc: Andi Kleen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Matt Mackall
     
  • Signed-off-by: Ben Collins
    Cc: Sam Ravnborg
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Collins
     
  • scripts/kconfig/qconf.h:25: error: extra qualification ‘ConfigSettings::’ on member ‘readSizes’
    scripts/kconfig/qconf.h:26: error: extra qualification ‘ConfigSettings::’ on member ‘writeSizes’
    scripts/kconfig/qconf.h:127: error: extra qualification ‘ConfigList::’ on member ‘updateMenuList’

    Signed-off-by: Dave Jones
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave Jones
     
  • Error: ./fs/quota_v2.o .opd refers to 0000000000000020 R_PPC64_ADDR64 .exit.text

    Been carrying this for some time in Red Hat trees.

    Keith Ownes commented:
    For our future {in}sanity, add a comment that this is the ppc .opd
    section, not the ia64 .opd section. ia64 .opd should not point to
    discarded sections.

    Any idea why ppc .opd points to discarded sections when ia64 does not?
    AFAICT no ia64 object has a useful .opd section, they are all empty or
    (sometimes) a dummy entry which is 1 byte long. ia64 .opd data is
    built at link time, not compile time.

    Signed-off-by: Dave Jones
    Signed-off-by: Sam Ravnborg

    Dave Jones
     
  • When building Debian packages directly from the git tree, the appended
    "git_dirty" is a problem due to the underscore. In order to cause the
    least problems, change that just to "dirty".

    Signed-off-by: Ryan Anderson
    Signed-off-by: Sam Ravnborg

    Ryan Anderson
     
  • SND_MAX should be FF_MAX

    Signed-off-by: Brian Gerst
    Signed-off-by: Sam Ravnborg

    Brian Gerst
     
  • Cleaning up the lxdialog Makefile by factoring out the
    ncurses compatibility checks.
    This made the checks much more obvious and easier to extend.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

07 Jan, 2006

3 commits

  • This makes things a little bit more reader friendly and gvim is less
    confused.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • This patch fixed "make gconfig" with POSIXLY_CORRECT=1 set.

    This issue was reported by Jens Elkner in kernel
    Bugzilla #2919.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Sam Ravnborg

    Adrian Bunk
     
  • Currently scripts/setlocalversion is a Perl script that tries to figure
    out the current git commit ID of a repo without using git. It also
    imports Digest::MD5 without using it and generally is too big for the
    small task it does. :] And it always reports a git ID, even when the
    HEAD is tagged -- this is a bug.

    This patch replaces it with a Bourne Shell script that uses git
    commands to do the same. I can't come up with a scenario where someone
    would use a git repo and refuse to install git core at the same time,
    so I think it's reasonable to assume git is available.

    The new script also reports uncommitted changes by adding -git_dirty to
    the version string. Obviously you can't see from that _what_ has been
    changed from the last commit, so it's more of a reminder that you
    forgot to commit something.

    The script is easily extensible: simply add a check for Mercurial (or
    whatever) below the git check.

    Note: the script doesn't print a newline char anymore. That's only
    because it was easier to implement it that way, not a feature (or bug).
    'make kernelrelease' doesn't care.

    Signed-off-by: Rene Scharfe
    Acked-by: Ryan Anderson
    Signed-off-by: Sam Ravnborg

    Rene Scharfe
     

05 Jan, 2006

3 commits


03 Jan, 2006

4 commits


02 Jan, 2006

3 commits

  • Remove support for lxdialog --checklist

    The checklist lxdialog functionality is not used by menuconfig
    (only the radiolist variant is used) and supporting it would
    significantly complicate the forthcoming liblxdialog API.

    Signed-off-by: Petr Baudis
    Signed-off-by: Sam Ravnborg

    Petr Baudis
     
  • Ignore all files generated from *_shipped files, plus a few others.

    Signed-off-by: Brian Gerst
    Signed-off-by: Sam Ravnborg

    Brian Gerst
     
  • Fix out-of-tree builds for the tar-pkg targets

    When I wrote the buildtar script, I didn't even think about
    out-of-tree builds because I didn't use these back then. This patch
    throughoutly uses ${objtree} instead of `pwd`.

    Also, the kernel version is no longer manually built. Instead, it will
    properly use $KERNELRELEASE . Installing modules is only done if
    CONFIG_MODULES is set.

    Signed-off-by: Jan-Benedict Glaw
    Signed-off-by: Sam Ravnborg

    Jan-Benedict Glaw
     

27 Dec, 2005

3 commits

  • If the file .kconfig.d is missing then make sure to run
    'make silentoldconfig', since we have no way to detect if
    a Kconfig file has been updated.

    -kconfig.d is created by kconfig and is removed as part
    of 'make clean' so the situation is likely to occur in reality.

    Jan Beulich reported this bug.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • Generate _shipped files so the genksyms change in previous commit is enabled.
    The files are generated with latest versions of the tools:

    bison (GNU Bison) 2.0
    flex version 2.5.4
    GNU gperf 3.0.1

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • This is a one-line change to parse.y.
    To take advantage of this the scripts/genksyms/*_shipped files needs to
    be rebuild - this is the next patch.

    When a .c file contains:
    DEFINE_PER_CPU(struct foo_s *, bar);

    the .cpp output looks like:
    __attribute__((__section__(".data.percpu"))) __typeof__(struct foo_s *) per_cpu__bar;

    With the existing parse.y, the value inside the paranthesis of
    __typeof__() does not evaluate as a type_specifier and therefore
    per_cpu__bar does not get assigned a type for genksyms which results in
    the EXPORT_PER_CPU_SYMBOL() not generating a CRC value.

    I have compared the Modules.symvers with and without this
    patch and for ia64's defconfig, the only change is:
    Before 0x00000000 per_cpu____sn_nodepda vmlinux
    After 0x9d3f3faa per_cpu____sn_nodepda vmlinux

    per_cpu____sn_nodepda was the original source of my problems.

    Signed-off-by: Robin Holt
    Signed-off-by: Sam Ravnborg

    Robin Holt
     

26 Dec, 2005

3 commits

  • This patch fixes a problem when we use well known kernel symbols as module
    names.

    For example, if module source name is current.c, idle_stack.c or etc.,
    we have a bad KBUILD_MODNAME value.
    For example, KBUILD_MODNAME will be "get_current()" instead of "current", or
    "(init_thread_union.stack)" instead of "idle_task".

    The trick is to define a stringify macro on the commandline - named
    KBUILD_STR for namespace reasons - and then to stringify the module
    name.

    There are a few uses of KBUILD_MODNAME throughout the tree but the usage
    is for debug and will not be harmed by this change so left untouched for now.

    While at it KBUILD_BASENAME was changed too. Any spinlock usage in the
    unix module would have created wrong section names without it.
    Usage in spinlock.h fixed so it no longer stringify KBUILD_BASENAME.

    Original patch from Ustyogov Roman - all bugs introduced by me.

    Signed-off-by: Sam Ravnborg

    Ustyugov Roman
     
  • Commandlines are contained in the ..cmd files and in case they
    contain a '#' char make see this as start of comment.
    Teach fixdep to escape the '#' char so make will assing the full commandline.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     
  • This is the patch for the following issue:

    In include/linux/module.h, "__crc_" and "__ksymtab_" are hard
    coded to be the prefix for some kinds of symbols (CRC symbol and
    ksymtab section). But in script /mod/modpost.c,
    MODULE_SYMBOL_PREFIX##"__crc_" is used as the prefix to search CRC
    symbols. So if an architecture (such as h8300 or Blackfin) defines
    MODULE_SYMBOL_PREFIX as not NULL ("_"), modpost will always warn about
    "no invalid crc".
    And it is the same with KSYMTAB_PFX.

    Signed-off-by: Luke Yang
    Signed-off-by: Sam Ravnborg

    Luke Yang